[INFO] fetching crate zebra-test 1.0.0-beta.42... [INFO] checking zebra-test-1.0.0-beta.42 against try#da25749bf5e6ba5ed862ff361c19afff2a986b2d for pr-132712 [INFO] extracting crate zebra-test 1.0.0-beta.42 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate zebra-test 1.0.0-beta.42 on toolchain da25749bf5e6ba5ed862ff361c19afff2a986b2d [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate zebra-test 1.0.0-beta.42 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate zebra-test 1.0.0-beta.42 [INFO] tweaked toml for crates.io crate zebra-test 1.0.0-beta.42 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 133 packages to latest compatible versions [INFO] [stderr] Adding backtrace v0.3.71 (available: v0.3.74) [INFO] [stderr] Adding thiserror v1.0.68 (available: v2.0.1) [INFO] [stderr] Adding tower v0.4.13 (available: v0.5.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7ce7ff7a9407f00165c83a4d044d164deb572ae608b2ba5f4517046dd800d55f [INFO] running `Command { std: "docker" "start" "-a" "7ce7ff7a9407f00165c83a4d044d164deb572ae608b2ba5f4517046dd800d55f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7ce7ff7a9407f00165c83a4d044d164deb572ae608b2ba5f4517046dd800d55f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ce7ff7a9407f00165c83a4d044d164deb572ae608b2ba5f4517046dd800d55f", kill_on_drop: false }` [INFO] [stdout] 7ce7ff7a9407f00165c83a4d044d164deb572ae608b2ba5f4517046dd800d55f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 32700d61c4ebab1b9e96fd2945c3abdfcc1226237aeab7b31b21fb109ed386e2 [INFO] running `Command { std: "docker" "start" "-a" "32700d61c4ebab1b9e96fd2945c3abdfcc1226237aeab7b31b21fb109ed386e2", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling syn v2.0.87 [INFO] [stderr] Compiling backtrace v0.3.71 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Compiling owo-colors v4.1.0 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking bytes v1.8.0 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking insta v1.41.1 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling pin-project-internal v1.1.7 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling thiserror-impl v1.0.68 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling spandoc-attribute v0.1.1 [INFO] [stderr] Checking tokio v1.41.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking pin-project v1.1.7 [INFO] [stderr] Checking thiserror v1.0.68 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking spandoc v0.2.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stderr] Checking color-spantrace v0.2.1 [INFO] [stderr] Checking color-eyre v0.6.3 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking zebra-test v1.0.0-beta.42 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/transcript.rs (1 fix) [INFO] [stderr] Fixed src/command.rs (5 fixes) [INFO] [stderr] Fixed src/command/arguments.rs (4 fixes) [INFO] [stderr] Fixed src/mock_service.rs (2 fixes) [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/mock_service.rs:689:27 [INFO] [stdout] | [INFO] [stdout] 687 | match timeout(self.max_request_delay, self.receiver.recv()).await { [INFO] [stdout] | ----------------------------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] 688 | Ok(Ok(item)) => { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | `item` calls a custom destructor [INFO] [stdout] | `item` will be dropped later as of Edition 2024 [INFO] [stdout] 689 | match item.lock().await.take() { Some(proxy_item) => { [INFO] [stdout] | -----------------^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#6` [INFO] [stdout] | | up until Edition 2021 `#6` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#5` [INFO] [stdout] | up until Edition 2021 `#5` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] 690 | return Some(proxy_item); [INFO] [stdout] 691 | } _ => {}} [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/oneshot.rs:844:1 [INFO] [stdout] | [INFO] [stdout] 844 | impl Drop for Sender { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#5` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mutex.rs:963:1 [INFO] [stdout] | [INFO] [stdout] 963 | impl Drop for MutexGuard<'_, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `__awaitee` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/runtime/time/entry.rs:652:1 [INFO] [stdout] | [INFO] [stdout] 652 | impl Drop for TimerEntry { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `__awaitee` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/broadcast.rs:1414:1 [INFO] [stdout] | [INFO] [stdout] 1414 | impl<'a, T> Drop for Recv<'a, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/oneshot.rs:844:1 [INFO] [stdout] | [INFO] [stdout] 844 | impl Drop for Sender { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `item` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/oneshot.rs:844:1 [INFO] [stdout] | [INFO] [stdout] 844 | impl Drop for Sender { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mutex.rs:963:1 [INFO] [stdout] | [INFO] [stdout] 963 | impl Drop for MutexGuard<'_, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/mock_service.rs:687:19 [INFO] [stdout] | [INFO] [stdout] 687 | match timeout(self.max_request_delay, self.receiver.recv()).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#5` [INFO] [stdout] | | up until Edition 2021 `#5` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] 688 | Ok(Ok(item)) => { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | `item` calls a custom destructor [INFO] [stdout] | `item` will be dropped later as of Edition 2024 [INFO] [stdout] 689 | match item.lock().await.take() { Some(proxy_item) => { [INFO] [stdout] | ----------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 696 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/oneshot.rs:844:1 [INFO] [stdout] | [INFO] [stdout] 844 | impl Drop for Sender { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#5` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/runtime/time/entry.rs:652:1 [INFO] [stdout] | [INFO] [stdout] 652 | impl Drop for TimerEntry { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#5` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/broadcast.rs:1414:1 [INFO] [stdout] | [INFO] [stdout] 1414 | impl<'a, T> Drop for Recv<'a, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `__awaitee` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/runtime/time/entry.rs:652:1 [INFO] [stdout] | [INFO] [stdout] 652 | impl Drop for TimerEntry { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `__awaitee` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/broadcast.rs:1414:1 [INFO] [stdout] | [INFO] [stdout] 1414 | impl<'a, T> Drop for Recv<'a, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/oneshot.rs:844:1 [INFO] [stdout] | [INFO] [stdout] 844 | impl Drop for Sender { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `item` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/oneshot.rs:844:1 [INFO] [stdout] | [INFO] [stdout] 844 | impl Drop for Sender { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mutex.rs:963:1 [INFO] [stdout] | [INFO] [stdout] 963 | impl Drop for MutexGuard<'_, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/transcript.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/command.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.34s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking zebra-test v1.0.0-beta.42 (/tmp/fixit) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.19s [INFO] running `Command { std: "docker" "inspect" "32700d61c4ebab1b9e96fd2945c3abdfcc1226237aeab7b31b21fb109ed386e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32700d61c4ebab1b9e96fd2945c3abdfcc1226237aeab7b31b21fb109ed386e2", kill_on_drop: false }` [INFO] [stdout] 32700d61c4ebab1b9e96fd2945c3abdfcc1226237aeab7b31b21fb109ed386e2