[INFO] fetching crate tonic-reflection 0.12.3... [INFO] checking tonic-reflection-0.12.3 against try#da25749bf5e6ba5ed862ff361c19afff2a986b2d for pr-132712 [INFO] extracting crate tonic-reflection 0.12.3 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate tonic-reflection 0.12.3 on toolchain da25749bf5e6ba5ed862ff361c19afff2a986b2d [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tonic-reflection 0.12.3 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate tonic-reflection 0.12.3 [INFO] tweaked toml for crates.io crate tonic-reflection 0.12.3 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 101 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5e2b6a245247f499cfee8810040a4d84dd29fe23237fe7efe2ce3d0e8250101f [INFO] running `Command { std: "docker" "start" "-a" "5e2b6a245247f499cfee8810040a4d84dd29fe23237fe7efe2ce3d0e8250101f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5e2b6a245247f499cfee8810040a4d84dd29fe23237fe7efe2ce3d0e8250101f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e2b6a245247f499cfee8810040a4d84dd29fe23237fe7efe2ce3d0e8250101f", kill_on_drop: false }` [INFO] [stdout] 5e2b6a245247f499cfee8810040a4d84dd29fe23237fe7efe2ce3d0e8250101f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b2e6aeb831db137982d0f37fa57232b62f217340381addac573a043f85ac54fa [INFO] running `Command { std: "docker" "start" "-a" "b2e6aeb831db137982d0f37fa57232b62f217340381addac573a043f85ac54fa", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking hashbrown v0.15.1 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling anyhow v1.0.93 [INFO] [stderr] Compiling httparse v1.9.5 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Compiling rustversion v1.0.18 [INFO] [stderr] Compiling syn v2.0.87 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling serde v1.0.214 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Checking indexmap v2.6.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking tower v0.5.1 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling pin-project-internal v1.1.7 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Compiling prost-derive v0.13.3 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking tokio v1.41.1 [INFO] [stderr] Checking axum-core v0.4.5 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking pin-project v1.1.7 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking prost v0.13.3 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking prost-types v0.13.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking axum v0.7.7 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking hyper v1.5.0 [INFO] [stderr] Checking hyper-util v0.1.10 [INFO] [stderr] Checking hyper-timeout v0.5.2 [INFO] [stderr] Checking tonic v0.12.3 [INFO] [stderr] Checking tonic-reflection v0.12.3 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/server/mod.rs (3 fixes) [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/server/v1.rs:35:35 [INFO] [stdout] | [INFO] [stdout] 35 | while let Some(req) = req_rx.next().await { [INFO] [stdout] | --- ^^^^^^^^^^^^^^----- [INFO] [stdout] | | | | [INFO] [stdout] | | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#5` [INFO] [stdout] | | up until Edition 2021 `#5` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `req` calls a custom destructor [INFO] [stdout] | `req` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let resp_msg = match req.message_request.clone() { [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | `resp_msg` calls a custom destructor [INFO] [stdout] | `resp_msg` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | resp_tx.send(Ok(resp)).await.expect("send"); [INFO] [stdout] | ---------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | resp_tx.send(Err(status)).await.expect("send"); [INFO] [stdout] | ------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | | `#4` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: `#5` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#5` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `req` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `req` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `resp_msg` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `resp_msg` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `__awaitee` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `__awaitee` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#3` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#4` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/server/v1alpha.rs:35:35 [INFO] [stdout] | [INFO] [stdout] 35 | while let Some(req) = req_rx.next().await { [INFO] [stdout] | --- ^^^^^^^^^^^^^^----- [INFO] [stdout] | | | | [INFO] [stdout] | | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#5` [INFO] [stdout] | | up until Edition 2021 `#5` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `req` calls a custom destructor [INFO] [stdout] | `req` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let resp_msg = match req.message_request.clone() { [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | `resp_msg` calls a custom destructor [INFO] [stdout] | `resp_msg` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | resp_tx.send(Ok(resp)).await.expect("send"); [INFO] [stdout] | ---------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | resp_tx.send(Err(status)).await.expect("send"); [INFO] [stdout] | ------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | | `#4` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: `#5` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#5` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `req` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `req` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `resp_msg` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `resp_msg` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `__awaitee` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `__awaitee` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#3` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#4` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/server.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/versions.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.90s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking tonic-reflection v0.12.3 (/tmp/fixit) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.67s [INFO] running `Command { std: "docker" "inspect" "b2e6aeb831db137982d0f37fa57232b62f217340381addac573a043f85ac54fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b2e6aeb831db137982d0f37fa57232b62f217340381addac573a043f85ac54fa", kill_on_drop: false }` [INFO] [stdout] b2e6aeb831db137982d0f37fa57232b62f217340381addac573a043f85ac54fa