[INFO] fetching crate tarpc 0.35.0... [INFO] checking tarpc-0.35.0 against try#da25749bf5e6ba5ed862ff361c19afff2a986b2d for pr-132712 [INFO] extracting crate tarpc 0.35.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate tarpc 0.35.0 on toolchain da25749bf5e6ba5ed862ff361c19afff2a986b2d [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tarpc 0.35.0 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate tarpc 0.35.0 [INFO] tweaked toml for crates.io crate tarpc 0.35.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate tarpc 0.35.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f6f343e8f8e8df6aaac949bb5109c2041892b78eaa153f8fdc6fde719cdac9e2 [INFO] running `Command { std: "docker" "start" "-a" "f6f343e8f8e8df6aaac949bb5109c2041892b78eaa153f8fdc6fde719cdac9e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f6f343e8f8e8df6aaac949bb5109c2041892b78eaa153f8fdc6fde719cdac9e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f6f343e8f8e8df6aaac949bb5109c2041892b78eaa153f8fdc6fde719cdac9e2", kill_on_drop: false }` [INFO] [stdout] f6f343e8f8e8df6aaac949bb5109c2041892b78eaa153f8fdc6fde719cdac9e2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a529fc0ce1a5df7776b282093c9cb94c424cb1780a280cdbaa91de589838be68 [INFO] running `Command { std: "docker" "start" "-a" "a529fc0ce1a5df7776b282093c9cb94c424cb1780a280cdbaa91de589838be68", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.161 [INFO] [stderr] Compiling serde v1.0.213 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking hashbrown v0.15.0 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling anyhow v1.0.91 [INFO] [stderr] Compiling syn v2.0.85 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Compiling serde_json v1.0.132 [INFO] [stderr] Compiling httparse v1.9.5 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Compiling thiserror v1.0.65 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Compiling aws-lc-rs v1.10.0 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking rustls-pki-types v1.10.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking mirai-annotations v1.12.0 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking winnow v0.6.20 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking indexmap v2.6.0 [INFO] [stderr] Compiling rustls v0.23.15 [INFO] [stderr] Compiling target-triple v0.1.3 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking flate2 v1.0.34 [INFO] [stderr] Checking opentelemetry-semantic-conventions v0.16.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling cc v1.1.31 [INFO] [stderr] Checking regex-automata v0.4.8 [INFO] [stderr] Compiling cmake v0.1.51 [INFO] [stderr] Checking hdrhistogram v7.5.4 [INFO] [stderr] Compiling aws-lc-sys v0.22.0 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling serde_derive v1.0.213 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Compiling pin-project-internal v1.1.7 [INFO] [stderr] Compiling prost-derive v0.13.3 [INFO] [stderr] Compiling thiserror-impl v1.0.65 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Compiling enum-ordinalize-derive v4.3.1 [INFO] [stderr] Compiling tarpc-plugins v0.14.0 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Compiling enum-ordinalize v4.3.0 [INFO] [stderr] Compiling educe v0.5.11 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking pin-project v1.1.7 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking opentelemetry v0.26.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking tower v0.5.1 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking futures-test v0.3.31 [INFO] [stderr] Checking bytes v1.8.0 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.8 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking toml_edit v0.22.22 [INFO] [stderr] Checking tokio v1.41.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking prost v0.13.3 [INFO] [stderr] Checking prost-types v0.13.3 [INFO] [stderr] Checking tokio-serde v0.9.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking axum-core v0.4.5 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking trybuild v1.0.101 [INFO] [stderr] Checking axum v0.7.7 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking opentelemetry_sdk v0.26.0 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tracing-opentelemetry v0.27.0 [INFO] [stderr] Checking tarpc v0.35.0 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/server.rs (1 fix) [INFO] [stderr] Fixed src/server/in_flight_requests.rs (2 fixes) [INFO] [stderr] Fixed src/client.rs (1 fix) [INFO] [stderr] Fixed src/client/in_flight_requests.rs (1 fix) [INFO] [stderr] Fixed src/trace.rs (2 fixes) [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/client.rs:164:35 [INFO] [stdout] | [INFO] [stdout] 130 | )] [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 140 | let (response_completion, mut response) = oneshot::channel(); [INFO] [stdout] | ------------ [INFO] [stdout] | | [INFO] [stdout] | `response` calls a custom destructor [INFO] [stdout] | `response` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | response_guard.response().await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/client.rs:216:1 [INFO] [stdout] | [INFO] [stdout] 216 | / impl Drop for ResponseGuard<'_, Resp> { [INFO] [stdout] 217 | | fn drop(&mut self) { [INFO] [stdout] 218 | | // The receiver needs to be closed to handle the edge case that the request has not [INFO] [stdout] 219 | | // yet been received by the dispatch task. It is possible for the cancel message to [INFO] [stdout] ... | [INFO] [stdout] 232 | | } [INFO] [stdout] 233 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `response` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.0/src/sync/oneshot.rs:1072:1 [INFO] [stdout] | [INFO] [stdout] 1072 | impl Drop for Receiver { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/server/request_hook/before.rs:97:31 [INFO] [stdout] | [INFO] [stdout] 94 | serve, mut hook, .. [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | `hook` calls a custom destructor [INFO] [stdout] | `hook` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | serve.serve(ctx, req).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 98 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking hyper v1.5.0 [INFO] [stderr] Checking hyper-util v0.1.9 [INFO] [stderr] Checking hyper-timeout v0.5.1 [INFO] [stderr] Checking tonic v0.12.3 [INFO] [stderr] Checking console-api v0.8.1 [INFO] [stderr] Checking opentelemetry-proto v0.26.1 [INFO] [stderr] Checking console-subscriber v0.4.1 [INFO] [stderr] Checking opentelemetry-otlp v0.26.0 [INFO] [stderr] Migrating tests/proc_macro_hygene.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/compile_fail.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.96s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking tarpc v0.35.0 (/tmp/fixit) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.08s [INFO] running `Command { std: "docker" "inspect" "a529fc0ce1a5df7776b282093c9cb94c424cb1780a280cdbaa91de589838be68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a529fc0ce1a5df7776b282093c9cb94c424cb1780a280cdbaa91de589838be68", kill_on_drop: false }` [INFO] [stdout] a529fc0ce1a5df7776b282093c9cb94c424cb1780a280cdbaa91de589838be68