[INFO] fetching crate pingora-core 0.4.0... [INFO] checking pingora-core-0.4.0 against try#da25749bf5e6ba5ed862ff361c19afff2a986b2d for pr-132712 [INFO] extracting crate pingora-core 0.4.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate pingora-core 0.4.0 on toolchain da25749bf5e6ba5ed862ff361c19afff2a986b2d [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pingora-core 0.4.0 [INFO] finished tweaking crates.io crate pingora-core 0.4.0 [INFO] tweaked toml for crates.io crate pingora-core 0.4.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 334 packages to latest compatible versions [INFO] [stderr] Adding brotli v3.5.0 (available: v7.0.0) [INFO] [stderr] Adding clap v3.2.25 (available: v4.5.20) [INFO] [stderr] Adding env_logger v0.9.3 (available: v0.11.5) [INFO] [stderr] Adding hyper v0.14.31 (available: v1.5.0) [INFO] [stderr] Adding hyperlocal v0.8.0 (available: v0.9.1) [INFO] [stderr] Adding nix v0.24.3 (available: v0.29.0) [INFO] [stderr] Adding reqwest v0.11.27 (available: v0.12.9) [INFO] [stderr] Adding sentry v0.26.0 (available: v0.34.0) [INFO] [stderr] Adding serde_yaml v0.8.26 (available: v0.9.34+deprecated) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 20512ab52d084a9472a37382b3d92adc7322020f472bcad4b93196c5da32ce81 [INFO] running `Command { std: "docker" "start" "-a" "20512ab52d084a9472a37382b3d92adc7322020f472bcad4b93196c5da32ce81", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "20512ab52d084a9472a37382b3d92adc7322020f472bcad4b93196c5da32ce81", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "20512ab52d084a9472a37382b3d92adc7322020f472bcad4b93196c5da32ce81", kill_on_drop: false }` [INFO] [stdout] 20512ab52d084a9472a37382b3d92adc7322020f472bcad4b93196c5da32ce81 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8bc7f6708b9d112c720c27ad0f868801ec48d753d6ae354259dcc9a5889005c8 [INFO] running `Command { std: "docker" "start" "-a" "8bc7f6708b9d112c720c27ad0f868801ec48d753d6ae354259dcc9a5889005c8", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.162 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking foldhash v0.1.3 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking writeable v0.5.5 [INFO] [stderr] Checking litemap v0.7.3 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Compiling syn v2.0.87 [INFO] [stderr] Checking icu_locid_transform_data v1.5.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking icu_properties_data v1.5.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking hashbrown v0.15.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking icu_normalizer_data v1.5.0 [INFO] [stderr] Checking utf16_iter v1.0.5 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking write16 v1.0.0 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Compiling rust_decimal v1.36.0 [INFO] [stderr] Compiling protobuf v2.28.0 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling prometheus v0.13.4 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking indexmap v2.6.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking brotli-decompressor v2.5.1 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking pingora-error v0.4.0 [INFO] [stderr] Compiling cc v1.1.37 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking pingora-http v0.4.0 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking unicase v2.8.0 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking webpki-roots v0.25.4 [INFO] [stderr] Checking ipnet v2.10.1 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking regex-automata v0.4.8 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking sfv v0.9.4 [INFO] [stderr] Checking brotli v3.5.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking daemonize v0.5.0 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Compiling cmake v0.1.51 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling jemalloc-sys v0.5.4+5.3.0-patched [INFO] [stderr] Compiling libz-ng-sys v1.1.20 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Compiling clap_derive v3.2.25 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.4 [INFO] [stderr] Compiling yoke-derive v0.7.4 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.214 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Compiling thiserror-impl v1.0.68 [INFO] [stderr] Compiling pin-project-internal v1.1.7 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking tokio v1.41.1 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking zerofrom v0.1.4 [INFO] [stderr] Checking thiserror v1.0.68 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking yoke v0.7.4 [INFO] [stderr] Checking pin-project v1.1.7 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking serde v1.0.214 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Checking pingora-timeout v0.4.0 [INFO] [stderr] Checking pingora-runtime v0.4.0 [INFO] [stderr] Checking pingora-pool v0.4.0 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking flate2 v1.0.34 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.3 [INFO] [stderr] Checking pingora-core v0.4.0 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Checking hyper v0.14.31 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking hyperlocal v0.8.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Fixed src/services/listening.rs (1 fix) [INFO] [stderr] Fixed src/connectors/http/mod.rs (1 fix) [INFO] [stderr] Fixed src/modules/http/mod.rs (1 fix) [INFO] [stderr] Fixed src/listeners/mod.rs (1 fix) [INFO] [stderr] Fixed src/protocols/http/v1/client.rs (1 fix) [INFO] [stderr] Fixed src/protocols/http/compression/mod.rs (5 fixes) [INFO] [stderr] Fixed src/protocols/http/conditional_filter.rs (2 fixes) [INFO] [stderr] Fixed src/server/mod.rs (1 fix) [INFO] [stderr] Fixed src/connectors/http/v2.rs (3 fixes) [INFO] [stderr] Fixed src/server/daemon.rs (1 fix) [INFO] [stderr] Fixed src/protocols/http/v2/server.rs (1 fix) [INFO] [stderr] Fixed src/connectors/mod.rs (1 fix) [INFO] [stderr] Fixed src/protocols/http/v2/client.rs (3 fixes) [INFO] [stderr] Fixed src/protocols/http/v1/server.rs (2 fixes) [INFO] [stderr] Fixed src/listeners/l4.rs (1 fix) [INFO] [stderr] Fixed src/connectors/http/v1.rs (1 fix) [INFO] [stderr] Fixed src/protocols/l4/ext.rs (1 fix) [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/apps/http_app.rs:203:15 [INFO] [stdout] | [INFO] [stdout] 131 | #[async_trait] [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 162 | let mut module_ctx = self.modules.build_ctx(); [INFO] [stdout] | -------------- [INFO] [stdout] | | [INFO] [stdout] | `module_ctx` calls a custom destructor [INFO] [stdout] | `module_ctx` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | match http.finish().await { [INFO] [stdout] | ^^^^^^^^^^^^^^----- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes_mut.rs:1123:1 [INFO] [stdout] | [INFO] [stdout] 1123 | impl Drop for BytesMut { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/h2-0.4.6/src/proto/streams/streams.rs:1440:1 [INFO] [stdout] | [INFO] [stdout] 1440 | impl Drop for OpaqueStreamRef { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/h2-0.4.6/src/share.rs:480:1 [INFO] [stdout] | [INFO] [stdout] 480 | impl Drop for RecvStream { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `module_ctx` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/protocols/http/v1/server.rs:245:35 [INFO] [stdout] | [INFO] [stdout] 125 | let mut buf = BytesMut::with_capacity(INIT_HEADER_BUF_SIZE); [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `buf` calls a custom destructor [INFO] [stdout] | `buf` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | KeepaliveStatus::Timeout(d) => match timeout(d, read_event).await { [INFO] [stdout] | ---------------------------- [INFO] [stdout] | | [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | match escape_illegal_request_line(&buf) { Some(new_buf) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes_mut.rs:1123:1 [INFO] [stdout] | [INFO] [stdout] 1123 | impl Drop for BytesMut { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `buf` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes_mut.rs:1123:1 [INFO] [stdout] | [INFO] [stdout] 1123 | impl Drop for BytesMut { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `__awaitee` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking jemallocator v0.5.4 [INFO] [stderr] Fixed src/connectors/l4.rs (1 fix) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 40.12s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking pingora-core v0.4.0 (/tmp/fixit) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.34s [INFO] running `Command { std: "docker" "inspect" "8bc7f6708b9d112c720c27ad0f868801ec48d753d6ae354259dcc9a5889005c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8bc7f6708b9d112c720c27ad0f868801ec48d753d6ae354259dcc9a5889005c8", kill_on_drop: false }` [INFO] [stdout] 8bc7f6708b9d112c720c27ad0f868801ec48d753d6ae354259dcc9a5889005c8