[INFO] fetching crate libunftp 0.20.1... [INFO] checking libunftp-0.20.1 against try#da25749bf5e6ba5ed862ff361c19afff2a986b2d for pr-132712 [INFO] extracting crate libunftp 0.20.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate libunftp 0.20.1 on toolchain da25749bf5e6ba5ed862ff361c19afff2a986b2d [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libunftp 0.20.1 [INFO] finished tweaking crates.io crate libunftp 0.20.1 [INFO] tweaked toml for crates.io crate libunftp 0.20.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 170 packages to latest compatible versions [INFO] [stderr] Adding dashmap v5.5.3 (available: v6.1.0) [INFO] [stderr] Adding derive_more v0.99.18 (available: v1.0.0) [INFO] [stderr] Adding thiserror v1.0.68 (available: v2.0.1) [INFO] [stderr] Adding triomphe v0.1.11 (available: v0.1.14) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3181767f3885cd3f469a4f23163272282ceded4723a6431fcdbc872f72cf6e23 [INFO] running `Command { std: "docker" "start" "-a" "3181767f3885cd3f469a4f23163272282ceded4723a6431fcdbc872f72cf6e23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3181767f3885cd3f469a4f23163272282ceded4723a6431fcdbc872f72cf6e23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3181767f3885cd3f469a4f23163272282ceded4723a6431fcdbc872f72cf6e23", kill_on_drop: false }` [INFO] [stdout] 3181767f3885cd3f469a4f23163272282ceded4723a6431fcdbc872f72cf6e23 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 573491f4a20976c0d6670a8aebcaf8605455853a07615e6f6042b561eb7ccb6a [INFO] running `Command { std: "docker" "start" "-a" "573491f4a20976c0d6670a8aebcaf8605455853a07615e6f6042b561eb7ccb6a", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.162 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling aws-lc-rs v1.10.0 [INFO] [stderr] Compiling syn v2.0.87 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking rusticata-macros v4.1.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling slog v2.7.0 [INFO] [stderr] Checking rustls-pki-types v1.10.0 [INFO] [stderr] Checking mirai-annotations v1.12.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Compiling oid-registry v0.7.1 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling rustls v0.23.16 [INFO] [stderr] Compiling prometheus v0.13.4 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling moka v0.12.8 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking tagptr v0.2.0 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking triomphe v0.1.11 [INFO] [stderr] Checking slog-scope v4.4.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking slog-stdlog v4.1.1 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking pretty_assertions v1.4.1 [INFO] [stderr] Compiling cc v1.1.37 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling cmake v0.1.51 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking uuid v1.11.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Compiling aws-lc-sys v0.22.0 [INFO] [stderr] Compiling snafu-derive v0.6.10 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Checking snafu v0.6.10 [INFO] [stderr] Checking proxy-protocol v0.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.68 [INFO] [stderr] Compiling asn1-rs-impl v0.2.0 [INFO] [stderr] Compiling asn1-rs-derive v0.5.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking tokio v1.41.1 [INFO] [stderr] Checking thiserror v1.0.68 [INFO] [stderr] Checking asn1-rs v0.6.2 [INFO] [stderr] Checking der-parser v9.0.0 [INFO] [stderr] Checking x509-parser v0.16.0 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking libunftp v0.20.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/server/controlchan/commands/cwd.rs (3 fixes) [INFO] [stderr] Fixed src/server/proxy_protocol.rs (1 fix) [INFO] [stderr] Fixed src/server/controlchan/commands/stor.rs (1 fix) [INFO] [stderr] Fixed src/server/controlchan/commands/abor.rs (1 fix) [INFO] [stderr] Fixed src/server/controlchan/commands/auth.rs (1 fix) [INFO] [stderr] Fixed src/server/controlchan/notify.rs (1 fix) [INFO] [stderr] Fixed src/server/controlchan/commands/mdtm.rs (2 fixes) [INFO] [stderr] Fixed src/server/controlchan/commands/rnto.rs (2 fixes) [INFO] [stderr] Fixed src/server/controlchan/commands/md5.rs (2 fixes) [INFO] [stderr] Fixed src/server/controlchan/commands/dele.rs (2 fixes) [INFO] [stderr] Fixed src/server/controlchan/commands/pass.rs (1 fix) [INFO] [stderr] Fixed src/server/controlchan/commands/retr.rs (1 fix) [INFO] [stderr] Fixed src/server/controlchan/commands/size.rs (2 fixes) [INFO] [stderr] Fixed src/server/controlchan/commands/pasv.rs (1 fix) [INFO] [stderr] Fixed src/server/controlchan/commands/mkd.rs (3 fixes) [INFO] [stderr] Fixed src/server/ftpserver/listen_proxied.rs (8 fixes) [INFO] [stderr] Fixed src/server/controlchan/commands/rmd.rs (3 fixes) [INFO] [stderr] Fixed src/server/controlchan/commands/stat.rs (2 fixes) [INFO] [stderr] Fixed src/server/ftpserver/listen.rs (1 fix) [INFO] [stderr] Fixed src/server/controlchan/commands/nlst.rs (1 fix) [INFO] [stderr] Fixed src/server/ftpserver.rs (1 fix) [INFO] [stderr] Fixed src/server/datachan.rs (7 fixes) [INFO] [stderr] Fixed src/server/controlchan/commands/stou.rs (1 fix) [INFO] [stderr] Fixed src/server/controlchan/commands/list.rs (1 fix) [INFO] [stderr] Fixed src/server/controlchan/control_loop.rs (2 fixes) [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/server/controlchan/commands/abor.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 26 | #[async_trait] [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 35 | let mut session = args.session.lock().await; [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | `session` calls a custom destructor [INFO] [stdout] | `session` will be dropped later as of Edition 2024 [INFO] [stdout] 36 | let logger = args.logger; [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | `logger` calls a custom destructor [INFO] [stdout] | `logger` will be dropped later as of Edition 2024 [INFO] [stdout] 37 | match session.data_abort_tx.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mpsc/chan.rs:225:1 [INFO] [stdout] | [INFO] [stdout] 225 | impl Drop for Tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `session` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mutex.rs:963:1 [INFO] [stdout] | [INFO] [stdout] 963 | impl Drop for MutexGuard<'_, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `logger` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/server/controlchan/commands/list.rs:49:15 [INFO] [stdout] | [INFO] [stdout] 31 | #[async_trait] [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 40 | let mut session = args.session.lock().await; [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | `session` calls a custom destructor [INFO] [stdout] | `session` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let logger = args.logger; [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | `logger` calls a custom destructor [INFO] [stdout] | `logger` will be dropped later as of Edition 2024 [INFO] [stdout] 49 | match session.data_cmd_tx.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mpsc/chan.rs:225:1 [INFO] [stdout] | [INFO] [stdout] 225 | impl Drop for Tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `session` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mutex.rs:963:1 [INFO] [stdout] | [INFO] [stdout] 963 | impl Drop for MutexGuard<'_, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `logger` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/server/controlchan/commands/nlst.rs:50:15 [INFO] [stdout] | [INFO] [stdout] 32 | #[async_trait] [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 41 | let mut session = args.session.lock().await; [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | `session` calls a custom destructor [INFO] [stdout] | `session` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let logger = args.logger; [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | `logger` calls a custom destructor [INFO] [stdout] | `logger` will be dropped later as of Edition 2024 [INFO] [stdout] 50 | match session.data_cmd_tx.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mpsc/chan.rs:225:1 [INFO] [stdout] | [INFO] [stdout] 225 | impl Drop for Tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `session` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mutex.rs:963:1 [INFO] [stdout] | [INFO] [stdout] 963 | impl Drop for MutexGuard<'_, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `logger` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/server/controlchan/commands/retr.rs:46:15 [INFO] [stdout] | [INFO] [stdout] 27 | #[async_trait] [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 36 | let mut session = args.session.lock().await; [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | `session` calls a custom destructor [INFO] [stdout] | `session` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let logger = args.logger; [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | `logger` calls a custom destructor [INFO] [stdout] | `logger` will be dropped later as of Edition 2024 [INFO] [stdout] 46 | match session.data_cmd_tx.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mpsc/chan.rs:225:1 [INFO] [stdout] | [INFO] [stdout] 225 | impl Drop for Tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `session` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mutex.rs:963:1 [INFO] [stdout] | [INFO] [stdout] 963 | impl Drop for MutexGuard<'_, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `logger` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/server/controlchan/commands/stor.rs:47:15 [INFO] [stdout] | [INFO] [stdout] 27 | #[async_trait] [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 36 | let mut session = args.session.lock().await; [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | `session` calls a custom destructor [INFO] [stdout] | `session` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let logger = args.logger; [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | `logger` calls a custom destructor [INFO] [stdout] | `logger` will be dropped later as of Edition 2024 [INFO] [stdout] 47 | match session.data_cmd_tx.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mpsc/chan.rs:225:1 [INFO] [stdout] | [INFO] [stdout] 225 | impl Drop for Tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `session` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mutex.rs:963:1 [INFO] [stdout] | [INFO] [stdout] 963 | impl Drop for MutexGuard<'_, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `logger` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/server/controlchan/commands/stou.rs:35:15 [INFO] [stdout] | [INFO] [stdout] 21 | #[async_trait] [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 30 | let mut session = args.session.lock().await; [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | `session` calls a custom destructor [INFO] [stdout] | `session` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let logger = args.logger; [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | `logger` calls a custom destructor [INFO] [stdout] | `logger` will be dropped later as of Edition 2024 [INFO] [stdout] 35 | match session.data_cmd_tx.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mpsc/chan.rs:225:1 [INFO] [stdout] | [INFO] [stdout] 225 | impl Drop for Tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `session` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mutex.rs:963:1 [INFO] [stdout] | [INFO] [stdout] 963 | impl Drop for MutexGuard<'_, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `logger` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/server/controlchan/control_loop.rs:475:30 [INFO] [stdout] | [INFO] [stdout] 416 | #[tracing_attributes::instrument] [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 433 | let handler: Box> = match cmd { [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `handler` calls a custom destructor [INFO] [stdout] | `handler` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 475 | handler.handle(args).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `handler` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/server/ftpserver/listen.rs:49:19 [INFO] [stdout] | [INFO] [stdout] 48 | let shutdown_listener = shutdown_topic.subscribe().await; [INFO] [stdout] | ----------------- [INFO] [stdout] | | [INFO] [stdout] | `shutdown_listener` calls a custom destructor [INFO] [stdout] | `shutdown_listener` will be dropped later as of Edition 2024 [INFO] [stdout] 49 | match listener.accept().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/io/poll_evented.rs:298:1 [INFO] [stdout] | [INFO] [stdout] 298 | impl Drop for PollEvented { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `shutdown_listener` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mpsc/chan.rs:225:1 [INFO] [stdout] | [INFO] [stdout] 225 | impl Drop for Tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `shutdown_listener` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/broadcast.rs:1343:1 [INFO] [stdout] | [INFO] [stdout] 1343 | impl Drop for Receiver { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/server/ftpserver/listen_proxied.rs:161:23 [INFO] [stdout] | [INFO] [stdout] 160 | let tx = tx.clone(); [INFO] [stdout] | -- [INFO] [stdout] | | [INFO] [stdout] | `tx` calls a custom destructor [INFO] [stdout] | `tx` will be dropped later as of Edition 2024 [INFO] [stdout] 161 | match tx.send(ControlChanMsg::CommandChannelReply(reply)).await { Err(err) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | } _ => {}} [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `tx` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mpsc/chan.rs:225:1 [INFO] [stdout] | [INFO] [stdout] 225 | impl Drop for Tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/pass_security.rs from 2021 edition to 2024 [INFO] [stdout] error[E0432]: unresolved import `unftp_sbe_fs` [INFO] [stdout] --> tests/common.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use unftp_sbe_fs::ServerExt; [INFO] [stdout] | ^^^^^^^^^^^^ use of undeclared crate or module `unftp_sbe_fs` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/common.rs from 2021 edition to 2024 [INFO] [stdout] error[E0599]: no function or associated item named `with_fs` found for struct `Server` in the current scope [INFO] [stdout] --> tests/common.rs:15:36 [INFO] [stdout] | [INFO] [stdout] 15 | let server = libunftp::Server::with_fs(std::env::temp_dir()) [INFO] [stdout] | ^^^^^^^ function or associated item not found in `Server<_, _>` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] Some errors have detailed explanations: E0432, E0599. [INFO] [stdout] [INFO] [stdout] For more information about an error, try `rustc --explain E0432`. [INFO] [stdout] [INFO] [stderr] error: could not compile `libunftp` (test "pass_security") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error[E0432]: unresolved import `unftp_sbe_fs` [INFO] [stdout] --> tests/common.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use unftp_sbe_fs::ServerExt; [INFO] [stdout] | ^^^^^^^^^^^^ use of undeclared crate or module `unftp_sbe_fs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0599]: no function or associated item named `with_fs` found for struct `Server` in the current scope [INFO] [stdout] --> tests/common.rs:15:36 [INFO] [stdout] | [INFO] [stdout] 15 | let server = libunftp::Server::with_fs(std::env::temp_dir()) [INFO] [stdout] | ^^^^^^^ function or associated item not found in `Server<_, _>` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] Some errors have detailed explanations: E0432, E0599. [INFO] [stdout] [INFO] [stdout] For more information about an error, try `rustc --explain E0432`. [INFO] [stdout] [INFO] [stderr] error: could not compile `libunftp` (test "common") due to 2 previous errors [INFO] [stderr] error: failed to migrate to next edition [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo fix --edition --allow-no-vcs --allow-dirty --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "573491f4a20976c0d6670a8aebcaf8605455853a07615e6f6042b561eb7ccb6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "573491f4a20976c0d6670a8aebcaf8605455853a07615e6f6042b561eb7ccb6a", kill_on_drop: false }` [INFO] [stdout] 573491f4a20976c0d6670a8aebcaf8605455853a07615e6f6042b561eb7ccb6a