[INFO] fetching crate libp2p-core 0.42.0... [INFO] checking libp2p-core-0.42.0 against try#da25749bf5e6ba5ed862ff361c19afff2a986b2d for pr-132712 [INFO] extracting crate libp2p-core 0.42.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate libp2p-core 0.42.0 on toolchain da25749bf5e6ba5ed862ff361c19afff2a986b2d [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libp2p-core 0.42.0 [INFO] finished tweaking crates.io crate libp2p-core 0.42.0 [INFO] tweaked toml for crates.io crate libp2p-core 0.42.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 185 packages to latest compatible versions [INFO] [stderr] Adding thiserror v1.0.68 (available: v2.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 38e20e4db3d4c807ad92def7e20db7c18902a4f04b214db77202529a6a5ae02f [INFO] running `Command { std: "docker" "start" "-a" "38e20e4db3d4c807ad92def7e20db7c18902a4f04b214db77202529a6a5ae02f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "38e20e4db3d4c807ad92def7e20db7c18902a4f04b214db77202529a6a5ae02f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "38e20e4db3d4c807ad92def7e20db7c18902a4f04b214db77202529a6a5ae02f", kill_on_drop: false }` [INFO] [stdout] 38e20e4db3d4c807ad92def7e20db7c18902a4f04b214db77202529a6a5ae02f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d28c4d95fd89a166b6a3fffa0e3d79afab926b2534eee57cd5df8d376486a5e1 [INFO] running `Command { std: "docker" "start" "-a" "d28c4d95fd89a166b6a3fffa0e3d79afab926b2534eee57cd5df8d376486a5e1", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Checking pin-project-lite v0.2.15 [INFO] [stderr] Compiling libc v0.2.162 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking writeable v0.5.5 [INFO] [stderr] Checking parking v2.2.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking value-bag v1.10.0 [INFO] [stderr] Compiling syn v2.0.87 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking litemap v0.7.3 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking icu_locid_transform_data v1.5.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking fastrand v2.2.0 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking icu_properties_data v1.5.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking utf16_iter v1.0.5 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking write16 v1.0.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling rustix v0.38.39 [INFO] [stderr] Checking icu_normalizer_data v1.5.0 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking futures-lite v2.5.0 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Compiling thiserror v1.0.68 [INFO] [stderr] Compiling data-encoding v2.6.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking arbitrary v1.4.1 [INFO] [stderr] Checking unsigned-varint v0.8.0 [INFO] [stderr] Compiling serde v1.0.214 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking quick-protobuf v0.8.1 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking bs58 v0.5.1 [INFO] [stderr] Checking base-x v0.2.11 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking unsigned-varint v0.7.2 [INFO] [stderr] Checking arrayref v0.3.9 [INFO] [stderr] Checking bytes v1.8.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking async-executor v1.13.1 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking web-time v1.1.0 [INFO] [stderr] Checking regex-automata v0.4.8 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Compiling data-encoding-macro-internal v0.1.13 [INFO] [stderr] Compiling async-attributes v1.1.2 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking data-encoding-macro v0.1.15 [INFO] [stderr] Checking multibase v0.9.1 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.4 [INFO] [stderr] Compiling yoke-derive v0.7.4 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.7 [INFO] [stderr] Compiling thiserror-impl v1.0.68 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking pin-project v1.1.7 [INFO] [stderr] Checking zerofrom v0.1.4 [INFO] [stderr] Checking yoke v0.7.4 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking polling v3.7.4 [INFO] [stderr] Checking async-io v2.4.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking async-std v1.13.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking multihash v0.19.2 [INFO] [stderr] Checking libp2p-identity v0.2.9 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking multistream-select v0.13.0 [INFO] [stderr] Checking rw-stream-sink v0.4.0 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.3 [INFO] [stderr] Checking multiaddr v0.18.2 [INFO] [stderr] Checking libp2p-core v0.42.0 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `libp2p_core` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/transport/global_only.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0308]: mismatched types [INFO] [stderr] --> src/transport/global_only.rs:321:34 [INFO] [stderr] | [INFO] [stderr] 272 | impl crate::Transport for Transport { [INFO] [stderr] | - found this type parameter [INFO] [stderr] ... [INFO] [stderr] 321 | Transport::poll(Pin::new(&mut self.inner), cx) [INFO] [stderr] | -------- ^^^^^^^^^^^^^^^ expected `&mut Transport<_>`, found `&mut T` [INFO] [stderr] | | [INFO] [stderr] | arguments to this function are incorrect [INFO] [stderr] | [INFO] [stderr] = note: expected mutable reference `&mut global_only::Transport<_>` [INFO] [stderr] found mutable reference `&mut T` [INFO] [stderr] note: associated function defined here [INFO] [stderr] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/core/src/pin.rs:1191:18 [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0308`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/either.rs:85:44 [INFO] [stdout] | [INFO] [stdout] 85 | future::Either::Left(inner) => inner.poll(cx).map_err(Either::Left), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: disambiguate the associated function: `StreamMuxer::poll(inner, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn rust-2024-prelude-collisions` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/either.rs:86:45 [INFO] [stdout] | [INFO] [stdout] 86 | future::Either::Right(inner) => inner.poll(cx).map_err(Either::Right), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: disambiguate the associated function: `StreamMuxer::poll(inner, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/either.rs:134:38 [INFO] [stdout] | [INFO] [stdout] 134 | Either::Left(a) => match a.poll(cx) { [INFO] [stdout] | ^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(a, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/either.rs:140:39 [INFO] [stdout] | [INFO] [stdout] 140 | Either::Right(b) => match b.poll(cx) { [INFO] [stdout] | ^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(b, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/muxing/boxed.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | self.project().inner.poll(cx).map_err(into_io_error) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `StreamMuxer::poll(self.project().inner, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/muxing.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | Pin::new(self).poll(cx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `StreamMuxer::poll(Pin::new(self), cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/and_then.rs:100:15 [INFO] [stdout] | [INFO] [stdout] 100 | match this.transport.poll(cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(this.transport, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/choice.rs:148:15 [INFO] [stdout] | [INFO] [stdout] 148 | match this.0.poll(cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(this.0, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/choice.rs:154:15 [INFO] [stdout] | [INFO] [stdout] 154 | match this.1.poll(cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(this.1, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/global_only.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 321 | Pin::new(&mut self.inner).poll(cx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(Pin::new(&mut self.inner), cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/map.rs:99:15 [INFO] [stdout] | [INFO] [stdout] 99 | match this.transport.poll(cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(this.transport, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/map_err.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | this.transport.poll(cx).map(|ev| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(this.transport, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/timeout.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | this.inner.poll(cx).map(|event| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(this.inner, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/upgrade.rs:363:9 [INFO] [stdout] | [INFO] [stdout] 363 | self.project().0.poll(cx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(self.project().0, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/upgrade.rs:436:9 [INFO] [stdout] | [INFO] [stdout] 436 | this.inner.poll(cx).map(|event| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(this.inner, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/boxed.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | self.poll(cx).map(|event| { [INFO] [stdout] | ^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(self, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/optional.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 100 | inner.poll(cx) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(inner, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transport.rs:432:12 [INFO] [stdout] | [INFO] [stdout] 432 | if let TransportEvent::NewAddress { listen_addr, .. } = self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transport.rs:434:9 [INFO] [stdout] | [INFO] [stdout] 434 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 432 ~ match self { TransportEvent::NewAddress { listen_addr, .. } => { [INFO] [stdout] 433 | Some(listen_addr) [INFO] [stdout] 434 ~ } _ => { [INFO] [stdout] 435 | None [INFO] [stdout] 436 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transport.rs:449:12 [INFO] [stdout] | [INFO] [stdout] 449 | if let TransportEvent::AddressExpired { listen_addr, .. } = self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transport.rs:451:9 [INFO] [stdout] | [INFO] [stdout] 451 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 449 ~ match self { TransportEvent::AddressExpired { listen_addr, .. } => { [INFO] [stdout] 450 | Some(listen_addr) [INFO] [stdout] 451 ~ } _ => { [INFO] [stdout] 452 | None [INFO] [stdout] 453 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transport.rs:466:12 [INFO] [stdout] | [INFO] [stdout] 466 | if let TransportEvent::ListenerError { error, .. } = self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transport.rs:468:9 [INFO] [stdout] | [INFO] [stdout] 468 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 466 ~ match self { TransportEvent::ListenerError { error, .. } => { [INFO] [stdout] 467 | Some(error) [INFO] [stdout] 468 ~ } _ => { [INFO] [stdout] 469 | None [INFO] [stdout] 470 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transport/memory.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 200 | if let Some(index) = self.listeners.iter().position(|listener| listener.id == id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^--------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transport/memory.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 206 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 200 ~ match self.listeners.iter().position(|listener| listener.id == id) { Some(index) => { [INFO] [stdout] 201 | let listener = self.listeners.get_mut(index).unwrap(); [INFO] [stdout] ... [INFO] [stdout] 205 | true [INFO] [stdout] 206 ~ } _ => { [INFO] [stdout] 207 | false [INFO] [stdout] 208 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transport/memory.rs:267:16 [INFO] [stdout] | [INFO] [stdout] 267 | if let Some(event) = event { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transport/memory.rs:269:13 [INFO] [stdout] | [INFO] [stdout] 269 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 267 ~ match event { Some(event) => { [INFO] [stdout] 268 | return Poll::Ready(event); [INFO] [stdout] 269 ~ } _ => { [INFO] [stdout] 270 | remaining -= 1; [INFO] [stdout] ... [INFO] [stdout] 273 | } [INFO] [stdout] 274 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transport/optional.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 68 | if let Some(inner) = self.0.as_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transport/optional.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 68 ~ match self.0.as_mut() { Some(inner) => { [INFO] [stdout] 69 | inner.listen_on(id, addr) [INFO] [stdout] 70 ~ } _ => { [INFO] [stdout] 71 | Err(TransportError::MultiaddrNotSupported(addr)) [INFO] [stdout] 72 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transport/optional.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 76 | if let Some(inner) = self.0.as_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transport/optional.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 76 ~ match self.0.as_mut() { Some(inner) => { [INFO] [stdout] 77 | inner.remove_listener(id) [INFO] [stdout] 78 ~ } _ => { [INFO] [stdout] 79 | false [INFO] [stdout] 80 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transport/optional.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 88 | if let Some(inner) = self.0.as_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transport/optional.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 88 ~ match self.0.as_mut() { Some(inner) => { [INFO] [stdout] 89 | inner.dial(addr, opts) [INFO] [stdout] 90 ~ } _ => { [INFO] [stdout] 91 | Err(TransportError::MultiaddrNotSupported(addr)) [INFO] [stdout] 92 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/transport_upgrade.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `libp2p_core` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/transport/global_only.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0308]: mismatched types [INFO] [stderr] --> src/transport/global_only.rs:321:34 [INFO] [stderr] | [INFO] [stderr] 272 | impl crate::Transport for Transport { [INFO] [stderr] | - found this type parameter [INFO] [stderr] ... [INFO] [stderr] 321 | Transport::poll(Pin::new(&mut self.inner), cx) [INFO] [stderr] | -------- ^^^^^^^^^^^^^^^ expected `&mut Transport<_>`, found `&mut T` [INFO] [stderr] | | [INFO] [stderr] | arguments to this function are incorrect [INFO] [stderr] | [INFO] [stderr] = note: expected mutable reference `&mut global_only::Transport<_>` [INFO] [stderr] found mutable reference `&mut T` [INFO] [stderr] note: associated function defined here [INFO] [stderr] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/core/src/pin.rs:1191:18 [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0308`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/either.rs:85:44 [INFO] [stdout] | [INFO] [stdout] 85 | future::Either::Left(inner) => inner.poll(cx).map_err(Either::Left), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: disambiguate the associated function: `StreamMuxer::poll(inner, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn rust-2024-prelude-collisions` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/either.rs:86:45 [INFO] [stdout] | [INFO] [stdout] 86 | future::Either::Right(inner) => inner.poll(cx).map_err(Either::Right), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: disambiguate the associated function: `StreamMuxer::poll(inner, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/either.rs:134:38 [INFO] [stdout] | [INFO] [stdout] 134 | Either::Left(a) => match a.poll(cx) { [INFO] [stdout] | ^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(a, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/either.rs:140:39 [INFO] [stdout] | [INFO] [stdout] 140 | Either::Right(b) => match b.poll(cx) { [INFO] [stdout] | ^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(b, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/muxing/boxed.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | self.project().inner.poll(cx).map_err(into_io_error) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `StreamMuxer::poll(self.project().inner, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/muxing.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | Pin::new(self).poll(cx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `StreamMuxer::poll(Pin::new(self), cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/and_then.rs:100:15 [INFO] [stdout] | [INFO] [stdout] 100 | match this.transport.poll(cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(this.transport, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/choice.rs:148:15 [INFO] [stdout] | [INFO] [stdout] 148 | match this.0.poll(cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(this.0, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/choice.rs:154:15 [INFO] [stdout] | [INFO] [stdout] 154 | match this.1.poll(cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(this.1, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/global_only.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 321 | Pin::new(&mut self.inner).poll(cx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(Pin::new(&mut self.inner), cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/map.rs:99:15 [INFO] [stdout] | [INFO] [stdout] 99 | match this.transport.poll(cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(this.transport, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/map_err.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | this.transport.poll(cx).map(|ev| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(this.transport, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/timeout.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | this.inner.poll(cx).map(|event| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(this.inner, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/upgrade.rs:363:9 [INFO] [stdout] | [INFO] [stdout] 363 | self.project().0.poll(cx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(self.project().0, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/upgrade.rs:436:9 [INFO] [stdout] | [INFO] [stdout] 436 | this.inner.poll(cx).map(|event| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(this.inner, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/boxed.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | self.poll(cx).map(|event| { [INFO] [stdout] | ^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(self, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `poll` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/transport/optional.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 100 | inner.poll(cx) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: disambiguate the associated function: `Transport::poll(inner, cx)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transport.rs:432:12 [INFO] [stdout] | [INFO] [stdout] 432 | if let TransportEvent::NewAddress { listen_addr, .. } = self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transport.rs:434:9 [INFO] [stdout] | [INFO] [stdout] 434 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 432 ~ match self { TransportEvent::NewAddress { listen_addr, .. } => { [INFO] [stdout] 433 | Some(listen_addr) [INFO] [stdout] 434 ~ } _ => { [INFO] [stdout] 435 | None [INFO] [stdout] 436 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transport.rs:449:12 [INFO] [stdout] | [INFO] [stdout] 449 | if let TransportEvent::AddressExpired { listen_addr, .. } = self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transport.rs:451:9 [INFO] [stdout] | [INFO] [stdout] 451 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 449 ~ match self { TransportEvent::AddressExpired { listen_addr, .. } => { [INFO] [stdout] 450 | Some(listen_addr) [INFO] [stdout] 451 ~ } _ => { [INFO] [stdout] 452 | None [INFO] [stdout] 453 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transport.rs:466:12 [INFO] [stdout] | [INFO] [stdout] 466 | if let TransportEvent::ListenerError { error, .. } = self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transport.rs:468:9 [INFO] [stdout] | [INFO] [stdout] 468 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 466 ~ match self { TransportEvent::ListenerError { error, .. } => { [INFO] [stdout] 467 | Some(error) [INFO] [stdout] 468 ~ } _ => { [INFO] [stdout] 469 | None [INFO] [stdout] 470 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transport/memory.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 200 | if let Some(index) = self.listeners.iter().position(|listener| listener.id == id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^--------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transport/memory.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 206 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 200 ~ match self.listeners.iter().position(|listener| listener.id == id) { Some(index) => { [INFO] [stdout] 201 | let listener = self.listeners.get_mut(index).unwrap(); [INFO] [stdout] ... [INFO] [stdout] 205 | true [INFO] [stdout] 206 ~ } _ => { [INFO] [stdout] 207 | false [INFO] [stdout] 208 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transport/memory.rs:267:16 [INFO] [stdout] | [INFO] [stdout] 267 | if let Some(event) = event { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transport/memory.rs:269:13 [INFO] [stdout] | [INFO] [stdout] 269 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 267 ~ match event { Some(event) => { [INFO] [stdout] 268 | return Poll::Ready(event); [INFO] [stdout] 269 ~ } _ => { [INFO] [stdout] 270 | remaining -= 1; [INFO] [stdout] ... [INFO] [stdout] 273 | } [INFO] [stdout] 274 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transport/memory.rs:558:20 [INFO] [stdout] | [INFO] [stdout] 558 | if let Some(upgrade) = event.into_incoming() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transport/memory.rs:560:17 [INFO] [stdout] | [INFO] [stdout] 560 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 558 ~ match event.into_incoming() { Some(upgrade) => { [INFO] [stdout] 559 | break upgrade; [INFO] [stdout] 560 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transport/memory.rs:607:20 [INFO] [stdout] | [INFO] [stdout] 607 | if let TransportEvent::Incoming { send_back_addr, .. } = [INFO] [stdout] | ____________________^ [INFO] [stdout] 608 | | listener_transport.select_next_some().await [INFO] [stdout] | |_____________________------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transport/memory.rs:615:17 [INFO] [stdout] | [INFO] [stdout] 615 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 607 ~ match listener_transport.select_next_some().await [INFO] [stdout] 608 ~ { TransportEvent::Incoming { send_back_addr, .. } => { [INFO] [stdout] 609 | assert!( [INFO] [stdout] ... [INFO] [stdout] 613 | return; [INFO] [stdout] 614 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transport/memory.rs:652:20 [INFO] [stdout] | [INFO] [stdout] 652 | if let TransportEvent::Incoming { send_back_addr, .. } = [INFO] [stdout] | ____________________^ [INFO] [stdout] 653 | | listener_transport.select_next_some().await [INFO] [stdout] | |_____________________------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transport/memory.rs:672:17 [INFO] [stdout] | [INFO] [stdout] 672 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 652 ~ match listener_transport.select_next_some().await [INFO] [stdout] 653 ~ { TransportEvent::Incoming { send_back_addr, .. } => { [INFO] [stdout] 654 | let dialer_port = [INFO] [stdout] ... [INFO] [stdout] 670 | return; [INFO] [stdout] 671 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transport/optional.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 68 | if let Some(inner) = self.0.as_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transport/optional.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 68 ~ match self.0.as_mut() { Some(inner) => { [INFO] [stdout] 69 | inner.listen_on(id, addr) [INFO] [stdout] 70 ~ } _ => { [INFO] [stdout] 71 | Err(TransportError::MultiaddrNotSupported(addr)) [INFO] [stdout] 72 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transport/optional.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 76 | if let Some(inner) = self.0.as_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transport/optional.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 76 ~ match self.0.as_mut() { Some(inner) => { [INFO] [stdout] 77 | inner.remove_listener(id) [INFO] [stdout] 78 ~ } _ => { [INFO] [stdout] 79 | false [INFO] [stdout] 80 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transport/optional.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 88 | if let Some(inner) = self.0.as_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transport/optional.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 88 ~ match self.0.as_mut() { Some(inner) => { [INFO] [stdout] 89 | inner.dial(addr, opts) [INFO] [stdout] 90 ~ } _ => { [INFO] [stdout] 91 | Err(TransportError::MultiaddrNotSupported(addr)) [INFO] [stdout] 92 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0432]: unresolved import `libp2p_mplex` [INFO] [stdout] --> tests/transport_upgrade.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | use libp2p_mplex::MplexConfig; [INFO] [stdout] | ^^^^^^^^^^^^ use of undeclared crate or module `libp2p_mplex` [INFO] [stdout] | [INFO] [stdout] help: there is a crate or module with a similar name [INFO] [stdout] | [INFO] [stdout] 28 | use libp2p_core::MplexConfig; [INFO] [stdout] | ~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0432]: unresolved import `libp2p_noise` [INFO] [stdout] --> tests/transport_upgrade.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | use libp2p_noise as noise; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ no external crate `libp2p_noise` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0432`. [INFO] [stdout] [INFO] [stderr] error: could not compile `libp2p-core` (test "transport_upgrade") due to 2 previous errors [INFO] [stderr] error: failed to migrate to next edition [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo fix --edition --allow-no-vcs --allow-dirty --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "d28c4d95fd89a166b6a3fffa0e3d79afab926b2534eee57cd5df8d376486a5e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d28c4d95fd89a166b6a3fffa0e3d79afab926b2534eee57cd5df8d376486a5e1", kill_on_drop: false }` [INFO] [stdout] d28c4d95fd89a166b6a3fffa0e3d79afab926b2534eee57cd5df8d376486a5e1