[INFO] fetching crate gcp_auth 0.12.3... [INFO] checking gcp_auth-0.12.3 against try#da25749bf5e6ba5ed862ff361c19afff2a986b2d for pr-132712 [INFO] extracting crate gcp_auth 0.12.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate gcp_auth 0.12.3 on toolchain da25749bf5e6ba5ed862ff361c19afff2a986b2d [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gcp_auth 0.12.3 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate gcp_auth 0.12.3 [INFO] tweaked toml for crates.io crate gcp_auth 0.12.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate gcp_auth 0.12.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8b2ec454fd92ab25954729ba98ddf16146e709a4e68fef600deab7a6ea2aa6c8 [INFO] running `Command { std: "docker" "start" "-a" "8b2ec454fd92ab25954729ba98ddf16146e709a4e68fef600deab7a6ea2aa6c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8b2ec454fd92ab25954729ba98ddf16146e709a4e68fef600deab7a6ea2aa6c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b2ec454fd92ab25954729ba98ddf16146e709a4e68fef600deab7a6ea2aa6c8", kill_on_drop: false }` [INFO] [stdout] 8b2ec454fd92ab25954729ba98ddf16146e709a4e68fef600deab7a6ea2aa6c8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 551f3d0c84f05f6c2546ff606037697958417959d70ee5d8079bc2182a580ec9 [INFO] running `Command { std: "docker" "start" "-a" "551f3d0c84f05f6c2546ff606037697958417959d70ee5d8079bc2182a580ec9", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.87 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking bytes v1.7.2 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Checking rustls-pki-types v1.9.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking hashbrown v0.15.0 [INFO] [stderr] Compiling httparse v1.9.5 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Compiling rustls v0.23.14 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling cc v1.1.30 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Checking unicode-bidi v0.3.17 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking rustls-native-certs v0.8.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking indexmap v2.6.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking regex-automata v0.4.8 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking regex v1.11.0 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling pin-project-internal v1.1.6 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking pin-project v1.1.6 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.9 [INFO] [stderr] Checking hyper-rustls v0.27.3 [INFO] [stderr] Checking gcp_auth v0.12.3 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/gcloud_authorized_user.rs (1 fix) [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/config_default_credentials.rs:33:36 [INFO] [stdout] | [INFO] [stdout] 32 | let client = HttpClient::new()?; [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | `client` calls a custom destructor [INFO] [stdout] | `client` will be dropped later as of Edition 2024 [INFO] [stdout] 33 | Self::with_client(&client).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 34 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/futures-channel-0.3.31/src/oneshot.rs:387:1 [INFO] [stdout] | [INFO] [stdout] 387 | impl Drop for Sender { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/futures-channel-0.3.31/src/oneshot.rs:387:1 [INFO] [stdout] | [INFO] [stdout] 387 | impl Drop for Sender { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.7.2/src/bytes.rs:571:1 [INFO] [stdout] | [INFO] [stdout] 571 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/sync/mpsc/chan.rs:225:1 [INFO] [stdout] | [INFO] [stdout] 225 | impl Drop for Tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `client` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `client` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/futures-channel-0.3.31/src/oneshot.rs:387:1 [INFO] [stdout] | [INFO] [stdout] 387 | impl Drop for Sender { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `client` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/futures-channel-0.3.31/src/oneshot.rs:387:1 [INFO] [stdout] | [INFO] [stdout] 387 | impl Drop for Sender { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `client` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.7.2/src/bytes.rs:571:1 [INFO] [stdout] | [INFO] [stdout] 571 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `client` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/sync/mpsc/chan.rs:225:1 [INFO] [stdout] | [INFO] [stdout] 225 | impl Drop for Tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/metadata_service_account.rs:28:36 [INFO] [stdout] | [INFO] [stdout] 27 | let client = HttpClient::new()?; [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | `client` calls a custom destructor [INFO] [stdout] | `client` will be dropped later as of Edition 2024 [INFO] [stdout] 28 | Self::with_client(&client).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 29 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: `client` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `client` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/futures-channel-0.3.31/src/oneshot.rs:387:1 [INFO] [stdout] | [INFO] [stdout] 387 | impl Drop for Sender { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `client` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/futures-channel-0.3.31/src/oneshot.rs:387:1 [INFO] [stdout] | [INFO] [stdout] 387 | impl Drop for Sender { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `client` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.7.2/src/bytes.rs:571:1 [INFO] [stdout] | [INFO] [stdout] 571 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `client` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/sync/mpsc/chan.rs:225:1 [INFO] [stdout] | [INFO] [stdout] 225 | impl Drop for Tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/simple.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.55s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking gcp_auth v0.12.3 (/tmp/fixit) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.77s [INFO] running `Command { std: "docker" "inspect" "551f3d0c84f05f6c2546ff606037697958417959d70ee5d8079bc2182a580ec9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "551f3d0c84f05f6c2546ff606037697958417959d70ee5d8079bc2182a580ec9", kill_on_drop: false }` [INFO] [stdout] 551f3d0c84f05f6c2546ff606037697958417959d70ee5d8079bc2182a580ec9