[INFO] fetching crate duplicate 2.0.0... [INFO] checking duplicate-2.0.0 against try#da25749bf5e6ba5ed862ff361c19afff2a986b2d for pr-132712 [INFO] extracting crate duplicate 2.0.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate duplicate 2.0.0 on toolchain da25749bf5e6ba5ed862ff361c19afff2a986b2d [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate duplicate 2.0.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate duplicate 2.0.0 [INFO] tweaked toml for crates.io crate duplicate 2.0.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 42 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fe2a13ed362505f610a95e99ddb4c37ad0ddd42d1fd35edccf4d419b96f0831a [INFO] running `Command { std: "docker" "start" "-a" "fe2a13ed362505f610a95e99ddb4c37ad0ddd42d1fd35edccf4d419b96f0831a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fe2a13ed362505f610a95e99ddb4c37ad0ddd42d1fd35edccf4d419b96f0831a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe2a13ed362505f610a95e99ddb4c37ad0ddd42d1fd35edccf4d419b96f0831a", kill_on_drop: false }` [INFO] [stdout] fe2a13ed362505f610a95e99ddb4c37ad0ddd42d1fd35edccf4d419b96f0831a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 93ae7b5c33c220cb2f3e7b35c688f6d1cd2e6e078490fc3c2da30f041f126805 [INFO] running `Command { std: "docker" "start" "-a" "93ae7b5c33c220cb2f3e7b35c688f6d1cd2e6e078490fc3c2da30f041f126805", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.89 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling serde v1.0.214 [INFO] [stderr] Compiling libc v0.2.162 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking hashbrown v0.15.1 [INFO] [stderr] Checking winnow v0.6.20 [INFO] [stderr] Compiling serde_json v1.0.132 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Compiling rustversion v1.0.18 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking heck v0.5.0 [INFO] [stderr] Compiling proc-macro2-diagnostics v0.10.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking indexmap v2.6.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking syn v2.0.87 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking regex-automata v0.4.8 [INFO] [stderr] Checking duplicate v2.0.0 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/token_iter.rs (5 fixes) [INFO] [stderr] Fixed src/module_disambiguation.rs (1 fix) [INFO] [stderr] Fixed src/parse.rs (5 fixes) [INFO] [stderr] Fixed src/substitute.rs (3 fixes) [INFO] [stderr] Compiling serde_derive v1.0.214 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/parse.rs:422:11 [INFO] [stdout] | [INFO] [stdout] 412 | let (group, _) = iter [INFO] [stdout] | ______________________________- [INFO] [stdout] 413 | | .next_group(Some(Delimiter::Bracket)) [INFO] [stdout] 414 | | .map_err(|err| err.hint(error))?; [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | |________________________________________________this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 422 | match iter.next_group(Some(Delimiter::Bracket)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 427 | } _ => {}} [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/proc_macro/src/bridge/client.rs:100:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/proc_macro/src/bridge/client.rs:100:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/proc_macro/src/bridge/client.rs:100:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] = note: this warning originates in the macro `define_client_handles` which comes from the expansion of the macro `with_api_handle_types` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/substitute.rs:73:27 [INFO] [stdout] | [INFO] [stdout] 73 | while let Some(token) = stream.next_fallible()? [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#5` [INFO] [stdout] | | up until Edition 2021 `#5` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `token` calls a custom destructor [INFO] [stdout] | `token` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | if let Some(sub_stream) = saved_tokens.take() [INFO] [stdout] | ------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | if let Some(sub_stream) = saved_tokens.take() [INFO] [stdout] | ------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | substitutions.push(SubType::Group(del, Substitution::new(arguments, iter)?)); [INFO] [stdout] | ----------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/proc_macro/src/bridge/client.rs:100:1 [INFO] [stdout] note: `#5` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/proc_macro/src/bridge/client.rs:100:1 [INFO] [stdout] note: `token` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/proc_macro/src/bridge/client.rs:100:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/proc_macro/src/bridge/client.rs:100:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/proc_macro/src/bridge/client.rs:100:1 [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/proc_macro/src/bridge/client.rs:100:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: this warning originates in the macro `define_client_handles` which comes from the expansion of the macro `with_api_handle_types` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/substitute.rs:169:11 [INFO] [stdout] | [INFO] [stdout] 168 | let mut iter = token.clone().into_iter(); [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | `iter` calls a custom destructor [INFO] [stdout] | `iter` will be dropped later as of Edition 2024 [INFO] [stdout] 169 | match iter.next()? [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | } _ => {}} [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/proc_macro/src/bridge/client.rs:100:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/proc_macro/src/bridge/client.rs:100:1 [INFO] [stdout] note: `iter` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/proc_macro/src/bridge/client.rs:100:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: this warning originates in the macro `define_client_handles` which comes from the expansion of the macro `with_api_handle_types` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/substitute.rs:268:14 [INFO] [stdout] | [INFO] [stdout] 268 | match group_iter.next_group(Some(Delimiter::Bracket)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | args.push(duplicate_and_substitute( [INFO] [stdout] | _______________________________________________- [INFO] [stdout] 273 | | group.to_token_stream(), [INFO] [stdout] 274 | | global_subs, [INFO] [stdout] 275 | | Some(substitutions).into_iter(), [INFO] [stdout] 276 | | )?); [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |______________________________________this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 296 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/proc_macro/src/bridge/client.rs:100:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/proc_macro/src/bridge/client.rs:100:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: this warning originates in the macro `define_client_handles` which comes from the expansion of the macro `with_api_handle_types` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.8 [INFO] [stderr] Checking toml_edit v0.22.22 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking duplicate_macrotest v1.0.7 [INFO] [stderr] Migrating tests/tests.rs from 2021 edition to 2024 [INFO] [stderr] Fixed tests/utils.rs (2 fixes) [INFO] [stderr] Migrating tests/utils.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.11s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Compiling duplicate v2.0.0 (/tmp/fixit) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.68s [INFO] running `Command { std: "docker" "inspect" "93ae7b5c33c220cb2f3e7b35c688f6d1cd2e6e078490fc3c2da30f041f126805", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93ae7b5c33c220cb2f3e7b35c688f6d1cd2e6e078490fc3c2da30f041f126805", kill_on_drop: false }` [INFO] [stdout] 93ae7b5c33c220cb2f3e7b35c688f6d1cd2e6e078490fc3c2da30f041f126805