[INFO] fetching crate deno_task_shell 0.18.1... [INFO] checking deno_task_shell-0.18.1 against try#da25749bf5e6ba5ed862ff361c19afff2a986b2d for pr-132712 [INFO] extracting crate deno_task_shell 0.18.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate deno_task_shell 0.18.1 on toolchain da25749bf5e6ba5ed862ff361c19afff2a986b2d [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-7-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate deno_task_shell 0.18.1 [INFO] finished tweaking crates.io crate deno_task_shell 0.18.1 [INFO] tweaked toml for crates.io crate deno_task_shell 0.18.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 74 packages to latest compatible versions [INFO] [stderr] Adding thiserror v1.0.68 (available: v2.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 66211f042f98c351a82c5b7dedae075268f3c6c50168ac4f0d390ea37ff2d79d [INFO] running `Command { std: "docker" "start" "-a" "66211f042f98c351a82c5b7dedae075268f3c6c50168ac4f0d390ea37ff2d79d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "66211f042f98c351a82c5b7dedae075268f3c6c50168ac4f0d390ea37ff2d79d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "66211f042f98c351a82c5b7dedae075268f3c6c50168ac4f0d390ea37ff2d79d", kill_on_drop: false }` [INFO] [stdout] 66211f042f98c351a82c5b7dedae075268f3c6c50168ac4f0d390ea37ff2d79d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 666e58530097cb03994f6074a146b43f387ab457b7ab78df5d55b4cbd6b756d9 [INFO] running `Command { std: "docker" "start" "-a" "666e58530097cb03994f6074a146b43f387ab457b7ab78df5d55b4cbd6b756d9", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling rustix v0.38.39 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking path-dedot v3.1.1 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking os_pipe v1.2.1 [INFO] [stderr] Checking monch v0.5.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.68 [INFO] [stderr] Checking serde_json v1.0.132 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking tokio v1.41.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking thiserror v1.0.68 [INFO] [stderr] Checking tempfile v3.14.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking deno_task_shell v0.18.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/shell/commands/cp_mv.rs (2 fixes) [INFO] [stderr] Fixed src/shell/commands/mkdir.rs (2 fixes) [INFO] [stderr] Fixed src/shell/which.rs (1 fix) [INFO] [stderr] Fixed src/parser.rs (1 fix) [INFO] [stderr] Fixed src/shell/commands/mod.rs (2 fixes) [INFO] [stderr] Fixed src/shell/types.rs (1 fix) [INFO] [stderr] Fixed src/shell/command.rs (1 fix) [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/shell/commands/cp_mv.rs:56:11 [INFO] [stdout] | [INFO] [stdout] 56 | match do_copy_operation(&flags, from, to).await { Err(err) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- --- [INFO] [stdout] | | | | [INFO] [stdout] | | | `err` calls a custom destructor [INFO] [stdout] | | | `err` will be dropped later as of Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | } _ => {}} [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#3` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `__awaitee` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `err` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/shell/commands/cp_mv.rs:108:29 [INFO] [stdout] | [INFO] [stdout] 108 | while let Some(entry) = read_dir.next_entry().await? { [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^-----^ [INFO] [stdout] | | | | [INFO] [stdout] | | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#7` [INFO] [stdout] | | up until Edition 2021 `#7` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#8` [INFO] [stdout] | | up until Edition 2021 `#8` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `entry` calls a custom destructor [INFO] [stdout] | `entry` will be dropped later as of Edition 2024 [INFO] [stdout] 109 | let file_type = entry.file_type().await?; [INFO] [stdout] | ----------------------- [INFO] [stdout] | | [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | / / copy_dir_recursively(new_from.clone(), new_to.clone()) [INFO] [stdout] 115 | | | .await [INFO] [stdout] | | | ----- [INFO] [stdout] | | | | | [INFO] [stdout] | | |____________|___this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | | | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | | `#4` will be dropped later as of Edition 2024 [INFO] [stdout] 116 | | .with_context(|| { [INFO] [stdout] 117 | | format!("Dir {} to {}", new_from.display(), new_to.display()) [INFO] [stdout] 118 | | })?; [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |_______________this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] 119 | } else if file_type.is_file() { [INFO] [stdout] 120 | tokio::fs::copy(&new_from, &new_to).await.with_context(|| { [INFO] [stdout] | ----------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#6` [INFO] [stdout] | _________`#6` will be dropped later as of Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | | [INFO] [stdout] 121 | | format!("Copying {} to {}", new_from.display(), new_to.display()) [INFO] [stdout] 122 | | })?; [INFO] [stdout] | | - [INFO] [stdout] | |___________| [INFO] [stdout] | |___________this value will be stored in a temporary; let us call it `#5` [INFO] [stdout] | `#5` will be dropped later as of Edition 2024 [INFO] [stdout] 123 | } [INFO] [stdout] 124 | | } [INFO] [stdout] | | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#7` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/alloc/src/ffi/c_str.rs:700:1 [INFO] [stdout] note: `#7` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/std/src/sys/pal/unix/fs.rs:857:1 [INFO] [stdout] note: `#8` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/alloc/src/ffi/c_str.rs:700:1 [INFO] [stdout] note: `#8` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/std/src/sys/pal/unix/fs.rs:857:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/alloc/src/ffi/c_str.rs:700:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/std/src/sys/pal/unix/fs.rs:857:1 [INFO] [stdout] note: `entry` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/alloc/src/ffi/c_str.rs:700:1 [INFO] [stdout] note: `entry` invokes this custom destructor [INFO] [stdout] --> /rustc/da25749bf5e6ba5ed862ff361c19afff2a986b2d/library/std/src/sys/pal/unix/fs.rs:857:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#3` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#5` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/shell/commands/rm.rs:56:42 [INFO] [stdout] | [INFO] [stdout] 56 | tokio::fs::remove_dir_all(&path).await [INFO] [stdout] | ---------------------------------^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] 57 | } else { [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] 58 | remove_file_or_dir(&path, &flags).await [INFO] [stdout] | --------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | remove_file_or_dir(&path, &flags).await [INFO] [stdout] | --------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/shell/commands/rm.rs:58:43 [INFO] [stdout] | [INFO] [stdout] 56 | tokio::fs::remove_dir_all(&path).await [INFO] [stdout] | -------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] 57 | } else { [INFO] [stdout] 58 | remove_file_or_dir(&path, &flags).await [INFO] [stdout] | ----------------------------------^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 59 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] 60 | } else { [INFO] [stdout] 61 | remove_file_or_dir(&path, &flags).await [INFO] [stdout] | --------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/shell/commands/rm.rs:61:41 [INFO] [stdout] | [INFO] [stdout] 56 | tokio::fs::remove_dir_all(&path).await [INFO] [stdout] | -------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] 57 | } else { [INFO] [stdout] 58 | remove_file_or_dir(&path, &flags).await [INFO] [stdout] | --------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | remove_file_or_dir(&path, &flags).await [INFO] [stdout] | ----------------------------------^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] 62 | }; [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed src/shell/test_builder.rs (2 fixes) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.96s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking deno_task_shell v0.18.1 (/tmp/fixit) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.00s [INFO] running `Command { std: "docker" "inspect" "666e58530097cb03994f6074a146b43f387ab457b7ab78df5d55b4cbd6b756d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "666e58530097cb03994f6074a146b43f387ab457b7ab78df5d55b4cbd6b756d9", kill_on_drop: false }` [INFO] [stdout] 666e58530097cb03994f6074a146b43f387ab457b7ab78df5d55b4cbd6b756d9