[INFO] fetching crate cucumber 0.21.1... [INFO] checking cucumber-0.21.1 against try#da25749bf5e6ba5ed862ff361c19afff2a986b2d for pr-132712 [INFO] extracting crate cucumber 0.21.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate cucumber 0.21.1 on toolchain da25749bf5e6ba5ed862ff361c19afff2a986b2d [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cucumber 0.21.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate cucumber 0.21.1 [INFO] tweaked toml for crates.io crate cucumber 0.21.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 165 packages to latest compatible versions [INFO] [stderr] Adding derive_more v0.99.18 (available: v1.0.0) [INFO] [stderr] Adding sealed v0.5.0 (available: v0.6.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8e0706aa51ee7736abfb103e9e2255cefe91d29824bcb7cc590f6a85fa51b9fa [INFO] running `Command { std: "docker" "start" "-a" "8e0706aa51ee7736abfb103e9e2255cefe91d29824bcb7cc590f6a85fa51b9fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8e0706aa51ee7736abfb103e9e2255cefe91d29824bcb7cc590f6a85fa51b9fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e0706aa51ee7736abfb103e9e2255cefe91d29824bcb7cc590f6a85fa51b9fa", kill_on_drop: false }` [INFO] [stdout] 8e0706aa51ee7736abfb103e9e2255cefe91d29824bcb7cc590f6a85fa51b9fa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6b16e0426592cbc06429dfdaa4bdbf615ec3b4c04da448557951b9720a451ce3 [INFO] running `Command { std: "docker" "start" "-a" "6b16e0426592cbc06429dfdaa4bdbf615ec3b4c04da448557951b9720a451ce3", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling regex-syntax v0.8.5 [INFO] [stderr] Compiling rustix v0.38.39 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Compiling serde v1.0.214 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling peg-runtime v0.6.3 [INFO] [stderr] Checking anstyle-query v1.1.2 [INFO] [stderr] Checking anstyle-parse v0.2.6 [INFO] [stderr] Compiling bytecount v0.6.8 [INFO] [stderr] Checking colorchoice v1.0.3 [INFO] [stderr] Compiling typed-builder-macro v0.15.2 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling sealed v0.5.0 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Compiling regex-syntax v0.7.5 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling anyhow v1.0.93 [INFO] [stderr] Compiling peg-macros v0.6.3 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling pin-project-internal v1.1.7 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling synthez-core v0.3.1 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking regex-automata v0.4.8 [INFO] [stderr] Checking peg v0.6.3 [INFO] [stderr] Checking typed-builder v0.15.2 [INFO] [stderr] Compiling synthez-codegen v0.3.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling inflections v1.1.1 [INFO] [stderr] Checking pin-project v1.1.7 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Compiling synthez v0.3.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling smart-default v0.7.1 [INFO] [stderr] Checking terminal_size v0.4.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking drain_filter_polyfill v0.1.3 [INFO] [stderr] Checking clap_builder v4.5.20 [INFO] [stderr] Checking tempfile v3.14.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling nom_locate v4.2.0 [INFO] [stderr] Checking tokio v1.41.1 [INFO] [stderr] Compiling serde_json v1.0.132 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking globset v0.4.15 [INFO] [stderr] Checking cucumber-expressions v0.3.0 [INFO] [stderr] Checking ignore v0.4.23 [INFO] [stderr] Compiling gherkin v0.14.0 [INFO] [stderr] Checking clap v4.5.20 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking globwalk v0.9.1 [INFO] [stderr] Compiling lazy-regex-proc_macros v3.3.0 [INFO] [stderr] Compiling cucumber-codegen v0.21.1 [INFO] [stderr] Checking lazy-regex v3.3.0 [INFO] [stderr] Checking cucumber v0.21.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/runner/basic.rs (5 fixes) [INFO] [stderr] Fixed src/writer/normalize.rs (2 fixes) [INFO] [stdout] warning: `impl Iterator>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/runner/basic.rs:2082:10 [INFO] [stdout] | [INFO] [stdout] 2082 | ) -> impl Iterator> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/runner/basic.rs:2071:9 [INFO] [stdout] | [INFO] [stdout] 2071 | &mut self, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl Iterator>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/runner/basic.rs:2082:10 [INFO] [stdout] | [INFO] [stdout] 2082 | ) -> impl Iterator> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/runner/basic.rs:2071:9 [INFO] [stdout] | [INFO] [stdout] 2071 | &mut self, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/cucumber.rs:785:30 [INFO] [stdout] | [INFO] [stdout] 785 | while let Some(ev) = events_stream.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 786 | writer.handle_event(ev, &writer_cli).await; [INFO] [stdout] | ------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] 787 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/runner/basic.rs:1057:23 [INFO] [stdout] | [INFO] [stdout] 968 | features.get(map_break(started_scenarios)).await; [INFO] [stdout] | ------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] 969 | if run_scenarios.is_empty() && runnable.is_empty() { [INFO] [stdout] 970 | if features.is_finished(started_scenarios.is_break()).await { [INFO] [stdout] | -------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 981 | let (sender, receiver) = oneshot::channel(); [INFO] [stdout] | ------------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 986 | _ = receiver.await.ok(); [INFO] [stdout] | -------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1057 | match storage.rule_scenario_finished( [INFO] [stdout] | _______________________^ [INFO] [stdout] 1058 | | Arc::clone(&feat), [INFO] [stdout] 1059 | | rule, [INFO] [stdout] 1060 | | retried, [INFO] [stdout] 1061 | | ) { Some(f) => { [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_________________this value will be stored in a temporary; let us call it `#5` [INFO] [stdout] | up until Edition 2021 `#5` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1064 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] 1065 | if let Some(f) = storage.feature_scenario_finished(feat, retried) { [INFO] [stdout] | ------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | `#4` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: `#5` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `__awaitee` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/futures-util-0.3.31/src/lock/mutex.rs:373:1 [INFO] [stdout] | [INFO] [stdout] 373 | impl Drop for MutexLockFuture<'_, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/futures-util-0.3.31/src/lock/mutex.rs:373:1 [INFO] [stdout] | [INFO] [stdout] 373 | impl Drop for MutexLockFuture<'_, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/futures-channel-0.3.31/src/oneshot.rs:478:1 [INFO] [stdout] | [INFO] [stdout] 478 | impl Drop for Receiver { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#4` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/writer/normalize.rs:830:38 [INFO] [stdout] | [INFO] [stdout] 830 | while let Some((ev, meta)) = self.current_item().map(Event::split) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 841 | writer.handle_event(Ok(ev), cli).await; [INFO] [stdout] | -------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 846 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.26s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking cucumber v0.21.1 (/tmp/fixit) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.18s [INFO] running `Command { std: "docker" "inspect" "6b16e0426592cbc06429dfdaa4bdbf615ec3b4c04da448557951b9720a451ce3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b16e0426592cbc06429dfdaa4bdbf615ec3b4c04da448557951b9720a451ce3", kill_on_drop: false }` [INFO] [stdout] 6b16e0426592cbc06429dfdaa4bdbf615ec3b4c04da448557951b9720a451ce3