[INFO] fetching crate clickhouse 0.13.1... [INFO] checking clickhouse-0.13.1 against try#da25749bf5e6ba5ed862ff361c19afff2a986b2d for pr-132712 [INFO] extracting crate clickhouse 0.13.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate clickhouse 0.13.1 on toolchain da25749bf5e6ba5ed862ff361c19afff2a986b2d [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate clickhouse 0.13.1 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate clickhouse 0.13.1 [INFO] tweaked toml for crates.io crate clickhouse 0.13.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate clickhouse 0.13.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0e0176c150e4a7cd03be4f3948658221f9ad92e8f49a9c273fb30e9e1acccf84 [INFO] running `Command { std: "docker" "start" "-a" "0e0176c150e4a7cd03be4f3948658221f9ad92e8f49a9c273fb30e9e1acccf84", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0e0176c150e4a7cd03be4f3948658221f9ad92e8f49a9c273fb30e9e1acccf84", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e0176c150e4a7cd03be4f3948658221f9ad92e8f49a9c273fb30e9e1acccf84", kill_on_drop: false }` [INFO] [stdout] 0e0176c150e4a7cd03be4f3948658221f9ad92e8f49a9c273fb30e9e1acccf84 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bed4254e220c1299d043f51f10858d3441df16753882a7004e8cdcbe70374670 [INFO] running `Command { std: "docker" "start" "-a" "bed4254e220c1299d043f51f10858d3441df16753882a7004e8cdcbe70374670", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Compiling serde_json v1.0.121 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking clap_builder v4.5.11 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking replace_with v0.1.7 [INFO] [stderr] Checking cityhash-rs v1.0.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking lz4_flex v0.11.3 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking clap v4.5.11 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling sealed v0.6.0 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling clickhouse-derive v0.2.0 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking fixnum v0.9.2 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking hyper-util v0.1.6 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking clickhouse v0.13.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `clickhouse` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/query.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: ambiguous `+` in a type [INFO] [stderr] --> src/query.rs:36:35 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn sql_display(&self) -> &impl Display + use<> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: try adding parentheses [INFO] [stderr] | [INFO] [stderr] 36 | pub fn sql_display(&self) -> &(impl Display + use<>) { [INFO] [stderr] | + + [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/insert.rs:109:12 [INFO] [stdout] | [INFO] [stdout] 109 | ($self:expr, $timeout:ident, $fut:expr) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 109 | ($self:expr_2021, $timeout:ident, $fut:expr) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/insert.rs:109:39 [INFO] [stdout] | [INFO] [stdout] 109 | ($self:expr, $timeout:ident, $fut:expr) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 109 | ($self:expr, $timeout:ident, $fut:expr_2021) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures::Future> + std::marker::Send + 'a` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/insert.rs:209:48 [INFO] [stdout] | [INFO] [stdout] 209 | pub fn write<'a>(&'a mut self, row: &T) -> impl Future> + 'a + Send [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/insert.rs:209:41 [INFO] [stdout] | [INFO] [stdout] 209 | pub fn write<'a>(&'a mut self, row: &T) -> impl Future> + 'a + Send [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 209 | pub fn write<'a>(&'a mut self, row: &T) -> impl Future> + 'a + Send + use<'a, T> [INFO] [stdout] | ++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/insert.rs:381:12 [INFO] [stdout] | [INFO] [stdout] 381 | if let Some(sender) = self.state.sender() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^----------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/insert.rs:383:9 [INFO] [stdout] | [INFO] [stdout] 383 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 381 ~ match self.state.sender() { Some(sender) => { [INFO] [stdout] 382 | sender.abort(); [INFO] [stdout] 383 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::fmt::Display` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/query.rs:36:35 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn sql_display(&self) -> &impl Display { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/query.rs:36:24 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn sql_display(&self) -> &impl Display { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 36 | pub fn sql_display(&self) -> &impl Display + use<> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/response.rs:160:12 [INFO] [stdout] | [INFO] [stdout] 160 | if let Some(mut stream) = self.0.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/response.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 170 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 160 ~ match self.0.take() { Some(mut stream) => { [INFO] [stdout] 161 | let res = Pin::new(&mut stream).poll_next(cx); [INFO] [stdout] ... [INFO] [stdout] 169 | res [INFO] [stdout] 170 ~ } _ => { [INFO] [stdout] 171 | Poll::Ready(None) [INFO] [stdout] 172 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/response.rs:270:24 [INFO] [stdout] | [INFO] [stdout] 270 | if let Some(err) = extract_exception(&mut chunk.data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^---------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/response.rs:274:21 [INFO] [stdout] | [INFO] [stdout] 274 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 270 ~ match extract_exception(&mut chunk.data) { Some(err) => { [INFO] [stdout] 271 | *self = Self::Exception(Some(err)); [INFO] [stdout] 272 | [INFO] [stdout] 273 | // NOTE: `chunk` can be empty, but it's ok for callers. [INFO] [stdout] 274 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/query.rs:128:31 [INFO] [stdout] | [INFO] [stdout] 128 | while let Some(row) = cursor.next().await? { [INFO] [stdout] | -------------------^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] 129 | result.push(row); [INFO] [stdout] 130 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: `#3` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/cursor.rs:127:19 [INFO] [stdout] | [INFO] [stdout] 118 | match rowbinary::deserialize_from(&mut slice) { [INFO] [stdout] | --------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | match self.raw.next().await? { [INFO] [stdout] | ---------------------^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#5` [INFO] [stdout] | | up until Edition 2021 `#5` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.6.1/src/bytes.rs:544:1 [INFO] [stdout] | [INFO] [stdout] 544 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#4` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.6.1/src/bytes.rs:544:1 [INFO] [stdout] | [INFO] [stdout] 544 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.6.1/src/bytes.rs:544:1 [INFO] [stdout] | [INFO] [stdout] 544 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/response.rs:120:29 [INFO] [stdout] | [INFO] [stdout] 120 | while let Some(chunk) = stream.try_next().await? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^-----^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 121 | bytes.put(chunk); [INFO] [stdout] 122 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.6.1/src/bytes.rs:544:1 [INFO] [stdout] | [INFO] [stdout] 544 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#3` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.6.1/src/bytes.rs:544:1 [INFO] [stdout] | [INFO] [stdout] 544 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.6.1/src/bytes.rs:544:1 [INFO] [stdout] | [INFO] [stdout] 544 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/custom_http_headers.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/it/main.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/enums.rs from 2021 edition to 2024 [INFO] [stderr] Migrating benches/insert.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `clickhouse` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/query.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: ambiguous `+` in a type [INFO] [stderr] --> src/query.rs:36:35 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn sql_display(&self) -> &impl Display + use<> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: try adding parentheses [INFO] [stderr] | [INFO] [stderr] 36 | pub fn sql_display(&self) -> &(impl Display + use<>) { [INFO] [stderr] | + + [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/insert.rs:109:12 [INFO] [stdout] | [INFO] [stdout] 109 | ($self:expr, $timeout:ident, $fut:expr) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 109 | ($self:expr_2021, $timeout:ident, $fut:expr) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/insert.rs:109:39 [INFO] [stdout] | [INFO] [stdout] 109 | ($self:expr, $timeout:ident, $fut:expr) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 109 | ($self:expr, $timeout:ident, $fut:expr_2021) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures::Future> + std::marker::Send + 'a` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/insert.rs:209:48 [INFO] [stdout] | [INFO] [stdout] 209 | pub fn write<'a>(&'a mut self, row: &T) -> impl Future> + 'a + Send [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/insert.rs:209:41 [INFO] [stdout] | [INFO] [stdout] 209 | pub fn write<'a>(&'a mut self, row: &T) -> impl Future> + 'a + Send [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 209 | pub fn write<'a>(&'a mut self, row: &T) -> impl Future> + 'a + Send + use<'a, T> [INFO] [stdout] | ++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/insert.rs:381:12 [INFO] [stdout] | [INFO] [stdout] 381 | if let Some(sender) = self.state.sender() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^----------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/insert.rs:383:9 [INFO] [stdout] | [INFO] [stdout] 383 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 381 ~ match self.state.sender() { Some(sender) => { [INFO] [stdout] 382 | sender.abort(); [INFO] [stdout] 383 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::fmt::Display` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/query.rs:36:35 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn sql_display(&self) -> &impl Display { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/query.rs:36:24 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn sql_display(&self) -> &impl Display { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 36 | pub fn sql_display(&self) -> &impl Display + use<> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/response.rs:160:12 [INFO] [stdout] | [INFO] [stdout] 160 | if let Some(mut stream) = self.0.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/response.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 170 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 160 ~ match self.0.take() { Some(mut stream) => { [INFO] [stdout] 161 | let res = Pin::new(&mut stream).poll_next(cx); [INFO] [stdout] ... [INFO] [stdout] 169 | res [INFO] [stdout] 170 ~ } _ => { [INFO] [stdout] 171 | Poll::Ready(None) [INFO] [stdout] 172 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/response.rs:270:24 [INFO] [stdout] | [INFO] [stdout] 270 | if let Some(err) = extract_exception(&mut chunk.data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^---------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/response.rs:274:21 [INFO] [stdout] | [INFO] [stdout] 274 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 270 ~ match extract_exception(&mut chunk.data) { Some(err) => { [INFO] [stdout] 271 | *self = Self::Exception(Some(err)); [INFO] [stdout] 272 | [INFO] [stdout] 273 | // NOTE: `chunk` can be empty, but it's ok for callers. [INFO] [stdout] 274 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/async_insert.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/usage.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/clickhouse_settings.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/session_id.rs from 2021 edition to 2024 [INFO] [stderr] Migrating benches/select_numbers.rs from 2021 edition to 2024 [INFO] [stderr] Migrating benches/select.rs from 2021 edition to 2024 [INFO] [stderr] Migrating benches/common.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/data_types_derive_containers.rs from 2021 edition to 2024 [INFO] [stderr] Fixed examples/data_types_derive_containers.rs (4 fixes) [INFO] [stderr] Migrating examples/custom_http_client.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/query_id.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.66s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking clickhouse v0.13.1 (/tmp/fixit) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.81s [INFO] running `Command { std: "docker" "inspect" "bed4254e220c1299d043f51f10858d3441df16753882a7004e8cdcbe70374670", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bed4254e220c1299d043f51f10858d3441df16753882a7004e8cdcbe70374670", kill_on_drop: false }` [INFO] [stdout] bed4254e220c1299d043f51f10858d3441df16753882a7004e8cdcbe70374670