[INFO] fetching crate binrw 0.14.1... [INFO] checking binrw-0.14.1 against try#da25749bf5e6ba5ed862ff361c19afff2a986b2d for pr-132712 [INFO] extracting crate binrw 0.14.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate binrw 0.14.1 on toolchain da25749bf5e6ba5ed862ff361c19afff2a986b2d [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate binrw 0.14.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate binrw 0.14.1 [INFO] tweaked toml for crates.io crate binrw 0.14.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 35 packages to latest compatible versions [INFO] [stderr] Adding trybuild v1.0.89 (available: v1.0.101) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9852b3f8b880dd3980b1c1a721326b883a6a55650b6dfb306a0a78e74e2d1863 [INFO] running `Command { std: "docker" "start" "-a" "9852b3f8b880dd3980b1c1a721326b883a6a55650b6dfb306a0a78e74e2d1863", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9852b3f8b880dd3980b1c1a721326b883a6a55650b6dfb306a0a78e74e2d1863", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9852b3f8b880dd3980b1c1a721326b883a6a55650b6dfb306a0a78e74e2d1863", kill_on_drop: false }` [INFO] [stdout] 9852b3f8b880dd3980b1c1a721326b883a6a55650b6dfb306a0a78e74e2d1863 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 08542cff376f57d32b4e87196f1735966659fcd415ec967ed905cfc379a8725b [INFO] running `Command { std: "docker" "start" "-a" "08542cff376f57d32b4e87196f1735966659fcd415ec967ed905cfc379a8725b", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.89 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde v1.0.214 [INFO] [stderr] Compiling binrw_derive v0.14.1 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling trybuild v1.0.89 [INFO] [stderr] Compiling binrw v0.14.1 (/tmp/fixit) [INFO] [stderr] Compiling owo-colors v3.5.0 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking bytemuck v1.19.0 [INFO] [stderr] Migrating build.rs from 2021 edition to 2024 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.87 [INFO] [stderr] Checking serde_json v1.0.132 [INFO] [stderr] Checking basic-toml v0.1.9 [INFO] [stderr] Compiling serde_derive v1.0.214 [INFO] [stderr] Compiling modular-bitfield-impl v0.11.2 [INFO] [stderr] Checking modular-bitfield v0.11.2 [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/helpers.rs (5 fixes) [INFO] [stderr] Fixed src/named_args.rs (2 fixes) [INFO] [stderr] Fixed src/meta.rs (1 fix) [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/helpers.rs:569:14 [INFO] [stdout] | [INFO] [stdout] 455 | vec_fast_int!(try (i8 i16 u16 i32 u32 i64 u64 i128 u128) using (container, reader, endian, n) else { [INFO] [stdout] | - --------- [INFO] [stdout] | | | [INFO] [stdout] | | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | _________| this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | | [INFO] [stdout] 456 | | // This extra branch for `Vec` makes it faster than [INFO] [stdout] 457 | | // `vec_fast_int`, but *only* because `vec_fast_int` is not allowed [INFO] [stdout] 458 | | // to use unsafe code to eliminate the unnecessary zero-fill. [INFO] [stdout] ... | [INFO] [stdout] 476 | | }} [INFO] [stdout] 477 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] ... [INFO] [stdout] 569 | $(if let Some(list) = ::downcast_mut::>(&mut $list) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/helpers.rs:608:9 [INFO] [stdout] | [INFO] [stdout] 455 | / vec_fast_int!(try (i8 i16 u16 i32 u32 i64 u64 i128 u128) using (container, reader, endian, n) else { [INFO] [stdout] 456 | | // This extra branch for `Vec` makes it faster than [INFO] [stdout] 457 | | // `vec_fast_int`, but *only* because `vec_fast_int` is not allowed [INFO] [stdout] 458 | | // to use unsafe code to eliminate the unnecessary zero-fill. [INFO] [stdout] ... | [INFO] [stdout] 476 | | }} [INFO] [stdout] 477 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] ... [INFO] [stdout] 608 | } else)* { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/helpers.rs:608:9 [INFO] [stdout] | [INFO] [stdout] 455 | / vec_fast_int!(try (i8 i16 u16 i32 u32 i64 u64 i128 u128) using (container, reader, endian, n) else { [INFO] [stdout] 456 | | // This extra branch for `Vec` makes it faster than [INFO] [stdout] 457 | | // `vec_fast_int`, but *only* because `vec_fast_int` is not allowed [INFO] [stdout] 458 | | // to use unsafe code to eliminate the unnecessary zero-fill. [INFO] [stdout] ... | [INFO] [stdout] 476 | | }} [INFO] [stdout] 477 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] ... [INFO] [stdout] 608 | } else)* { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/helpers.rs:608:9 [INFO] [stdout] | [INFO] [stdout] 455 | / vec_fast_int!(try (i8 i16 u16 i32 u32 i64 u64 i128 u128) using (container, reader, endian, n) else { [INFO] [stdout] 456 | | // This extra branch for `Vec` makes it faster than [INFO] [stdout] 457 | | // `vec_fast_int`, but *only* because `vec_fast_int` is not allowed [INFO] [stdout] 458 | | // to use unsafe code to eliminate the unnecessary zero-fill. [INFO] [stdout] ... | [INFO] [stdout] 476 | | }} [INFO] [stdout] 477 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] ... [INFO] [stdout] 608 | } else)* { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/helpers.rs:608:9 [INFO] [stdout] | [INFO] [stdout] 455 | / vec_fast_int!(try (i8 i16 u16 i32 u32 i64 u64 i128 u128) using (container, reader, endian, n) else { [INFO] [stdout] 456 | | // This extra branch for `Vec` makes it faster than [INFO] [stdout] 457 | | // `vec_fast_int`, but *only* because `vec_fast_int` is not allowed [INFO] [stdout] 458 | | // to use unsafe code to eliminate the unnecessary zero-fill. [INFO] [stdout] ... | [INFO] [stdout] 476 | | }} [INFO] [stdout] 477 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] ... [INFO] [stdout] 608 | } else)* { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/helpers.rs:608:9 [INFO] [stdout] | [INFO] [stdout] 455 | / vec_fast_int!(try (i8 i16 u16 i32 u32 i64 u64 i128 u128) using (container, reader, endian, n) else { [INFO] [stdout] 456 | | // This extra branch for `Vec` makes it faster than [INFO] [stdout] 457 | | // `vec_fast_int`, but *only* because `vec_fast_int` is not allowed [INFO] [stdout] 458 | | // to use unsafe code to eliminate the unnecessary zero-fill. [INFO] [stdout] ... | [INFO] [stdout] 476 | | }} [INFO] [stdout] 477 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] ... [INFO] [stdout] 608 | } else)* { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/helpers.rs:608:9 [INFO] [stdout] | [INFO] [stdout] 455 | / vec_fast_int!(try (i8 i16 u16 i32 u32 i64 u64 i128 u128) using (container, reader, endian, n) else { [INFO] [stdout] 456 | | // This extra branch for `Vec` makes it faster than [INFO] [stdout] 457 | | // `vec_fast_int`, but *only* because `vec_fast_int` is not allowed [INFO] [stdout] 458 | | // to use unsafe code to eliminate the unnecessary zero-fill. [INFO] [stdout] ... | [INFO] [stdout] 476 | | }} [INFO] [stdout] 477 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] ... [INFO] [stdout] 608 | } else)* { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/helpers.rs:608:9 [INFO] [stdout] | [INFO] [stdout] 455 | / vec_fast_int!(try (i8 i16 u16 i32 u32 i64 u64 i128 u128) using (container, reader, endian, n) else { [INFO] [stdout] 456 | | // This extra branch for `Vec` makes it faster than [INFO] [stdout] 457 | | // `vec_fast_int`, but *only* because `vec_fast_int` is not allowed [INFO] [stdout] 458 | | // to use unsafe code to eliminate the unnecessary zero-fill. [INFO] [stdout] ... | [INFO] [stdout] 476 | | }} [INFO] [stdout] 477 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] ... [INFO] [stdout] 608 | } else)* { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/helpers.rs:608:9 [INFO] [stdout] | [INFO] [stdout] 455 | / vec_fast_int!(try (i8 i16 u16 i32 u32 i64 u64 i128 u128) using (container, reader, endian, n) else { [INFO] [stdout] 456 | | // This extra branch for `Vec` makes it faster than [INFO] [stdout] 457 | | // `vec_fast_int`, but *only* because `vec_fast_int` is not allowed [INFO] [stdout] 458 | | // to use unsafe code to eliminate the unnecessary zero-fill. [INFO] [stdout] ... | [INFO] [stdout] 476 | | }} [INFO] [stdout] 477 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] ... [INFO] [stdout] 608 | } else)* { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/helpers.rs:608:9 [INFO] [stdout] | [INFO] [stdout] 455 | / vec_fast_int!(try (i8 i16 u16 i32 u32 i64 u64 i128 u128) using (container, reader, endian, n) else { [INFO] [stdout] 456 | | // This extra branch for `Vec` makes it faster than [INFO] [stdout] 457 | | // `vec_fast_int`, but *only* because `vec_fast_int` is not allowed [INFO] [stdout] 458 | | // to use unsafe code to eliminate the unnecessary zero-fill. [INFO] [stdout] ... | [INFO] [stdout] 476 | | }} [INFO] [stdout] 477 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] ... [INFO] [stdout] 608 | } else)* { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] = note: this warning originates in the macro `vec_fast_int` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed src/error/backtrace.rs (3 fixes) [INFO] [stderr] Migrating tests/binwrite_impls.rs from 2021 edition to 2024 [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/helpers.rs:569:14 [INFO] [stdout] | [INFO] [stdout] 455 | vec_fast_int!(try (i8 i16 u16 i32 u32 i64 u64 i128 u128) using (container, reader, endian, n) else { [INFO] [stdout] | - --------- [INFO] [stdout] | | | [INFO] [stdout] | | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | _________| this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | | [INFO] [stdout] 456 | | // This extra branch for `Vec` makes it faster than [INFO] [stdout] 457 | | // `vec_fast_int`, but *only* because `vec_fast_int` is not allowed [INFO] [stdout] 458 | | // to use unsafe code to eliminate the unnecessary zero-fill. [INFO] [stdout] ... | [INFO] [stdout] 476 | | }} [INFO] [stdout] 477 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] ... [INFO] [stdout] 569 | $(if let Some(list) = ::downcast_mut::>(&mut $list) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/helpers.rs:608:9 [INFO] [stdout] | [INFO] [stdout] 455 | / vec_fast_int!(try (i8 i16 u16 i32 u32 i64 u64 i128 u128) using (container, reader, endian, n) else { [INFO] [stdout] 456 | | // This extra branch for `Vec` makes it faster than [INFO] [stdout] 457 | | // `vec_fast_int`, but *only* because `vec_fast_int` is not allowed [INFO] [stdout] 458 | | // to use unsafe code to eliminate the unnecessary zero-fill. [INFO] [stdout] ... | [INFO] [stdout] 476 | | }} [INFO] [stdout] 477 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] ... [INFO] [stdout] 608 | } else)* { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/helpers.rs:608:9 [INFO] [stdout] | [INFO] [stdout] 455 | / vec_fast_int!(try (i8 i16 u16 i32 u32 i64 u64 i128 u128) using (container, reader, endian, n) else { [INFO] [stdout] 456 | | // This extra branch for `Vec` makes it faster than [INFO] [stdout] 457 | | // `vec_fast_int`, but *only* because `vec_fast_int` is not allowed [INFO] [stdout] 458 | | // to use unsafe code to eliminate the unnecessary zero-fill. [INFO] [stdout] ... | [INFO] [stdout] 476 | | }} [INFO] [stdout] 477 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] ... [INFO] [stdout] 608 | } else)* { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/helpers.rs:608:9 [INFO] [stdout] | [INFO] [stdout] 455 | / vec_fast_int!(try (i8 i16 u16 i32 u32 i64 u64 i128 u128) using (container, reader, endian, n) else { [INFO] [stdout] 456 | | // This extra branch for `Vec` makes it faster than [INFO] [stdout] 457 | | // `vec_fast_int`, but *only* because `vec_fast_int` is not allowed [INFO] [stdout] 458 | | // to use unsafe code to eliminate the unnecessary zero-fill. [INFO] [stdout] ... | [INFO] [stdout] 476 | | }} [INFO] [stdout] 477 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] ... [INFO] [stdout] 608 | } else)* { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/helpers.rs:608:9 [INFO] [stdout] | [INFO] [stdout] 455 | / vec_fast_int!(try (i8 i16 u16 i32 u32 i64 u64 i128 u128) using (container, reader, endian, n) else { [INFO] [stdout] 456 | | // This extra branch for `Vec` makes it faster than [INFO] [stdout] 457 | | // `vec_fast_int`, but *only* because `vec_fast_int` is not allowed [INFO] [stdout] 458 | | // to use unsafe code to eliminate the unnecessary zero-fill. [INFO] [stdout] ... | [INFO] [stdout] 476 | | }} [INFO] [stdout] 477 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] ... [INFO] [stdout] 608 | } else)* { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/helpers.rs:608:9 [INFO] [stdout] | [INFO] [stdout] 455 | / vec_fast_int!(try (i8 i16 u16 i32 u32 i64 u64 i128 u128) using (container, reader, endian, n) else { [INFO] [stdout] 456 | | // This extra branch for `Vec` makes it faster than [INFO] [stdout] 457 | | // `vec_fast_int`, but *only* because `vec_fast_int` is not allowed [INFO] [stdout] 458 | | // to use unsafe code to eliminate the unnecessary zero-fill. [INFO] [stdout] ... | [INFO] [stdout] 476 | | }} [INFO] [stdout] 477 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] ... [INFO] [stdout] 608 | } else)* { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/helpers.rs:608:9 [INFO] [stdout] | [INFO] [stdout] 455 | / vec_fast_int!(try (i8 i16 u16 i32 u32 i64 u64 i128 u128) using (container, reader, endian, n) else { [INFO] [stdout] 456 | | // This extra branch for `Vec` makes it faster than [INFO] [stdout] 457 | | // `vec_fast_int`, but *only* because `vec_fast_int` is not allowed [INFO] [stdout] 458 | | // to use unsafe code to eliminate the unnecessary zero-fill. [INFO] [stdout] ... | [INFO] [stdout] 476 | | }} [INFO] [stdout] 477 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] ... [INFO] [stdout] 608 | } else)* { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/helpers.rs:608:9 [INFO] [stdout] | [INFO] [stdout] 455 | / vec_fast_int!(try (i8 i16 u16 i32 u32 i64 u64 i128 u128) using (container, reader, endian, n) else { [INFO] [stdout] 456 | | // This extra branch for `Vec` makes it faster than [INFO] [stdout] 457 | | // `vec_fast_int`, but *only* because `vec_fast_int` is not allowed [INFO] [stdout] 458 | | // to use unsafe code to eliminate the unnecessary zero-fill. [INFO] [stdout] ... | [INFO] [stdout] 476 | | }} [INFO] [stdout] 477 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] ... [INFO] [stdout] 608 | } else)* { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/helpers.rs:608:9 [INFO] [stdout] | [INFO] [stdout] 455 | / vec_fast_int!(try (i8 i16 u16 i32 u32 i64 u64 i128 u128) using (container, reader, endian, n) else { [INFO] [stdout] 456 | | // This extra branch for `Vec` makes it faster than [INFO] [stdout] 457 | | // `vec_fast_int`, but *only* because `vec_fast_int` is not allowed [INFO] [stdout] 458 | | // to use unsafe code to eliminate the unnecessary zero-fill. [INFO] [stdout] ... | [INFO] [stdout] 476 | | }} [INFO] [stdout] 477 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] ... [INFO] [stdout] 608 | } else)* { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/helpers.rs:608:9 [INFO] [stdout] | [INFO] [stdout] 455 | / vec_fast_int!(try (i8 i16 u16 i32 u32 i64 u64 i128 u128) using (container, reader, endian, n) else { [INFO] [stdout] 456 | | // This extra branch for `Vec` makes it faster than [INFO] [stdout] 457 | | // `vec_fast_int`, but *only* because `vec_fast_int` is not allowed [INFO] [stdout] 458 | | // to use unsafe code to eliminate the unnecessary zero-fill. [INFO] [stdout] ... | [INFO] [stdout] 476 | | }} [INFO] [stdout] 477 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] ... [INFO] [stdout] 608 | } else)* { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] = note: this warning originates in the macro `vec_fast_int` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed tests/binwrite_impls.rs (5 fixes) [INFO] [stderr] Migrating tests/dbg.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/meta.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/error.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/named_args.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/stream_ext.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/endian.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/binread_impls.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/pos_value.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/infer_map.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/punctuated.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/ui.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed tests/derive/enum.rs (1 fix) [INFO] [stderr] Migrating tests/strings.rs from 2021 edition to 2024 [INFO] [stderr] Fixed tests/derive/write/assert.rs (5 fixes) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.51s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Compiling binrw v0.14.1 (/tmp/fixit) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.18s [INFO] running `Command { std: "docker" "inspect" "08542cff376f57d32b4e87196f1735966659fcd415ec967ed905cfc379a8725b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "08542cff376f57d32b4e87196f1735966659fcd415ec967ed905cfc379a8725b", kill_on_drop: false }` [INFO] [stdout] 08542cff376f57d32b4e87196f1735966659fcd415ec967ed905cfc379a8725b