[INFO] fetching crate sqlite-extras 0.1.1... [INFO] checking sqlite-extras-0.1.1 against try#65132f36b923285d5da381c2fbafee6ce899e841 for pr-132712-1 [INFO] extracting crate sqlite-extras 0.1.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate sqlite-extras 0.1.1 on toolchain 65132f36b923285d5da381c2fbafee6ce899e841 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sqlite-extras 0.1.1 [INFO] finished tweaking crates.io crate sqlite-extras 0.1.1 [INFO] tweaked toml for crates.io crate sqlite-extras 0.1.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate sqlite-extras 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5155ed5bc446c9ea780c5a6fc97cb0622c62fbc13f044b5f27cfb40140688947 [INFO] running `Command { std: "docker" "start" "-a" "5155ed5bc446c9ea780c5a6fc97cb0622c62fbc13f044b5f27cfb40140688947", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5155ed5bc446c9ea780c5a6fc97cb0622c62fbc13f044b5f27cfb40140688947", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5155ed5bc446c9ea780c5a6fc97cb0622c62fbc13f044b5f27cfb40140688947", kill_on_drop: false }` [INFO] [stdout] 5155ed5bc446c9ea780c5a6fc97cb0622c62fbc13f044b5f27cfb40140688947 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f37cae965d4fe88696ec43785b7243f8c7dc42f4f2b0343c1a6e0715138911a8 [INFO] running `Command { std: "docker" "start" "-a" "f37cae965d4fe88696ec43785b7243f8c7dc42f4f2b0343c1a6e0715138911a8", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.162 [INFO] [stderr] Compiling serde v1.0.214 [INFO] [stderr] Compiling stable_deref_trait v1.2.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling writeable v0.5.5 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Compiling cc v1.1.37 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling litemap v0.7.3 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling zerofrom v0.1.4 [INFO] [stderr] Compiling futures-core v0.3.31 [INFO] [stderr] Compiling pin-project-lite v0.2.15 [INFO] [stderr] Compiling icu_locid_transform_data v1.5.0 [INFO] [stderr] Compiling rustls v0.23.16 [INFO] [stderr] Checking yoke v0.7.4 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling serde_json v1.0.132 [INFO] [stderr] Compiling icu_properties_data v1.5.0 [INFO] [stderr] Compiling write16 v1.0.0 [INFO] [stderr] Compiling rustls-pki-types v1.10.0 [INFO] [stderr] Compiling futures-sink v0.3.31 [INFO] [stderr] Compiling icu_normalizer_data v1.5.0 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Compiling utf8_iter v1.0.4 [INFO] [stderr] Compiling utf16_iter v1.0.5 [INFO] [stderr] Compiling percent-encoding v2.3.1 [INFO] [stderr] Compiling untrusted v0.9.0 [INFO] [stderr] Compiling zerocopy v0.7.35 [INFO] [stderr] Compiling spin v0.9.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling form_urlencoded v1.2.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling pin-utils v0.1.0 [INFO] [stderr] Compiling futures-io v0.3.31 [INFO] [stderr] Compiling futures-task v0.3.31 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling allocator-api2 v0.2.19 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Compiling bytes v1.8.0 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling crypto-common v0.1.6 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling futures-util v0.3.31 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Compiling concurrent-queue v2.5.0 [INFO] [stderr] Compiling tracing-core v0.1.32 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling mio v1.0.2 [INFO] [stderr] Compiling socket2 v0.5.7 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Compiling tokio v1.41.1 [INFO] [stderr] Compiling crc-catalog v2.4.0 [INFO] [stderr] Compiling subtle v2.6.1 [INFO] [stderr] Compiling iana-time-zone v0.1.61 [INFO] [stderr] Compiling cpufeatures v0.2.14 [INFO] [stderr] Compiling parking v2.2.1 [INFO] [stderr] Compiling unicode_categories v0.1.1 [INFO] [stderr] Compiling zeroize v1.8.1 [INFO] [stderr] Compiling rustix v0.38.39 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Compiling hashlink v0.9.1 [INFO] [stderr] Compiling tracing v0.1.40 [INFO] [stderr] Compiling event-listener v5.3.1 [INFO] [stderr] Compiling chrono v0.4.38 [INFO] [stderr] Compiling sha2 v0.10.8 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Compiling crc v3.2.1 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling crossbeam-queue v0.3.11 [INFO] [stderr] Compiling webpki-roots v0.26.6 [INFO] [stderr] Compiling rustls-pemfile v2.2.0 [INFO] [stderr] Compiling sqlformat v0.2.6 [INFO] [stderr] Compiling futures-channel v0.3.31 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling hex v0.4.3 [INFO] [stderr] Compiling flume v0.11.1 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling serde_urlencoded v0.7.1 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling fastrand v2.2.0 [INFO] [stderr] Compiling futures-executor v0.3.31 [INFO] [stderr] Checking anstyle-parse v0.2.6 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking anstyle-query v1.1.2 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle v1.0.10 [INFO] [stderr] Checking colorchoice v1.0.3 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Compiling dotenvy v0.15.7 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Compiling tempfile v3.14.0 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking clap_builder v4.5.20 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking url v2.5.3 [INFO] [stderr] Checking encode_unicode v1.0.0 [INFO] [stderr] Checking prettytable-rs v0.10.0 [INFO] [stderr] Compiling tokio-stream v0.1.16 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Checking clap v4.5.20 [INFO] [stderr] Checking sqlx-core v0.8.2 [INFO] [stderr] Checking sqlx-sqlite v0.8.2 [INFO] [stderr] Compiling sqlx-macros-core v0.8.2 [INFO] [stderr] Compiling sqlx-macros v0.8.2 [INFO] [stderr] Checking sqlx v0.8.2 [INFO] [stderr] Checking sqlite-extras v0.1.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:96:14 [INFO] [stdout] | [INFO] [stdout] 89 | let conn = match SqlitePool::connect(db_url()?.as_str()).await { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | `conn` calls a custom destructor [INFO] [stdout] | `conn` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(match sqlx::query(&query).fetch_all(&conn).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/sqlx-sqlite-0.8.2/src/value.rs:165:1 [INFO] [stdout] | [INFO] [stdout] 165 | impl Drop for ValueHandle { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `conn` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/sqlx-core-0.8.2/src/pool/inner.rs:443:1 [INFO] [stdout] | [INFO] [stdout] 443 | impl Drop for PoolInner { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed src/lib.rs (1 fix) [INFO] [stderr] Migrating bin/main.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.52s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking sqlite-extras v0.1.1 (/tmp/fixit) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.57s [INFO] running `Command { std: "docker" "inspect" "f37cae965d4fe88696ec43785b7243f8c7dc42f4f2b0343c1a6e0715138911a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f37cae965d4fe88696ec43785b7243f8c7dc42f4f2b0343c1a6e0715138911a8", kill_on_drop: false }` [INFO] [stdout] f37cae965d4fe88696ec43785b7243f8c7dc42f4f2b0343c1a6e0715138911a8