[INFO] fetching crate rndz 0.1.3... [INFO] checking rndz-0.1.3 against try#65132f36b923285d5da381c2fbafee6ce899e841 for pr-132712-1 [INFO] extracting crate rndz 0.1.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate rndz 0.1.3 on toolchain 65132f36b923285d5da381c2fbafee6ce899e841 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rndz 0.1.3 [INFO] finished tweaking crates.io crate rndz 0.1.3 [INFO] tweaked toml for crates.io crate rndz 0.1.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate rndz 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8a425f596a3b6586b3e6f6b392b72395ba0b86e9d34ed5e30e670b3469d47fab [INFO] running `Command { std: "docker" "start" "-a" "8a425f596a3b6586b3e6f6b392b72395ba0b86e9d34ed5e30e670b3469d47fab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8a425f596a3b6586b3e6f6b392b72395ba0b86e9d34ed5e30e670b3469d47fab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a425f596a3b6586b3e6f6b392b72395ba0b86e9d34ed5e30e670b3469d47fab", kill_on_drop: false }` [INFO] [stdout] 8a425f596a3b6586b3e6f6b392b72395ba0b86e9d34ed5e30e670b3469d47fab [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 849d3c74526f5809e5aaf03415682d0bc651e8328b5066b231e00bcb1b353748 [INFO] running `Command { std: "docker" "start" "-a" "849d3c74526f5809e5aaf03415682d0bc651e8328b5066b231e00bcb1b353748", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.121 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling protobuf v2.27.1 [INFO] [stderr] Compiling syn v1.0.89 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Compiling parking_lot_core v0.9.2 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Compiling unicode-segmentation v1.9.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling quote v1.0.16 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking mio v0.8.2 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling protobuf-codegen v2.27.1 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Compiling protobuf-codegen-pure v2.27.1 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Compiling rndz v0.1.3 (/tmp/fixit) [INFO] [stderr] Migrating build.rs from 2021 edition to 2024 [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/tcp/server.rs (2 fixes) [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/tcp/server.rs:49:45 [INFO] [stdout] | [INFO] [stdout] 49 | while let Ok((mut stream, _addr)) = self.listener.accept().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | / task::spawn(async move { [INFO] [stdout] 54 | | let (tx, rx) = channel(10); [INFO] [stdout] 55 | | let (r, w) = stream.split(); [INFO] [stdout] 56 | | let h = PeerHandler { [INFO] [stdout] ... | [INFO] [stdout] 65 | | h.handle_stream(r).await; [INFO] [stdout] 66 | | }); [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |______________this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] 67 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.17.0/src/io/poll_evented.rs:207:1 [INFO] [stdout] | [INFO] [stdout] 207 | impl Drop for PollEvented { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.17.0/src/io/poll_evented.rs:207:1 [INFO] [stdout] | [INFO] [stdout] 207 | impl Drop for PollEvented { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.17.0/src/runtime/task/join.rs:256:1 [INFO] [stdout] | [INFO] [stdout] 256 | impl Drop for JoinHandle { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/tcp/client_async.rs:131:32 [INFO] [stdout] | [INFO] [stdout] 112 | let (mut r, mut w) = svr.into_split(); [INFO] [stdout] | ----- ----- [INFO] [stdout] | | | [INFO] [stdout] | | `w` calls a custom destructor [INFO] [stdout] | | `w` will be dropped later as of Edition 2024 [INFO] [stdout] | `r` calls a custom destructor [INFO] [stdout] | `r` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | s.connect(target_addr).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 132 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/65132f36b923285d5da381c2fbafee6ce899e841/library/std/src/os/fd/owned.rs:172:1 [INFO] [stdout] note: `r` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.17.0/src/io/poll_evented.rs:207:1 [INFO] [stdout] | [INFO] [stdout] 207 | impl Drop for PollEvented { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `w` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.17.0/src/net/tcp/split_owned.rs:430:1 [INFO] [stdout] | [INFO] [stdout] 430 | impl Drop for OwnedWriteHalf { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/tcp/client_async.rs:266:25 [INFO] [stdout] | [INFO] [stdout] 266 | let _ = join!(rl, wl); [INFO] [stdout] | ^^^^^^^^^^^^^- now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.17.0/src/runtime/task/join.rs:256:1 [INFO] [stdout] | [INFO] [stdout] 256 | impl Drop for JoinHandle { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: this warning originates in the macro `$crate::join` which comes from the expansion of the macro `join` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/demo-async-tcp.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/demo-udp.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/demo-tcp.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.85s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Compiling rndz v0.1.3 (/tmp/fixit) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.69s [INFO] running `Command { std: "docker" "inspect" "849d3c74526f5809e5aaf03415682d0bc651e8328b5066b231e00bcb1b353748", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "849d3c74526f5809e5aaf03415682d0bc651e8328b5066b231e00bcb1b353748", kill_on_drop: false }` [INFO] [stdout] 849d3c74526f5809e5aaf03415682d0bc651e8328b5066b231e00bcb1b353748