[INFO] fetching crate ratchet_core 1.2.1... [INFO] checking ratchet_core-1.2.1 against try#65132f36b923285d5da381c2fbafee6ce899e841 for pr-132712-1 [INFO] extracting crate ratchet_core 1.2.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate ratchet_core 1.2.1 on toolchain 65132f36b923285d5da381c2fbafee6ce899e841 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ratchet_core 1.2.1 [INFO] finished tweaking crates.io crate ratchet_core 1.2.1 [INFO] tweaked toml for crates.io crate ratchet_core 1.2.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 105 packages to latest compatible versions [INFO] [stderr] Adding thiserror v1.0.69 (available: v2.0.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0a835c7d5bd5a69f1bbcb5d6944c2dab4c767f7fef3ffbdee60eb9e81282fcbd [INFO] running `Command { std: "docker" "start" "-a" "0a835c7d5bd5a69f1bbcb5d6944c2dab4c767f7fef3ffbdee60eb9e81282fcbd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0a835c7d5bd5a69f1bbcb5d6944c2dab4c767f7fef3ffbdee60eb9e81282fcbd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0a835c7d5bd5a69f1bbcb5d6944c2dab4c767f7fef3ffbdee60eb9e81282fcbd", kill_on_drop: false }` [INFO] [stdout] 0a835c7d5bd5a69f1bbcb5d6944c2dab4c767f7fef3ffbdee60eb9e81282fcbd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2b6c71a0c0fecaca9fda20fe312660623805958f33af899d8a2518c40de7ab6f [INFO] running `Command { std: "docker" "start" "-a" "2b6c71a0c0fecaca9fda20fe312660623805958f33af899d8a2518c40de7ab6f", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.92 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling libc v0.2.164 [INFO] [stderr] Checking litemap v0.7.4 [INFO] [stderr] Checking writeable v0.5.5 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking icu_locid_transform_data v1.5.0 [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking pin-project-lite v0.2.15 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking icu_properties_data v1.5.0 [INFO] [stderr] Checking icu_normalizer_data v1.5.0 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Checking write16 v1.0.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking utf16_iter v1.0.5 [INFO] [stderr] Checking bytes v1.8.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling httparse v1.9.5 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking itoa v1.0.13 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling syn v2.0.89 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking cpufeatures v0.2.16 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha-1 v0.10.1 [INFO] [stderr] Checking ratchet_ext v1.2.1 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking tokio v1.41.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking ratchet_core v1.2.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/framed/mod.rs (1 fix) [INFO] [stderr] Fixed src/handshake/client/encoding.rs (1 fix) [INFO] [stderr] Fixed src/handshake/subprotocols.rs (2 fixes) [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/builder.rs:67:10 [INFO] [stdout] | [INFO] [stdout] 57 | extension, [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `extension` calls a custom destructor [INFO] [stdout] | `extension` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 68 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes_mut.rs:1123:1 [INFO] [stdout] | [INFO] [stdout] 1123 | impl Drop for BytesMut { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/handshake/server/mod.rs:116:11 [INFO] [stdout] | [INFO] [stdout] 106 | let mut buf = BytesMut::new(); [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `buf` calls a custom destructor [INFO] [stdout] | `buf` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | match parser.parse().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^----- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `buf` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes_mut.rs:1123:1 [INFO] [stdout] | [INFO] [stdout] 1123 | impl Drop for BytesMut { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/handshake/server/mod.rs:322:70 [INFO] [stdout] | [INFO] [stdout] 314 | mut stream, [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | `stream` calls a custom destructor [INFO] [stdout] | `stream` will be dropped later as of Edition 2024 [INFO] [stdout] 315 | mut buf, [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `buf` calls a custom destructor [INFO] [stdout] | `buf` will be dropped later as of Edition 2024 [INFO] [stdout] 316 | request, [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `request` calls a custom destructor [INFO] [stdout] | `request` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 322 | write_response(&mut stream, &mut buf, status, headers, None).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 323 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `buf` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes_mut.rs:1123:1 [INFO] [stdout] | [INFO] [stdout] 1123 | impl Drop for BytesMut { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `request` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `request` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.14s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking ratchet_core v1.2.1 (/tmp/fixit) [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> src/framed/tests.rs:108:22 [INFO] [stdout] | [INFO] [stdout] 108 | unsafe { "hello".to_string().as_bytes_mut() }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^--------------- [INFO] [stdout] | | | [INFO] [stdout] | | temporary value is freed at the end of this statement [INFO] [stdout] | creates a temporary value which is freed while still in use [INFO] [stdout] | borrow later used here [INFO] [stdout] | [INFO] [stdout] = note: consider using a `let` binding to create a longer lived value [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> src/framed/tests.rs:118:22 [INFO] [stdout] | [INFO] [stdout] 118 | unsafe { "hello again".to_string().as_bytes_mut() }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^--------------- [INFO] [stdout] | | | [INFO] [stdout] | | temporary value is freed at the end of this statement [INFO] [stdout] | creates a temporary value which is freed while still in use [INFO] [stdout] | borrow later used here [INFO] [stdout] | [INFO] [stdout] = note: consider using a `let` binding to create a longer lived value [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> src/framed/tests.rs:147:22 [INFO] [stdout] | [INFO] [stdout] 147 | unsafe { "hello".to_string().as_bytes_mut() }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^--------------- [INFO] [stdout] | | | [INFO] [stdout] | | temporary value is freed at the end of this statement [INFO] [stdout] | creates a temporary value which is freed while still in use [INFO] [stdout] | borrow later used here [INFO] [stdout] | [INFO] [stdout] = note: consider using a `let` binding to create a longer lived value [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> src/framed/tests.rs:176:22 [INFO] [stdout] | [INFO] [stdout] 176 | unsafe { "Houston, we have a problem.".to_string().as_bytes_mut() }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------- [INFO] [stdout] | | | [INFO] [stdout] | | temporary value is freed at the end of this statement [INFO] [stdout] | creates a temporary value which is freed while still in use [INFO] [stdout] | borrow later used here [INFO] [stdout] | [INFO] [stdout] = note: consider using a `let` binding to create a longer lived value [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0716`. [INFO] [stdout] [INFO] [stderr] error: could not compile `ratchet_core` (lib test) due to 4 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "2b6c71a0c0fecaca9fda20fe312660623805958f33af899d8a2518c40de7ab6f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b6c71a0c0fecaca9fda20fe312660623805958f33af899d8a2518c40de7ab6f", kill_on_drop: false }` [INFO] [stdout] 2b6c71a0c0fecaca9fda20fe312660623805958f33af899d8a2518c40de7ab6f