[INFO] fetching crate nyxstone 0.1.4... [INFO] checking nyxstone-0.1.4 against try#65132f36b923285d5da381c2fbafee6ce899e841 for pr-132712-1 [INFO] extracting crate nyxstone 0.1.4 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate nyxstone 0.1.4 on toolchain 65132f36b923285d5da381c2fbafee6ce899e841 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nyxstone 0.1.4 [INFO] finished tweaking crates.io crate nyxstone 0.1.4 [INFO] tweaked toml for crates.io crate nyxstone 0.1.4 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate nyxstone 0.1.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 91f0cb782c6ea33ed553d3e3e2f56ff28d9c4517a244252a1ca91335a06c66e9 [INFO] running `Command { std: "docker" "start" "-a" "91f0cb782c6ea33ed553d3e3e2f56ff28d9c4517a244252a1ca91335a06c66e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "91f0cb782c6ea33ed553d3e3e2f56ff28d9c4517a244252a1ca91335a06c66e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91f0cb782c6ea33ed553d3e3e2f56ff28d9c4517a244252a1ca91335a06c66e9", kill_on_drop: false }` [INFO] [stdout] 91f0cb782c6ea33ed553d3e3e2f56ff28d9c4517a244252a1ca91335a06c66e9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3e51bd80f483a74ef79b7ad2f25ed8119eef2781262c61d242e46e48c823c4ed [INFO] running `Command { std: "docker" "start" "-a" "3e51bd80f483a74ef79b7ad2f25ed8119eef2781262c61d242e46e48c823c4ed", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling cc v1.0.99 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling scratch v1.0.7 [INFO] [stderr] Compiling termcolor v1.4.1 [INFO] [stderr] Compiling cxxbridge-flags v1.0.124 [INFO] [stderr] Compiling unicode-width v0.1.13 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling codespan-reporting v0.11.1 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling link-cplusplus v1.0.9 [INFO] [stderr] Compiling cxx v1.0.124 [INFO] [stderr] Compiling cxx-build v1.0.124 [INFO] [stderr] Compiling cxxbridge-macro v1.0.124 [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Compiling nyxstone v0.1.4 (/tmp/fixit) [INFO] [stderr] Migrating build.rs from 2021 edition to 2024 [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> build.rs:411:15 [INFO] [stdout] | [INFO] [stdout] 411 | match get_link_libraries_impl(llvm_config_path, kind) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 412 | Ok(s) => return (kind, extract_library(&s, kind)), [INFO] [stdout] 413 | Err(err) => { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `err` calls a custom destructor [INFO] [stdout] | `err` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 416 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.86/src/error.rs:600:1 [INFO] [stdout] | [INFO] [stdout] 600 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `err` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.86/src/error.rs:600:1 [INFO] [stdout] | [INFO] [stdout] 600 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `nyxstone` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/lib.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: expected expression, found `>` [INFO] [stderr] --> src/lib.rs:305:39 [INFO] [stderr] | [INFO] [stderr] 305 | pub ok: Vec), [INFO] [stderr] | ^ expected expression [INFO] [stderr] [INFO] [stderr] error: expected type, found `>` [INFO] [stderr] --> src/lib.rs:305:39 [INFO] [stderr] | [INFO] [stderr] 305 | pub ok: Vec), [INFO] [stderr] | ^ expected type [INFO] [stderr] | [INFO] [stderr] help: expressions must be enclosed in braces to be used as const generic arguments [INFO] [stderr] | [INFO] [stderr] 305 | pub ok: Vec<{ Instructionunsafe(>) }, [INFO] [stderr] | + + [INFO] [stderr] [INFO] [stderr] error: expected one of `>`, a const expression, lifetime, or type, found keyword `pub` [INFO] [stderr] --> src/lib.rs:306:9 [INFO] [stderr] | [INFO] [stderr] 304 | pub struct InstructionResult { [INFO] [stderr] | ----------------- while parsing this struct [INFO] [stderr] 305 | pub ok: Vec), [INFO] [stderr] | - expected one of `>`, a const expression, lifetime, or type [INFO] [stderr] 306 | pub error: String, [INFO] [stderr] | ^^^ unexpected token [INFO] [stderr] | [INFO] [stderr] help: you might have meant to end the type parameters here [INFO] [stderr] | [INFO] [stderr] 305 | pub ok: Vec)>, [INFO] [stderr] | + [INFO] [stderr] [INFO] [stderr] error: expected `,` [INFO] [stderr] --> src/lib.rs:305:38 [INFO] [stderr] | [INFO] [stderr] 305 | pub ok: Vec), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] error[E0432]: unresolved import `ffi` [INFO] [stderr] --> src/lib.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use ffi::create_nyxstone_ffi; [INFO] [stderr] | ^^^ help: a similar path exists: `std::ffi` [INFO] [stderr] [INFO] [stderr] error[E0432]: unresolved import `ffi` [INFO] [stderr] --> src/lib.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use ffi::LabelDefinition; [INFO] [stderr] | ^^^ help: a similar path exists: `std::ffi` [INFO] [stderr] [INFO] [stderr] error[E0432]: unresolved import `crate::ffi` [INFO] [stderr] --> src/lib.rs:6:16 [INFO] [stderr] | [INFO] [stderr] 6 | pub use crate::ffi::Instruction; [INFO] [stderr] | ^^^ [INFO] [stderr] | | [INFO] [stderr] | unresolved import [INFO] [stderr] | help: a similar path exists: `core::ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/lib.rs:50:33 [INFO] [stderr] | [INFO] [stderr] 50 | IntegerBase::Dec => ffi::IntegerBase::Dec, [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/lib.rs:51:39 [INFO] [stderr] | [INFO] [stderr] 51 | IntegerBase::HexPrefix => ffi::IntegerBase::HexPrefix, [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/lib.rs:280:28 [INFO] [stdout] | [INFO] [stdout] 280 | #[derive(Clone, Debug, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] = note: `--force-warn unsafe-attr-outside-unsafe` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 280 | #[derive(Clone, Debug, Paunsafe(rtialE)q, Eq)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] --> src/lib.rs:52:39 [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/lib.rs:289:28 [INFO] [stdout] | [INFO] [stdout] 289 | #[derive(Clone, Debug, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 289 | #[derive(Clone, Debug, Paunsafe(rtialE)q, Eq)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/lib.rs:305:32 [INFO] [stdout] | [INFO] [stdout] 305 | pub ok: Vec, [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 305 | pub ok: Vec), [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] 52 | IntegerBase::HexSuffix => ffi::IntegerBase::HexSuffix, [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/lib.rs:344:115 [INFO] [stdout] | [INFO] [stdout] 344 | fn create_nyxstone_ffi(triple_name: &str, cpu: &str, features: &str, style: IntegerBase) -> NyxstoneResult; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] = note: `--force-warn missing-unsafe-on-extern` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/lib.rs:349:112 [INFO] [stdout] | [INFO] [stdout] 349 | fn assemble(self: &NyxstoneFFI, assembly: &str, address: u64, labels: &[LabelDefinition]) -> ByteResult; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/lib.rs:359:31 [INFO] [stdout] | [INFO] [stdout] 359 | ) -> InstructionResult; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/lib.rs:362:101 [INFO] [stdout] | [INFO] [stdout] 362 | fn disassemble(self: &NyxstoneFFI, bytes: &[u8], address: u64, count: usize) -> StringResult; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] --> src/lib.rs:32:27 [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/lib.rs:370:31 [INFO] [stdout] | [INFO] [stdout] 370 | ) -> InstructionResult; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/lib.rs:315:38 [INFO] [stdout] | [INFO] [stdout] 315 | pub ok: UniquePtr, [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] 32 | inner: cxx::UniquePtr, [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/lib.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | impl From for ffi::IntegerBase { [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/lib.rs:374:22 [INFO] [stderr] | [INFO] [stderr] 374 | unsafe impl Send for ffi::NyxstoneFFI {} [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error: aborting due to 13 previous errors [INFO] [stderr] [INFO] [stderr] Some errors have detailed explanations: E0432, E0433. [INFO] [stderr] For more information about an error, try `rustc --explain E0432`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `nyxstone` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/lib.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: expected expression, found `>` [INFO] [stderr] --> src/lib.rs:305:39 [INFO] [stderr] | [INFO] [stderr] 305 | pub ok: Vec), [INFO] [stderr] | ^ expected expression [INFO] [stderr] [INFO] [stderr] error: expected type, found `>` [INFO] [stderr] --> src/lib.rs:305:39 [INFO] [stderr] | [INFO] [stderr] 305 | pub ok: Vec), [INFO] [stderr] | ^ expected type [INFO] [stderr] | [INFO] [stderr] help: expressions must be enclosed in braces to be used as const generic arguments [INFO] [stderr] | [INFO] [stderr] 305 | pub ok: Vec<{ Instructionunsafe(>) }, [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/lib.rs:280:28 [INFO] [stdout] | [INFO] [stdout] 280 | #[derive(Clone, Debug, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] = note: `--force-warn unsafe-attr-outside-unsafe` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 280 | #[derive(Clone, Debug, Paunsafe(rtialE)q, Eq)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | + + [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/lib.rs:289:28 [INFO] [stdout] | [INFO] [stdout] 289 | #[derive(Clone, Debug, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 289 | #[derive(Clone, Debug, Paunsafe(rtialE)q, Eq)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/lib.rs:305:32 [INFO] [stdout] | [INFO] [stdout] 305 | pub ok: Vec, [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 305 | pub ok: Vec), [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: expected one of `>`, a const expression, lifetime, or type, found keyword `pub` [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/lib.rs:344:115 [INFO] [stdout] | [INFO] [stdout] 344 | fn create_nyxstone_ffi(triple_name: &str, cpu: &str, features: &str, style: IntegerBase) -> NyxstoneResult; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] = note: `--force-warn missing-unsafe-on-extern` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] --> src/lib.rs:306:9 [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/lib.rs:349:112 [INFO] [stdout] | [INFO] [stdout] 349 | fn assemble(self: &NyxstoneFFI, assembly: &str, address: u64, labels: &[LabelDefinition]) -> ByteResult; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/lib.rs:359:31 [INFO] [stdout] | [INFO] [stdout] 359 | ) -> InstructionResult; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] 304 | pub struct InstructionResult { [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/lib.rs:362:101 [INFO] [stdout] | [INFO] [stdout] 362 | fn disassemble(self: &NyxstoneFFI, bytes: &[u8], address: u64, count: usize) -> StringResult; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | ----------------- while parsing this struct [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/lib.rs:370:31 [INFO] [stdout] | [INFO] [stdout] 370 | ) -> InstructionResult; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] 305 | pub ok: Vec), [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/lib.rs:315:38 [INFO] [stdout] | [INFO] [stdout] 315 | pub ok: UniquePtr, [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | - expected one of `>`, a const expression, lifetime, or type [INFO] [stderr] 306 | pub error: String, [INFO] [stderr] | ^^^ unexpected token [INFO] [stderr] | [INFO] [stderr] help: you might have meant to end the type parameters here [INFO] [stderr] | [INFO] [stderr] 305 | pub ok: Vec)>, [INFO] [stderr] | + [INFO] [stderr] [INFO] [stderr] error: expected `,` [INFO] [stderr] --> src/lib.rs:305:38 [INFO] [stderr] | [INFO] [stderr] 305 | pub ok: Vec), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] error[E0432]: unresolved import `ffi` [INFO] [stderr] --> src/lib.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use ffi::create_nyxstone_ffi; [INFO] [stderr] | ^^^ help: a similar path exists: `std::ffi` [INFO] [stderr] [INFO] [stderr] error[E0432]: unresolved import `ffi` [INFO] [stderr] --> src/lib.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use ffi::LabelDefinition; [INFO] [stderr] | ^^^ help: a similar path exists: `std::ffi` [INFO] [stderr] [INFO] [stderr] error[E0432]: unresolved import `crate::ffi` [INFO] [stderr] --> src/lib.rs:6:16 [INFO] [stderr] | [INFO] [stderr] 6 | pub use crate::ffi::Instruction; [INFO] [stderr] | ^^^ [INFO] [stderr] | | [INFO] [stderr] | unresolved import [INFO] [stderr] | help: a similar path exists: `core::ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/lib.rs:50:33 [INFO] [stderr] | [INFO] [stderr] 50 | IntegerBase::Dec => ffi::IntegerBase::Dec, [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/lib.rs:51:39 [INFO] [stderr] | [INFO] [stderr] 51 | IntegerBase::HexPrefix => ffi::IntegerBase::HexPrefix, [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/lib.rs:52:39 [INFO] [stderr] | [INFO] [stderr] 52 | IntegerBase::HexSuffix => ffi::IntegerBase::HexSuffix, [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/lib.rs:32:27 [INFO] [stderr] | [INFO] [stderr] 32 | inner: cxx::UniquePtr, [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/lib.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | impl From for ffi::IntegerBase { [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/lib.rs:374:22 [INFO] [stderr] | [INFO] [stderr] 374 | unsafe impl Send for ffi::NyxstoneFFI {} [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error: aborting due to 13 previous errors [INFO] [stderr] [INFO] [stderr] Some errors have detailed explanations: E0432, E0433. [INFO] [stderr] For more information about an error, try `rustc --explain E0432`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.99s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Compiling nyxstone v0.1.4 (/tmp/fixit) [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/lib.rs:344:115 [INFO] [stdout] | [INFO] [stdout] 344 | fn create_nyxstone_ffi(triple_name: &str, cpu: &str, features: &str, style: IntegerBase) -> NyxstoneResult; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/lib.rs:349:112 [INFO] [stdout] | [INFO] [stdout] 349 | fn assemble(self: &NyxstoneFFI, assembly: &str, address: u64, labels: &[LabelDefinition]) -> ByteResult; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/lib.rs:359:31 [INFO] [stdout] | [INFO] [stdout] 359 | ) -> InstructionResult; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/lib.rs:362:101 [INFO] [stdout] | [INFO] [stdout] 362 | fn disassemble(self: &NyxstoneFFI, bytes: &[u8], address: u64, count: usize) -> StringResult; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/lib.rs:370:31 [INFO] [stdout] | [INFO] [stdout] 370 | ) -> InstructionResult; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/lib.rs:315:38 [INFO] [stdout] | [INFO] [stdout] 315 | pub ok: UniquePtr, [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/lib.rs:280:28 [INFO] [stdout] | [INFO] [stdout] 280 | #[derive(Clone, Debug, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 280 | #[derive(Clone, Debug, Paunsafe(rtialE)q, Eq)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/lib.rs:289:28 [INFO] [stdout] | [INFO] [stdout] 289 | #[derive(Clone, Debug, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 289 | #[derive(Clone, Debug, Paunsafe(rtialE)q, Eq)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/lib.rs:305:32 [INFO] [stdout] | [INFO] [stdout] 305 | pub ok: Vec, [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 305 | pub ok: Vec), [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/lib.rs:344:115 [INFO] [stdout] | [INFO] [stdout] 344 | fn create_nyxstone_ffi(triple_name: &str, cpu: &str, features: &str, style: IntegerBase) -> NyxstoneResult; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/lib.rs:349:112 [INFO] [stdout] | [INFO] [stdout] 349 | fn assemble(self: &NyxstoneFFI, assembly: &str, address: u64, labels: &[LabelDefinition]) -> ByteResult; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/lib.rs:359:31 [INFO] [stdout] | [INFO] [stdout] 359 | ) -> InstructionResult; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/lib.rs:362:101 [INFO] [stdout] | [INFO] [stdout] 362 | fn disassemble(self: &NyxstoneFFI, bytes: &[u8], address: u64, count: usize) -> StringResult; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/lib.rs:370:31 [INFO] [stdout] | [INFO] [stdout] 370 | ) -> InstructionResult; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/lib.rs:315:38 [INFO] [stdout] | [INFO] [stdout] 315 | pub ok: UniquePtr, [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/lib.rs:280:28 [INFO] [stdout] | [INFO] [stdout] 280 | #[derive(Clone, Debug, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 280 | #[derive(Clone, Debug, Paunsafe(rtialE)q, Eq)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/lib.rs:289:28 [INFO] [stdout] | [INFO] [stdout] 289 | #[derive(Clone, Debug, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 289 | #[derive(Clone, Debug, Paunsafe(rtialE)q, Eq)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/lib.rs:305:32 [INFO] [stdout] | [INFO] [stdout] 305 | pub ok: Vec, [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 305 | pub ok: Vec), [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nyxstone` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `nyxstone` (lib test) due to 9 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "3e51bd80f483a74ef79b7ad2f25ed8119eef2781262c61d242e46e48c823c4ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e51bd80f483a74ef79b7ad2f25ed8119eef2781262c61d242e46e48c823c4ed", kill_on_drop: false }` [INFO] [stdout] 3e51bd80f483a74ef79b7ad2f25ed8119eef2781262c61d242e46e48c823c4ed