[INFO] fetching crate netavark 1.13.0... [INFO] checking netavark-1.13.0 against try#65132f36b923285d5da381c2fbafee6ce899e841 for pr-132712-1 [INFO] extracting crate netavark 1.13.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate netavark 1.13.0 on toolchain 65132f36b923285d5da381c2fbafee6ce899e841 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate netavark 1.13.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate netavark 1.13.0 [INFO] tweaked toml for crates.io crate netavark 1.13.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate netavark 1.13.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bf6043aea863215a1ae390d5eef73c2e187310e65b7785d056703c0c0ba9b4a4 [INFO] running `Command { std: "docker" "start" "-a" "bf6043aea863215a1ae390d5eef73c2e187310e65b7785d056703c0c0ba9b4a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bf6043aea863215a1ae390d5eef73c2e187310e65b7785d056703c0c0ba9b4a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf6043aea863215a1ae390d5eef73c2e187310e65b7785d056703c0c0ba9b4a4", kill_on_drop: false }` [INFO] [stdout] bf6043aea863215a1ae390d5eef73c2e187310e65b7785d056703c0c0ba9b4a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ba4842b563ce9776739a708ef7eab62eb583401ada54b2ef718f26300c92d4ae [INFO] running `Command { std: "docker" "start" "-a" "ba4842b563ce9776739a708ef7eab62eb583401ada54b2ef718f26300c92d4ae", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.89 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling libc v0.2.161 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Compiling anyhow v1.0.91 [INFO] [stderr] Compiling thiserror v1.0.65 [INFO] [stderr] Compiling serde v1.0.213 [INFO] [stderr] Compiling hashbrown v0.15.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Compiling rustix v0.38.38 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling bytes v1.8.0 [INFO] [stderr] Compiling indexmap v2.6.0 [INFO] [stderr] Checking unicode-bidi v0.3.17 [INFO] [stderr] Compiling regex-syntax v0.8.5 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling syn v2.0.85 [INFO] [stderr] Compiling prettyplease v0.2.25 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling toml_edit v0.22.22 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling regex-automata v0.4.8 [INFO] [stderr] Compiling serde_json v1.0.132 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Compiling tempfile v3.13.0 [INFO] [stderr] Compiling regex v1.11.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Compiling multimap v0.10.0 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking anstyle v1.0.9 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking anstream v0.6.17 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Compiling zvariant_utils v2.1.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Compiling iana-time-zone v0.1.61 [INFO] [stderr] Checking endi v1.1.0 [INFO] [stderr] Checking cpufeatures v0.2.14 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Compiling dhcproto-macros v0.1.0 [INFO] [stderr] Checking etherparse v0.13.0 [INFO] [stderr] Compiling enum-as-inner v0.5.1 [INFO] [stderr] Checking clap_builder v4.5.20 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking async-fs v2.1.2 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.65 [INFO] [stderr] Compiling serde_derive v1.0.213 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking tokio v1.41.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling prost-derive v0.13.3 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking netlink-packet-utils v0.5.2 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Checking netlink-packet-core v0.7.0 [INFO] [stderr] Checking netlink-packet-generic v0.3.3 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling enumflags2_derive v0.7.10 [INFO] [stderr] Checking netlink-packet-route v0.19.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling zvariant_derive v4.2.0 [INFO] [stderr] Compiling pin-project-internal v1.1.7 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling prost v0.13.3 [INFO] [stderr] Checking polling v3.7.3 [INFO] [stderr] Compiling prost-types v0.13.3 [INFO] [stderr] Compiling chrono v0.4.38 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking pin-project v1.1.7 [INFO] [stderr] Checking tower v0.5.1 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking axum-core v0.4.5 [INFO] [stderr] Checking async-io v2.3.4 [INFO] [stderr] Compiling zbus_macros v4.4.0 [INFO] [stderr] Compiling prost-build v0.13.3 [INFO] [stderr] Checking netlink-sys v0.8.6 [INFO] [stderr] Checking netlink-proto v0.11.3 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking genetlink v0.2.5 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Checking mptcp-pm v0.1.3 [INFO] [stderr] Checking rtnetlink v0.14.1 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking ethtool v0.2.5 [INFO] [stderr] Checking wl-nl80211 v0.2.0 [INFO] [stderr] Compiling tonic-build v0.12.3 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling enum-as-inner v0.6.1 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking enumflags2 v0.7.10 [INFO] [stderr] Checking ipnet v2.10.1 [INFO] [stderr] Compiling netavark v1.13.0 (/tmp/fixit) [INFO] [stderr] Migrating build.rs from 2021 edition to 2024 [INFO] [stderr] Checking zvariant v4.2.0 [INFO] [stderr] Checking axum v0.7.7 [INFO] [stderr] Checking trust-dns-proto v0.22.0 [INFO] [stderr] Checking nispor v1.2.21 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking hyper v1.5.0 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking async-executor v1.13.1 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking async-broadcast v0.7.1 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking nftables v0.5.0 [INFO] [stderr] Checking sysctl v0.6.0 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking hyper-util v0.1.10 [INFO] [stderr] Checking dhcproto v0.9.0 [INFO] [stderr] Checking netlink-packet-route v0.21.0 [INFO] [stderr] Checking zbus_names v3.0.0 [INFO] [stderr] Checking zbus v4.4.0 [INFO] [stderr] Checking iptables v0.5.2 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hyper-timeout v0.5.1 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking clap v4.5.20 [INFO] [stderr] Checking tonic v0.12.3 [INFO] [stderr] Checking mozim v0.2.4 [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/error/mod.rs (2 fixes) [INFO] [stderr] Fixed src/dhcp_proxy/cache.rs (6 fixes) [INFO] [stderr] Fixed src/commands/setup.rs (1 fix) [INFO] [stderr] Fixed src/commands/update.rs (1 fix) [INFO] [stderr] Fixed src/firewall/firewalld.rs (5 fixes) [INFO] [stderr] Fixed src/network/core_utils.rs (3 fixes) [INFO] [stderr] Fixed src/network/netlink.rs (2 fixes) [INFO] [stderr] Fixed src/commands/firewalld_reload.rs (1 fix) [INFO] [stderr] Fixed src/firewall/nft.rs (3 fixes) [INFO] [stderr] Fixed src/commands/teardown.rs (1 fix) [INFO] [stderr] Fixed src/firewall/state.rs (5 fixes) [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/commands/dhcp_proxy.rs:336:52 [INFO] [stdout] | [INFO] [stdout] 336 | match timeout(timeout_duration, rx.recv()).await { [INFO] [stdout] | -------------------------------------^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 355 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.0/src/runtime/time/entry.rs:652:1 [INFO] [stdout] | [INFO] [stdout] 652 | impl Drop for TimerEntry { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `__awaitee` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.0/src/runtime/time/entry.rs:652:1 [INFO] [stdout] | [INFO] [stdout] 652 | impl Drop for TimerEntry { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/dhcp_proxy/dhcp_service.rs:148:31 [INFO] [stdout] | [INFO] [stdout] 148 | match update_lease_ip( [INFO] [stdout] | _______________________________^ [INFO] [stdout] 149 | | &client.network_config.ns_path, [INFO] [stdout] 150 | | &client.network_config.container_iface, [INFO] [stdout] 151 | | old_lease, [INFO] [stdout] 152 | | &lease, [INFO] [stdout] 153 | | ) { [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_________________________this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 154 | Ok(_) => {} [INFO] [stdout] 155 | Err(err) => { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `err` calls a custom destructor [INFO] [stdout] | `err` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/65132f36b923285d5da381c2fbafee6ce899e841/library/std/src/os/fd/owned.rs:172:1 [INFO] [stdout] = note: `err` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `err` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `err` invokes this custom destructor [INFO] [stdout] --> /rustc/65132f36b923285d5da381c2fbafee6ce899e841/library/std/src/os/fd/owned.rs:172:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed src/dhcp_proxy/proxy_conf.rs (2 fixes) [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/test/netlink.rs (2 fixes) [INFO] [stderr] Migrating src/dhcp_proxy_client/client.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/stderr-plugin.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/host-device-plugin.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/error-plugin.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 24.27s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Compiling netavark v1.13.0 (/tmp/fixit) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.24s [INFO] running `Command { std: "docker" "inspect" "ba4842b563ce9776739a708ef7eab62eb583401ada54b2ef718f26300c92d4ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba4842b563ce9776739a708ef7eab62eb583401ada54b2ef718f26300c92d4ae", kill_on_drop: false }` [INFO] [stdout] ba4842b563ce9776739a708ef7eab62eb583401ada54b2ef718f26300c92d4ae