[INFO] fetching crate lc3-ensemble 0.9.1... [INFO] checking lc3-ensemble-0.9.1 against try#65132f36b923285d5da381c2fbafee6ce899e841 for pr-132712-1 [INFO] extracting crate lc3-ensemble 0.9.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate lc3-ensemble 0.9.1 on toolchain 65132f36b923285d5da381c2fbafee6ce899e841 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lc3-ensemble 0.9.1 [INFO] finished tweaking crates.io crate lc3-ensemble 0.9.1 [INFO] tweaked toml for crates.io crate lc3-ensemble 0.9.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 22 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 448ed7a7d33a88a2a9157e32316d5d978de76c07241a7295f07f2e442d6df849 [INFO] running `Command { std: "docker" "start" "-a" "448ed7a7d33a88a2a9157e32316d5d978de76c07241a7295f07f2e442d6df849", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "448ed7a7d33a88a2a9157e32316d5d978de76c07241a7295f07f2e442d6df849", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "448ed7a7d33a88a2a9157e32316d5d978de76c07241a7295f07f2e442d6df849", kill_on_drop: false }` [INFO] [stdout] 448ed7a7d33a88a2a9157e32316d5d978de76c07241a7295f07f2e442d6df849 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 28e7c3114d31a0ee8fee33d72ffd85fbf372d5385c7d75bf9ce8cfc1e2c244f6 [INFO] running `Command { std: "docker" "start" "-a" "28e7c3114d31a0ee8fee33d72ffd85fbf372d5385c7d75bf9ce8cfc1e2c244f6", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling regex-syntax v0.8.5 [INFO] [stderr] Compiling syn v2.0.89 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling logos-codegen v0.14.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling logos-derive v0.14.2 [INFO] [stderr] Checking logos v0.14.2 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking lc3-ensemble v0.9.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `lc3_ensemble` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/parse.rs [INFO] [stderr] * src/parse/lex.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: expected one of `(`, `,`, `::`, or `=`, found `+` [INFO] [stderr] --> src/parse/lex.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Debug, Logos + use<'s>, PartialEq, Eq)] [INFO] [stderr] | ^ expected one of `(`, `,`, `::`, or `=` [INFO] [stderr] [INFO] [stderr] error[E0432]: unresolved import `lex::Token` [INFO] [stderr] --> src/parse.rs:24:18 [INFO] [stderr] | [INFO] [stderr] 24 | use lex::{Ident, Token}; [INFO] [stderr] | ^^^^^ no `Token` in `parse::lex` [INFO] [stderr] [INFO] [stderr] error[E0432]: unresolved import `super::lex::Token` [INFO] [stderr] --> src/parse.rs:293:37 [INFO] [stderr] | [INFO] [stderr] 293 | use super::lex::{Ident, LexErr, Token}; [INFO] [stderr] | ^^^^^ no `Token` in `parse::lex` [INFO] [stderr] | [INFO] [stderr] = help: consider importing this unresolved item through its public re-export instead: [INFO] [stderr] crate::parse::Token [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/parse/lex.rs:74:6 [INFO] [stderr] | [INFO] [stderr] 74 | impl Token { [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/parse/lex.rs:206:36 [INFO] [stderr] | [INFO] [stderr] 206 | fn lex_unsigned_dec(lx: &Lexer<'_, Token>) -> Result { [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] | [INFO] [stderr] help: you might be missing a type parameter [INFO] [stderr] | [INFO] [stderr] 206 | fn lex_unsigned_dec(lx: &Lexer<'_, Token>) -> Result { [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/parse/lex.rs:216:34 [INFO] [stderr] | [INFO] [stderr] 216 | fn lex_signed_dec(lx: &Lexer<'_, Token>) -> Result { [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] | [INFO] [stderr] help: you might be missing a type parameter [INFO] [stderr] | [INFO] [stderr] 216 | fn lex_signed_dec(lx: &Lexer<'_, Token>) -> Result { [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/parse/lex.rs:225:36 [INFO] [stderr] | [INFO] [stderr] 225 | fn lex_unsigned_hex(lx: &Lexer<'_, Token>) -> Result { [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] | [INFO] [stderr] help: you might be missing a type parameter [INFO] [stderr] | [INFO] [stderr] 225 | fn lex_unsigned_hex(lx: &Lexer<'_, Token>) -> Result { [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/parse/lex.rs:233:34 [INFO] [stderr] | [INFO] [stderr] 233 | fn lex_signed_hex(lx: &Lexer<'_, Token>) -> Result { [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] | [INFO] [stderr] help: you might be missing a type parameter [INFO] [stderr] | [INFO] [stderr] 233 | fn lex_signed_hex(lx: &Lexer<'_, Token>) -> Result { [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/parse/lex.rs:241:27 [INFO] [stderr] | [INFO] [stderr] 241 | fn lex_reg(lx: &Lexer<'_, Token>) -> Result { [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] | [INFO] [stderr] help: you might be missing a type parameter [INFO] [stderr] | [INFO] [stderr] 241 | fn lex_reg(lx: &Lexer<'_, Token>) -> Result { [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/parse/lex.rs:246:39 [INFO] [stderr] | [INFO] [stderr] 246 | fn lex_str_literal(lx: &mut Lexer<'_, Token>) -> Result { [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] | [INFO] [stderr] help: you might be missing a type parameter [INFO] [stderr] | [INFO] [stderr] 246 | fn lex_str_literal(lx: &mut Lexer<'_, Token>) -> Result { [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `Token` [INFO] [stderr] --> src/parse/lex.rs:76:24 [INFO] [stderr] | [INFO] [stderr] 76 | matches!(self, Token::NewLine) [INFO] [stderr] | ^^^^^ use of undeclared type `Token` [INFO] [stderr] [INFO] [stderr] error: aborting due to 11 previous errors [INFO] [stderr] [INFO] [stderr] Some errors have detailed explanations: E0412, E0432, E0433. [INFO] [stderr] For more information about an error, try `rustc --explain E0412`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/sim/mem.rs:332:14 [INFO] [stdout] | [INFO] [stdout] 332 | self.gen() [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl CallbackResult<'s, Ident, Token>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/parse/lex.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos, PartialEq, Eq)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/parse/lex.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos, PartialEq, Eq)] [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] = note: this warning originates in the derive macro `Logos` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos + use<'s>, PartialEq, Eq)] [INFO] [stdout] | +++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl CallbackResult<'s, Ident, Token>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/parse/lex.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos, PartialEq, Eq)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/parse/lex.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos, PartialEq, Eq)] [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: this warning originates in the derive macro `Logos` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos + use<'s>, PartialEq, Eq)] [INFO] [stdout] | +++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl CallbackResult<'s, String, Token>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/parse/lex.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos, PartialEq, Eq)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/parse/lex.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos, PartialEq, Eq)] [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: this warning originates in the derive macro `Logos` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos + use<'s>, PartialEq, Eq)] [INFO] [stdout] | +++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl CallbackResult<'s, String, Token>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/parse/lex.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos, PartialEq, Eq)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/parse/lex.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos, PartialEq, Eq)] [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: this warning originates in the derive macro `Logos` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos + use<'s>, PartialEq, Eq)] [INFO] [stdout] | +++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sim.rs:749:20 [INFO] [stdout] | [INFO] [stdout] 749 | if let Some(data) = self.device_handler.io_read(addr, ctx.io_effects) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^-------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sim.rs:751:17 [INFO] [stdout] | [INFO] [stdout] 751 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 749 ~ match self.device_handler.io_read(addr, ctx.io_effects) { Some(data) => { [INFO] [stdout] 750 | self.mem[addr].set(data); [INFO] [stdout] 751 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl WordFiller` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/sim/mem.rs:362:39 [INFO] [stdout] | [INFO] [stdout] 362 | pub(super) fn generator(&self) -> impl WordFiller { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/sim/mem.rs:362:29 [INFO] [stdout] | [INFO] [stdout] 362 | pub(super) fn generator(&self) -> impl WordFiller { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 362 | pub(super) fn generator(&self) -> impl WordFiller + use<> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sim/device.rs:165:12 [INFO] [stdout] | [INFO] [stdout] 165 | if let Some(dev_ref) = self.devices.get_mut(dev_id as usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^------------^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sim/device.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 165 ~ match self.devices.get_mut(dev_id as usize) { Some(dev_ref) => { [INFO] [stdout] 166 | std::mem::take(dev_ref); [INFO] [stdout] ... [INFO] [stdout] 173 | } [INFO] [stdout] 174 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sim/device.rs:460:12 [INFO] [stdout] | [INFO] [stdout] 460 | if let Some(mut guard) = resolve_lock(self.try_write()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sim/device.rs:462:9 [INFO] [stdout] | [INFO] [stdout] 462 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 460 ~ match resolve_lock(self.try_write()) { Some(mut guard) => { [INFO] [stdout] 461 | guard.io_reset(); [INFO] [stdout] 462 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sim/device.rs:482:12 [INFO] [stdout] | [INFO] [stdout] 482 | if let Some(mut guard) = resolve_lock(self.try_lock()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^----------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sim/device.rs:484:9 [INFO] [stdout] | [INFO] [stdout] 484 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 482 ~ match resolve_lock(self.try_lock()) { Some(mut guard) => { [INFO] [stdout] 483 | guard.io_reset(); [INFO] [stdout] 484 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sim/device/keyboard.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 106 | if let Some(mut inp) = self.try_input() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^---------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sim/device/keyboard.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 106 ~ match self.try_input() { Some(mut inp) => { [INFO] [stdout] 107 | inp.clear(); [INFO] [stdout] 108 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sim/device/display.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 79 | if let Some(mut out) = self.try_output() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sim/device/display.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 79 ~ match self.try_output() { Some(mut out) => { [INFO] [stdout] 80 | out.clear(); [INFO] [stdout] 81 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl RangeBounds` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/sim/device/timer.rs:99:32 [INFO] [stdout] | [INFO] [stdout] 99 | pub fn get_range(&self) -> impl RangeBounds { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/sim/device/timer.rs:99:22 [INFO] [stdout] | [INFO] [stdout] 99 | pub fn get_range(&self) -> impl RangeBounds { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 99 | pub fn get_range(&self) -> impl RangeBounds + use<> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl Iterator` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/sim/observer.rs:38:43 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn take_mem_changes(&mut self) -> impl Iterator { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/sim/observer.rs:38:29 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn take_mem_changes(&mut self) -> impl Iterator { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 38 | pub fn take_mem_changes(&mut self) -> impl Iterator + use<> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `lc3_ensemble` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/parse.rs [INFO] [stderr] * src/parse/lex.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: expected one of `(`, `,`, `::`, or `=`, found `+` [INFO] [stderr] --> src/parse/lex.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Debug, Logos + use<'s>, PartialEq, Eq)] [INFO] [stderr] | ^ expected one of `(`, `,`, `::`, or `=` [INFO] [stderr] [INFO] [stderr] error[E0432]: unresolved import `lex::Token` [INFO] [stderr] --> src/parse.rs:24:18 [INFO] [stderr] | [INFO] [stderr] 24 | use lex::{Ident, Token}; [INFO] [stderr] | ^^^^^ no `Token` in `parse::lex` [INFO] [stderr] [INFO] [stderr] error[E0432]: unresolved import `super::lex::Token` [INFO] [stderr] --> src/parse.rs:293:37 [INFO] [stderr] | [INFO] [stderr] 293 | use super::lex::{Ident, LexErr, Token}; [INFO] [stderr] | ^^^^^ no `Token` in `parse::lex` [INFO] [stderr] | [INFO] [stderr] = help: consider importing this unresolved item through its public re-export instead: [INFO] [stderr] crate::parse::Token [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/parse/lex.rs:74:6 [INFO] [stderr] | [INFO] [stderr] 74 | impl Token { [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/parse/lex.rs:206:36 [INFO] [stderr] | [INFO] [stderr] 206 | fn lex_unsigned_dec(lx: &Lexer<'_, Token>) -> Result { [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] | [INFO] [stderr] help: you might be missing a type parameter [INFO] [stderr] | [INFO] [stderr] 206 | fn lex_unsigned_dec(lx: &Lexer<'_, Token>) -> Result { [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/parse/lex.rs:216:34 [INFO] [stderr] | [INFO] [stderr] 216 | fn lex_signed_dec(lx: &Lexer<'_, Token>) -> Result { [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] | [INFO] [stderr] help: you might be missing a type parameter [INFO] [stderr] | [INFO] [stderr] 216 | fn lex_signed_dec(lx: &Lexer<'_, Token>) -> Result { [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/sim/mem.rs:332:14 [INFO] [stdout] | [INFO] [stdout] 332 | self.gen() [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/parse/lex.rs:225:36 [INFO] [stderr] | [INFO] [stderr] 225 | fn lex_unsigned_hex(lx: &Lexer<'_, Token>) -> Result { [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] | [INFO] [stderr] help: you might be missing a type parameter [INFO] [stderr] | [INFO] [stderr] 225 | fn lex_unsigned_hex(lx: &Lexer<'_, Token>) -> Result { [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/parse/lex.rs:233:34 [INFO] [stderr] | [INFO] [stderr] 233 | fn lex_signed_hex(lx: &Lexer<'_, Token>) -> Result { [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] | [INFO] [stderr] help: you might be missing a type parameter [INFO] [stderr] | [INFO] [stderr] 233 | fn lex_signed_hex(lx: &Lexer<'_, Token>) -> Result { [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/parse/lex.rs:241:27 [INFO] [stderr] | [INFO] [stderr] 241 | fn lex_reg(lx: &Lexer<'_, Token>) -> Result { [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] | [INFO] [stderr] help: you might be missing a type parameter [INFO] [stderr] | [INFO] [stderr] 241 | fn lex_reg(lx: &Lexer<'_, Token>) -> Result { [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/parse/lex.rs:246:39 [INFO] [stderr] | [INFO] [stderr] 246 | fn lex_str_literal(lx: &mut Lexer<'_, Token>) -> Result { [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] | [INFO] [stderr] help: you might be missing a type parameter [INFO] [stderr] | [INFO] [stderr] 246 | fn lex_str_literal(lx: &mut Lexer<'_, Token>) -> Result { [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `Token` [INFO] [stderr] --> src/parse/lex.rs:76:24 [INFO] [stderr] | [INFO] [stderr] 76 | matches!(self, Token::NewLine) [INFO] [stderr] | ^^^^^ use of undeclared type `Token` [INFO] [stderr] [INFO] [stderr] error: aborting due to 11 previous errors [INFO] [stderr] [INFO] [stderr] Some errors have detailed explanations: E0412, E0432, E0433. [INFO] [stderr] For more information about an error, try `rustc --explain E0412`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `impl CallbackResult<'s, Ident, Token>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/parse/lex.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos, PartialEq, Eq)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/parse/lex.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos, PartialEq, Eq)] [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] = note: this warning originates in the derive macro `Logos` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos + use<'s>, PartialEq, Eq)] [INFO] [stdout] | +++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl CallbackResult<'s, Ident, Token>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/parse/lex.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos, PartialEq, Eq)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/parse/lex.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos, PartialEq, Eq)] [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: this warning originates in the derive macro `Logos` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos + use<'s>, PartialEq, Eq)] [INFO] [stdout] | +++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl CallbackResult<'s, String, Token>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/parse/lex.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos, PartialEq, Eq)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/parse/lex.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos, PartialEq, Eq)] [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: this warning originates in the derive macro `Logos` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos + use<'s>, PartialEq, Eq)] [INFO] [stdout] | +++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl CallbackResult<'s, String, Token>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/parse/lex.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos, PartialEq, Eq)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/parse/lex.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos, PartialEq, Eq)] [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: this warning originates in the derive macro `Logos` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Logos + use<'s>, PartialEq, Eq)] [INFO] [stdout] | +++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sim.rs:749:20 [INFO] [stdout] | [INFO] [stdout] 749 | if let Some(data) = self.device_handler.io_read(addr, ctx.io_effects) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^-------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sim.rs:751:17 [INFO] [stdout] | [INFO] [stdout] 751 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 749 ~ match self.device_handler.io_read(addr, ctx.io_effects) { Some(data) => { [INFO] [stdout] 750 | self.mem[addr].set(data); [INFO] [stdout] 751 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl WordFiller` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/sim/mem.rs:362:39 [INFO] [stdout] | [INFO] [stdout] 362 | pub(super) fn generator(&self) -> impl WordFiller { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/sim/mem.rs:362:29 [INFO] [stdout] | [INFO] [stdout] 362 | pub(super) fn generator(&self) -> impl WordFiller { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 362 | pub(super) fn generator(&self) -> impl WordFiller + use<> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sim/device.rs:165:12 [INFO] [stdout] | [INFO] [stdout] 165 | if let Some(dev_ref) = self.devices.get_mut(dev_id as usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^------------^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sim/device.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 165 ~ match self.devices.get_mut(dev_id as usize) { Some(dev_ref) => { [INFO] [stdout] 166 | std::mem::take(dev_ref); [INFO] [stdout] ... [INFO] [stdout] 173 | } [INFO] [stdout] 174 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sim/device.rs:460:12 [INFO] [stdout] | [INFO] [stdout] 460 | if let Some(mut guard) = resolve_lock(self.try_write()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sim/device.rs:462:9 [INFO] [stdout] | [INFO] [stdout] 462 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 460 ~ match resolve_lock(self.try_write()) { Some(mut guard) => { [INFO] [stdout] 461 | guard.io_reset(); [INFO] [stdout] 462 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sim/device.rs:482:12 [INFO] [stdout] | [INFO] [stdout] 482 | if let Some(mut guard) = resolve_lock(self.try_lock()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^----------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sim/device.rs:484:9 [INFO] [stdout] | [INFO] [stdout] 484 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 482 ~ match resolve_lock(self.try_lock()) { Some(mut guard) => { [INFO] [stdout] 483 | guard.io_reset(); [INFO] [stdout] 484 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sim/device/keyboard.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 106 | if let Some(mut inp) = self.try_input() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^---------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sim/device/keyboard.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 106 ~ match self.try_input() { Some(mut inp) => { [INFO] [stdout] 107 | inp.clear(); [INFO] [stdout] 108 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sim/device/display.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 79 | if let Some(mut out) = self.try_output() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sim/device/display.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 79 ~ match self.try_output() { Some(mut out) => { [INFO] [stdout] 80 | out.clear(); [INFO] [stdout] 81 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl RangeBounds` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/sim/device/timer.rs:99:32 [INFO] [stdout] | [INFO] [stdout] 99 | pub fn get_range(&self) -> impl RangeBounds { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/sim/device/timer.rs:99:22 [INFO] [stdout] | [INFO] [stdout] 99 | pub fn get_range(&self) -> impl RangeBounds { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 99 | pub fn get_range(&self) -> impl RangeBounds + use<> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl Iterator` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/sim/observer.rs:38:43 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn take_mem_changes(&mut self) -> impl Iterator { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/sim/observer.rs:38:29 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn take_mem_changes(&mut self) -> impl Iterator { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 38 | pub fn take_mem_changes(&mut self) -> impl Iterator + use<> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.42s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking lc3-ensemble v0.9.1 (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/sim/mem.rs:332:14 [INFO] [stdout] | [INFO] [stdout] 332 | self.gen() [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 332 | self.r#gen() [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/sim/mem.rs:332:14 [INFO] [stdout] | [INFO] [stdout] 332 | self.gen() [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 332 | self.r#gen() [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lc3-ensemble` (lib test) due to 1 previous error [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `lc3-ensemble` (lib) due to 1 previous error [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "28e7c3114d31a0ee8fee33d72ffd85fbf372d5385c7d75bf9ce8cfc1e2c244f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28e7c3114d31a0ee8fee33d72ffd85fbf372d5385c7d75bf9ce8cfc1e2c244f6", kill_on_drop: false }` [INFO] [stdout] 28e7c3114d31a0ee8fee33d72ffd85fbf372d5385c7d75bf9ce8cfc1e2c244f6