[INFO] fetching crate hydro_deploy 0.10.0... [INFO] checking hydro_deploy-0.10.0 against try#65132f36b923285d5da381c2fbafee6ce899e841 for pr-132712-1 [INFO] extracting crate hydro_deploy 0.10.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate hydro_deploy 0.10.0 on toolchain 65132f36b923285d5da381c2fbafee6ce899e841 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hydro_deploy 0.10.0 [INFO] finished tweaking crates.io crate hydro_deploy 0.10.0 [INFO] tweaked toml for crates.io crate hydro_deploy 0.10.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 189 packages to latest compatible versions [INFO] [stderr] Adding cargo_metadata v0.18.1 (available: v0.19.0) [INFO] [stderr] Adding inferno v0.11.21 (available: v0.12.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e1a2c6d166d6caab50e248a665ebfa8c0dd8299e018c9731f4258002bb5de02a [INFO] running `Command { std: "docker" "start" "-a" "e1a2c6d166d6caab50e248a665ebfa8c0dd8299e018c9731f4258002bb5de02a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e1a2c6d166d6caab50e248a665ebfa8c0dd8299e018c9731f4258002bb5de02a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e1a2c6d166d6caab50e248a665ebfa8c0dd8299e018c9731f4258002bb5de02a", kill_on_drop: false }` [INFO] [stdout] e1a2c6d166d6caab50e248a665ebfa8c0dd8299e018c9731f4258002bb5de02a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 296401a6eb512a4d58d33ae572a0dc99b53f9263e8c5fabc23216b7fd7810640 [INFO] running `Command { std: "docker" "start" "-a" "296401a6eb512a4d58d33ae572a0dc99b53f9263e8c5fabc23216b7fd7810640", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.164 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling rustix v0.38.41 [INFO] [stderr] Checking parking v2.2.1 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling syn v2.0.89 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Compiling serde_json v1.0.133 [INFO] [stderr] Compiling camino v1.1.9 [INFO] [stderr] Checking futures-lite v2.5.0 [INFO] [stderr] Checking clap_lex v0.7.3 [INFO] [stderr] Compiling portable-atomic v1.10.0 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking object v0.36.5 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking clap_builder v4.5.21 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking hashbrown v0.15.1 [INFO] [stderr] Checking bytemuck v1.20.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling anyhow v1.0.93 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Checking rgb v0.8.50 [INFO] [stderr] Checking num-format v0.4.4 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Compiling str_inflector v0.12.0 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking quick-xml v0.26.0 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking str_stack v0.1.0 [INFO] [stderr] Checking unicode-width v0.2.0 [INFO] [stderr] Compiling openssl-sys v0.9.104 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking indexmap v2.6.0 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking memo-map v0.3.3 [INFO] [stderr] Checking shell-escape v0.1.5 [INFO] [stderr] Checking dunce v1.0.5 [INFO] [stderr] Checking nameof v1.2.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking indicatif v0.17.9 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Compiling serde_derive v1.0.215 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Compiling try_match_inner v0.5.2 [INFO] [stderr] Compiling pin-project-internal v1.1.7 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Checking polling v3.7.4 [INFO] [stderr] Checking tempfile v3.14.0 [INFO] [stderr] Checking async-io v2.4.0 [INFO] [stderr] Compiling try_match v0.4.2 [INFO] [stderr] Checking tokio v1.41.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking pin-project v1.1.7 [INFO] [stderr] Checking async-signal v0.2.10 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Compiling buildstructor v0.5.4 [INFO] [stderr] Checking async-process v2.3.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking ssh2 v0.9.4 [INFO] [stderr] Checking clap v4.5.21 [INFO] [stderr] Checking inferno v0.11.21 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking nanoid v0.4.0 [INFO] [stderr] Checking serde v1.0.215 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Checking async-ssh2-lite v0.5.0 [INFO] [stderr] Checking cargo-platform v0.1.8 [INFO] [stderr] Checking hydroflow_deploy_integration v0.10.0 [INFO] [stderr] Checking cargo_metadata v0.18.1 [INFO] [stderr] Checking hydro_deploy v0.10.0 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/hydroflow_crate/ports.rs (1 fix) [INFO] [stderr] Fixed src/ssh.rs (1 fix) [INFO] [stderr] Fixed src/util.rs (3 fixes) [INFO] [stderr] Fixed src/hydroflow_crate/build.rs (1 fix) [INFO] [stderr] Fixed src/hydroflow_crate/service.rs (2 fixes) [INFO] [stderr] Fixed src/terraform.rs (2 fixes) [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/util.rs:58:19 [INFO] [stdout] | [INFO] [stdout] 43 | if let Some(deploy_receivers) = weak_priority_receivers.upgrade() { [INFO] [stdout] | ---------------- --------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | `deploy_receivers` calls a custom destructor [INFO] [stdout] | `deploy_receivers` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let successful_send = match deploy_receivers.take() { Some(r) => { [INFO] [stdout] | ----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | match weak_receivers.upgrade() { Some(receivers) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ --------- [INFO] [stdout] | | | [INFO] [stdout] | | `receivers` calls a custom destructor [INFO] [stdout] | | `receivers` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 59 | let mut receivers = receivers.lock().unwrap(); [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mpsc/chan.rs:225:1 [INFO] [stdout] | [INFO] [stdout] 225 | impl Drop for Tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/oneshot.rs:844:1 [INFO] [stdout] | [INFO] [stdout] 844 | impl Drop for Sender { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `deploy_receivers` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/oneshot.rs:844:1 [INFO] [stdout] | [INFO] [stdout] 844 | impl Drop for Sender { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/oneshot.rs:844:1 [INFO] [stdout] | [INFO] [stdout] 844 | impl Drop for Sender { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `receivers` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mpsc/chan.rs:225:1 [INFO] [stdout] | [INFO] [stdout] 225 | impl Drop for Tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/65132f36b923285d5da381c2fbafee6ce899e841/library/std/src/sync/mutex.rs:546:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.31s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking hydro_deploy v0.10.0 (/tmp/fixit) [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> src/localhost/mod.rs:191:27 [INFO] [stdout] | [INFO] [stdout] 182 | .arg({ [INFO] [stdout] | --- borrow later used by call [INFO] [stdout] ... [INFO] [stdout] 191 | &*shell_escape::unix::escape(inner_command.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | | [INFO] [stdout] | | temporary value is freed at the end of this statement [INFO] [stdout] | creates a temporary value which is freed while still in use [INFO] [stdout] | [INFO] [stdout] = note: consider using a `let` binding to create a longer lived value [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> src/localhost/mod.rs:191:27 [INFO] [stdout] | [INFO] [stdout] 182 | .arg({ [INFO] [stdout] | --- borrow later used by call [INFO] [stdout] ... [INFO] [stdout] 191 | &*shell_escape::unix::escape(inner_command.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | | [INFO] [stdout] | | temporary value is freed at the end of this statement [INFO] [stdout] | creates a temporary value which is freed while still in use [INFO] [stdout] | [INFO] [stdout] = note: consider using a `let` binding to create a longer lived value [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0716`. [INFO] [stdout] [INFO] [stderr] error: could not compile `hydro_deploy` (lib test) due to 1 previous error [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] For more information about this error, try `rustc --explain E0716`. [INFO] [stdout] [INFO] [stderr] error: could not compile `hydro_deploy` (lib) due to 1 previous error [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "296401a6eb512a4d58d33ae572a0dc99b53f9263e8c5fabc23216b7fd7810640", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "296401a6eb512a4d58d33ae572a0dc99b53f9263e8c5fabc23216b7fd7810640", kill_on_drop: false }` [INFO] [stdout] 296401a6eb512a4d58d33ae572a0dc99b53f9263e8c5fabc23216b7fd7810640