[INFO] fetching crate google-cloud-spanner 0.31.1... [INFO] checking google-cloud-spanner-0.31.1 against try#65132f36b923285d5da381c2fbafee6ce899e841 for pr-132712-1 [INFO] extracting crate google-cloud-spanner 0.31.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate google-cloud-spanner 0.31.1 on toolchain 65132f36b923285d5da381c2fbafee6ce899e841 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate google-cloud-spanner 0.31.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate google-cloud-spanner 0.31.1 [INFO] tweaked toml for crates.io crate google-cloud-spanner 0.31.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 267 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.21.7 (available: v0.22.1) [INFO] [stderr] Adding ctor v0.1.26 (available: v0.2.9) [INFO] [stderr] Adding thiserror v1.0.69 (available: v2.0.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 31f7bb01a8ec2006cc89fb8b616c44209c55865cee137ce3becad57d401fc9b6 [INFO] running `Command { std: "docker" "start" "-a" "31f7bb01a8ec2006cc89fb8b616c44209c55865cee137ce3becad57d401fc9b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "31f7bb01a8ec2006cc89fb8b616c44209c55865cee137ce3becad57d401fc9b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "31f7bb01a8ec2006cc89fb8b616c44209c55865cee137ce3becad57d401fc9b6", kill_on_drop: false }` [INFO] [stdout] 31f7bb01a8ec2006cc89fb8b616c44209c55865cee137ce3becad57d401fc9b6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2ea4f736e8c13a4cc3654e17e13483d60cb9805c32e76cf7c565b79674f111d6 [INFO] running `Command { std: "docker" "start" "-a" "2ea4f736e8c13a4cc3654e17e13483d60cb9805c32e76cf7c565b79674f111d6", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking hashbrown v0.15.1 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling anyhow v1.0.93 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling openssl v0.10.68 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling pin-project-internal v1.1.7 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling rustls v0.23.18 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking indexmap v2.6.0 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking tokio v1.41.1 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Compiling openssl-sys v0.9.104 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking google-cloud-token v0.1.2 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Compiling google-cloud-googleapis v0.15.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking flate2 v1.0.35 [INFO] [stderr] Compiling libm v0.2.11 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking pem v3.0.4 [INFO] [stderr] Compiling bigdecimal v0.4.6 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking pin-project v1.1.7 [INFO] [stderr] Checking sdd v3.0.4 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling serial_test_derive v3.2.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking scc v2.2.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling prost-derive v0.13.3 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking tower v0.5.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking axum-core v0.4.5 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking serial_test v3.2.0 [INFO] [stderr] Checking simple_asn1 v0.6.2 [INFO] [stderr] Checking prost v0.13.3 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking prost-types v0.13.3 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Checking tokio-retry2 v0.5.6 [INFO] [stderr] Compiling ctor v0.1.26 [INFO] [stderr] Checking axum v0.7.9 [INFO] [stderr] Checking h2 v0.4.7 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Checking jsonwebtoken v9.3.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking hyper v1.5.1 [INFO] [stderr] Checking hyper-util v0.1.10 [INFO] [stderr] Checking hyper-timeout v0.5.2 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.9 [INFO] [stderr] Checking tonic v0.12.3 [INFO] [stderr] Checking google-cloud-metadata v0.5.0 [INFO] [stderr] Checking google-cloud-auth v0.17.1 [INFO] [stderr] Checking google-cloud-gax v0.19.1 [INFO] [stderr] Checking google-cloud-longrunning v0.20.1 [INFO] [stderr] Checking google-cloud-spanner v0.31.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/session.rs (4 fixes) [INFO] [stderr] Fixed src/transaction.rs (2 fixes) [INFO] [stdout] warning: `impl reader::Reader` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/transaction.rs:183:33 [INFO] [stdout] | [INFO] [stdout] 183 | ) -> Result, Status> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/transaction.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 179 | &mut self, [INFO] [stdout] | ^ [INFO] [stdout] 180 | table: &str, [INFO] [stdout] | ^ [INFO] [stdout] 181 | columns: &[&str], [INFO] [stdout] | ^ ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] note: you could use a `use<...>` bound to explicitly specify captures, but argument-position `impl Trait`s are not nameable [INFO] [stdout] --> src/transaction.rs:182:18 [INFO] [stdout] | [INFO] [stdout] 182 | key_set: impl Into, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 178 ~ pub async fn read>( [INFO] [stdout] 179 | &mut self, [INFO] [stdout] 180 | table: &str, [INFO] [stdout] 181 | columns: &[&str], [INFO] [stdout] 182 ~ key_set: T, [INFO] [stdout] 183 ~ ) -> Result>, Status> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl reader::Reader` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/transaction.rs:195:33 [INFO] [stdout] | [INFO] [stdout] 195 | ) -> Result, Status> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/transaction.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | &mut self, [INFO] [stdout] | ^ [INFO] [stdout] 191 | table: &str, [INFO] [stdout] | ^ [INFO] [stdout] 192 | columns: &[&str], [INFO] [stdout] | ^ ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] note: you could use a `use<...>` bound to explicitly specify captures, but argument-position `impl Trait`s are not nameable [INFO] [stdout] --> src/transaction.rs:193:18 [INFO] [stdout] | [INFO] [stdout] 193 | key_set: impl Into, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 189 ~ pub async fn read_with_option>( [INFO] [stdout] 190 | &mut self, [INFO] [stdout] 191 | table: &str, [INFO] [stdout] 192 | columns: &[&str], [INFO] [stdout] 193 ~ key_set: T, [INFO] [stdout] 194 | options: ReadOptions, [INFO] [stdout] 195 ~ ) -> Result>, Status> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/client.rs:342:22 [INFO] [stdout] | [INFO] [stdout] 333 | let mut tx = [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | `tx` calls a custom destructor [INFO] [stdout] | `tx` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 342 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 343 | .map_err(|e| (Error::GRPC(e), tx.take_session())) [INFO] [stdout] 344 | }, [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `tx` invokes this custom destructor [INFO] [stdout] --> src/session.rs:90:1 [INFO] [stdout] | [INFO] [stdout] 90 | / impl Drop for ManagedSession { [INFO] [stdout] 91 | | fn drop(&mut self) { [INFO] [stdout] 92 | | let session = self.session.take().unwrap(); [INFO] [stdout] 93 | | self.session_pool.recycle(session); [INFO] [stdout] 94 | | } [INFO] [stdout] 95 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/client.rs:393:10 [INFO] [stdout] | [INFO] [stdout] 378 | let mut session = self.get_session().await?; [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | `session` calls a custom destructor [INFO] [stdout] | `session` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 393 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 394 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/runtime/time/entry.rs:652:1 [INFO] [stdout] | [INFO] [stdout] 652 | impl Drop for TimerEntry { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `session` invokes this custom destructor [INFO] [stdout] --> src/session.rs:90:1 [INFO] [stdout] | [INFO] [stdout] 90 | / impl Drop for ManagedSession { [INFO] [stdout] 91 | | fn drop(&mut self) { [INFO] [stdout] 92 | | let session = self.session.take().unwrap(); [INFO] [stdout] 93 | | self.session_pool.recycle(session); [INFO] [stdout] 94 | | } [INFO] [stdout] 95 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/client.rs:529:53 [INFO] [stdout] | [INFO] [stdout] 527 | let mut tx = self.create_read_write_transaction::(session, bo.clone()).await?; [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | `tx` calls a custom destructor [INFO] [stdout] | `tx` will be dropped later as of Edition 2024 [INFO] [stdout] 528 | let result = f(&mut tx).await; [INFO] [stdout] 529 | tx.finish(result, Some(co.clone())).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 530 | }, [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `tx` invokes this custom destructor [INFO] [stdout] --> src/session.rs:90:1 [INFO] [stdout] | [INFO] [stdout] 90 | / impl Drop for ManagedSession { [INFO] [stdout] 91 | | fn drop(&mut self) { [INFO] [stdout] 92 | | let session = self.session.take().unwrap(); [INFO] [stdout] 93 | | self.session_pool.recycle(session); [INFO] [stdout] 94 | | } [INFO] [stdout] 95 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/client.rs:608:53 [INFO] [stdout] | [INFO] [stdout] 606 | let mut tx = self.create_read_write_transaction::(session, bo.clone()).await?; [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | `tx` calls a custom destructor [INFO] [stdout] | `tx` will be dropped later as of Edition 2024 [INFO] [stdout] 607 | let result = f(&mut tx); [INFO] [stdout] 608 | tx.finish(result, Some(co.clone())).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 609 | }, [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `tx` invokes this custom destructor [INFO] [stdout] --> src/session.rs:90:1 [INFO] [stdout] | [INFO] [stdout] 90 | / impl Drop for ManagedSession { [INFO] [stdout] 91 | | fn drop(&mut self) { [INFO] [stdout] 92 | | let session = self.session.take().unwrap(); [INFO] [stdout] 93 | | self.session_pool.recycle(session); [INFO] [stdout] 94 | | } [INFO] [stdout] 95 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/session.rs:265:27 [INFO] [stdout] | [INFO] [stdout] 260 | let (on_session_acquired, session_count) = { [INFO] [stdout] | ________________________________________________________- [INFO] [stdout] 261 | | let mut sessions = self.inner.write(); [INFO] [stdout] | | ------------ [INFO] [stdout] | | | [INFO] [stdout] | | `sessions` calls a custom destructor [INFO] [stdout] | | `sessions` will be dropped later as of Edition 2024 [INFO] [stdout] 262 | | [INFO] [stdout] 263 | | // Prioritize waiters over new acquirers. [INFO] [stdout] 264 | | if sessions.waiters.is_empty() { [INFO] [stdout] 265 | | match sessions.take() { Some(mut s) => { [INFO] [stdout] | | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#5` [INFO] [stdout] | | up until Edition 2021 `#5` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 268 | | } _ => {}} [INFO] [stdout] | | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... | [INFO] [stdout] 271 | | let (sender, receiver) = oneshot::channel(); [INFO] [stdout] | | ------------------ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 274 | | (receiver, session_count) [INFO] [stdout] 275 | | }; [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |_____________this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 282 | match timeout(self.config.session_get_timeout, on_session_acquired).await { [INFO] [stdout] | ------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] 283 | Ok(Ok(())) => { [INFO] [stdout] 284 | let mut sessions = self.inner.write(); [INFO] [stdout] | ------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] 285 | match sessions.take() { Some(mut s) => { [INFO] [stdout] | --------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | `#4` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#5` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#5` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#5` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/semaphore.rs:1196:1 [INFO] [stdout] | [INFO] [stdout] 1196 | impl Drop for OwnedSemaphorePermit { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#5` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mpsc/chan.rs:225:1 [INFO] [stdout] | [INFO] [stdout] 225 | impl Drop for Tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `sessions` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/lock_api-0.4.12/src/rwlock.rs:1709:1 [INFO] [stdout] | [INFO] [stdout] 1709 | impl<'a, R: RawRwLock + 'a, T: ?Sized + 'a> Drop for RwLockWriteGuard<'a, R, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `__awaitee` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/runtime/time/entry.rs:652:1 [INFO] [stdout] | [INFO] [stdout] 652 | impl Drop for TimerEntry { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `__awaitee` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/oneshot.rs:1072:1 [INFO] [stdout] | [INFO] [stdout] 1072 | impl Drop for Receiver { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/lock_api-0.4.12/src/rwlock.rs:1709:1 [INFO] [stdout] | [INFO] [stdout] 1709 | impl<'a, R: RawRwLock + 'a, T: ?Sized + 'a> Drop for RwLockWriteGuard<'a, R, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#4` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/semaphore.rs:1196:1 [INFO] [stdout] | [INFO] [stdout] 1196 | impl Drop for OwnedSemaphorePermit { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mpsc/chan.rs:225:1 [INFO] [stdout] | [INFO] [stdout] 225 | impl Drop for Tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/session.rs:560:19 [INFO] [stdout] | [INFO] [stdout] 559 | let mut locked = sessions.inner.write(); [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | `locked` calls a custom destructor [INFO] [stdout] | `locked` will be dropped later as of Edition 2024 [INFO] [stdout] 560 | match locked.take() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 576 | }; [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/semaphore.rs:1196:1 [INFO] [stdout] | [INFO] [stdout] 1196 | impl Drop for OwnedSemaphorePermit { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.41.1/src/sync/mpsc/chan.rs:225:1 [INFO] [stdout] | [INFO] [stdout] 225 | impl Drop for Tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `locked` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/lock_api-0.4.12/src/rwlock.rs:1709:1 [INFO] [stdout] | [INFO] [stdout] 1709 | impl<'a, R: RawRwLock + 'a, T: ?Sized + 'a> Drop for RwLockWriteGuard<'a, R, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/transaction.rs:245:23 [INFO] [stdout] | [INFO] [stdout] 241 | let mut reader = self [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | `reader` calls a custom destructor [INFO] [stdout] | `reader` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | reader.next().await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 246 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `reader` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes.rs:590:1 [INFO] [stdout] | [INFO] [stdout] 590 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `reader` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.8.0/src/bytes_mut.rs:1123:1 [INFO] [stdout] | [INFO] [stdout] 1123 | impl Drop for BytesMut { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `reader` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed src/apiv1/mod.rs (1 fix) [INFO] [stderr] Migrating tests/transaction_ro_test.rs from 2021 edition to 2024 [INFO] [stdout] warning: `impl reader::Reader` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/transaction.rs:183:33 [INFO] [stdout] | [INFO] [stdout] 183 | ) -> Result, Status> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/transaction.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 179 | &mut self, [INFO] [stdout] | ^ [INFO] [stdout] 180 | table: &str, [INFO] [stdout] | ^ [INFO] [stdout] 181 | columns: &[&str], [INFO] [stdout] | ^ ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] note: you could use a `use<...>` bound to explicitly specify captures, but argument-position `impl Trait`s are not nameable [INFO] [stdout] --> src/transaction.rs:182:18 [INFO] [stdout] | [INFO] [stdout] 182 | key_set: impl Into, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 178 ~ pub async fn read>( [INFO] [stdout] 179 | &mut self, [INFO] [stdout] 180 | table: &str, [INFO] [stdout] 181 | columns: &[&str], [INFO] [stdout] 182 ~ key_set: T, [INFO] [stdout] 183 ~ ) -> Result>, Status> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl reader::Reader` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/transaction.rs:195:33 [INFO] [stdout] | [INFO] [stdout] 195 | ) -> Result, Status> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/transaction.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | &mut self, [INFO] [stdout] | ^ [INFO] [stdout] 191 | table: &str, [INFO] [stdout] | ^ [INFO] [stdout] 192 | columns: &[&str], [INFO] [stdout] | ^ ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] note: you could use a `use<...>` bound to explicitly specify captures, but argument-position `impl Trait`s are not nameable [INFO] [stdout] --> src/transaction.rs:193:18 [INFO] [stdout] | [INFO] [stdout] 193 | key_set: impl Into, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 189 ~ pub async fn read_with_option>( [INFO] [stdout] 190 | &mut self, [INFO] [stdout] 191 | table: &str, [INFO] [stdout] 192 | columns: &[&str], [INFO] [stdout] 193 ~ key_set: T, [INFO] [stdout] 194 | options: ReadOptions, [INFO] [stdout] 195 ~ ) -> Result>, Status> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed tests/transaction_ro_test.rs (1 fix) [INFO] [stderr] Migrating tests/common.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/transaction_rw_test.rs from 2021 edition to 2024 [INFO] [stderr] Fixed tests/transaction_rw_test.rs (1 fix) [INFO] [stderr] Migrating tests/client_test.rs from 2021 edition to 2024 [INFO] [stderr] Fixed tests/client_test.rs (2 fixes) [INFO] [stderr] Migrating tests/change_stream_test.rs from 2021 edition to 2024 [INFO] [stderr] Fixed tests/change_stream_test.rs (1 fix) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 29.93s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking google-cloud-spanner v0.31.1 (/tmp/fixit) [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> tests/transaction_ro_test.rs:26:41 [INFO] [stdout] | [INFO] [stdout] 26 | let reader = match tx.read("User", &user_columns(), Key::new(&user_id)).await { [INFO] [stdout] | ^^^^^^^^^^^^^^ creates a temporary value which is freed while still in use [INFO] [stdout] ... [INFO] [stdout] 29 | }; [INFO] [stdout] | - temporary value is freed at the end of this statement [INFO] [stdout] 30 | let mut rows = all_rows(reader).await.unwrap(); [INFO] [stdout] | ------ borrow later used here [INFO] [stdout] | [INFO] [stdout] = note: consider using a `let` binding to create a longer lived value [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> tests/transaction_ro_test.rs:26:24 [INFO] [stdout] | [INFO] [stdout] 26 | let reader = match tx.read("User", &user_columns(), Key::new(&user_id)).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: if you can modify this crate, add a precise capturing bound to avoid overcapturing: `+ use` [INFO] [stdout] --> /tmp/fixit/src/transaction.rs:183:33 [INFO] [stdout] | [INFO] [stdout] 183 | ) -> Result, Status> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> tests/client_test.rs:99:24 [INFO] [stdout] | [INFO] [stdout] 99 | .read("User", &user_columns(), Key::new(&"user_client_1x")) [INFO] [stdout] | ^^^^^^^^^^^^^^ creates a temporary value which is freed while still in use [INFO] [stdout] 100 | .await [INFO] [stdout] 101 | .unwrap(); [INFO] [stdout] | - temporary value is freed at the end of this statement [INFO] [stdout] 102 | let row = all_rows(record).await.unwrap().pop().unwrap(); [INFO] [stdout] | ------ borrow later used here [INFO] [stdout] | [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> tests/client_test.rs:98:18 [INFO] [stdout] | [INFO] [stdout] 98 | let record = ro [INFO] [stdout] | __________________^ [INFO] [stdout] 99 | | .read("User", &user_columns(), Key::new(&"user_client_1x")) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] help: if you can modify this crate, add a precise capturing bound to avoid overcapturing: `+ use` [INFO] [stdout] --> /tmp/fixit/src/transaction.rs:183:33 [INFO] [stdout] | [INFO] [stdout] 183 | ) -> Result, Status> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] help: consider using a `let` binding to create a longer lived value [INFO] [stdout] | [INFO] [stdout] 98 ~ let binding = user_columns(); [INFO] [stdout] 99 ~ let record = ro [INFO] [stdout] 100 ~ .read("User", &binding, Key::new(&"user_client_1x")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> tests/client_test.rs:106:24 [INFO] [stdout] | [INFO] [stdout] 106 | .read("User", &user_columns(), Key::new(&"user_client_2x")) [INFO] [stdout] | ^^^^^^^^^^^^^^ creates a temporary value which is freed while still in use [INFO] [stdout] 107 | .await [INFO] [stdout] 108 | .unwrap(); [INFO] [stdout] | - temporary value is freed at the end of this statement [INFO] [stdout] 109 | let row = all_rows(record).await.unwrap().pop().unwrap(); [INFO] [stdout] | ------ borrow later used here [INFO] [stdout] | [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> tests/client_test.rs:105:18 [INFO] [stdout] | [INFO] [stdout] 105 | let record = ro [INFO] [stdout] | __________________^ [INFO] [stdout] 106 | | .read("User", &user_columns(), Key::new(&"user_client_2x")) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] help: if you can modify this crate, add a precise capturing bound to avoid overcapturing: `+ use` [INFO] [stdout] --> /tmp/fixit/src/transaction.rs:183:33 [INFO] [stdout] | [INFO] [stdout] 183 | ) -> Result, Status> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] help: consider using a `let` binding to create a longer lived value [INFO] [stdout] | [INFO] [stdout] 105 ~ let binding = user_columns(); [INFO] [stdout] 106 ~ let record = ro [INFO] [stdout] 107 ~ .read("User", &binding, Key::new(&"user_client_2x")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> tests/client_test.rs:136:39 [INFO] [stdout] | [INFO] [stdout] 136 | let record = ro.read("User", &user_columns(), Key::new(&x)).await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ - temporary value is freed at the end of this statement [INFO] [stdout] | | [INFO] [stdout] | creates a temporary value which is freed while still in use [INFO] [stdout] 137 | let row: Row = all_rows(record).await.unwrap().pop().unwrap(); [INFO] [stdout] | ------ borrow later used here [INFO] [stdout] | [INFO] [stdout] = note: consider using a `let` binding to create a longer lived value [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> tests/client_test.rs:136:22 [INFO] [stdout] | [INFO] [stdout] 136 | let record = ro.read("User", &user_columns(), Key::new(&x)).await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: if you can modify this crate, add a precise capturing bound to avoid overcapturing: `+ use` [INFO] [stdout] --> /tmp/fixit/src/transaction.rs:183:33 [INFO] [stdout] | [INFO] [stdout] 183 | ) -> Result, Status> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> tests/client_test.rs:157:39 [INFO] [stdout] | [INFO] [stdout] 157 | let record = ro.read("User", &user_columns(), Key::new(&x)).await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ - temporary value is freed at the end of this statement [INFO] [stdout] | | [INFO] [stdout] | creates a temporary value which is freed while still in use [INFO] [stdout] 158 | let row = all_rows(record).await.unwrap().pop().unwrap(); [INFO] [stdout] | ------ borrow later used here [INFO] [stdout] | [INFO] [stdout] = note: consider using a `let` binding to create a longer lived value [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> tests/client_test.rs:157:22 [INFO] [stdout] | [INFO] [stdout] 157 | let record = ro.read("User", &user_columns(), Key::new(&x)).await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: if you can modify this crate, add a precise capturing bound to avoid overcapturing: `+ use` [INFO] [stdout] --> /tmp/fixit/src/transaction.rs:183:33 [INFO] [stdout] | [INFO] [stdout] 183 | ) -> Result, Status> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> tests/transaction_rw_test.rs:100:35 [INFO] [stdout] | [INFO] [stdout] 100 | let reader = tx.read("User", &user_columns(), Key::new(&past_user)).await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ - temporary value is freed at the end of this statement [INFO] [stdout] | | [INFO] [stdout] | creates a temporary value which is freed while still in use [INFO] [stdout] 101 | let row: Row = all_rows(reader).await.unwrap().pop().unwrap(); [INFO] [stdout] | ------ borrow later used here [INFO] [stdout] | [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> tests/transaction_rw_test.rs:100:18 [INFO] [stdout] | [INFO] [stdout] 100 | let reader = tx.read("User", &user_columns(), Key::new(&past_user)).await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: if you can modify this crate, add a precise capturing bound to avoid overcapturing: `+ use` [INFO] [stdout] --> /tmp/fixit/src/transaction.rs:183:33 [INFO] [stdout] | [INFO] [stdout] 183 | ) -> Result, Status> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] help: consider using a `let` binding to create a longer lived value [INFO] [stdout] | [INFO] [stdout] 100 ~ let binding = user_columns(); [INFO] [stdout] 101 ~ let reader = tx.read("User", &binding, Key::new(&past_user)).await.unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0716`. [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0716`. [INFO] [stdout] [INFO] [stderr] error: could not compile `google-cloud-spanner` (test "transaction_rw_test") due to 1 previous error [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `google-cloud-spanner` (test "client_test") due to 4 previous errors [INFO] [stdout] For more information about this error, try `rustc --explain E0716`. [INFO] [stdout] [INFO] [stderr] error: could not compile `google-cloud-spanner` (test "transaction_ro_test") due to 1 previous error [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "2ea4f736e8c13a4cc3654e17e13483d60cb9805c32e76cf7c565b79674f111d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2ea4f736e8c13a4cc3654e17e13483d60cb9805c32e76cf7c565b79674f111d6", kill_on_drop: false }` [INFO] [stdout] 2ea4f736e8c13a4cc3654e17e13483d60cb9805c32e76cf7c565b79674f111d6