[INFO] fetching crate finality-grandpa 0.16.2... [INFO] checking finality-grandpa-0.16.2 against try#65132f36b923285d5da381c2fbafee6ce899e841 for pr-132712-1 [INFO] extracting crate finality-grandpa 0.16.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate finality-grandpa 0.16.2 on toolchain 65132f36b923285d5da381c2fbafee6ce899e841 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate finality-grandpa 0.16.2 [INFO] finished tweaking crates.io crate finality-grandpa 0.16.2 [INFO] tweaked toml for crates.io crate finality-grandpa 0.16.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 78 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3bb3cdacb315affb0cbcb336630601151e9101025a057fa11a13272df7aa8092 [INFO] running `Command { std: "docker" "start" "-a" "3bb3cdacb315affb0cbcb336630601151e9101025a057fa11a13272df7aa8092", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3bb3cdacb315affb0cbcb336630601151e9101025a057fa11a13272df7aa8092", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3bb3cdacb315affb0cbcb336630601151e9101025a057fa11a13272df7aa8092", kill_on_drop: false }` [INFO] [stdout] 3bb3cdacb315affb0cbcb336630601151e9101025a057fa11a13272df7aa8092 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ae8e6335d15a45b06bf0f2e067079c243bf38b0fc13bb173d71d3a352cca712b [INFO] running `Command { std: "docker" "start" "-a" "ae8e6335d15a45b06bf0f2e067079c243bf38b0fc13bb173d71d3a352cca712b", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Compiling serde v1.0.215 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Compiling parity-scale-codec v3.7.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling impl-trait-for-tuples v0.2.3 [INFO] [stderr] Compiling parity-scale-codec-derive v3.7.0 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Checking byte-slice-cast v1.2.2 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling scale-info-derive v2.11.6 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking scale-info v2.11.6 [INFO] [stderr] Checking finality-grandpa v0.16.2 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/voter/voting_round.rs (8 fixes) [INFO] [stderr] Fixed src/vote_graph.rs (6 fixes) [INFO] [stderr] Fixed src/voter/mod.rs (3 fixes) [INFO] [stderr] Fixed src/round.rs (5 fixes) [INFO] [stderr] Fixed src/voter/past_rounds.rs (3 fixes) [INFO] [stdout] warning: trait method `into_future` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/voter/mod.rs:1340:5 [INFO] [stdout] | [INFO] [stdout] 1340 | / round_stream [INFO] [stdout] 1341 | | .into_future() [INFO] [stdout] | |__________________________________^ help: disambiguate the associated function: `StreamExt::into_future(round_stream)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn rust-2024-prelude-collisions` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `finality_grandpa` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/voter/mod.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `StreamExt` [INFO] [stderr] --> src/voter/mod.rs:1340:5 [INFO] [stderr] | [INFO] [stderr] 1340 | StreamExt::into_future(round_stream) [INFO] [stderr] | ^^^^^^^^^ use of undeclared type `StreamExt` [INFO] [stderr] | [INFO] [stderr] help: a trait with a similar name exists [INFO] [stderr] | [INFO] [stderr] 1340 | Stream::into_future(round_stream) [INFO] [stderr] | ~~~~~~ [INFO] [stderr] help: consider importing one of these traits [INFO] [stderr] | [INFO] [stderr] 1080 + use crate::voter::stream::StreamExt; [INFO] [stderr] | [INFO] [stderr] 1080 + use futures::StreamExt; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `StreamExt` [INFO] [stderr] --> src/voter/mod.rs:1378:4 [INFO] [stderr] | [INFO] [stderr] 1378 | StreamExt::into_future(commits_stream).then(|(_, stream)| { [INFO] [stderr] | ^^^^^^^^^ use of undeclared type `StreamExt` [INFO] [stderr] | [INFO] [stderr] help: a trait with a similar name exists [INFO] [stderr] | [INFO] [stderr] 1378 | Stream::into_future(commits_stream).then(|(_, stream)| { [INFO] [stderr] | ~~~~~~ [INFO] [stderr] help: consider importing one of these traits [INFO] [stderr] | [INFO] [stderr] 1080 + use crate::voter::stream::StreamExt; [INFO] [stderr] | [INFO] [stderr] 1080 + use futures::StreamExt; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `StreamExt` [INFO] [stderr] --> src/voter/mod.rs:1450:15 [INFO] [stderr] | [INFO] [stderr] 1450 | .run_until(StreamExt::into_future(env.finalized_stream()).map(move |(msg, _)| msg.unwrap().2)); [INFO] [stderr] | ^^^^^^^^^ use of undeclared type `StreamExt` [INFO] [stderr] | [INFO] [stderr] help: a trait with a similar name exists [INFO] [stderr] | [INFO] [stderr] 1450 | .run_until(Stream::into_future(env.finalized_stream()).map(move |(msg, _)| msg.unwrap().2)); [INFO] [stderr] | ~~~~~~ [INFO] [stderr] help: consider importing one of these traits [INFO] [stderr] | [INFO] [stderr] 1080 + use crate::voter::stream::StreamExt; [INFO] [stderr] | [INFO] [stderr] 1080 + use futures::StreamExt; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `StreamExt` [INFO] [stderr] --> src/voter/mod.rs:1532:19 [INFO] [stderr] | [INFO] [stderr] 1532 | let finalized = StreamExt::into_future(env.finalized_stream().take(1)); [INFO] [stderr] | ^^^^^^^^^ use of undeclared type `StreamExt` [INFO] [stderr] | [INFO] [stderr] help: a trait with a similar name exists [INFO] [stderr] | [INFO] [stderr] 1532 | let finalized = Stream::into_future(env.finalized_stream().take(1)); [INFO] [stderr] | ~~~~~~ [INFO] [stderr] help: consider importing one of these traits [INFO] [stderr] | [INFO] [stderr] 1080 + use crate::voter::stream::StreamExt; [INFO] [stderr] | [INFO] [stderr] 1080 + use futures::StreamExt; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `StreamExt` [INFO] [stderr] --> src/voter/mod.rs:1688:4 [INFO] [stderr] | [INFO] [stderr] 1688 | StreamExt::into_future(round_stream [INFO] [stderr] | ^^^^^^^^^ use of undeclared type `StreamExt` [INFO] [stderr] | [INFO] [stderr] help: a trait with a similar name exists [INFO] [stderr] | [INFO] [stderr] 1688 | Stream::into_future(round_stream [INFO] [stderr] | ~~~~~~ [INFO] [stderr] help: consider importing one of these traits [INFO] [stderr] | [INFO] [stderr] 1080 + use crate::voter::stream::StreamExt; [INFO] [stderr] | [INFO] [stderr] 1080 + use futures::StreamExt; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0433`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: trait method `into_future` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/voter/mod.rs:1379:4 [INFO] [stdout] | [INFO] [stdout] 1379 | commits_stream.into_future().then(|(_, stream)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `StreamExt::into_future(commits_stream)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `into_future` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/voter/mod.rs:1451:15 [INFO] [stdout] | [INFO] [stdout] 1451 | .run_until(env.finalized_stream().into_future().map(move |(msg, _)| msg.unwrap().2)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `StreamExt::into_future(env.finalized_stream())` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `into_future` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/voter/mod.rs:1533:19 [INFO] [stdout] | [INFO] [stdout] 1533 | let finalized = env.finalized_stream().take(1).into_future(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `StreamExt::into_future(env.finalized_stream().take(1))` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `into_future` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/voter/mod.rs:1689:4 [INFO] [stdout] | [INFO] [stdout] 1689 | / round_stream [INFO] [stdout] 1690 | | .skip_while(move |v| { [INFO] [stdout] 1691 | | let v = v.as_ref().unwrap(); [INFO] [stdout] 1692 | | if let Message::Prevote(_) = v.message { [INFO] [stdout] ... | [INFO] [stdout] 1697 | | }) [INFO] [stdout] 1698 | | .into_future() [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: disambiguate the associated function [INFO] [stdout] | [INFO] [stdout] 1689 ~ StreamExt::into_future(round_stream [INFO] [stdout] 1690 ~ .skip_while(move |v| { [INFO] [stdout] 1691 ~ let v = v.as_ref().unwrap(); [INFO] [stdout] 1692 ~ if let Message::Prevote(_) = v.message { [INFO] [stdout] 1693 ~ future::ready(v.id != local_id) [INFO] [stdout] 1694 ~ } else { [INFO] [stdout] 1695 ~ future::ready(true) [INFO] [stdout] 1696 ~ } [INFO] [stdout] 1697 ~ })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter_set.rs:203:8 [INFO] [stdout] | [INFO] [stdout] 203 | if let Some(set) = VoterSet::new(ids.into_iter().zip(weights)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter_set.rs:205:5 [INFO] [stdout] | [INFO] [stdout] 205 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 203 ~ match VoterSet::new(ids.into_iter().zip(weights)) { Some(set) => { [INFO] [stdout] 204 | break set [INFO] [stdout] 205 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures::Stream>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/testing.rs:383:9 [INFO] [stdout] | [INFO] [stdout] 383 | ) -> (impl Stream>, impl Sink) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/testing.rs:381:4 [INFO] [stdout] | [INFO] [stdout] 381 | &mut self, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 383 | ) -> (impl Stream> + use, impl Sink) { [INFO] [stdout] | ++++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures::Sink` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/testing.rs:383:47 [INFO] [stdout] | [INFO] [stdout] 383 | ) -> (impl Stream>, impl Sink) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/testing.rs:381:4 [INFO] [stdout] | [INFO] [stdout] 381 | &mut self, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 383 | ) -> (impl Stream>, impl Sink + use) { [INFO] [stdout] | ++++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures::Stream, Error>>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/testing.rs:446:4 [INFO] [stdout] | [INFO] [stdout] 446 | impl Stream, Error>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/testing.rs:442:4 [INFO] [stdout] | [INFO] [stdout] 442 | &self, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 446 | impl Stream, Error>> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures::Sink, Error = Error>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/testing.rs:447:4 [INFO] [stdout] | [INFO] [stdout] 447 | impl Sink, Error = Error>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/testing.rs:442:4 [INFO] [stdout] | [INFO] [stdout] 442 | &self, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 447 | impl Sink, Error = Error> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures::Stream, Error>>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/testing.rs:463:4 [INFO] [stdout] | [INFO] [stdout] 463 | impl Stream, Error>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/testing.rs:461:4 [INFO] [stdout] | [INFO] [stdout] 461 | &self, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 463 | impl Stream, Error>> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures::Sink, Error = Error>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/testing.rs:464:4 [INFO] [stdout] | [INFO] [stdout] 464 | impl Sink, Error = Error>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/testing.rs:461:4 [INFO] [stdout] | [INFO] [stdout] 461 | &self, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 464 | impl Sink, Error = Error> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.48s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking finality-grandpa v0.16.2 (/tmp/fixit) [INFO] [stdout] error[E0597]: `rounds` does not live long enough [INFO] [stdout] --> src/testing.rs:450:4 [INFO] [stdout] | [INFO] [stdout] 442 | &self, [INFO] [stdout] | - let's call the lifetime of this reference `'1` [INFO] [stdout] ... [INFO] [stdout] 449 | let mut rounds = self.rounds.lock(); [INFO] [stdout] | ---------- binding `rounds` declared here [INFO] [stdout] 450 | rounds [INFO] [stdout] | -^^^^^ [INFO] [stdout] | | [INFO] [stdout] | _____________borrowed value does not live long enough [INFO] [stdout] | | [INFO] [stdout] 451 | | .entry(round_number) [INFO] [stdout] 452 | | .or_insert_with(RoundNetwork::new) [INFO] [stdout] 453 | | .add_node(move |message| SignedMessage { [INFO] [stdout] ... | [INFO] [stdout] 456 | | id: node_id, [INFO] [stdout] 457 | | }) [INFO] [stdout] | |__________________- argument requires that `rounds` is borrowed for `'1` [INFO] [stdout] 458 | } [INFO] [stdout] | - `rounds` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `global_messages` does not live long enough [INFO] [stdout] --> src/testing.rs:467:4 [INFO] [stdout] | [INFO] [stdout] 461 | &self, [INFO] [stdout] | - let's call the lifetime of this reference `'1` [INFO] [stdout] ... [INFO] [stdout] 466 | let mut global_messages = self.global_messages.lock(); [INFO] [stdout] | ------------------- binding `global_messages` declared here [INFO] [stdout] 467 | global_messages.add_node(|message| match message { [INFO] [stdout] | -^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | _____________borrowed value does not live long enough [INFO] [stdout] | | [INFO] [stdout] 468 | | CommunicationOut::Commit(r, commit) => [INFO] [stdout] 469 | | CommunicationIn::Commit(r, commit.into(), Callback::Blank), [INFO] [stdout] 470 | | }) [INFO] [stdout] | |______________- argument requires that `global_messages` is borrowed for `'1` [INFO] [stdout] 471 | } [INFO] [stdout] | - `global_messages` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1101:22 [INFO] [stdout] | [INFO] [stdout] 1099 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1100 | [INFO] [stdout] 1101 | let global_comms = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1132 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] | [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> src/voter/mod.rs:1101:22 [INFO] [stdout] | [INFO] [stdout] 1101 | let global_comms = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] --> src/testing.rs:463:88 [INFO] [stdout] | [INFO] [stdout] 463 | impl Stream, Error>> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0505]: cannot move out of `network` because it is borrowed [INFO] [stdout] --> src/voter/mod.rs:1102:39 [INFO] [stdout] | [INFO] [stdout] 1099 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1100 | [INFO] [stdout] 1101 | let global_comms = network.make_global_comms(); [INFO] [stdout] | --------------------------- [INFO] [stdout] | | [INFO] [stdout] | borrow of `network` occurs here [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] 1102 | let env = Arc::new(Environment::new(network, local_id)); [INFO] [stdout] | ^^^^^^^ move out of `network` occurs here [INFO] [stdout] | [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> src/voter/mod.rs:1101:22 [INFO] [stdout] | [INFO] [stdout] 1101 | let global_comms = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] --> src/testing.rs:463:88 [INFO] [stdout] | [INFO] [stdout] 463 | impl Stream, Error>> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] help: consider cloning the value if the performance cost is acceptable [INFO] [stdout] | [INFO] [stdout] 1101 | let global_comms = network.clone().make_global_comms(); [INFO] [stdout] | ++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1147:41 [INFO] [stdout] | [INFO] [stdout] 1139 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] ... [INFO] [stdout] 1144 | .map(|i| { [INFO] [stdout] | --- value captured here [INFO] [stdout] ... [INFO] [stdout] 1147 | let env = Arc::new(Environment::new(network.clone(), local_id)); [INFO] [stdout] | ^^^^^^^ borrowed value does not live long enough [INFO] [stdout] ... [INFO] [stdout] 1158 | network.make_global_comms(), [INFO] [stdout] | --------------------------- argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1177 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1193:41 [INFO] [stdout] | [INFO] [stdout] 1185 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] ... [INFO] [stdout] 1190 | .map(|i| { [INFO] [stdout] | --- value captured here [INFO] [stdout] ... [INFO] [stdout] 1193 | let env = Arc::new(Environment::new(network.clone(), local_id)); [INFO] [stdout] | ^^^^^^^ borrowed value does not live long enough [INFO] [stdout] ... [INFO] [stdout] 1204 | network.make_global_comms(), [INFO] [stdout] | --------------------------- argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1248 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1258:22 [INFO] [stdout] | [INFO] [stdout] 1255 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] ... [INFO] [stdout] 1258 | let global_comms = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1284 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] | [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> src/voter/mod.rs:1258:22 [INFO] [stdout] | [INFO] [stdout] 1258 | let global_comms = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] --> src/testing.rs:463:88 [INFO] [stdout] | [INFO] [stdout] 463 | impl Stream, Error>> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0505]: cannot move out of `network` because it is borrowed [INFO] [stdout] --> src/voter/mod.rs:1259:39 [INFO] [stdout] | [INFO] [stdout] 1255 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1256 | let (commits, _) = network.make_global_comms(); [INFO] [stdout] | ------- borrow of `network` occurs here [INFO] [stdout] ... [INFO] [stdout] 1259 | let env = Arc::new(Environment::new(network, local_id)); [INFO] [stdout] | ^^^^^^^ move out of `network` occurs here [INFO] [stdout] ... [INFO] [stdout] 1283 | pool.run_until(commits.take(1).for_each(|_| future::ready(()))) [INFO] [stdout] | ------- borrow later used here [INFO] [stdout] | [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> src/voter/mod.rs:1256:22 [INFO] [stdout] | [INFO] [stdout] 1256 | let (commits, _) = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] --> src/testing.rs:463:88 [INFO] [stdout] | [INFO] [stdout] 463 | impl Stream, Error>> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] help: consider cloning the value if the performance cost is acceptable [INFO] [stdout] | [INFO] [stdout] 1256 | let (commits, _) = network.clone().make_global_comms(); [INFO] [stdout] | ++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1294:40 [INFO] [stdout] | [INFO] [stdout] 1293 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1294 | let (commits_stream, commits_sink) = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1393 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] | [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> src/voter/mod.rs:1294:40 [INFO] [stdout] | [INFO] [stdout] 1294 | let (commits_stream, commits_sink) = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] --> src/testing.rs:463:88 [INFO] [stdout] | [INFO] [stdout] 463 | impl Stream, Error>> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1295:36 [INFO] [stdout] | [INFO] [stdout] 1293 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1294 | let (commits_stream, commits_sink) = network.make_global_comms(); [INFO] [stdout] 1295 | let (round_stream, round_sink) = network.make_round_comms(1, test_id); [INFO] [stdout] | ^^^^^^^----------------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1393 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] | [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> src/voter/mod.rs:1295:36 [INFO] [stdout] | [INFO] [stdout] 1295 | let (round_stream, round_sink) = network.make_round_comms(1, test_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] --> src/testing.rs:446:86 [INFO] [stdout] | [INFO] [stdout] 446 | impl Stream, Error>> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1314:22 [INFO] [stdout] | [INFO] [stdout] 1293 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] ... [INFO] [stdout] 1314 | let global_comms = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1393 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] | [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> src/voter/mod.rs:1314:22 [INFO] [stdout] | [INFO] [stdout] 1314 | let global_comms = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] --> src/testing.rs:463:88 [INFO] [stdout] | [INFO] [stdout] 463 | impl Stream, Error>> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0505]: cannot move out of `network` because it is borrowed [INFO] [stdout] --> src/voter/mod.rs:1315:39 [INFO] [stdout] | [INFO] [stdout] 1293 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1294 | let (commits_stream, commits_sink) = network.make_global_comms(); [INFO] [stdout] | --------------------------- [INFO] [stdout] | | [INFO] [stdout] | borrow of `network` occurs here [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1315 | let env = Arc::new(Environment::new(network, local_id)); [INFO] [stdout] | ^^^^^^^ move out of `network` occurs here [INFO] [stdout] | [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> src/voter/mod.rs:1294:40 [INFO] [stdout] | [INFO] [stdout] 1294 | let (commits_stream, commits_sink) = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] --> src/testing.rs:463:88 [INFO] [stdout] | [INFO] [stdout] 463 | impl Stream, Error>> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] help: consider cloning the value if the performance cost is acceptable [INFO] [stdout] | [INFO] [stdout] 1294 | let (commits_stream, commits_sink) = network.clone().make_global_comms(); [INFO] [stdout] | ++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1403:27 [INFO] [stdout] | [INFO] [stdout] 1402 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1403 | let (_, commits_sink) = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1454 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] | [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> src/voter/mod.rs:1403:27 [INFO] [stdout] | [INFO] [stdout] 1403 | let (_, commits_sink) = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] --> src/testing.rs:464:80 [INFO] [stdout] | [INFO] [stdout] 464 | impl Sink, Error = Error> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1416:22 [INFO] [stdout] | [INFO] [stdout] 1402 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] ... [INFO] [stdout] 1416 | let global_comms = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1454 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] | [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> src/voter/mod.rs:1416:22 [INFO] [stdout] | [INFO] [stdout] 1416 | let global_comms = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] --> src/testing.rs:464:80 [INFO] [stdout] | [INFO] [stdout] 464 | impl Sink, Error = Error> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0505]: cannot move out of `network` because it is borrowed [INFO] [stdout] --> src/voter/mod.rs:1417:39 [INFO] [stdout] | [INFO] [stdout] 1402 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1403 | let (_, commits_sink) = network.make_global_comms(); [INFO] [stdout] | --------------------------- [INFO] [stdout] | | [INFO] [stdout] | borrow of `network` occurs here [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1417 | let env = Arc::new(Environment::new(network, local_id)); [INFO] [stdout] | ^^^^^^^ move out of `network` occurs here [INFO] [stdout] | [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> src/voter/mod.rs:1403:27 [INFO] [stdout] | [INFO] [stdout] 1403 | let (_, commits_sink) = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] --> src/testing.rs:464:80 [INFO] [stdout] | [INFO] [stdout] 464 | impl Sink, Error = Error> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] help: consider cloning the value if the performance cost is acceptable [INFO] [stdout] | [INFO] [stdout] 1403 | let (_, commits_sink) = network.clone().make_global_comms(); [INFO] [stdout] | ++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1482:5 [INFO] [stdout] | [INFO] [stdout] 1464 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] ... [INFO] [stdout] 1482 | network.make_global_comms(), [INFO] [stdout] | ^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1563 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] | [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> src/voter/mod.rs:1482:5 [INFO] [stdout] | [INFO] [stdout] 1482 | network.make_global_comms(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] --> src/testing.rs:463:88 [INFO] [stdout] | [INFO] [stdout] 463 | impl Stream, Error>> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1572:22 [INFO] [stdout] | [INFO] [stdout] 1570 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1571 | [INFO] [stdout] 1572 | let global_comms = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1602 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] | [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> src/voter/mod.rs:1572:22 [INFO] [stdout] | [INFO] [stdout] 1572 | let global_comms = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] --> src/testing.rs:463:88 [INFO] [stdout] | [INFO] [stdout] 463 | impl Stream, Error>> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0505]: cannot move out of `network` because it is borrowed [INFO] [stdout] --> src/voter/mod.rs:1573:39 [INFO] [stdout] | [INFO] [stdout] 1570 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1571 | [INFO] [stdout] 1572 | let global_comms = network.make_global_comms(); [INFO] [stdout] | --------------------------- [INFO] [stdout] | | [INFO] [stdout] | borrow of `network` occurs here [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] 1573 | let env = Arc::new(Environment::new(network, local_id)); [INFO] [stdout] | ^^^^^^^ move out of `network` occurs here [INFO] [stdout] | [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> src/voter/mod.rs:1572:22 [INFO] [stdout] | [INFO] [stdout] 1572 | let global_comms = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] --> src/testing.rs:463:88 [INFO] [stdout] | [INFO] [stdout] 463 | impl Stream, Error>> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] help: consider cloning the value if the performance cost is acceptable [INFO] [stdout] | [INFO] [stdout] 1572 | let global_comms = network.clone().make_global_comms(); [INFO] [stdout] | ++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1611:22 [INFO] [stdout] | [INFO] [stdout] 1609 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1610 | [INFO] [stdout] 1611 | let global_comms = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1703 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] | [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> src/voter/mod.rs:1611:22 [INFO] [stdout] | [INFO] [stdout] 1611 | let global_comms = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] --> src/testing.rs:463:88 [INFO] [stdout] | [INFO] [stdout] 463 | impl Stream, Error>> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1650:26 [INFO] [stdout] | [INFO] [stdout] 1609 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] ... [INFO] [stdout] 1650 | let (_, round_sink) = network.make_round_comms(2, Id(id)); [INFO] [stdout] | ^^^^^^^---------------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1703 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] | [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> src/voter/mod.rs:1650:26 [INFO] [stdout] | [INFO] [stdout] 1650 | let (_, round_sink) = network.make_round_comms(2, Id(id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] --> src/testing.rs:447:56 [INFO] [stdout] | [INFO] [stdout] 447 | impl Sink, Error = Error> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1658:25 [INFO] [stdout] | [INFO] [stdout] 1609 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] ... [INFO] [stdout] 1658 | let (_, round_sink) = network.make_round_comms(1, sender); [INFO] [stdout] | ^^^^^^^---------------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1703 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] | [INFO] [stdout] note: this call may capture more lifetimes than intended, because Rust 2024 has adjusted the `impl Trait` lifetime capture rules [INFO] [stdout] --> src/voter/mod.rs:1658:25 [INFO] [stdout] | [INFO] [stdout] 1658 | let (_, round_sink) = network.make_round_comms(1, sender); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] --> src/testing.rs:447:56 [INFO] [stdout] | [INFO] [stdout] 447 | impl Sink, Error = Error> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: lifetime may not live long enough [INFO] [stdout] --> src/testing.rs:247:4 [INFO] [stdout] | [INFO] [stdout] 243 | fn round_data(&self, round: u64) -> RoundData { [INFO] [stdout] | - let's call the lifetime of this reference `'1` [INFO] [stdout] ... [INFO] [stdout] 247 | / RoundData { [INFO] [stdout] 248 | | voter_id: Some(self.local_id), [INFO] [stdout] 249 | | prevote_timer: Box::new(Delay::new(GOSSIP_DURATION).map(Ok)), [INFO] [stdout] 250 | | precommit_timer: Box::new(Delay::new(GOSSIP_DURATION + GOSSIP_DURATION).map(Ok)), [INFO] [stdout] 251 | | incoming: Box::new(incoming), [INFO] [stdout] 252 | | outgoing: Box::pin(outgoing), [INFO] [stdout] 253 | | } [INFO] [stdout] | |_____________^ returning this value requires that `'1` must outlive `'static` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] Some errors have detailed explanations: E0505, E0597. [INFO] [stdout] [INFO] [stdout] For more information about an error, try `rustc --explain E0505`. [INFO] [stdout] [INFO] [stderr] error: could not compile `finality-grandpa` (lib test) due to 22 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "ae8e6335d15a45b06bf0f2e067079c243bf38b0fc13bb173d71d3a352cca712b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae8e6335d15a45b06bf0f2e067079c243bf38b0fc13bb173d71d3a352cca712b", kill_on_drop: false }` [INFO] [stdout] ae8e6335d15a45b06bf0f2e067079c243bf38b0fc13bb173d71d3a352cca712b