[INFO] fetching crate ffi 0.1.1... [INFO] checking ffi-0.1.1 against try#65132f36b923285d5da381c2fbafee6ce899e841 for pr-132712-1 [INFO] extracting crate ffi 0.1.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate ffi 0.1.1 on toolchain 65132f36b923285d5da381c2fbafee6ce899e841 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ffi 0.1.1 [INFO] finished tweaking crates.io crate ffi 0.1.1 [INFO] tweaked toml for crates.io crate ffi 0.1.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate ffi 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 75ffc05d8e8f39869c94ce171407cb73d998a966732f8deeae8ce0c3a068fd3d [INFO] running `Command { std: "docker" "start" "-a" "75ffc05d8e8f39869c94ce171407cb73d998a966732f8deeae8ce0c3a068fd3d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "75ffc05d8e8f39869c94ce171407cb73d998a966732f8deeae8ce0c3a068fd3d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "75ffc05d8e8f39869c94ce171407cb73d998a966732f8deeae8ce0c3a068fd3d", kill_on_drop: false }` [INFO] [stdout] 75ffc05d8e8f39869c94ce171407cb73d998a966732f8deeae8ce0c3a068fd3d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1b18e05564ca8e34b4346740d3a774e5e55509d40ae44d11a9f1231e0abb7948 [INFO] running `Command { std: "docker" "start" "-a" "1b18e05564ca8e34b4346740d3a774e5e55509d40ae44d11a9f1231e0abb7948", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.75 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Compiling serde v1.0.194 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Compiling trybuild v1.0.87 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking termcolor v1.4.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking quote v1.0.35 [INFO] [stderr] Checking syn v2.0.48 [INFO] [stderr] Checking basic-toml v0.1.8 [INFO] [stderr] Checking darling_core v0.20.3 [INFO] [stderr] Compiling serde_derive v1.0.194 [INFO] [stderr] Compiling darling_macro v0.20.3 [INFO] [stderr] Checking darling v0.20.3 [INFO] [stderr] Compiling ffi v0.1.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/lib.rs (11 fixes) [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:239:27 [INFO] [stdout] | [INFO] [stdout] 232 | let mut name = None; [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | `name` calls a custom destructor [INFO] [stdout] | `name` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | let ty = if let Some(ref ty) = arg.ty { [INFO] [stdout] | -- [INFO] [stdout] | | [INFO] [stdout] | `ty` calls a custom destructor [INFO] [stdout] | `ty` will be dropped later as of Edition 2024 [INFO] [stdout] 239 | match parse_str::(ty) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 240 | Ok(ty) => quote!(#ty), [INFO] [stdout] | -- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | } else { match self.ffi_self_ty { Some(ref ty) => { [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 294 | / renames.insert( [INFO] [stdout] 295 | | i, [INFO] [stdout] 296 | | FfiFuncRename { [INFO] [stdout] 297 | | rename: rename.clone(), [INFO] [stdout] 298 | | _ty: ty.clone(), [INFO] [stdout] 299 | | }, [INFO] [stdout] 300 | | ); [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |_____________________this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/65132f36b923285d5da381c2fbafee6ce899e841/library/proc_macro/src/bridge/client.rs:100:1 [INFO] [stdout] note: `name` invokes this custom destructor [INFO] [stdout] --> /rustc/65132f36b923285d5da381c2fbafee6ce899e841/library/proc_macro/src/bridge/client.rs:100:1 [INFO] [stdout] note: `ty` invokes this custom destructor [INFO] [stdout] --> /rustc/65132f36b923285d5da381c2fbafee6ce899e841/library/proc_macro/src/bridge/client.rs:100:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/65132f36b923285d5da381c2fbafee6ce899e841/library/proc_macro/src/bridge/client.rs:100:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/65132f36b923285d5da381c2fbafee6ce899e841/library/proc_macro/src/bridge/client.rs:100:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] = note: this warning originates in the macro `define_client_handles` which comes from the expansion of the macro `with_api_handle_types` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/forward.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/test.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/reverse.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.72s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Compiling ffi v0.1.1 (/tmp/fixit) [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> examples/reverse.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | #[ffi(from_ptr, self_ty = "*mut std::ffi::c_void")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = note: this error originates in the attribute macro `ffi` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 20 | #[unsafe(ffi(from_ptr, self_ty = "*mut std::ffi::c_void"))] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> examples/forward.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | #[ffi(from_ptr, self_ty = "*mut std::ffi::c_void")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = note: this error originates in the attribute macro `ffi` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 20 | #[unsafe(ffi(from_ptr, self_ty = "*mut std::ffi::c_void"))] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> tests/test.rs:27:1 [INFO] [stdout] | [INFO] [stdout] 27 | #[ffi(from_ptr, self_ty = "*mut std::ffi::c_void")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = note: this error originates in the attribute macro `ffi` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 27 | #[unsafe(ffi(from_ptr, self_ty = "*mut std::ffi::c_void"))] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ffi` (example "reverse") due to 1 previous error [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ffi` (example "forward") due to 1 previous error [INFO] [stderr] error: could not compile `ffi` (test "test") due to 1 previous error [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "1b18e05564ca8e34b4346740d3a774e5e55509d40ae44d11a9f1231e0abb7948", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b18e05564ca8e34b4346740d3a774e5e55509d40ae44d11a9f1231e0abb7948", kill_on_drop: false }` [INFO] [stdout] 1b18e05564ca8e34b4346740d3a774e5e55509d40ae44d11a9f1231e0abb7948