[INFO] fetching crate falco_plugin 0.4.0... [INFO] checking falco_plugin-0.4.0 against try#65132f36b923285d5da381c2fbafee6ce899e841 for pr-132712-1 [INFO] extracting crate falco_plugin 0.4.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate falco_plugin 0.4.0 on toolchain 65132f36b923285d5da381c2fbafee6ce899e841 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate falco_plugin 0.4.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate falco_plugin 0.4.0 [INFO] tweaked toml for crates.io crate falco_plugin 0.4.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate falco_plugin 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3b9fc27c0f96b443cbda6cd32bd99618ff8436dddb612ee4dd0298d728b07b81 [INFO] running `Command { std: "docker" "start" "-a" "3b9fc27c0f96b443cbda6cd32bd99618ff8436dddb612ee4dd0298d728b07b81", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3b9fc27c0f96b443cbda6cd32bd99618ff8436dddb612ee4dd0298d728b07b81", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b9fc27c0f96b443cbda6cd32bd99618ff8436dddb612ee4dd0298d728b07b81", kill_on_drop: false }` [INFO] [stdout] 3b9fc27c0f96b443cbda6cd32bd99618ff8436dddb612ee4dd0298d728b07b81 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f70e12dd833f9e790c810e4aebc38d52cb5e3545d5fcb2382b829ca6ac8e9b63 [INFO] running `Command { std: "docker" "start" "-a" "f70e12dd833f9e790c810e4aebc38d52cb5e3545d5fcb2382b829ca6ac8e9b63", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling serde_json v1.0.130 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling anyhow v1.0.89 [INFO] [stderr] Compiling refcell-lock-api v0.1.0 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling schemars v0.8.16 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking falco_plugin_api v0.4.0 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling serde_derive_internals v0.26.0 [INFO] [stderr] Compiling schemars_derive v0.8.16 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling falco_event_derive v0.4.0 [INFO] [stderr] Compiling falco_plugin_derive v0.4.0 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking falco_event v0.4.0 [INFO] [stderr] Checking falco_plugin v0.4.0 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/plugin/tables/data.rs (1 fix) [INFO] [stderr] Fixed src/plugin/parse/wrappers.rs (2 fixes) [INFO] [stderr] Fixed src/plugin/base/logger.rs (2 fixes) [INFO] [stderr] Fixed src/plugin/tables/table/raw.rs (3 fixes) [INFO] [stderr] Fixed src/plugin/error/ffi_result.rs (1 fix) [INFO] [stderr] Fixed src/plugin/listen/wrappers.rs (4 fixes) [INFO] [stderr] Fixed src/plugin/exported_tables/field_value/dynamic.rs (1 fix) [INFO] [stderr] Fixed src/plugin/base/wrappers.rs (21 fixes) [INFO] [stderr] Fixed src/plugin/extract/wrappers.rs (1 fix) [INFO] [stderr] Fixed src/plugin/async_event/wrappers.rs (1 fix) [INFO] [stderr] Fixed src/plugin/extract/fields.rs (1 fix) [INFO] [stderr] Fixed src/plugin/exported_tables/field_value/scalar.rs (1 fix) [INFO] [stderr] Fixed src/plugin/source/wrappers.rs (7 fixes) [INFO] [stderr] Fixed src/plugin/listen/routine.rs (1 fix) [INFO] [stderr] Fixed src/plugin/tables/table/mod.rs (1 fix) [INFO] [stderr] Fixed src/plugin/tables/entry/raw.rs (2 fixes) [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | if let DynamicFieldValue::$variant(val) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 69 | impl_scalar_field!(u8 => u8_ => FieldTypeId::U8 => U8); [INFO] [stdout] | ------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | } else { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 69 | impl_scalar_field!(u8 => u8_ => FieldTypeId::U8 => U8); [INFO] [stdout] | ------------------------------------------------------ in this macro invocation [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] = note: this warning originates in the macro `impl_scalar_field` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | if let DynamicFieldValue::$variant(val) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 70 | impl_scalar_field!(i8 => s8 => FieldTypeId::I8 => I8); [INFO] [stdout] | ----------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | } else { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 70 | impl_scalar_field!(i8 => s8 => FieldTypeId::I8 => I8); [INFO] [stdout] | ----------------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_scalar_field` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | if let DynamicFieldValue::$variant(val) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 71 | impl_scalar_field!(u16 => u16_ => FieldTypeId::U16 => U16); [INFO] [stdout] | ---------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | } else { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 71 | impl_scalar_field!(u16 => u16_ => FieldTypeId::U16 => U16); [INFO] [stdout] | ---------------------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_scalar_field` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | if let DynamicFieldValue::$variant(val) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 72 | impl_scalar_field!(i16 => s16 => FieldTypeId::I16 => I16); [INFO] [stdout] | --------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | } else { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 72 | impl_scalar_field!(i16 => s16 => FieldTypeId::I16 => I16); [INFO] [stdout] | --------------------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_scalar_field` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | if let DynamicFieldValue::$variant(val) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 73 | impl_scalar_field!(u32 => u32_ => FieldTypeId::U32 => U32); [INFO] [stdout] | ---------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | } else { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 73 | impl_scalar_field!(u32 => u32_ => FieldTypeId::U32 => U32); [INFO] [stdout] | ---------------------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_scalar_field` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | if let DynamicFieldValue::$variant(val) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 74 | impl_scalar_field!(i32 => s32 => FieldTypeId::I32 => I32); [INFO] [stdout] | --------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | } else { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 74 | impl_scalar_field!(i32 => s32 => FieldTypeId::I32 => I32); [INFO] [stdout] | --------------------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_scalar_field` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | if let DynamicFieldValue::$variant(val) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 75 | impl_scalar_field!(u64 => u64_ => FieldTypeId::U64 => U64); [INFO] [stdout] | ---------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | } else { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 75 | impl_scalar_field!(u64 => u64_ => FieldTypeId::U64 => U64); [INFO] [stdout] | ---------------------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_scalar_field` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | if let DynamicFieldValue::$variant(val) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 76 | impl_scalar_field!(i64 => s64 => FieldTypeId::I64 => I64); [INFO] [stdout] | --------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | } else { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 76 | impl_scalar_field!(i64 => s64 => FieldTypeId::I64 => I64); [INFO] [stdout] | --------------------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_scalar_field` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | if let DynamicFieldValue::$variant(val) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 77 | impl_scalar_field!(bool => b => FieldTypeId::Bool => Bool); [INFO] [stdout] | ---------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | } else { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 77 | impl_scalar_field!(bool => b => FieldTypeId::Bool => Bool); [INFO] [stdout] | ---------------------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_scalar_field` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | if let DynamicFieldValue::$variant(val) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 78 | impl_scalar_field!(CString => str_ => FieldTypeId::String => String); [INFO] [stdout] | -------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | } else { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 78 | impl_scalar_field!(CString => str_ => FieldTypeId::String => String); [INFO] [stdout] | -------------------------------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_scalar_field` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/dummy_source.rs from 2021 edition to 2024 [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | if let DynamicFieldValue::$variant(val) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 69 | impl_scalar_field!(u8 => u8_ => FieldTypeId::U8 => U8); [INFO] [stdout] | ------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | } else { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 69 | impl_scalar_field!(u8 => u8_ => FieldTypeId::U8 => U8); [INFO] [stdout] | ------------------------------------------------------ in this macro invocation [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] = note: this warning originates in the macro `impl_scalar_field` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | if let DynamicFieldValue::$variant(val) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 70 | impl_scalar_field!(i8 => s8 => FieldTypeId::I8 => I8); [INFO] [stdout] | ----------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | } else { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 70 | impl_scalar_field!(i8 => s8 => FieldTypeId::I8 => I8); [INFO] [stdout] | ----------------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_scalar_field` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | if let DynamicFieldValue::$variant(val) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 71 | impl_scalar_field!(u16 => u16_ => FieldTypeId::U16 => U16); [INFO] [stdout] | ---------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | } else { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 71 | impl_scalar_field!(u16 => u16_ => FieldTypeId::U16 => U16); [INFO] [stdout] | ---------------------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_scalar_field` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | if let DynamicFieldValue::$variant(val) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 72 | impl_scalar_field!(i16 => s16 => FieldTypeId::I16 => I16); [INFO] [stdout] | --------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | } else { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 72 | impl_scalar_field!(i16 => s16 => FieldTypeId::I16 => I16); [INFO] [stdout] | --------------------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_scalar_field` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | if let DynamicFieldValue::$variant(val) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 73 | impl_scalar_field!(u32 => u32_ => FieldTypeId::U32 => U32); [INFO] [stdout] | ---------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | } else { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 73 | impl_scalar_field!(u32 => u32_ => FieldTypeId::U32 => U32); [INFO] [stdout] | ---------------------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_scalar_field` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | if let DynamicFieldValue::$variant(val) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 74 | impl_scalar_field!(i32 => s32 => FieldTypeId::I32 => I32); [INFO] [stdout] | --------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | } else { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 74 | impl_scalar_field!(i32 => s32 => FieldTypeId::I32 => I32); [INFO] [stdout] | --------------------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_scalar_field` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | if let DynamicFieldValue::$variant(val) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 75 | impl_scalar_field!(u64 => u64_ => FieldTypeId::U64 => U64); [INFO] [stdout] | ---------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | } else { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 75 | impl_scalar_field!(u64 => u64_ => FieldTypeId::U64 => U64); [INFO] [stdout] | ---------------------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_scalar_field` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | if let DynamicFieldValue::$variant(val) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 76 | impl_scalar_field!(i64 => s64 => FieldTypeId::I64 => I64); [INFO] [stdout] | --------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | } else { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 76 | impl_scalar_field!(i64 => s64 => FieldTypeId::I64 => I64); [INFO] [stdout] | --------------------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_scalar_field` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | if let DynamicFieldValue::$variant(val) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 77 | impl_scalar_field!(bool => b => FieldTypeId::Bool => Bool); [INFO] [stdout] | ---------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | } else { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 77 | impl_scalar_field!(bool => b => FieldTypeId::Bool => Bool); [INFO] [stdout] | ---------------------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_scalar_field` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | if let DynamicFieldValue::$variant(val) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 78 | impl_scalar_field!(CString => str_ => FieldTypeId::String => String); [INFO] [stdout] | -------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/plugin/exported_tables/field_value/scalar.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | } else { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 78 | impl_scalar_field!(CString => str_ => FieldTypeId::String => String); [INFO] [stdout] | -------------------------------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_scalar_field` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 24.23s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking falco_plugin v0.4.0 (/tmp/fixit) [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> examples/dummy_source.rs:75:1 [INFO] [stdout] | [INFO] [stdout] 75 | plugin!(DummyPlugin); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = note: this error originates in the macro `plugin` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] --> /tmp/fixit/src/plugin/base/wrappers.rs:501:11 [INFO] [stdout] | [INFO] [stdout] 501| #[unsafe($attr)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> examples/dummy_source.rs:75:1 [INFO] [stdout] | [INFO] [stdout] 75 | plugin!(DummyPlugin); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = note: this error originates in the macro `plugin` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] --> /tmp/fixit/src/plugin/base/wrappers.rs:230:11 [INFO] [stdout] | [INFO] [stdout] 230| #[unsafe($attr)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> examples/dummy_source.rs:78:1 [INFO] [stdout] | [INFO] [stdout] 78 | source_plugin!(DummyPlugin); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = note: this error originates in the macro `source_plugin` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] --> /tmp/fixit/src/plugin/base/wrappers.rs:230:11 [INFO] [stdout] | [INFO] [stdout] 230| #[unsafe($attr)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `falco_plugin` (example "dummy_source") due to 3 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "f70e12dd833f9e790c810e4aebc38d52cb5e3545d5fcb2382b829ca6ac8e9b63", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f70e12dd833f9e790c810e4aebc38d52cb5e3545d5fcb2382b829ca6ac8e9b63", kill_on_drop: false }` [INFO] [stdout] f70e12dd833f9e790c810e4aebc38d52cb5e3545d5fcb2382b829ca6ac8e9b63