[INFO] fetching crate crsh 0.0.1... [INFO] checking crsh-0.0.1 against try#65132f36b923285d5da381c2fbafee6ce899e841 for pr-132712-1 [INFO] extracting crate crsh 0.0.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate crsh 0.0.1 on toolchain 65132f36b923285d5da381c2fbafee6ce899e841 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate crsh 0.0.1 [INFO] finished tweaking crates.io crate crsh 0.0.1 [INFO] tweaked toml for crates.io crate crsh 0.0.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate crsh 0.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] daa86cdf7232609858335f2038a9ef5c62885bda55e54669f6bd04a29abb88ba [INFO] running `Command { std: "docker" "start" "-a" "daa86cdf7232609858335f2038a9ef5c62885bda55e54669f6bd04a29abb88ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "daa86cdf7232609858335f2038a9ef5c62885bda55e54669f6bd04a29abb88ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "daa86cdf7232609858335f2038a9ef5c62885bda55e54669f6bd04a29abb88ba", kill_on_drop: false }` [INFO] [stdout] daa86cdf7232609858335f2038a9ef5c62885bda55e54669f6bd04a29abb88ba [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 88c32ea41a4058fb743047afd69a07c8e3df0202841e182fcb599848f51cea29 [INFO] running `Command { std: "docker" "start" "-a" "88c32ea41a4058fb743047afd69a07c8e3df0202841e182fcb599848f51cea29", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling regex-syntax v0.8.3 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling crsh v0.0.1 (/tmp/fixit) [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Migrating build.rs from 2021 edition to 2024 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking os_pipe v1.2.0 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking vte v0.11.1 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking strip-ansi-escapes v0.2.0 [INFO] [stderr] Compiling logos-codegen v0.14.0 [INFO] [stderr] Compiling logos-derive v0.14.0 [INFO] [stderr] Checking logos v0.14.0 [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `crsh` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/shell/parsing.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: expected one of `(`, `,`, `::`, or `=`, found `+` [INFO] [stderr] --> src/shell/parsing.rs:5:36 [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Debug, Copy, Clone, Logos + use<'s>)] [INFO] [stderr] | ^ expected one of `(`, `,`, `::`, or `=` [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/shell/parsing.rs:31:10 [INFO] [stderr] | [INFO] [stderr] 31 | impl<'a> Token<'a> { [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/shell/parsing.rs:60:22 [INFO] [stderr] | [INFO] [stderr] 60 | lexer: Lexer<'a, Token<'a>>, [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/shell/parsing.rs:61:25 [INFO] [stderr] | [INFO] [stderr] 61 | next: Option, ()>>, [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/shell/parsing.rs:62:25 [INFO] [stderr] | [INFO] [stderr] 62 | last: Option, ()>>, [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/shell/parsing.rs:77:37 [INFO] [stderr] | [INFO] [stderr] 77 | fn peek(&self) -> Option, ()>> { [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/shell/parsing.rs:81:41 [INFO] [stderr] | [INFO] [stderr] 81 | fn next(&mut self) -> Option, ()>> { [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `Token` [INFO] [stderr] --> src/shell/parsing.rs:67:25 [INFO] [stderr] | [INFO] [stderr] 67 | let mut lexer = Token::lexer(input); [INFO] [stderr] | ^^^^^ use of undeclared type `Token` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `Token` [INFO] [stderr] --> src/shell/parsing.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | Token::DoubleAnd => BindingPower::Infix(3, 4), [INFO] [stderr] | ^^^^^ use of undeclared type `Token` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `Token` [INFO] [stderr] --> src/shell/parsing.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | Token::DoublePipe => BindingPower::Infix(5, 6), [INFO] [stderr] | ^^^^^ use of undeclared type `Token` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `Token` [INFO] [stderr] --> src/shell/parsing.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | Token::Pipe => BindingPower::Infix(1, 2), [INFO] [stderr] | ^^^^^ use of undeclared type `Token` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `Token` [INFO] [stderr] --> src/shell/parsing.rs:149:25 [INFO] [stderr] | [INFO] [stderr] 149 | Token::Pipe => { [INFO] [stderr] | ^^^^^ use of undeclared type `Token` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `Token` [INFO] [stderr] --> src/shell/parsing.rs:95:25 [INFO] [stderr] | [INFO] [stderr] 95 | Token::Word(keyword) => { [INFO] [stderr] | ^^^^^ use of undeclared type `Token` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `Token` [INFO] [stderr] --> src/shell/parsing.rs:99:47 [INFO] [stderr] | [INFO] [stderr] 99 | ... while let Some(Ok(Token::Word(arg))) = self.peek() { [INFO] [stderr] | ^^^^^ use of undeclared type `Token` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `Token` [INFO] [stderr] --> src/shell/parsing.rs:139:25 [INFO] [stderr] | [INFO] [stderr] 139 | Token::DoubleAnd => Command::Logical { [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/shell/builtin/cd.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | env::set_var("OLDPWD", &sh.env.pwd); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 79 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 80 ~ unsafe { env::set_var("OLDPWD", &sh.env.pwd) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | ^^^^^ use of undeclared type `Token` [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/shell/execution.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | if let Some(builder) = Self::get_builtin_builder(keyword) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^---------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/shell/execution.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | } else if self.find_on_path(keyword).is_some() { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 27 ~ match Self::get_builtin_builder(keyword) { Some(builder) => { [INFO] [stdout] 28 | match builder(args) { [INFO] [stdout] ... [INFO] [stdout] 34 | } [INFO] [stdout] 35 ~ } _ => if self.find_on_path(keyword).is_some() { [INFO] [stdout] 36 | let args = args.iter().map(|s| s.to_string()).collect::>(); [INFO] [stdout] ... [INFO] [stdout] 65 | -1 [INFO] [stdout] 66 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `Token` [INFO] [stderr] --> src/shell/parsing.rs:144:25 [INFO] [stderr] | [INFO] [stderr] 144 | Token::DoublePipe => Command::Logical { [INFO] [stderr] | ^^^^^ use of undeclared type `Token` [INFO] [stderr] [INFO] [stdout] warning: `impl CallbackResult<'s, &'s str, Token<'s>>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/shell/parsing.rs:5:30 [INFO] [stdout] | [INFO] [stdout] 5 | #[derive(Debug, Copy, Clone, Logos)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/shell/parsing.rs:5:30 [INFO] [stdout] | [INFO] [stdout] 5 | #[derive(Debug, Copy, Clone, Logos)] [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] = note: this warning originates in the derive macro `Logos` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 5 | #[derive(Debug, Copy, Clone, Logos + use<'s>)] [INFO] [stdout] | +++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: aborting due to 16 previous errors [INFO] [stderr] [INFO] [stderr] Some errors have detailed explanations: E0412, E0433. [INFO] [stderr] For more information about an error, try `rustc --explain E0412`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `impl CallbackResult<'s, &'s str, Token<'s>>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/shell/parsing.rs:5:30 [INFO] [stdout] | [INFO] [stdout] 5 | #[derive(Debug, Copy, Clone, Logos)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/shell/parsing.rs:5:30 [INFO] [stdout] | [INFO] [stdout] 5 | #[derive(Debug, Copy, Clone, Logos)] [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: this warning originates in the derive macro `Logos` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 5 | #[derive(Debug, Copy, Clone, Logos + use<'s>)] [INFO] [stdout] | +++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `crsh` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/shell/parsing.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: expected one of `(`, `,`, `::`, or `=`, found `+` [INFO] [stderr] --> src/shell/parsing.rs:5:36 [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Debug, Copy, Clone, Logos + use<'s>)] [INFO] [stderr] | ^ expected one of `(`, `,`, `::`, or `=` [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/shell/parsing.rs:31:10 [INFO] [stderr] | [INFO] [stderr] 31 | impl<'a> Token<'a> { [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/shell/parsing.rs:60:22 [INFO] [stderr] | [INFO] [stderr] 60 | lexer: Lexer<'a, Token<'a>>, [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/shell/parsing.rs:61:25 [INFO] [stderr] | [INFO] [stderr] 61 | next: Option, ()>>, [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/shell/parsing.rs:62:25 [INFO] [stderr] | [INFO] [stderr] 62 | last: Option, ()>>, [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/shell/parsing.rs:77:37 [INFO] [stderr] | [INFO] [stderr] 77 | fn peek(&self) -> Option, ()>> { [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] [INFO] [stderr] error[E0412]: cannot find type `Token` in this scope [INFO] [stderr] --> src/shell/parsing.rs:81:41 [INFO] [stderr] | [INFO] [stderr] 81 | fn next(&mut self) -> Option, ()>> { [INFO] [stderr] | ^^^^^ not found in this scope [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `Token` [INFO] [stderr] --> src/shell/parsing.rs:67:25 [INFO] [stderr] | [INFO] [stderr] 67 | let mut lexer = Token::lexer(input); [INFO] [stderr] | ^^^^^ use of undeclared type `Token` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `Token` [INFO] [stderr] --> src/shell/parsing.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | Token::DoubleAnd => BindingPower::Infix(3, 4), [INFO] [stderr] | ^^^^^ use of undeclared type `Token` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `Token` [INFO] [stderr] --> src/shell/parsing.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | Token::DoublePipe => BindingPower::Infix(5, 6), [INFO] [stderr] | ^^^^^ use of undeclared type `Token` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `Token` [INFO] [stderr] --> src/shell/parsing.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | Token::Pipe => BindingPower::Infix(1, 2), [INFO] [stderr] | ^^^^^ use of undeclared type `Token` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `Token` [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/shell/builtin/cd.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | env::set_var("OLDPWD", &sh.env.pwd); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 79 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 80 ~ unsafe { env::set_var("OLDPWD", &sh.env.pwd) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] --> src/shell/parsing.rs:149:25 [INFO] [stderr] | [INFO] [stderr] 149 | Token::Pipe => { [INFO] [stderr] | ^^^^^ use of undeclared type `Token` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `Token` [INFO] [stderr] --> src/shell/parsing.rs:95:25 [INFO] [stderr] | [INFO] [stderr] 95 | Token::Word(keyword) => { [INFO] [stderr] | ^^^^^ use of undeclared type `Token` [INFO] [stderr] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/shell/execution.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | if let Some(builder) = Self::get_builtin_builder(keyword) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^---------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/shell/execution.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | } else if self.find_on_path(keyword).is_some() { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 27 ~ match Self::get_builtin_builder(keyword) { Some(builder) => { [INFO] [stdout] 28 | match builder(args) { [INFO] [stdout] ... [INFO] [stdout] 34 | } [INFO] [stdout] 35 ~ } _ => if self.find_on_path(keyword).is_some() { [INFO] [stdout] 36 | let args = args.iter().map(|s| s.to_string()).collect::>(); [INFO] [stdout] ... [INFO] [stdout] 65 | -1 [INFO] [stdout] 66 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `Token` [INFO] [stderr] --> src/shell/parsing.rs:99:47 [INFO] [stderr] | [INFO] [stderr] 99 | ... while let Some(Ok(Token::Word(arg))) = self.peek() { [INFO] [stderr] | ^^^^^ use of undeclared type `Token` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `Token` [INFO] [stderr] --> src/shell/parsing.rs:139:25 [INFO] [stderr] | [INFO] [stderr] 139 | Token::DoubleAnd => Command::Logical { [INFO] [stderr] | ^^^^^ use of undeclared type `Token` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `Token` [INFO] [stderr] --> src/shell/parsing.rs:144:25 [INFO] [stderr] | [INFO] [stderr] 144 | Token::DoublePipe => Command::Logical { [INFO] [stderr] | ^^^^^ use of undeclared type `Token` [INFO] [stderr] [INFO] [stderr] error: aborting due to 16 previous errors [INFO] [stdout] warning: `impl CallbackResult<'s, &'s str, Token<'s>>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/shell/parsing.rs:5:30 [INFO] [stdout] | [INFO] [stdout] 5 | #[derive(Debug, Copy, Clone, Logos)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/shell/parsing.rs:5:30 [INFO] [stdout] | [INFO] [stdout] 5 | #[derive(Debug, Copy, Clone, Logos)] [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] = note: this warning originates in the derive macro `Logos` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 5 | #[derive(Debug, Copy, Clone, Logos + use<'s>)] [INFO] [stdout] | +++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stderr] Some errors have detailed explanations: E0412, E0433. [INFO] [stderr] For more information about an error, try `rustc --explain E0412`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `impl CallbackResult<'s, &'s str, Token<'s>>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/shell/parsing.rs:5:30 [INFO] [stdout] | [INFO] [stdout] 5 | #[derive(Debug, Copy, Clone, Logos)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/shell/parsing.rs:5:30 [INFO] [stdout] | [INFO] [stdout] 5 | #[derive(Debug, Copy, Clone, Logos)] [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: this warning originates in the derive macro `Logos` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 5 | #[derive(Debug, Copy, Clone, Logos + use<'s>)] [INFO] [stdout] | +++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.99s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Compiling crsh v0.0.1 (/tmp/fixit) [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe function or block [INFO] [stdout] --> src/shell/builtin/cd.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | env::set_var("OLDPWD", &sh.env.pwd); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe function or block [INFO] [stdout] --> src/shell/builtin/cd.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | env::set_var("OLDPWD", &sh.env.pwd); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `crsh` (bin "crsh") due to 1 previous error [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `crsh` (bin "crsh" test) due to 1 previous error [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "88c32ea41a4058fb743047afd69a07c8e3df0202841e182fcb599848f51cea29", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "88c32ea41a4058fb743047afd69a07c8e3df0202841e182fcb599848f51cea29", kill_on_drop: false }` [INFO] [stdout] 88c32ea41a4058fb743047afd69a07c8e3df0202841e182fcb599848f51cea29