[INFO] fetching crate computercraft_websocket_control 0.1.1... [INFO] checking computercraft_websocket_control-0.1.1 against try#65132f36b923285d5da381c2fbafee6ce899e841 for pr-132712-1 [INFO] extracting crate computercraft_websocket_control 0.1.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate computercraft_websocket_control 0.1.1 on toolchain 65132f36b923285d5da381c2fbafee6ce899e841 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate computercraft_websocket_control 0.1.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate computercraft_websocket_control 0.1.1 [INFO] tweaked toml for crates.io crate computercraft_websocket_control 0.1.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate computercraft_websocket_control 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3277ab4eaca8239c3a34767e270c6ea993e2c2bb8ec080169406fa20de52e31a [INFO] running `Command { std: "docker" "start" "-a" "3277ab4eaca8239c3a34767e270c6ea993e2c2bb8ec080169406fa20de52e31a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3277ab4eaca8239c3a34767e270c6ea993e2c2bb8ec080169406fa20de52e31a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3277ab4eaca8239c3a34767e270c6ea993e2c2bb8ec080169406fa20de52e31a", kill_on_drop: false }` [INFO] [stdout] 3277ab4eaca8239c3a34767e270c6ea993e2c2bb8ec080169406fa20de52e31a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0746b734915e674201dbc4cfcc68e77c9f9e7f010844a39c0aa925903ebd0a49 [INFO] running `Command { std: "docker" "start" "-a" "0746b734915e674201dbc4cfcc68e77c9f9e7f010844a39c0aa925903ebd0a49", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Checking futures-task v0.3.28 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling thiserror v1.0.49 [INFO] [stderr] Checking cpufeatures v0.2.9 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Compiling rustix v0.38.20 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking data-encoding v2.4.0 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking futures-channel v0.3.28 [INFO] [stderr] Checking linux-raw-sys v0.4.10 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking headers v0.3.9 [INFO] [stderr] Checking stupid_utils v0.2.4 [INFO] [stderr] Checking termcolor v1.3.0 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling axum-core v0.3.4 [INFO] [stderr] Compiling axum v0.6.20 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking parking_lot_core v0.9.8 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.4 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_path_to_error v0.1.14 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Compiling async-trait v0.1.73 [INFO] [stderr] Compiling axum-macros v0.3.8 [INFO] [stderr] Checking tokio v1.33.0 [INFO] [stderr] Checking futures-util v0.3.28 [INFO] [stderr] Checking tungstenite v0.20.1 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-tungstenite v0.20.1 [INFO] [stderr] Checking computercraft_websocket_control v0.1.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/get_router.rs (1 fix) [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/get_router_with_tick_func.rs:58:19 [INFO] [stdout] | [INFO] [stdout] 58 | match tick.call(&mut state, ws.ports(), dt).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] 59 | Ok(_) => {} [INFO] [stdout] 60 | Err(e) => { [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `e` calls a custom destructor [INFO] [stdout] | `e` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/random_line.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/unused.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/minesweeper.rs from 2021 edition to 2024 [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> examples/unused.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | / async fn tick( [INFO] [stdout] 9 | | state: &mut f32, [INFO] [stdout] 10 | | ports: Ports<'_>, [INFO] [stdout] 11 | | dt: Duration, [INFO] [stdout] 12 | | ) -> Result<(), computercraft_websocket_control::Errors> { [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in Rust 2024 and in a future release in all editions! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromIterator<()>` will fail [INFO] [stdout] --> examples/unused.rs:30:16 [INFO] [stdout] | [INFO] [stdout] 30 | .collect::>()?; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] = note: `--force-warn dependency-on-unit-never-type-fallback` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed examples/minesweeper.rs (6 fixes) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.00s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking computercraft_websocket_control v0.1.1 (/tmp/fixit) [INFO] [stdout] error[E0277]: a value of type `!` cannot be built from an iterator over elements of type `()` [INFO] [stdout] --> examples/unused.rs:30:16 [INFO] [stdout] | [INFO] [stdout] 30 | .collect::>()?; [INFO] [stdout] | ------- ^^^^^^^^^^^^ value of type `!` cannot be built from `std::iter::Iterator` [INFO] [stdout] | | [INFO] [stdout] | required by a bound introduced by this call [INFO] [stdout] | [INFO] [stdout] = help: the trait `FromIterator<()>` is not implemented for `!` [INFO] [stdout] = help: the trait `FromIterator>` is implemented for `Result` [INFO] [stdout] = note: this error might have been caused by changes to Rust's type-inference algorithm (see issue #48950 for more information) [INFO] [stdout] = help: did you intend to use the type `()` here instead? [INFO] [stdout] = note: required for `Result` to implement `FromIterator>` [INFO] [stdout] note: required by a bound in `std::iter::Iterator::collect` [INFO] [stdout] --> /rustc/65132f36b923285d5da381c2fbafee6ce899e841/library/core/src/iter/traits/iterator.rs:1967:5 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0277`. [INFO] [stdout] [INFO] [stderr] error: could not compile `computercraft_websocket_control` (example "unused") due to 1 previous error [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "0746b734915e674201dbc4cfcc68e77c9f9e7f010844a39c0aa925903ebd0a49", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0746b734915e674201dbc4cfcc68e77c9f9e7f010844a39c0aa925903ebd0a49", kill_on_drop: false }` [INFO] [stdout] 0746b734915e674201dbc4cfcc68e77c9f9e7f010844a39c0aa925903ebd0a49