[INFO] fetching crate coerce-redis 0.4.4... [INFO] checking coerce-redis-0.4.4 against try#65132f36b923285d5da381c2fbafee6ce899e841 for pr-132712-1 [INFO] extracting crate coerce-redis 0.4.4 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate coerce-redis 0.4.4 on toolchain 65132f36b923285d5da381c2fbafee6ce899e841 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate coerce-redis 0.4.4 [INFO] finished tweaking crates.io crate coerce-redis 0.4.4 [INFO] tweaked toml for crates.io crate coerce-redis 0.4.4 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 121 packages to latest compatible versions [INFO] [stderr] Adding protobuf v3.2.0 (available: v3.7.1) [INFO] [stderr] Adding protobuf-support v3.2.0 (available: v3.7.1) [INFO] [stderr] Adding redis v0.23.3 (available: v0.27.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 72bba791041e70dd3fedb3c77938957e06184cb53ff8bb73e619738b737819be [INFO] running `Command { std: "docker" "start" "-a" "72bba791041e70dd3fedb3c77938957e06184cb53ff8bb73e619738b737819be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "72bba791041e70dd3fedb3c77938957e06184cb53ff8bb73e619738b737819be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "72bba791041e70dd3fedb3c77938957e06184cb53ff8bb73e619738b737819be", kill_on_drop: false }` [INFO] [stdout] 72bba791041e70dd3fedb3c77938957e06184cb53ff8bb73e619738b737819be [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4c2c87acf993c19eb5115001d2a611586e6a449a80672bffdcaa4db020211573 [INFO] running `Command { std: "docker" "start" "-a" "4c2c87acf993c19eb5115001d2a611586e6a449a80672bffdcaa4db020211573", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.92 [INFO] [stderr] Compiling unicode-ident v1.0.14 [INFO] [stderr] Compiling libc v0.2.164 [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking litemap v0.7.4 [INFO] [stderr] Checking writeable v0.5.5 [INFO] [stderr] Checking pin-project-lite v0.2.15 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking icu_locid_transform_data v1.5.0 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Checking icu_properties_data v1.5.0 [INFO] [stderr] Checking bytes v1.8.0 [INFO] [stderr] Compiling serde v1.0.215 [INFO] [stderr] Checking icu_normalizer_data v1.5.0 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Checking utf16_iter v1.0.5 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking write16 v1.0.0 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Compiling protobuf v3.2.0 [INFO] [stderr] Compiling anyhow v1.0.93 [INFO] [stderr] Compiling valuable v0.1.0 [INFO] [stderr] Checking itoa v1.0.13 [INFO] [stderr] Compiling serde_json v1.0.133 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.89 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling valuable-derive v0.1.0 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.215 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking tokio v1.41.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Checking protobuf-support v3.2.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking uuid v1.11.0 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking coerce v0.8.11 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking redis v0.23.3 [INFO] [stderr] Checking coerce-redis v0.4.4 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/journal/actor.rs (3 fixes) [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/journal/actor.rs:261:1 [INFO] [stdout] | [INFO] [stdout] 261 | #[async_trait] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in Rust 2024 and in a future release in all editions! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/journal/actor.rs:269:14 [INFO] [stdout] | [INFO] [stdout] 269 | .query_async(&mut self.0) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `--force-warn dependency-on-unit-never-type-fallback` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/journal/actor.rs:91:18 [INFO] [stdout] | [INFO] [stdout] 85 | let mut connection = connection; [INFO] [stdout] | -------------- [INFO] [stdout] | | [INFO] [stdout] | `connection` calls a custom destructor [INFO] [stdout] | `connection` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | }); [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/journal/actor.rs:121:61 [INFO] [stdout] | [INFO] [stdout] 110 | let mut connection = connection; [INFO] [stdout] | -------------- [INFO] [stdout] | | [INFO] [stdout] | `connection` calls a custom destructor [INFO] [stdout] | `connection` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | match cmd.query_async::(&mut connection).await { Err(e) => { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | }); [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/journal/actor.rs:144:18 [INFO] [stdout] | [INFO] [stdout] 138 | let mut connection = connection; [INFO] [stdout] | -------------- [INFO] [stdout] | | [INFO] [stdout] | `connection` calls a custom destructor [INFO] [stdout] | `connection` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | }); [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/journal/mod.rs:77:59 [INFO] [stdout] | [INFO] [stdout] 74 | / create_provider( [INFO] [stdout] 75 | | { [INFO] [stdout] 76 | | let client = Client::open(config.nodes[0].clone()).expect("redis client create"); [INFO] [stdout] 77 | | client.get_multiplexed_tokio_connection().await.unwrap() [INFO] [stdout] | | ^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 81 | | ) [INFO] [stdout] 82 | | .await [INFO] [stdout] | | ----- [INFO] [stdout] | | | | [INFO] [stdout] | |__________|___`__awaitee` calls a custom destructor [INFO] [stdout] | | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 83 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: `__awaitee` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/journal/actor.rs:261:1 [INFO] [stdout] | [INFO] [stdout] 261 | #[async_trait] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in Rust 2024 and in a future release in all editions! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/journal/actor.rs:269:14 [INFO] [stdout] | [INFO] [stdout] 269 | .query_async(&mut self.0) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `--force-warn dependency-on-unit-never-type-fallback` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/test_redis_journal_storage.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 18.86s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking coerce-redis v0.4.4 (/tmp/fixit) [INFO] [stdout] error[E0277]: the trait bound `!: FromRedisValue` is not satisfied [INFO] [stdout] --> src/journal/actor.rs:269:14 [INFO] [stdout] | [INFO] [stdout] 269 | .query_async(&mut self.0) [INFO] [stdout] | ^^^^^^^^^^^ the trait `FromRedisValue` is not implemented for `!` [INFO] [stdout] | [INFO] [stdout] = help: the following other types implement trait `FromRedisValue`: [INFO] [stdout] () [INFO] [stdout] (T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12) [INFO] [stdout] (T10, T11, T12) [INFO] [stdout] (T11, T12) [INFO] [stdout] (T12,) [INFO] [stdout] (T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12) [INFO] [stdout] (T3, T4, T5, T6, T7, T8, T9, T10, T11, T12) [INFO] [stdout] (T4, T5, T6, T7, T8, T9, T10, T11, T12) [INFO] [stdout] and 42 others [INFO] [stdout] = note: this error might have been caused by changes to Rust's type-inference algorithm (see issue #48950 for more information) [INFO] [stdout] = help: did you intend to use the type `()` here instead? [INFO] [stdout] note: required by a bound in `Cmd::query_async` [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/redis-0.23.3/src/cmd.rs:429:36 [INFO] [stdout] | [INFO] [stdout] 429 | pub async fn query_async(&self, con: &mut C) -> RedisResult [INFO] [stdout] | ^^^^^^^^^^^^^^ required by this bound in `Cmd::query_async` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0277]: the trait bound `!: FromRedisValue` is not satisfied [INFO] [stdout] --> src/journal/actor.rs:269:14 [INFO] [stdout] | [INFO] [stdout] 269 | .query_async(&mut self.0) [INFO] [stdout] | ^^^^^^^^^^^ the trait `FromRedisValue` is not implemented for `!` [INFO] [stdout] | [INFO] [stdout] = help: the following other types implement trait `FromRedisValue`: [INFO] [stdout] () [INFO] [stdout] (T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12) [INFO] [stdout] (T10, T11, T12) [INFO] [stdout] (T11, T12) [INFO] [stdout] (T12,) [INFO] [stdout] (T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12) [INFO] [stdout] (T3, T4, T5, T6, T7, T8, T9, T10, T11, T12) [INFO] [stdout] (T4, T5, T6, T7, T8, T9, T10, T11, T12) [INFO] [stdout] and 42 others [INFO] [stdout] = note: this error might have been caused by changes to Rust's type-inference algorithm (see issue #48950 for more information) [INFO] [stdout] = help: did you intend to use the type `()` here instead? [INFO] [stdout] note: required by a bound in `Cmd::query_async` [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/redis-0.23.3/src/cmd.rs:429:36 [INFO] [stdout] | [INFO] [stdout] 429 | pub async fn query_async(&self, con: &mut C) -> RedisResult [INFO] [stdout] | ^^^^^^^^^^^^^^ required by this bound in `Cmd::query_async` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0277`. [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0277`. [INFO] [stdout] [INFO] [stderr] error: could not compile `coerce-redis` (lib test) due to 1 previous error [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `coerce-redis` (lib) due to 1 previous error [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "4c2c87acf993c19eb5115001d2a611586e6a449a80672bffdcaa4db020211573", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c2c87acf993c19eb5115001d2a611586e6a449a80672bffdcaa4db020211573", kill_on_drop: false }` [INFO] [stdout] 4c2c87acf993c19eb5115001d2a611586e6a449a80672bffdcaa4db020211573