[INFO] cloning repository https://github.com/dylanwh/plbindgen_macros [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dylanwh/plbindgen_macros" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdylanwh%2Fplbindgen_macros", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdylanwh%2Fplbindgen_macros'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1ade33e590ee5dfca5a48e52933dc5881a3b3d6d [INFO] checking dylanwh/plbindgen_macros/1ade33e590ee5dfca5a48e52933dc5881a3b3d6d against try#65132f36b923285d5da381c2fbafee6ce899e841 for pr-132712-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdylanwh%2Fplbindgen_macros" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dylanwh/plbindgen_macros on toolchain 65132f36b923285d5da381c2fbafee6ce899e841 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dylanwh/plbindgen_macros [INFO] finished tweaking git repo https://github.com/dylanwh/plbindgen_macros [INFO] tweaked toml for git repo https://github.com/dylanwh/plbindgen_macros written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/dylanwh/plbindgen_macros already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 26adf3368afaa3cf37b0c24df255ea30bebcbaa7a30a48a8459f5e53938b53de [INFO] running `Command { std: "docker" "start" "-a" "26adf3368afaa3cf37b0c24df255ea30bebcbaa7a30a48a8459f5e53938b53de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "26adf3368afaa3cf37b0c24df255ea30bebcbaa7a30a48a8459f5e53938b53de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26adf3368afaa3cf37b0c24df255ea30bebcbaa7a30a48a8459f5e53938b53de", kill_on_drop: false }` [INFO] [stdout] 26adf3368afaa3cf37b0c24df255ea30bebcbaa7a30a48a8459f5e53938b53de [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 83b9afd8a7fccd29d8c2d6b013a9cb51b720c8b6691f8bbeaa99dbc5fa369fa7 [INFO] running `Command { std: "docker" "start" "-a" "83b9afd8a7fccd29d8c2d6b013a9cb51b720c8b6691f8bbeaa99dbc5fa369fa7", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking quote v1.0.36 [INFO] [stderr] Checking syn v2.0.67 [INFO] [stderr] Checking plbindgen_macros v0.1.0 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/lib.rs (1 fix) [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:43:15 [INFO] [stdout] | [INFO] [stdout] 43 | match check_arg.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | / check_arg.replace(CheckArg { [INFO] [stdout] 51 | | ident: format_ident!("{name}_len"), [INFO] [stdout] 52 | | fn_arg: input.clone(), [INFO] [stdout] 53 | | }); [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |__________________this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/65132f36b923285d5da381c2fbafee6ce899e841/library/proc_macro/src/bridge/client.rs:100:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/65132f36b923285d5da381c2fbafee6ce899e841/library/proc_macro/src/bridge/client.rs:100:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] = note: this warning originates in the macro `define_client_handles` which comes from the expansion of the macro `with_api_handle_types` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/basic.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `basic` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * tests/basic.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: expected item, found `{` [INFO] [stderr] --> tests/basic.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | { unsafe #[export]} [INFO] [stderr] | ^ expected item [INFO] [stderr] | [INFO] [stderr] = note: for a full list of items that can appear in modules, see [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> tests/basic.rs:10:20 [INFO] [stdout] | [INFO] [stdout] 10 | let nums = std::slice::from_raw_parts(nums, nums_len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> tests/basic.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | #[export] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] = note: `--force-warn unsafe-op-in-unsafe-fn` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] = note: this warning originates in the attribute macro `export` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.40s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Compiling plbindgen_macros v0.1.0 (/tmp/fixit) [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> tests/basic.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | #[export] [INFO] [stdout] | ^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = note: this error originates in the attribute macro `export` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 8 | #[unsafe(export)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `plbindgen_macros` (test "basic") due to 1 previous error [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "83b9afd8a7fccd29d8c2d6b013a9cb51b720c8b6691f8bbeaa99dbc5fa369fa7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "83b9afd8a7fccd29d8c2d6b013a9cb51b720c8b6691f8bbeaa99dbc5fa369fa7", kill_on_drop: false }` [INFO] [stdout] 83b9afd8a7fccd29d8c2d6b013a9cb51b720c8b6691f8bbeaa99dbc5fa369fa7