[INFO] cloning repository https://github.com/BradenEverson/td [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/BradenEverson/td" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBradenEverson%2Ftd", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBradenEverson%2Ftd'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c0fa5b28fc4bf3367a1db8c7bdb8d5c2175684cf [INFO] checking BradenEverson/td/c0fa5b28fc4bf3367a1db8c7bdb8d5c2175684cf against try#65132f36b923285d5da381c2fbafee6ce899e841 for pr-132712-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBradenEverson%2Ftd" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/BradenEverson/td on toolchain 65132f36b923285d5da381c2fbafee6ce899e841 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/BradenEverson/td [INFO] finished tweaking git repo https://github.com/BradenEverson/td [INFO] tweaked toml for git repo https://github.com/BradenEverson/td written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/BradenEverson/td already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3f15742be5d04fa17201e2f4043811dae71ac9f7f79d5e8cd052915be2f80929 [INFO] running `Command { std: "docker" "start" "-a" "3f15742be5d04fa17201e2f4043811dae71ac9f7f79d5e8cd052915be2f80929", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3f15742be5d04fa17201e2f4043811dae71ac9f7f79d5e8cd052915be2f80929", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3f15742be5d04fa17201e2f4043811dae71ac9f7f79d5e8cd052915be2f80929", kill_on_drop: false }` [INFO] [stdout] 3f15742be5d04fa17201e2f4043811dae71ac9f7f79d5e8cd052915be2f80929 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+65132f36b923285d5da381c2fbafee6ce899e841" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e4b2bde7c77c3263217c5a75a9044cc4569c83b42ee1b8b9db455e584b59684f [INFO] running `Command { std: "docker" "start" "-a" "e4b2bde7c77c3263217c5a75a9044cc4569c83b42ee1b8b9db455e584b59684f", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling syn v2.0.74 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling serde v1.0.206 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling serde_json v1.0.125 [INFO] [stderr] Compiling td v0.1.0 (/tmp/fixit) [INFO] [stderr] Migrating build.rs from 2021 edition to 2024 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.206 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tungstenite v0.23.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-tungstenite v0.23.1 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking hyper-tungstenite v0.14.0 [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/server/state.rs (2 fixes) [INFO] [stderr] Fixed src/server/user.rs (1 fix) [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/server/service.rs:70:51 [INFO] [stdout] | [INFO] [stdout] 70 | while let Some(Ok(msg)) = reader.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^----- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#8` [INFO] [stdout] | up until Edition 2021 `#8` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | "Text" => tx.send(ServerMessage::text( [INFO] [stdout] | ___________________________________________________- [INFO] [stdout] 77 | | user_id, [INFO] [stdout] 78 | | &parsed.data.unwrap(), [INFO] [stdout] 79 | | ))?, [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |___________________________________________this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] 80 | "ConnectReq" => tx.send(ServerMessage::new( [INFO] [stdout] | _________________________________________________________- [INFO] [stdout] | |_________________________________________________________| [INFO] [stdout] 81 | | user_id, [INFO] [stdout] 82 | | MessageType::ConnectReq(parsed.data.unwrap()), [INFO] [stdout] 83 | | ))?, [INFO] [stdout] | | - [INFO] [stdout] | |___________________________________________| [INFO] [stdout] | |___________________________________________this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] 84 | "BeginGame" => { [INFO] [stdout] 85 | / tx.send(ServerMessage::new( [INFO] [stdout] 86 | | user_id, [INFO] [stdout] 87 | | MessageType::BeginGame, [INFO] [stdout] 88 | | ))?; [INFO] [stdout] | | - [INFO] [stdout] | |_______________________________________________| [INFO] [stdout] | |_______________________________________________this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | `#4` will be dropped later as of Edition 2024 [INFO] [stdout] 89 | } [INFO] [stdout] 90 | "SpawnUnit" => tx.send(ServerMessage::new( [INFO] [stdout] | ________________________________________________________- [INFO] [stdout] | |________________________________________________________| [INFO] [stdout] 91 | | user_id, [INFO] [stdout] 92 | | MessageType::PlayUnit(parsed.data.unwrap()), [INFO] [stdout] 93 | | ))?, [INFO] [stdout] | | - [INFO] [stdout] | |___________________________________________| [INFO] [stdout] | |___________________________________________this value will be stored in a temporary; let us call it `#5` [INFO] [stdout] | `#5` will be dropped later as of Edition 2024 [INFO] [stdout] 94 | "DmgPing" => tx.send(ServerMessage::new( [INFO] [stdout] | ______________________________________________________- [INFO] [stdout] | |______________________________________________________| [INFO] [stdout] 95 | | user_id, [INFO] [stdout] 96 | | MessageType::DmgPing( [INFO] [stdout] 97 | | parsed.data.unwrap().parse::().unwrap(), [INFO] [stdout] 98 | | ), [INFO] [stdout] 99 | | ))?, [INFO] [stdout] | | - [INFO] [stdout] | |___________________________________________| [INFO] [stdout] | |___________________________________________this value will be stored in a temporary; let us call it `#6` [INFO] [stdout] | `#6` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | | tx.send(ServerMessage::new(user_id, MessageType::Disconnect))?; [INFO] [stdout] | | -------------------------------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#7` [INFO] [stdout] | | `#7` will be dropped later as of Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 109 | | } [INFO] [stdout] | | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: `#8` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#8` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.7.1/src/bytes.rs:569:1 [INFO] [stdout] | [INFO] [stdout] 569 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.7.1/src/bytes.rs:569:1 [INFO] [stdout] | [INFO] [stdout] 569 | impl Drop for Bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/futures-util-0.3.30/src/lock/bilock.rs:200:1 [INFO] [stdout] | [INFO] [stdout] 200 | impl Drop for Inner { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/futures-util-0.3.30/src/lock/bilock.rs:200:1 [INFO] [stdout] | [INFO] [stdout] 200 | impl Drop for Inner { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/futures-util-0.3.30/src/lock/bilock.rs:200:1 [INFO] [stdout] | [INFO] [stdout] 200 | impl Drop for Inner { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#5` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/futures-util-0.3.30/src/lock/bilock.rs:200:1 [INFO] [stdout] | [INFO] [stdout] 200 | impl Drop for Inner { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#6` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/futures-util-0.3.30/src/lock/bilock.rs:200:1 [INFO] [stdout] | [INFO] [stdout] 200 | impl Drop for Inner { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#7` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/futures-util-0.3.30/src/lock/bilock.rs:200:1 [INFO] [stdout] | [INFO] [stdout] 200 | impl Drop for Inner { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/main.rs (1 fix) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.66s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Compiling td v0.1.0 (/tmp/fixit) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.49s [INFO] running `Command { std: "docker" "inspect" "e4b2bde7c77c3263217c5a75a9044cc4569c83b42ee1b8b9db455e584b59684f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e4b2bde7c77c3263217c5a75a9044cc4569c83b42ee1b8b9db455e584b59684f", kill_on_drop: false }` [INFO] [stdout] e4b2bde7c77c3263217c5a75a9044cc4569c83b42ee1b8b9db455e584b59684f