[INFO] fetching crate zng-task 0.4.6... [INFO] checking zng-task-0.4.6 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate zng-task 0.4.6 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate zng-task 0.4.6 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate zng-task 0.4.6 [INFO] finished tweaking crates.io crate zng-task 0.4.6 [INFO] tweaked toml for crates.io crate zng-task 0.4.6 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 237 packages to latest compatible versions [INFO] [stderr] Adding async-channel v1.9.0 (available: v2.3.1) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding castaway v0.1.2 (available: v0.2.3) [INFO] [stderr] Adding event-listener v2.5.3 (available: v5.3.1) [INFO] [stderr] Adding fastrand v1.9.0 (available: v2.1.1) [INFO] [stderr] Adding fixedbitset v0.4.2 (available: v0.5.7) [INFO] [stderr] Adding futures-lite v1.13.0 (available: v2.3.0) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (available: v1.1.0) [INFO] [stderr] Adding http-cache-semantics v1.0.2 (available: v2.1.0) [INFO] [stderr] Adding http-serde v1.1.3 (available: v2.1.1) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding polling v2.8.0 (available: v3.7.3) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-strings v0.1.0 (available: v0.2.0) [INFO] [stderr] Adding windows-sys v0.48.0 (available: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (available: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cfb712c0675dbc930de129b3814e1ecc9f561f9d5af81525ef9d3ec9dc59b4d9 [INFO] running `Command { std: "docker" "start" "-a" "cfb712c0675dbc930de129b3814e1ecc9f561f9d5af81525ef9d3ec9dc59b4d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cfb712c0675dbc930de129b3814e1ecc9f561f9d5af81525ef9d3ec9dc59b4d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cfb712c0675dbc930de129b3814e1ecc9f561f9d5af81525ef9d3ec9dc59b4d9", kill_on_drop: false }` [INFO] [stdout] cfb712c0675dbc930de129b3814e1ecc9f561f9d5af81525ef9d3ec9dc59b4d9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d136731a77e555bc9b8828fc24f458a8ef9e4db824968062dde824443fb63823 [INFO] running `Command { std: "docker" "start" "-a" "d136731a77e555bc9b8828fc24f458a8ef9e4db824968062dde824443fb63823", kill_on_drop: false }` [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling bytemuck_derive v1.7.1 [INFO] [stderr] Compiling linkme-impl v0.3.28 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling zng-app-context v0.5.9 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking rustc-hash v2.0.0 [INFO] [stderr] Compiling zng-var v0.5.6 [INFO] [stderr] Compiling zng-task v0.4.6 (/opt/rustwide/workdir) [INFO] [stderr] Compiling zng-var-proc-macros v0.2.8 [INFO] [stderr] Checking pretty-type-name v1.0.1 [INFO] [stderr] Checking zng-clone-move v0.2.5 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking zng-handle v0.2.5 [INFO] [stderr] Compiling zng-task-proc-macros v0.2.6 [INFO] [stderr] Checking dunce v1.0.5 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking linkme v0.3.28 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking bytemuck v1.18.0 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking async-fs v2.1.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.8 [INFO] [stderr] Checking zng-txt v0.2.8 [INFO] [stderr] Checking semver v1.0.23 [INFO] [stderr] Checking euclid v0.22.11 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking zng-unique-id v0.4.6 [INFO] [stderr] Checking toml_edit v0.22.22 [INFO] [stderr] Checking zng-unit v0.2.9 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Compiling zng-env-proc-macros v0.2.2 [INFO] [stderr] Checking zng-env v0.3.5 [INFO] [stderr] Checking zng-time v0.2.21 [INFO] [stdout] error: this value of type `UiTaskState` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:113:15 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn into_result(mut self) -> Result { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | match mem::replace(&mut self.0, UiTaskState::Cancelled) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(Pin + Send>>, Option)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:168:46 [INFO] [stdout] | [INFO] [stdout] 166 | fn wake(self: Arc) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | // continue task in spawn threads [INFO] [stdout] 168 | if let Some((task, Some(ctx))) = self.fut.lock().take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option + Send>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:196:34 [INFO] [stdout] | [INFO] [stdout] 195 | let mut task = self.fut.lock(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | if let Some(mut t) = task.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option + Send>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:436:38 [INFO] [stdout] | [INFO] [stdout] 435 | let mut task = self.fut.lock(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 436 | if let Some(mut t) = task.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option + Send>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:542:38 [INFO] [stdout] | [INFO] [stdout] 541 | let mut task = self.fut.lock(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 542 | if let Some(mut t) = task.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zng-task` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `UiTaskState` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:113:15 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn into_result(mut self) -> Result { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | match mem::replace(&mut self.0, UiTaskState::Cancelled) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(std::pin::Pin + Send>>, Option)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:168:46 [INFO] [stdout] | [INFO] [stdout] 166 | fn wake(self: Arc) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | // continue task in spawn threads [INFO] [stdout] 168 | if let Some((task, Some(ctx))) = self.fut.lock().take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option + Send>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:196:34 [INFO] [stdout] | [INFO] [stdout] 195 | let mut task = self.fut.lock(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | if let Some(mut t) = task.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option + Send>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:436:38 [INFO] [stdout] | [INFO] [stdout] 435 | let mut task = self.fut.lock(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 436 | if let Some(mut t) = task.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option + Send>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:542:38 [INFO] [stdout] | [INFO] [stdout] 541 | let mut task = self.fut.lock(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 542 | if let Some(mut t) = task.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a module [INFO] [stdout] --> src/lib.rs:1979:1 [INFO] [stdout] | [INFO] [stdout] 1979 | pub mod tests { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | #![warn(missing_docs)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a macro [INFO] [stdout] --> src/io.rs:887:5 [INFO] [stdout] | [INFO] [stdout] 887 | macro_rules! assert_vec_eq { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a function [INFO] [stdout] --> src/lib.rs:1994:5 [INFO] [stdout] | [INFO] [stdout] 1994 | pub fn any_one() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a function [INFO] [stdout] --> src/lib.rs:2001:5 [INFO] [stdout] | [INFO] [stdout] 2001 | pub fn any_nine() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a function [INFO] [stdout] --> src/lib.rs:2046:5 [INFO] [stdout] | [INFO] [stdout] 2046 | pub fn run_wake_immediately() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a function [INFO] [stdout] --> src/lib.rs:2056:5 [INFO] [stdout] | [INFO] [stdout] 2056 | pub fn run_panic_handling() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a function [INFO] [stdout] --> src/lib.rs:2072:5 [INFO] [stdout] | [INFO] [stdout] 2072 | pub fn run_panic_handling_parallel() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zng-task` (lib test) due to 6 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d136731a77e555bc9b8828fc24f458a8ef9e4db824968062dde824443fb63823", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d136731a77e555bc9b8828fc24f458a8ef9e4db824968062dde824443fb63823", kill_on_drop: false }` [INFO] [stdout] d136731a77e555bc9b8828fc24f458a8ef9e4db824968062dde824443fb63823