[INFO] fetching crate zbus 4.4.0... [INFO] checking zbus-4.4.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate zbus 4.4.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate zbus 4.4.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate zbus 4.4.0 [INFO] finished tweaking crates.io crate zbus 4.4.0 [INFO] tweaked toml for crates.io crate zbus 4.4.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate zbus 4.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7f864c60bdede83dad9a6ab0182b65785bd32bf9787c9feffb8a68d0dba473c5 [INFO] running `Command { std: "docker" "start" "-a" "7f864c60bdede83dad9a6ab0182b65785bd32bf9787c9feffb8a68d0dba473c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7f864c60bdede83dad9a6ab0182b65785bd32bf9787c9feffb8a68d0dba473c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f864c60bdede83dad9a6ab0182b65785bd32bf9787c9feffb8a68d0dba473c5", kill_on_drop: false }` [INFO] [stdout] 7f864c60bdede83dad9a6ab0182b65785bd32bf9787c9feffb8a68d0dba473c5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 05e19a01e81257ef0a9bf1f0ef37a654298e658f399b43567cea6a6441f25f67 [INFO] running `Command { std: "docker" "start" "-a" "05e19a01e81257ef0a9bf1f0ef37a654298e658f399b43567cea6a6441f25f67", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling toml_datetime v0.6.6 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Checking endi v1.1.0 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking piper v0.2.3 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-broadcast v0.7.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking async-fs v2.1.2 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking xdg-home v1.2.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Compiling zvariant_utils v2.1.0 [INFO] [stderr] Compiling ntest_test_cases v0.9.3 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling enumflags2_derive v0.7.10 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling test-log-macros v0.2.16 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling zvariant_derive v4.2.0 [INFO] [stderr] Compiling zbus_macros v4.4.0 [INFO] [stderr] Compiling ntest_timeout v0.9.3 [INFO] [stderr] Checking ntest v0.9.3 [INFO] [stderr] Checking tokio v1.38.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking polling v3.7.2 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking async-io v2.3.3 [INFO] [stderr] Checking test-log v0.2.16 [INFO] [stderr] Checking enumflags2 v0.7.10 [INFO] [stderr] Checking quick-xml v0.30.0 [INFO] [stderr] Checking zvariant v4.2.0 [INFO] [stderr] Checking zbus_names v3.0.0 [INFO] [stderr] Checking zbus_xml v4.0.0 [INFO] [stderr] Checking zbus v4.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::result::Result<(), fdo::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object_server/mod.rs:770:41 [INFO] [stdout] | [INFO] [stdout] 768 | let server = connection.object_server(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 769 | let hdr = msg.header(); [INFO] [stdout] 770 | if let Err(e) = server [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 771 | | .dispatch_call_to_iface(iface, &connection, &msg, &hdr) [INFO] [stdout] 772 | | .await [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `connection::Connection` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy/mod.rs:1367:13 [INFO] [stdout] | [INFO] [stdout] 1367 | let conn = Connection::session().await?; [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 1400 | futures_util::join!(owner_changed_stream.next(), name_acquired_stream.next(),); [INFO] [stdout] | ------------------------------------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), fdo::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object_server/mod.rs:770:41 [INFO] [stdout] | [INFO] [stdout] 768 | let server = connection.object_server(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 769 | let hdr = msg.header(); [INFO] [stdout] 770 | if let Err(e) = server [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 771 | | .dispatch_call_to_iface(iface, &connection, &msg, &hdr) [INFO] [stdout] 772 | | .await [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/lib.rs:908:5 [INFO] [stdout] | [INFO] [stdout] 908 | async fn issue_260_client(connection: &Connection) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: zvariant::Type` will fail [INFO] [stdout] --> src/lib.rs:916:10 [INFO] [stdout] | [INFO] [stdout] 916 | .call("Whatever", &()) [INFO] [stdout] | ^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), error::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy/mod.rs:313:29 [INFO] [stdout] | [INFO] [stdout] 286 | let result = cache_clone [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 313 | if let Err(e) = cache_clone [INFO] [stdout] | _____________________________^ [INFO] [stdout] 314 | | .keep_updated(prop_changes, interface, uncached_properties) [INFO] [stdout] 315 | | .await [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy/mod.rs:1289:26 [INFO] [stdout] | [INFO] [stdout] 1289 | match ready!(OrderedStream::poll_next_before( [INFO] [stdout] | ____________________- ^ [INFO] [stdout] | |____________________| | [INFO] [stdout] | |____________________| | [INFO] [stdout] | | __________________________| [INFO] [stdout] 1290 | || Pin::new(&mut this.stream), [INFO] [stdout] 1291 | || cx, [INFO] [stdout] 1292 | || before [INFO] [stdout] 1293 | || )) { [INFO] [stdout] | || ^- [INFO] [stdout] | ||_____________|| [INFO] [stdout] | ||_____________|these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | ||_____________|these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________|these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zbus` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::result::Result<(), error::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy/mod.rs:313:29 [INFO] [stdout] | [INFO] [stdout] 286 | let result = cache_clone [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 313 | if let Err(e) = cache_clone [INFO] [stdout] | _____________________________^ [INFO] [stdout] 314 | | .keep_updated(prop_changes, interface, uncached_properties) [INFO] [stdout] 315 | | .await [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy/mod.rs:1289:26 [INFO] [stdout] | [INFO] [stdout] 1289 | match ready!(OrderedStream::poll_next_before( [INFO] [stdout] | ____________________- ^ [INFO] [stdout] | |____________________| | [INFO] [stdout] | |____________________| | [INFO] [stdout] | | __________________________| [INFO] [stdout] 1290 | || Pin::new(&mut this.stream), [INFO] [stdout] 1291 | || cx, [INFO] [stdout] 1292 | || before [INFO] [stdout] 1293 | || )) { [INFO] [stdout] | || ^- [INFO] [stdout] | ||_____________|| [INFO] [stdout] | ||_____________|these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | ||_____________|these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________|these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zbus` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "05e19a01e81257ef0a9bf1f0ef37a654298e658f399b43567cea6a6441f25f67", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "05e19a01e81257ef0a9bf1f0ef37a654298e658f399b43567cea6a6441f25f67", kill_on_drop: false }` [INFO] [stdout] 05e19a01e81257ef0a9bf1f0ef37a654298e658f399b43567cea6a6441f25f67