[INFO] fetching crate yama 0.4.0... [INFO] checking yama-0.4.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate yama 0.4.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate yama 0.4.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate yama 0.4.0 [INFO] finished tweaking crates.io crate yama 0.4.0 [INFO] tweaked toml for crates.io crate yama 0.4.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate yama 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8b833625152866ade44ea8bf1f55bd9ea447d4dd2e18e8346871bd25bbae940a [INFO] running `Command { std: "docker" "start" "-a" "8b833625152866ade44ea8bf1f55bd9ea447d4dd2e18e8346871bd25bbae940a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8b833625152866ade44ea8bf1f55bd9ea447d4dd2e18e8346871bd25bbae940a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b833625152866ade44ea8bf1f55bd9ea447d4dd2e18e8346871bd25bbae940a", kill_on_drop: false }` [INFO] [stdout] 8b833625152866ade44ea8bf1f55bd9ea447d4dd2e18e8346871bd25bbae940a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 80752073c05c890806b44d7972e6d033a28ba9b592b870cbff0f4c9544825f6e [INFO] running `Command { std: "docker" "start" "-a" "80752073c05c890806b44d7972e6d033a28ba9b592b870cbff0f4c9544825f6e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Checking ahash v0.4.7 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling indexmap v1.6.2 [INFO] [stderr] Compiling zstd-safe v3.0.1+zstd.1.4.9 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling libsqlite3-sys v0.20.1 [INFO] [stderr] Checking lock_api v0.4.4 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Compiling anyhow v1.0.41 [INFO] [stderr] Compiling nix v0.17.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking hashlink v0.6.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking textwrap v0.12.1 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking shell-escape v0.1.5 [INFO] [stderr] Checking os_str_bytes v2.4.0 [INFO] [stderr] Checking utf8parse v0.2.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking number_prefix v0.3.0 [INFO] [stderr] Checking sshish v0.1.1 [INFO] [stderr] Checking rusqlite v0.24.2 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking fastcdc v1.0.5 [INFO] [stderr] Checking temp-dir v0.1.11 [INFO] [stderr] Compiling blake v2.0.1 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Compiling jobserver v0.1.22 [INFO] [stderr] Compiling cc v1.0.68 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking nix v0.19.1 [INFO] [stderr] Checking users v0.9.1 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking sled v0.34.6 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Compiling zstd-sys v1.4.20+zstd.1.4.9 [INFO] [stderr] Compiling libsodium-sys v0.2.6 [INFO] [stderr] Checking console v0.14.1 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking indicatif v0.14.0 [INFO] [stderr] Checking twox-hash v1.6.0 [INFO] [stderr] Checking rustyline v7.1.0 [INFO] [stderr] Compiling clap_derive v3.0.0-beta.2 [INFO] [stderr] Compiling thiserror-impl v1.0.25 [INFO] [stderr] Checking thiserror v1.0.25 [INFO] [stderr] Checking clap v3.0.0-beta.2 [INFO] [stderr] Checking serde_bare v0.3.0 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking zstd v0.6.1+zstd.1.4.9 [INFO] [stderr] Checking sodiumoxide v0.2.6 [INFO] [stderr] Checking yama v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pile/local_sqlitebloblogs.rs:280:15 [INFO] [stdout] | [INFO] [stdout] 278 | let inner = self.inner.lock().unwrap(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | let offset_i64 = i64::try_from(pointer.offset).expect("ouch! can't turn u64 into i64..."); [INFO] [stdout] 280 | match inner.connection.execute( [INFO] [stdout] | _______________^ [INFO] [stdout] 281 | | "INSERT INTO chunks (chunk_id, bloblog, offset) VALUES (?1, ?2, ?3)", [INFO] [stdout] 282 | | params![&chunk_id[..], pointer.bloblog, offset_i64], [INFO] [stdout] 283 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pile/local_sqlitebloblogs.rs:280:15 [INFO] [stdout] | [INFO] [stdout] 278 | let inner = self.inner.lock().unwrap(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | let offset_i64 = i64::try_from(pointer.offset).expect("ouch! can't turn u64 into i64..."); [INFO] [stdout] 280 | match inner.connection.execute( [INFO] [stdout] | _______________^ [INFO] [stdout] 281 | | "INSERT INTO chunks (chunk_id, bloblog, offset) VALUES (?1, ?2, ?3)", [INFO] [stdout] 282 | | params![&chunk_id[..], pointer.bloblog, offset_i64], [INFO] [stdout] 283 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/chunking.rs:117:30 [INFO] [stdout] | [INFO] [stdout] 117 | self.pile.clone(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Pile` does not implement `Clone`, so calling `clone` on `&Pile` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 117 - self.pile.clone(), [INFO] [stdout] 117 + self.pile, [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Pile`, implement `Clone` for it [INFO] [stdout] --> src/pile.rs:117:1 [INFO] [stdout] | [INFO] [stdout] 117 + #[derive(Clone)] [INFO] [stdout] 118 | pub struct Pile { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yama` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/chunking.rs:117:30 [INFO] [stdout] | [INFO] [stdout] 117 | self.pile.clone(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Pile` does not implement `Clone`, so calling `clone` on `&Pile` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 117 - self.pile.clone(), [INFO] [stdout] 117 + self.pile, [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Pile`, implement `Clone` for it [INFO] [stdout] --> src/pile.rs:117:1 [INFO] [stdout] | [INFO] [stdout] 117 + #[derive(Clone)] [INFO] [stdout] 118 | pub struct Pile { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yama` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "80752073c05c890806b44d7972e6d033a28ba9b592b870cbff0f4c9544825f6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "80752073c05c890806b44d7972e6d033a28ba9b592b870cbff0f4c9544825f6e", kill_on_drop: false }` [INFO] [stdout] 80752073c05c890806b44d7972e6d033a28ba9b592b870cbff0f4c9544825f6e