[INFO] fetching crate xidlehook 0.10.0... [INFO] checking xidlehook-0.10.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate xidlehook 0.10.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate xidlehook 0.10.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xidlehook 0.10.0 [INFO] finished tweaking crates.io crate xidlehook 0.10.0 [INFO] tweaked toml for crates.io crate xidlehook 0.10.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate xidlehook 0.10.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bb2bc1333fff644f857f3258452212746c94ce253976ee3d22d635e246ea982b [INFO] running `Command { std: "docker" "start" "-a" "bb2bc1333fff644f857f3258452212746c94ce253976ee3d22d635e246ea982b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bb2bc1333fff644f857f3258452212746c94ce253976ee3d22d635e246ea982b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb2bc1333fff644f857f3258452212746c94ce253976ee3d22d635e246ea982b", kill_on_drop: false }` [INFO] [stdout] bb2bc1333fff644f857f3258452212746c94ce253976ee3d22d635e246ea982b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3483d031f713e0cd083aeacb37effee1ceab72ef5d090dae7f02f9d02122d687 [INFO] running `Command { std: "docker" "start" "-a" "3483d031f713e0cd083aeacb37effee1ceab72ef5d090dae7f02f9d02122d687", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.87 [INFO] [stderr] Compiling syn v1.0.60 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking futures-core v0.3.13 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling serde_derive v1.0.123 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking futures-sink v0.3.13 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Checking futures-channel v0.3.13 [INFO] [stderr] Checking futures-io v0.3.13 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking futures-task v0.3.13 [INFO] [stderr] Compiling nix v0.15.0 [INFO] [stderr] Checking pin-project-lite v0.2.5 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking once_cell v1.7.2 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling serde v1.0.123 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking pin-project-lite v0.1.12 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking regex-syntax v0.6.22 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Compiling libpulse-sys v1.18.0 [INFO] [stderr] Compiling x11 v2.18.2 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking signal-hook-registry v1.3.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Compiling xcb v0.9.0 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking regex v1.4.3 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Compiling futures-macro v0.3.13 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Compiling tokio-macros v0.2.6 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Checking tokio v0.2.25 [INFO] [stderr] Checking futures-util v0.3.13 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Checking libpulse-binding v2.23.0 [INFO] [stderr] Checking futures-executor v0.3.13 [INFO] [stderr] Checking futures v0.3.13 [INFO] [stderr] Checking xidlehook-core v0.3.0 [INFO] [stderr] Checking xidlehook v0.10.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `tokio::sync::mpsc::Sender<(models::Message, tokio::sync::oneshot::Sender)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:151:14 [INFO] [stdout] | [INFO] [stdout] 151 | let (socket_tx, socket_rx) = mpsc::channel(4); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 185 | / tokio::select! { [INFO] [stdout] 186 | | data = socket_msg => { [INFO] [stdout] 187 | | if let Some((msg, reply)) = data { [INFO] [stdout] 188 | | trace!("Got command over socket: {:#?}", msg); [INFO] [stdout] ... | [INFO] [stdout] 209 | | }, [INFO] [stdout] 210 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/main.rs:156:24 [INFO] [stdout] | [INFO] [stdout] 156 | if let Err(err) = socket::main_loop(&address, socket_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::sync::mpsc::Sender<(models::Message, tokio::sync::oneshot::Sender)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:151:14 [INFO] [stdout] | [INFO] [stdout] 151 | let (socket_tx, socket_rx) = mpsc::channel(4); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 185 | / tokio::select! { [INFO] [stdout] 186 | | data = socket_msg => { [INFO] [stdout] 187 | | if let Some((msg, reply)) = data { [INFO] [stdout] 188 | | trace!("Got command over socket: {:#?}", msg); [INFO] [stdout] ... | [INFO] [stdout] 209 | | }, [INFO] [stdout] 210 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/main.rs:156:24 [INFO] [stdout] | [INFO] [stdout] 156 | if let Err(err) = socket::main_loop(&address, socket_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xidlehook` (bin "xidlehook" test) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xidlehook` (bin "xidlehook") due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "3483d031f713e0cd083aeacb37effee1ceab72ef5d090dae7f02f9d02122d687", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3483d031f713e0cd083aeacb37effee1ceab72ef5d090dae7f02f9d02122d687", kill_on_drop: false }` [INFO] [stdout] 3483d031f713e0cd083aeacb37effee1ceab72ef5d090dae7f02f9d02122d687