[INFO] fetching crate witchcraft-metrics 1.0.1... [INFO] checking witchcraft-metrics-1.0.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate witchcraft-metrics 1.0.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate witchcraft-metrics 1.0.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate witchcraft-metrics 1.0.1 [INFO] finished tweaking crates.io crate witchcraft-metrics 1.0.1 [INFO] tweaked toml for crates.io crate witchcraft-metrics 1.0.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 41 packages to latest compatible versions [INFO] [stderr] Adding ordered-float v2.10.1 (available: v4.3.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a93788238dd28546d6d760167852d933c687ea6fb6519d444a6235f8af2d7a3f [INFO] running `Command { std: "docker" "start" "-a" "a93788238dd28546d6d760167852d933c687ea6fb6519d444a6235f8af2d7a3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a93788238dd28546d6d760167852d933c687ea6fb6519d444a6235f8af2d7a3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a93788238dd28546d6d760167852d933c687ea6fb6519d444a6235f8af2d7a3f", kill_on_drop: false }` [INFO] [stdout] a93788238dd28546d6d760167852d933c687ea6fb6519d444a6235f8af2d7a3f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8a2095b1e4df081c38d136fb469d4112e69e8f085f7e8c0ce3b19ea189ec6833 [INFO] running `Command { std: "docker" "start" "-a" "8a2095b1e4df081c38d136fb469d4112e69e8f085f7e8c0ce3b19ea189ec6833", kill_on_drop: false }` [INFO] [stderr] Checking assert_approx_eq v1.1.0 [INFO] [stderr] Checking ordered-float v4.3.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking exponential-decay-histogram v0.1.11 [INFO] [stderr] Checking witchcraft-metrics v1.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `parking_lot::lock_api::MutexGuard<'_, parking_lot::RawMutex, Arc, Metric>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:95:34 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn counter_with(&self, id: T, make_counter: F) -> Arc [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | match Arc::make_mut(&mut self.metrics.lock()).entry(Arc::new(id.into())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parking_lot::lock_api::MutexGuard<'_, parking_lot::RawMutex, Arc, Metric>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:130:34 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn meter_with(&self, id: T, make_meter: F) -> Arc [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | match Arc::make_mut(&mut self.metrics.lock()).entry(Arc::new(id.into())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parking_lot::lock_api::MutexGuard<'_, parking_lot::RawMutex, Arc, Metric>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:166:34 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn gauge_with(&self, id: T, make_gauge: F) -> Arc [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | match Arc::make_mut(&mut self.metrics.lock()).entry(Arc::new(id.into())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parking_lot::lock_api::MutexGuard<'_, parking_lot::RawMutex, Arc, Metric>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:212:34 [INFO] [stdout] | [INFO] [stdout] 207 | pub fn histogram_with(&self, id: T, make_histogram: F) -> Arc [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | match Arc::make_mut(&mut self.metrics.lock()).entry(Arc::new(id.into())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parking_lot::lock_api::MutexGuard<'_, parking_lot::RawMutex, Arc, Metric>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:252:34 [INFO] [stdout] | [INFO] [stdout] 247 | pub fn timer_with(&self, id: T, make_timer: F) -> Arc [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | match Arc::make_mut(&mut self.metrics.lock()).entry(Arc::new(id.into())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `witchcraft-metrics` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `parking_lot::lock_api::MutexGuard<'_, parking_lot::RawMutex, std::sync::Arc, registry::Metric>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:95:34 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn counter_with(&self, id: T, make_counter: F) -> Arc [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | match Arc::make_mut(&mut self.metrics.lock()).entry(Arc::new(id.into())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parking_lot::lock_api::MutexGuard<'_, parking_lot::RawMutex, std::sync::Arc, registry::Metric>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:130:34 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn meter_with(&self, id: T, make_meter: F) -> Arc [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | match Arc::make_mut(&mut self.metrics.lock()).entry(Arc::new(id.into())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parking_lot::lock_api::MutexGuard<'_, parking_lot::RawMutex, std::sync::Arc, registry::Metric>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:166:34 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn gauge_with(&self, id: T, make_gauge: F) -> Arc [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | match Arc::make_mut(&mut self.metrics.lock()).entry(Arc::new(id.into())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parking_lot::lock_api::MutexGuard<'_, parking_lot::RawMutex, std::sync::Arc, registry::Metric>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:212:34 [INFO] [stdout] | [INFO] [stdout] 207 | pub fn histogram_with(&self, id: T, make_histogram: F) -> Arc [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | match Arc::make_mut(&mut self.metrics.lock()).entry(Arc::new(id.into())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parking_lot::lock_api::MutexGuard<'_, parking_lot::RawMutex, std::sync::Arc, registry::Metric>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:252:34 [INFO] [stdout] | [INFO] [stdout] 247 | pub fn timer_with(&self, id: T, make_timer: F) -> Arc [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | match Arc::make_mut(&mut self.metrics.lock()).entry(Arc::new(id.into())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a module [INFO] [stdout] --> src/clock.rs:37:1 [INFO] [stdout] | [INFO] [stdout] 37 | pub mod test { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | #![warn(missing_docs)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a struct [INFO] [stdout] --> src/clock.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | pub struct TestClock { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for an associated function [INFO] [stdout] --> src/clock.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new() -> TestClock { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a method [INFO] [stdout] --> src/clock.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn advance(&self, dur: Duration) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `witchcraft-metrics` (lib test) due to 6 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8a2095b1e4df081c38d136fb469d4112e69e8f085f7e8c0ce3b19ea189ec6833", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a2095b1e4df081c38d136fb469d4112e69e8f085f7e8c0ce3b19ea189ec6833", kill_on_drop: false }` [INFO] [stdout] 8a2095b1e4df081c38d136fb469d4112e69e8f085f7e8c0ce3b19ea189ec6833