[INFO] fetching crate websocket 0.27.1... [INFO] checking websocket-0.27.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate websocket 0.27.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate websocket 0.27.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate websocket 0.27.1 [INFO] finished tweaking crates.io crate websocket 0.27.1 [INFO] tweaked toml for crates.io crate websocket 0.27.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate websocket 0.27.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0ea0efe23ff9a9ac42309bbdfc4c3795ff9d33805b77e0fd4cb81d5834e7f691 [INFO] running `Command { std: "docker" "start" "-a" "0ea0efe23ff9a9ac42309bbdfc4c3795ff9d33805b77e0fd4cb81d5834e7f691", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0ea0efe23ff9a9ac42309bbdfc4c3795ff9d33805b77e0fd4cb81d5834e7f691", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ea0efe23ff9a9ac42309bbdfc4c3795ff9d33805b77e0fd4cb81d5834e7f691", kill_on_drop: false }` [INFO] [stdout] 0ea0efe23ff9a9ac42309bbdfc4c3795ff9d33805b77e0fd4cb81d5834e7f691 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 33b60e231eb963038a0e1b3e21a950e0c2b77c5c181e1b7f1e1630be08ac0590 [INFO] running `Command { std: "docker" "start" "-a" "33b60e231eb963038a0e1b3e21a950e0c2b77c5c181e1b7f1e1630be08ac0590", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.117 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Compiling openssl v0.10.38 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking tokio-sync v0.1.8 [INFO] [stderr] Compiling openssl-sys v0.9.72 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling native-tls v0.2.8 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Compiling unicase v1.4.2 [INFO] [stderr] Checking block-padding v0.1.5 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking generic-array v0.12.4 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling httparse v1.5.1 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking tokio-codec v0.1.2 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking block-buffer v0.7.3 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Checking safemem v0.3.3 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking crossbeam-deque v0.7.4 [INFO] [stderr] Checking sha-1 v0.8.2 [INFO] [stderr] Checking base64 v0.9.3 [INFO] [stderr] Checking mime v0.2.6 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Checking traitobject v0.1.0 [INFO] [stderr] Checking typeable v0.1.2 [INFO] [stderr] Checking language-tags v0.2.2 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking hyper v0.10.16 [INFO] [stderr] Checking tokio-tls v0.2.1 [INFO] [stderr] Checking websocket-base v0.26.5 [INFO] [stderr] Checking websocket v0.27.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `tokio_codec::FramedParts` [INFO] [stdout] --> src/client/builder.rs:56:10 [INFO] [stdout] | [INFO] [stdout] 56 | pub use tokio_codec::FramedParts; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Framed` [INFO] [stdout] --> src/client/builder.rs:57:33 [INFO] [stdout] | [INFO] [stdout] 57 | pub use tokio_codec::{Decoder, Framed}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio_reactor::Handle` [INFO] [stdout] --> src/client/builder.rs:58:10 [INFO] [stdout] | [INFO] [stdout] 58 | pub use tokio_reactor::Handle; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio_codec::FramedParts` [INFO] [stdout] --> src/client/builder.rs:56:10 [INFO] [stdout] | [INFO] [stdout] 56 | pub use tokio_codec::FramedParts; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Framed` [INFO] [stdout] --> src/client/builder.rs:57:33 [INFO] [stdout] | [INFO] [stdout] 57 | pub use tokio_codec::{Decoder, Framed}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio_reactor::Handle` [INFO] [stdout] --> src/client/builder.rs:58:10 [INFO] [stdout] | [INFO] [stdout] 58 | pub use tokio_reactor::Handle; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/builder.rs:903:9 [INFO] [stdout] | [INFO] [stdout] 900 | cb: impl FnOnce(url::SocketAddrs) -> Box + Send>, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 903 | match self [INFO] [stdout] | _______________^ [INFO] [stdout] 904 | | .extract_host_port(secure) [INFO] [stdout] 905 | | .and_then(|p| Ok(p.to_socket_addrs()?)) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/builder.rs:903:9 [INFO] [stdout] | [INFO] [stdout] 900 | cb: impl FnOnce(url::SocketAddrs) -> Box + Send>, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 903 | match self [INFO] [stdout] | _______________^ [INFO] [stdout] 904 | | .extract_host_port(secure) [INFO] [stdout] 905 | | .and_then(|p| Ok(p.to_socket_addrs()?)) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), HyperIntoWsError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/upgrade/sync.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 187 | let request = parse_request(&mut reader); [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | match validate(&request.subject.0, request.version, &request.headers) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), HyperIntoWsError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/upgrade/sync.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 216 | fn into_ws(self) -> Result, Self::Error> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | match validate(&self.1.subject.0, self.1.version, &self.1.headers) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), upgrade::HyperIntoWsError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/upgrade/sync.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 187 | let request = parse_request(&mut reader); [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | match validate(&request.subject.0, request.version, &request.headers) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), upgrade::HyperIntoWsError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/upgrade/sync.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 216 | fn into_ws(self) -> Result, Self::Error> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | match validate(&self.1.subject.0, self.1.version, &self.1.headers) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `websocket` (lib) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `InvalidConnection` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/sync.rs:293:8 [INFO] [stdout] | [INFO] [stdout] 282 | let mut server = Server::bind("127.0.0.1:0").unwrap(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 289 | let result = server.accept(); [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 293 | Err(e) => match e.error { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `websocket` (lib test) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "33b60e231eb963038a0e1b3e21a950e0c2b77c5c181e1b7f1e1630be08ac0590", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "33b60e231eb963038a0e1b3e21a950e0c2b77c5c181e1b7f1e1630be08ac0590", kill_on_drop: false }` [INFO] [stdout] 33b60e231eb963038a0e1b3e21a950e0c2b77c5c181e1b7f1e1630be08ac0590