[INFO] fetching crate volaris-tools 0.0.4... [INFO] checking volaris-tools-0.0.4 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate volaris-tools 0.0.4 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate volaris-tools 0.0.4 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate volaris-tools 0.0.4 [INFO] finished tweaking crates.io crate volaris-tools 0.0.4 [INFO] tweaked toml for crates.io crate volaris-tools 0.0.4 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 82 packages to latest compatible versions [INFO] [stderr] Adding argon2 v0.4.1 (available: v0.5.3) [INFO] [stderr] Adding balloon-hash v0.3.0 (available: v0.4.0) [INFO] [stderr] Adding crypto-bigint v0.4.9 (available: v0.5.5) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding password-hash v0.4.2 (available: v0.5.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f45e7fbb237c70c5c5b2dbf721fb056885cb83f9292f6b06de0bd33d94ef9546 [INFO] running `Command { std: "docker" "start" "-a" "f45e7fbb237c70c5c5b2dbf721fb056885cb83f9292f6b06de0bd33d94ef9546", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f45e7fbb237c70c5c5b2dbf721fb056885cb83f9292f6b06de0bd33d94ef9546", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f45e7fbb237c70c5c5b2dbf721fb056885cb83f9292f6b06de0bd33d94ef9546", kill_on_drop: false }` [INFO] [stdout] f45e7fbb237c70c5c5b2dbf721fb056885cb83f9292f6b06de0bd33d94ef9546 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 84007cec4a79d32f30cf5a6668813a7a37bbdad2c8aa49637854fec51f42f1ab [INFO] running `Command { std: "docker" "start" "-a" "84007cec4a79d32f30cf5a6668813a7a37bbdad2c8aa49637854fec51f42f1ab", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking arrayref v0.3.9 [INFO] [stderr] Compiling zip v2.2.0 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling cc v1.1.22 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-bigint v0.4.9 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking password-hash v0.4.2 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling blake3 v1.5.4 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking balloon-hash v0.3.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking argon2 v0.4.1 [INFO] [stderr] Checking deoxys v0.1.0 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking volaris-crypto v0.0.3 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking volaris-tools v0.0.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/pack.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 73 | let options: zip::write::FileOptions<'_, ()> = FileOptions::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | unused_qualifications, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 73 - let options: zip::write::FileOptions<'_, ()> = FileOptions::default() [INFO] [stdout] 73 + let options: FileOptions<'_, ()> = FileOptions::default() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/pack.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 73 | let options: zip::write::FileOptions<'_, ()> = FileOptions::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | unused_qualifications, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 73 - let options: zip::write::FileOptions<'_, ()> = FileOptions::default() [INFO] [stdout] 73 + let options: FileOptions<'_, ()> = FileOptions::default() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, volaris_tools::storage::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/storage.rs:12:11 [INFO] [stdout] | [INFO] [stdout] 10 | let stor = TestFileStorage::new(1); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | [INFO] [stdout] 12 | match stor.create_file("hello_1.txt") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, volaris_tools::storage::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/storage.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 23 | let stor = TestFileStorage::new(2); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | match stor.create_file("hello_2.txt") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, volaris_tools::storage::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/storage.rs:36:11 [INFO] [stdout] | [INFO] [stdout] 34 | let stor = TestFileStorage::new(3); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | [INFO] [stdout] 36 | match stor.read_file("hello_3.txt") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, volaris_tools::storage::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/storage.rs:46:11 [INFO] [stdout] | [INFO] [stdout] 44 | let stor = TestFileStorage::new(4); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | [INFO] [stdout] 46 | match stor.write_file("hello_4.txt") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, volaris_tools::storage::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/storage.rs:57:11 [INFO] [stdout] | [INFO] [stdout] 54 | let stor = TestFileStorage::new(5); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | match stor.read_file("hello_5.txt") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, volaris_tools::storage::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/storage.rs:78:11 [INFO] [stdout] | [INFO] [stdout] 75 | let stor = TestFileStorage::new(6); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | match stor.write_file("hello_6.txt") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/storage.rs:134:24 [INFO] [stdout] | [INFO] [stdout] 128 | let stor = TestFileStorage::new(8); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | Ok(_) => match fs::File::open("hello_8.txt") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/storage.rs:150:24 [INFO] [stdout] | [INFO] [stdout] 144 | let stor = TestFileStorage::new(9); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | Ok(_) => match fs::File::open("hello_9.txt") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, volaris_tools::storage::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/storage.rs:179:11 [INFO] [stdout] | [INFO] [stdout] 176 | let stor = TestFileStorage::new(11); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | match stor.read_file("bar_11/foo/") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Result, Result)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/storage.rs:194:25 [INFO] [stdout] | [INFO] [stdout] 187 | let stor = TestFileStorage::new(12); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | Ok(()) => match (fs::read_dir("bar_12/"), fs::read_dir("bar_12/foo/")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Result, Result)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/storage.rs:211:25 [INFO] [stdout] | [INFO] [stdout] 204 | let stor = TestFileStorage::new(13); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | Ok(()) => match (fs::read_dir("bar_13/"), fs::read_dir("bar_13/foo/")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result>, volaris_tools::storage::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/storage.rs:227:11 [INFO] [stdout] | [INFO] [stdout] 221 | let stor = TestFileStorage::new(14); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | let file = stor.read_file("bar_14/").unwrap(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | [INFO] [stdout] 227 | match stor.read_dir(&file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result>, volaris_tools::storage::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/storage.rs:257:11 [INFO] [stdout] | [INFO] [stdout] 251 | let stor = TestFileStorage::new(15); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 255 | let file = stor.read_file("bar_15/").unwrap(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 256 | [INFO] [stdout] 257 | match stor.read_dir(&file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `volaris-tools` (test "storage") due to 14 previous errors [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "84007cec4a79d32f30cf5a6668813a7a37bbdad2c8aa49637854fec51f42f1ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "84007cec4a79d32f30cf5a6668813a7a37bbdad2c8aa49637854fec51f42f1ab", kill_on_drop: false }` [INFO] [stdout] 84007cec4a79d32f30cf5a6668813a7a37bbdad2c8aa49637854fec51f42f1ab