[INFO] fetching crate viz-core 0.8.8... [INFO] checking viz-core-0.8.8 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate viz-core 0.8.8 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate viz-core 0.8.8 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate viz-core 0.8.8 [INFO] finished tweaking crates.io crate viz-core 0.8.8 [INFO] tweaked toml for crates.io crate viz-core 0.8.8 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 140 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.21.7 (available: v0.22.1) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding opentelemetry v0.23.0 (available: v0.25.0) [INFO] [stderr] Adding opentelemetry-semantic-conventions v0.15.0 (available: v0.25.0) [INFO] [stderr] Adding tokio-tungstenite v0.21.0 (available: v0.24.0) [INFO] [stderr] Adding tungstenite v0.21.0 (available: v0.24.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f8033e26d5300c26ce0f071a3ac0e471ce3d6b574dcc9100d97c024004409f33 [INFO] running `Command { std: "docker" "start" "-a" "f8033e26d5300c26ce0f071a3ac0e471ce3d6b574dcc9100d97c024004409f33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f8033e26d5300c26ce0f071a3ac0e471ce3d6b574dcc9100d97c024004409f33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f8033e26d5300c26ce0f071a3ac0e471ce3d6b574dcc9100d97c024004409f33", kill_on_drop: false }` [INFO] [stdout] f8033e26d5300c26ce0f071a3ac0e471ce3d6b574dcc9100d97c024004409f33 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 96558b580d0451d186fddfbca1bcb5d3ed16a7ea69098dfd73f76fc99ef32588 [INFO] running `Command { std: "docker" "start" "-a" "96558b580d0451d186fddfbca1bcb5d3ed16a7ea69098dfd73f76fc99ef32588", kill_on_drop: false }` [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling uncased v0.9.10 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling cookie v0.18.1 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking headers-core v0.3.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking rfc7239 v0.1.1 [INFO] [stderr] Checking headers v0.4.0 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.9 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking form-data v0.5.5 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking sessions-core v0.6.0 [INFO] [stderr] Checking viz-core v0.8.8 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::result::Result, PoisonError>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/cookie.rs:54:28 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn remove(&self, name: impl AsRef) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | if let Ok(mut c) = self.jar().lock() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result, PoisonError>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/cookie.rs:128:28 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn private_remove(&self, name: impl AsRef) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | if let Ok(mut c) = self.jar().lock() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result, PayloadError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/json.rs:101:15 [INFO] [stdout] | [INFO] [stdout] 100 | fn into_response(self) -> Response { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | match Response::json(self.0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result, PoisonError>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/cookie.rs:54:28 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn remove(&self, name: impl AsRef) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | if let Ok(mut c) = self.jar().lock() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result, PoisonError>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/cookie.rs:128:28 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn private_remove(&self, name: impl AsRef) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | if let Ok(mut c) = self.jar().lock() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result, PayloadError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/json.rs:101:15 [INFO] [stdout] | [INFO] [stdout] 100 | fn into_response(self) -> Response { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | match Response::json(self.0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `viz-core` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `viz-core` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "96558b580d0451d186fddfbca1bcb5d3ed16a7ea69098dfd73f76fc99ef32588", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96558b580d0451d186fddfbca1bcb5d3ed16a7ea69098dfd73f76fc99ef32588", kill_on_drop: false }` [INFO] [stdout] 96558b580d0451d186fddfbca1bcb5d3ed16a7ea69098dfd73f76fc99ef32588