[INFO] fetching crate vhost-device-scmi 0.2.0... [INFO] checking vhost-device-scmi-0.2.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate vhost-device-scmi 0.2.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate vhost-device-scmi 0.2.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vhost-device-scmi 0.2.0 [INFO] finished tweaking crates.io crate vhost-device-scmi 0.2.0 [INFO] tweaked toml for crates.io crate vhost-device-scmi 0.2.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate vhost-device-scmi 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 68ebb2a504fae156eafa9a7fe95b75a3563d11ef5fe630e053d89f142ce407eb [INFO] running `Command { std: "docker" "start" "-a" "68ebb2a504fae156eafa9a7fe95b75a3563d11ef5fe630e053d89f142ce407eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "68ebb2a504fae156eafa9a7fe95b75a3563d11ef5fe630e053d89f142ce407eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "68ebb2a504fae156eafa9a7fe95b75a3563d11ef5fe630e053d89f142ce407eb", kill_on_drop: false }` [INFO] [stdout] 68ebb2a504fae156eafa9a7fe95b75a3563d11ef5fe630e053d89f142ce407eb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1cb7d6106d3ac8f209d4c013a5695b615e28675b189ceb70d04a624792fd8b40 [INFO] running `Command { std: "docker" "start" "-a" "1cb7d6106d3ac8f209d4c013a5695b615e28675b189ceb70d04a624792fd8b40", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking virtio-bindings v0.2.2 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking clap_builder v4.5.9 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.46 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking vmm-sys-util v0.12.1 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling clap_derive v4.5.8 [INFO] [stderr] Checking vm-memory v0.14.1 [INFO] [stderr] Checking vhost v0.11.0 [INFO] [stderr] Checking virtio-queue v0.12.0 [INFO] [stderr] Checking clap v4.5.9 [INFO] [stderr] Checking vhost-user-backend v0.15.0 [INFO] [stderr] Checking vhost-device-scmi v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/devices/common.rs:67:60 [INFO] [stdout] | [INFO] [stdout] 67 | fn extra<'a>(&'a self, allowed: &[&'a str]) -> HashSet<&str> { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/devices/common.rs:72:63 [INFO] [stdout] | [INFO] [stdout] 72 | fn missing<'a>(&'a self, required: &[&'a str]) -> HashSet<&str> { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/devices/common.rs:67:60 [INFO] [stdout] | [INFO] [stdout] 67 | fn extra<'a>(&'a self, allowed: &[&'a str]) -> HashSet<&str> { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/devices/common.rs:72:63 [INFO] [stdout] | [INFO] [stdout] 72 | fn missing<'a>(&'a self, required: &[&'a str]) -> HashSet<&str> { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `HashSet<&str>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/devices/common.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 68 | let allowed_set: HashSet<&str> = HashSet::from_iter(allowed.iter().copied()); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | self.names().difference(&allowed_set).copied().collect() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `HashSet<&str>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/devices/common.rs:74:34 [INFO] [stdout] | [INFO] [stdout] 73 | let required_set: HashSet<&str> = HashSet::from_iter(required.iter().copied()); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | required_set.difference(&self.names()).copied().collect() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `invalid_property` and `process_property` are never used [INFO] [stdout] --> src/devices/common.rs:301:8 [INFO] [stdout] | [INFO] [stdout] 276 | pub trait SensorT: Send { [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 301 | fn invalid_property(&self, name: &str) -> Result<(), DeviceError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 308 | fn process_property(&mut self, name: &str, _value: &str) -> Result<(), DeviceError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::collections::HashSet<&str>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/devices/common.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 68 | let allowed_set: HashSet<&str> = HashSet::from_iter(allowed.iter().copied()); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | self.names().difference(&allowed_set).copied().collect() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::collections::HashSet<&str>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/devices/common.rs:74:34 [INFO] [stdout] | [INFO] [stdout] 73 | let required_set: HashSet<&str> = HashSet::from_iter(required.iter().copied()); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | required_set.difference(&self.names()).copied().collect() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vhost-device-scmi` (bin "vhost-device-scmi") due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `AvailIter<'_, GuestMemoryLoadGuard>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vhu_scmi.rs:491:9 [INFO] [stdout] | [INFO] [stdout] 460 | let mem = &GuestMemoryMmap::<()>::from_ranges(&[(GuestAddress(0), 0x1000)]).unwrap(); [INFO] [stdout] | ------------------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 491 | / vq.create_queue::() [INFO] [stdout] 492 | | .unwrap() [INFO] [stdout] 493 | | .iter(GuestMemoryAtomic::new(mem.clone()).memory()) [INFO] [stdout] 494 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `AvailIter<'_, GuestMemoryLoadGuard>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vhu_scmi.rs:515:9 [INFO] [stdout] | [INFO] [stdout] 500 | let mem = &GuestMemoryMmap::<()>::from_ranges(&[(GuestAddress(0), 0x1000)]).unwrap(); [INFO] [stdout] | ------------------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 515 | / vq.create_queue::() [INFO] [stdout] 516 | | .unwrap() [INFO] [stdout] 517 | | .iter(GuestMemoryAtomic::new(mem.clone()).memory()) [INFO] [stdout] 518 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `AvailIter<'_, GuestMemoryLoadGuard>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vhu_scmi.rs:555:9 [INFO] [stdout] | [INFO] [stdout] 530 | let mem = &GuestMemoryMmap::<()>::from_ranges(&[(GuestAddress(0), 0x1000)]).unwrap(); [INFO] [stdout] | ------------------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 555 | / vq.create_queue::() [INFO] [stdout] 556 | | .unwrap() [INFO] [stdout] 557 | | .iter(GuestMemoryAtomic::new(mem.clone()).memory()) [INFO] [stdout] 558 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `invalid_property` and `process_property` are never used [INFO] [stdout] --> src/devices/common.rs:301:8 [INFO] [stdout] | [INFO] [stdout] 276 | pub trait SensorT: Send { [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 301 | fn invalid_property(&self, name: &str) -> Result<(), DeviceError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 308 | fn process_property(&mut self, name: &str, _value: &str) -> Result<(), DeviceError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vhost-device-scmi` (bin "vhost-device-scmi" test) due to 6 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1cb7d6106d3ac8f209d4c013a5695b615e28675b189ceb70d04a624792fd8b40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1cb7d6106d3ac8f209d4c013a5695b615e28675b189ceb70d04a624792fd8b40", kill_on_drop: false }` [INFO] [stdout] 1cb7d6106d3ac8f209d4c013a5695b615e28675b189ceb70d04a624792fd8b40