[INFO] fetching crate vex-rt-macros 1.0.0-rc.5... [INFO] checking vex-rt-macros-1.0.0-rc.5 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate vex-rt-macros 1.0.0-rc.5 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate vex-rt-macros 1.0.0-rc.5 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vex-rt-macros 1.0.0-rc.5 [INFO] finished tweaking crates.io crate vex-rt-macros 1.0.0-rc.5 [INFO] tweaked toml for crates.io crate vex-rt-macros 1.0.0-rc.5 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 16 packages to latest compatible versions [INFO] [stderr] Adding bitmaps v2.1.0 (available: v3.2.1) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding sized-chunks v0.6.5 (available: v0.7.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5116ff584700fe8ce981dbeeec23d5196a58bfdb2076a446af29a8fe0caeafd7 [INFO] running `Command { std: "docker" "start" "-a" "5116ff584700fe8ce981dbeeec23d5196a58bfdb2076a446af29a8fe0caeafd7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5116ff584700fe8ce981dbeeec23d5196a58bfdb2076a446af29a8fe0caeafd7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5116ff584700fe8ce981dbeeec23d5196a58bfdb2076a446af29a8fe0caeafd7", kill_on_drop: false }` [INFO] [stdout] 5116ff584700fe8ce981dbeeec23d5196a58bfdb2076a446af29a8fe0caeafd7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a0af01aaa1ce373909b7fa9a8a5d9b78f7c3894e08d4063b35905bf4be3e23fa [INFO] running `Command { std: "docker" "start" "-a" "a0af01aaa1ce373909b7fa9a8a5d9b78f7c3894e08d4063b35905bf4be3e23fa", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling im v15.1.0 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking bitmaps v2.1.0 [INFO] [stderr] Checking sized-chunks v0.6.5 [INFO] [stderr] Checking generics-util v0.1.0 [INFO] [stderr] Checking vex-rt-macros v1.0.0-rc.5 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_machine/input.rs:203:20 [INFO] [stdout] | [INFO] [stdout] 201 | let paren_content; [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | Ok(Self { [INFO] [stdout] 203 | attrs: Attribute::parse_outer(input)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 204 | ident: Ident::parse(input)?, [INFO] [stdout] 205 | paren_token: parenthesized!(paren_content in input), [INFO] [stdout] | -------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_machine/mod.rs:316:16 [INFO] [stdout] | [INFO] [stdout] 287 | state_generics_args: PathArguments, [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | let shared_option = shared_vars [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | attrs: attrs.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 321 | fields: Fields::Unnamed(parse_quote!(( [INFO] [stdout] | _________________________________- [INFO] [stdout] | |_________________________________| [INFO] [stdout] | |_________________________________| [INFO] [stdout] 322 | | #crate_::machine::StateMachineHandle<#state_ident #state_generics_args>, [INFO] [stdout] 323 | | ::core::marker::PhantomData<(#(#phantom_vars,)*)>, [INFO] [stdout] 324 | | #shared_option [INFO] [stdout] 325 | | ))), [INFO] [stdout] | | - [INFO] [stdout] | |__________| [INFO] [stdout] | |__________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_machine/input.rs:203:20 [INFO] [stdout] | [INFO] [stdout] 201 | let paren_content; [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | Ok(Self { [INFO] [stdout] 203 | attrs: Attribute::parse_outer(input)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 204 | ident: Ident::parse(input)?, [INFO] [stdout] 205 | paren_token: parenthesized!(paren_content in input), [INFO] [stdout] | -------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_machine/mod.rs:316:16 [INFO] [stdout] | [INFO] [stdout] 287 | state_generics_args: PathArguments, [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | let shared_option = shared_vars [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | attrs: attrs.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 321 | fields: Fields::Unnamed(parse_quote!(( [INFO] [stdout] | _________________________________- [INFO] [stdout] | |_________________________________| [INFO] [stdout] | |_________________________________| [INFO] [stdout] 322 | | #crate_::machine::StateMachineHandle<#state_ident #state_generics_args>, [INFO] [stdout] 323 | | ::core::marker::PhantomData<(#(#phantom_vars,)*)>, [INFO] [stdout] 324 | | #shared_option [INFO] [stdout] 325 | | ))), [INFO] [stdout] | | - [INFO] [stdout] | |__________| [INFO] [stdout] | |__________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `eq` is never read [INFO] [stdout] --> src/state_machine/attributes.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct StackDepthAttr { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 8 | pub eq: Token![=], [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `StackDepthAttr` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `semi_token` is never read [INFO] [stdout] --> src/state_machine/input.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct Input { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 17 | pub crate_: Path, [INFO] [stdout] 18 | pub semi_token: Token![;], [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Input` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `eq_token` is never read [INFO] [stdout] --> src/state_machine/input.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 132 | pub struct Var { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 135 | pub eq_token: Token![=], [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Var` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `eq_token` and `semi_token` are never read [INFO] [stdout] --> src/state_machine/input.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 151 | pub struct InitialState { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 152 | pub eq_token: Token![=], [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 156 | pub semi_token: Token![;], [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `InitialState` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `comma_token` is never read [INFO] [stdout] --> src/state_machine/input.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 188 | pub struct State { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 193 | pub comma_token: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `State` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/state_machine/input.rs:63:44 [INFO] [stdout] | [INFO] [stdout] 63 | while let Ok(state) = input.clone().parse() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ParseBuffer<'_>` does not implement `Clone`, so calling `clone` on `&ParseBuffer<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 63 - while let Ok(state) = input.clone().parse() { [INFO] [stdout] 63 + while let Ok(state) = input.parse() { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ParseBuffer<'_>`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/syn-1.0.109/src/parse.rs:252:1 [INFO] [stdout] | [INFO] [stdout] 252+ #[derive(Clone)] [INFO] [stdout] 253| pub struct ParseBuffer<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vex-rt-macros` (lib test) due to 3 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `eq` is never read [INFO] [stdout] --> src/state_machine/attributes.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct StackDepthAttr { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 8 | pub eq: Token![=], [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `StackDepthAttr` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `semi_token` is never read [INFO] [stdout] --> src/state_machine/input.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct Input { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 17 | pub crate_: Path, [INFO] [stdout] 18 | pub semi_token: Token![;], [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Input` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `eq_token` is never read [INFO] [stdout] --> src/state_machine/input.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 132 | pub struct Var { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 135 | pub eq_token: Token![=], [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Var` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `eq_token` and `semi_token` are never read [INFO] [stdout] --> src/state_machine/input.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 151 | pub struct InitialState { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 152 | pub eq_token: Token![=], [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 156 | pub semi_token: Token![;], [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `InitialState` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `comma_token` is never read [INFO] [stdout] --> src/state_machine/input.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 188 | pub struct State { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 193 | pub comma_token: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `State` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/state_machine/input.rs:63:44 [INFO] [stdout] | [INFO] [stdout] 63 | while let Ok(state) = input.clone().parse() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ParseBuffer<'_>` does not implement `Clone`, so calling `clone` on `&ParseBuffer<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 63 - while let Ok(state) = input.clone().parse() { [INFO] [stdout] 63 + while let Ok(state) = input.parse() { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ParseBuffer<'_>`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/syn-1.0.109/src/parse.rs:252:1 [INFO] [stdout] | [INFO] [stdout] 252+ #[derive(Clone)] [INFO] [stdout] 253| pub struct ParseBuffer<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vex-rt-macros` (lib) due to 3 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a0af01aaa1ce373909b7fa9a8a5d9b78f7c3894e08d4063b35905bf4be3e23fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a0af01aaa1ce373909b7fa9a8a5d9b78f7c3894e08d4063b35905bf4be3e23fa", kill_on_drop: false }` [INFO] [stdout] a0af01aaa1ce373909b7fa9a8a5d9b78f7c3894e08d4063b35905bf4be3e23fa