[INFO] fetching crate valence_protocol_macros 0.2.0-alpha.1+mc.1.20.1... [INFO] checking valence_protocol_macros-0.2.0-alpha.1+mc.1.20.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate valence_protocol_macros 0.2.0-alpha.1+mc.1.20.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate valence_protocol_macros 0.2.0-alpha.1+mc.1.20.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate valence_protocol_macros 0.2.0-alpha.1+mc.1.20.1 [INFO] finished tweaking crates.io crate valence_protocol_macros 0.2.0-alpha.1+mc.1.20.1 [INFO] tweaked toml for crates.io crate valence_protocol_macros 0.2.0-alpha.1+mc.1.20.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 93a1a99d9d43aba8b316818ad3c67764b7f2ef6f4ea60a341436a8790aa37ce7 [INFO] running `Command { std: "docker" "start" "-a" "93a1a99d9d43aba8b316818ad3c67764b7f2ef6f4ea60a341436a8790aa37ce7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "93a1a99d9d43aba8b316818ad3c67764b7f2ef6f4ea60a341436a8790aa37ce7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93a1a99d9d43aba8b316818ad3c67764b7f2ef6f4ea60a341436a8790aa37ce7", kill_on_drop: false }` [INFO] [stdout] 93a1a99d9d43aba8b316818ad3c67764b7f2ef6f4ea60a341436a8790aa37ce7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5e38703a6c151cddc4ab8df09d7eda94fffa3d342a3eb193d9b97942309f59f3 [INFO] running `Command { std: "docker" "start" "-a" "5e38703a6c151cddc4ab8df09d7eda94fffa3d342a3eb193d9b97942309f59f3", kill_on_drop: false }` [INFO] [stderr] Checking valence_protocol_macros v0.2.0-alpha.1+mc.1.20.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `DataStruct` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode.rs:30:22 [INFO] [stdout] | [INFO] [stdout] 9 | let mut input = parse2::(item)?; [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Data::Struct(struct_) => { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 41 | / quote! { [INFO] [stdout] 42 | | Self { [INFO] [stdout] 43 | | #(#init)* [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `DataStruct` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode.rs:30:22 [INFO] [stdout] | [INFO] [stdout] 9 | let mut input = parse2::(item)?; [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Data::Struct(struct_) => { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 41 | / quote! { [INFO] [stdout] 42 | | Self { [INFO] [stdout] 43 | | #(#init)* [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `proc_macro2::TokenStream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encode.rs:82:33 [INFO] [stdout] | [INFO] [stdout] 82 | ... let encode_fields = field_names [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 96 | / ... quote! { [INFO] [stdout] 97 | | ... Self::#variant_name { #(#field_names,)* } => { [INFO] [stdout] 98 | | ... VarInt(#disc).encode(&mut _w).context(#disc_ctx)?; [INFO] [stdout] ... | [INFO] [stdout] 102 | | ... } [INFO] [stdout] 103 | | ... } [INFO] [stdout] | | - [INFO] [stdout] | |_______________________| [INFO] [stdout] | |_______________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | / ... quote! { [INFO] [stdout] 125 | | ... Self::#variant_name(#(#field_names,)*) => { [INFO] [stdout] 126 | | ... VarInt(#disc).encode(&mut _w).context(#disc_ctx)?; [INFO] [stdout] ... | [INFO] [stdout] 130 | | ... } [INFO] [stdout] 131 | | ... } [INFO] [stdout] | | - [INFO] [stdout] | |_______________________| [INFO] [stdout] | |_______________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `proc_macro2::TokenStream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encode.rs:82:33 [INFO] [stdout] | [INFO] [stdout] 82 | ... let encode_fields = field_names [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 96 | / ... quote! { [INFO] [stdout] 97 | | ... Self::#variant_name { #(#field_names,)* } => { [INFO] [stdout] 98 | | ... VarInt(#disc).encode(&mut _w).context(#disc_ctx)?; [INFO] [stdout] ... | [INFO] [stdout] 102 | | ... } [INFO] [stdout] 103 | | ... } [INFO] [stdout] | | - [INFO] [stdout] | |_______________________| [INFO] [stdout] | |_______________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | / ... quote! { [INFO] [stdout] 125 | | ... Self::#variant_name(#(#field_names,)*) => { [INFO] [stdout] 126 | | ... VarInt(#disc).encode(&mut _w).context(#disc_ctx)?; [INFO] [stdout] ... | [INFO] [stdout] 130 | | ... } [INFO] [stdout] 131 | | ... } [INFO] [stdout] | | - [INFO] [stdout] | |_______________________| [INFO] [stdout] | |_______________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `valence_protocol_macros` (lib test) due to 3 previous errors [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `valence_protocol_macros` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "5e38703a6c151cddc4ab8df09d7eda94fffa3d342a3eb193d9b97942309f59f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e38703a6c151cddc4ab8df09d7eda94fffa3d342a3eb193d9b97942309f59f3", kill_on_drop: false }` [INFO] [stdout] 5e38703a6c151cddc4ab8df09d7eda94fffa3d342a3eb193d9b97942309f59f3