[INFO] fetching crate unsafe_target_feature 0.1.1... [INFO] checking unsafe_target_feature-0.1.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate unsafe_target_feature 0.1.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate unsafe_target_feature 0.1.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate unsafe_target_feature 0.1.1 [INFO] finished tweaking crates.io crate unsafe_target_feature 0.1.1 [INFO] tweaked toml for crates.io crate unsafe_target_feature 0.1.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d55f04b988cc9ce512f06ec955c387c91e575cc0add64f1616fe7c8fd90cb3bb [INFO] running `Command { std: "docker" "start" "-a" "d55f04b988cc9ce512f06ec955c387c91e575cc0add64f1616fe7c8fd90cb3bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d55f04b988cc9ce512f06ec955c387c91e575cc0add64f1616fe7c8fd90cb3bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d55f04b988cc9ce512f06ec955c387c91e575cc0add64f1616fe7c8fd90cb3bb", kill_on_drop: false }` [INFO] [stdout] d55f04b988cc9ce512f06ec955c387c91e575cc0add64f1616fe7c8fd90cb3bb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8c997d4d76cad45ea23ac24b842a7f28a6f28fed18c198fb671858d8086126de [INFO] running `Command { std: "docker" "start" "-a" "8c997d4d76cad45ea23ac24b842a7f28a6f28fed18c198fb671858d8086126de", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.79 [INFO] [stderr] Checking unsafe_target_feature v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Generics` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:420:18 [INFO] [stdout] | [INFO] [stdout] 292 | function: syn::ItemFn, [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | outer: Option<(syn::Generics, Box)>, [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | let function_visibility = function.vis; [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 309 | let function_name = function.sig.ident; [INFO] [stdout] 310 | let function_return = function.sig.output; [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 313 | let function_args = function.sig.inputs; [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 314 | let function_body = function.block; [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 315 | let mut function_call_args = Vec::new(); [INFO] [stdout] 316 | let mut function_args_outer = Vec::new(); [INFO] [stdout] | ----------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | let mut function_args_inner = Vec::new(); [INFO] [stdout] | ----------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 382 | let mut maybe_inline = quote::quote! {}; [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 383 | let mut maybe_outer_attributes = Vec::new(); [INFO] [stdout] | -------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 384 | let mut maybe_cfg = quote::quote! {}; [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 420 | if let Some((generics, self_ty)) = outer { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 425 | let item_trait = quote::quote! { [INFO] [stdout] | __________________________- [INFO] [stdout] | |__________________________| [INFO] [stdout] | |__________________________| [INFO] [stdout] 426 | | #[allow(non_camel_case_types)] [INFO] [stdout] 427 | | trait #trait_ident #outer_impl_generics #outer_where_clause { [INFO] [stdout] 428 | | unsafe fn #function_inner_name #fn_impl_generics (#(#function_args_outer),*) #function_return #fn_where_clause; [INFO] [stdout] 429 | | } [INFO] [stdout] 430 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 431 | [INFO] [stdout] 432 | let item_trait_impl = quote::quote! { [INFO] [stdout] | _______________________________- [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] 433 | | impl #outer_impl_generics #trait_ident #outer_ty_generics for #self_ty #outer_where_clause { [INFO] [stdout] 434 | | #[target_feature(enable = #attributes)] [INFO] [stdout] 435 | | #maybe_inline [INFO] [stdout] 436 | | unsafe fn #function_inner_name #fn_impl_generics (#(#function_args_inner),*) #function_return #fn_where_clause #f... [INFO] [stdout] 437 | | } [INFO] [stdout] 438 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 439 | [INFO] [stdout] 440 | / quote::quote! { [INFO] [stdout] 441 | | #[inline(always)] [INFO] [stdout] 442 | | #(#maybe_outer_attributes)* [INFO] [stdout] 443 | | #function_visibility fn #function_name #fn_impl_generics (#(#function_args_outer),*) #function_return #fn_where_clause { [INFO] [stdout] ... | [INFO] [stdout] 449 | | } [INFO] [stdout] 450 | | }.into() [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 451 | } else { [INFO] [stdout] 452 | / quote::quote! { [INFO] [stdout] 453 | | #[inline(always)] [INFO] [stdout] 454 | | #maybe_cfg [INFO] [stdout] 455 | | #(#maybe_outer_attributes)* [INFO] [stdout] ... | [INFO] [stdout] 463 | | } [INFO] [stdout] 464 | | }.into() [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `unsafe_target_feature` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Generics` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:420:18 [INFO] [stdout] | [INFO] [stdout] 292 | function: syn::ItemFn, [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | outer: Option<(syn::Generics, Box)>, [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | let function_visibility = function.vis; [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 309 | let function_name = function.sig.ident; [INFO] [stdout] 310 | let function_return = function.sig.output; [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 313 | let function_args = function.sig.inputs; [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 314 | let function_body = function.block; [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 315 | let mut function_call_args = Vec::new(); [INFO] [stdout] 316 | let mut function_args_outer = Vec::new(); [INFO] [stdout] | ----------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | let mut function_args_inner = Vec::new(); [INFO] [stdout] | ----------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 382 | let mut maybe_inline = quote::quote! {}; [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 383 | let mut maybe_outer_attributes = Vec::new(); [INFO] [stdout] | -------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 384 | let mut maybe_cfg = quote::quote! {}; [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 420 | if let Some((generics, self_ty)) = outer { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 425 | let item_trait = quote::quote! { [INFO] [stdout] | __________________________- [INFO] [stdout] | |__________________________| [INFO] [stdout] | |__________________________| [INFO] [stdout] 426 | | #[allow(non_camel_case_types)] [INFO] [stdout] 427 | | trait #trait_ident #outer_impl_generics #outer_where_clause { [INFO] [stdout] 428 | | unsafe fn #function_inner_name #fn_impl_generics (#(#function_args_outer),*) #function_return #fn_where_clause; [INFO] [stdout] 429 | | } [INFO] [stdout] 430 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 431 | [INFO] [stdout] 432 | let item_trait_impl = quote::quote! { [INFO] [stdout] | _______________________________- [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] 433 | | impl #outer_impl_generics #trait_ident #outer_ty_generics for #self_ty #outer_where_clause { [INFO] [stdout] 434 | | #[target_feature(enable = #attributes)] [INFO] [stdout] 435 | | #maybe_inline [INFO] [stdout] 436 | | unsafe fn #function_inner_name #fn_impl_generics (#(#function_args_inner),*) #function_return #fn_where_clause #f... [INFO] [stdout] 437 | | } [INFO] [stdout] 438 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 439 | [INFO] [stdout] 440 | / quote::quote! { [INFO] [stdout] 441 | | #[inline(always)] [INFO] [stdout] 442 | | #(#maybe_outer_attributes)* [INFO] [stdout] 443 | | #function_visibility fn #function_name #fn_impl_generics (#(#function_args_outer),*) #function_return #fn_where_clause { [INFO] [stdout] ... | [INFO] [stdout] 449 | | } [INFO] [stdout] 450 | | }.into() [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 451 | } else { [INFO] [stdout] 452 | / quote::quote! { [INFO] [stdout] 453 | | #[inline(always)] [INFO] [stdout] 454 | | #maybe_cfg [INFO] [stdout] 455 | | #(#maybe_outer_attributes)* [INFO] [stdout] ... | [INFO] [stdout] 463 | | } [INFO] [stdout] 464 | | }.into() [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `unsafe_target_feature` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "8c997d4d76cad45ea23ac24b842a7f28a6f28fed18c198fb671858d8086126de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c997d4d76cad45ea23ac24b842a7f28a6f28fed18c198fb671858d8086126de", kill_on_drop: false }` [INFO] [stdout] 8c997d4d76cad45ea23ac24b842a7f28a6f28fed18c198fb671858d8086126de