[INFO] fetching crate unconst 0.10.0... [INFO] checking unconst-0.10.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate unconst 0.10.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate unconst 0.10.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate unconst 0.10.0 [INFO] finished tweaking crates.io crate unconst 0.10.0 [INFO] tweaked toml for crates.io crate unconst 0.10.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6d16ed1c8317122f48c09025b929fa34208b3901688a04a5225b58711baea4b7 [INFO] running `Command { std: "docker" "start" "-a" "6d16ed1c8317122f48c09025b929fa34208b3901688a04a5225b58711baea4b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6d16ed1c8317122f48c09025b929fa34208b3901688a04a5225b58711baea4b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d16ed1c8317122f48c09025b929fa34208b3901688a04a5225b58711baea4b7", kill_on_drop: false }` [INFO] [stdout] 6d16ed1c8317122f48c09025b929fa34208b3901688a04a5225b58711baea4b7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b395a1465b7decc4a4a1ea0989deadc408ff2b1bf165bd4b2c9c2f450b0924df [INFO] running `Command { std: "docker" "start" "-a" "b395a1465b7decc4a4a1ea0989deadc408ff2b1bf165bd4b2c9c2f450b0924df", kill_on_drop: false }` [INFO] [stderr] Checking syn v2.0.79 [INFO] [stderr] Checking unconst v0.10.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `syn::Item` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unconst.rs:16:11 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn unconst(_attr: TokenStream, item: TokenStream) -> TokenStream { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | match parse::(item).unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/unconst/impl_const.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 202 | fn fmt(&self, formatter: &mut core::fmt::Formatter) -> core::fmt::Result { [INFO] [stdout] | ------------------------------------------------------------------------ move the `impl` block outside of this method `fmt` [INFO] [stdout] 203 | impl ItemImplConst { [INFO] [stdout] | ^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | `ItemImplConst` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `unconst` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `syn::Item` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unconst.rs:16:11 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn unconst(_attr: TokenStream, item: TokenStream) -> TokenStream { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | match parse::(item).unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/unconst/impl_const.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 202 | fn fmt(&self, formatter: &mut core::fmt::Formatter) -> core::fmt::Result { [INFO] [stdout] | ------------------------------------------------------------------------ move the `impl` block outside of this method `fmt` [INFO] [stdout] 203 | impl ItemImplConst { [INFO] [stdout] | ^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | `ItemImplConst` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `unconst` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "b395a1465b7decc4a4a1ea0989deadc408ff2b1bf165bd4b2c9c2f450b0924df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b395a1465b7decc4a4a1ea0989deadc408ff2b1bf165bd4b2c9c2f450b0924df", kill_on_drop: false }` [INFO] [stdout] b395a1465b7decc4a4a1ea0989deadc408ff2b1bf165bd4b2c9c2f450b0924df