[INFO] fetching crate umbral-rs 0.0.4... [INFO] checking umbral-rs-0.0.4 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate umbral-rs 0.0.4 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate umbral-rs 0.0.4 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate umbral-rs 0.0.4 [INFO] finished tweaking crates.io crate umbral-rs 0.0.4 [INFO] tweaked toml for crates.io crate umbral-rs 0.0.4 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate umbral-rs 0.0.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f5e7bd5361817136d95510086fe6584bf2aee16d4805ebf48ab8966841af8517 [INFO] running `Command { std: "docker" "start" "-a" "f5e7bd5361817136d95510086fe6584bf2aee16d4805ebf48ab8966841af8517", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f5e7bd5361817136d95510086fe6584bf2aee16d4805ebf48ab8966841af8517", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f5e7bd5361817136d95510086fe6584bf2aee16d4805ebf48ab8966841af8517", kill_on_drop: false }` [INFO] [stdout] f5e7bd5361817136d95510086fe6584bf2aee16d4805ebf48ab8966841af8517 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8d755e305d78432184253dfc9260c3e90dbac2b193c142703752ff4772b11688 [INFO] running `Command { std: "docker" "start" "-a" "8d755e305d78432184253dfc9260c3e90dbac2b193c142703752ff4772b11688", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Checking cpufeatures v0.2.9 [INFO] [stderr] Checking zeroize v1.6.0 [INFO] [stderr] Checking block-padding v0.2.1 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling openssl v0.10.57 [INFO] [stderr] Checking keccak v0.1.4 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking sha3 v0.9.1 [INFO] [stderr] Checking crypto-mac v0.8.0 [INFO] [stderr] Checking hmac v0.8.1 [INFO] [stderr] Checking blake2 v0.9.2 [INFO] [stderr] Checking hkdf v0.9.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking modinverse v0.1.1 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Compiling openssl-sys v0.9.93 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking umbral-rs v0.0.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `unstable` [INFO] [stdout] --> src/lib.rs:1:13 [INFO] [stdout] | [INFO] [stdout] 1 | #![cfg_attr(feature = "unstable", feature(test))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `unstable` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `unstable` [INFO] [stdout] --> src/lib.rs:1:13 [INFO] [stdout] | [INFO] [stdout] 1 | #![cfg_attr(feature = "unstable", feature(test))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `unstable` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `EcdsaSig` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal/keys.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 122 | let ver_key = EcKey::from_public_key(verifying_pk.params().group(), verifying_pk.point()) [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | .expect("Error in Key creation"); [INFO] [stdout] 124 | / EcdsaSig::from_private_components( [INFO] [stdout] 125 | | self.r.bn().to_owned().unwrap(), [INFO] [stdout] 126 | | self.s.bn().to_owned().unwrap(), [INFO] [stdout] 127 | | ) [INFO] [stdout] 128 | | .unwrap() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/internal/curve.rs:476:26 [INFO] [stdout] | [INFO] [stdout] 476 | let _ = self.bn().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `BigNumRef` does not implement `Clone`, so calling `clone` on `&BigNumRef` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 476 - let _ = self.bn().clone(); [INFO] [stdout] 476 + let _ = self.bn(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `BigNumRef`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/foreign-types-0.3.2/src/lib.rs:299:9 [INFO] [stdout] | [INFO] [stdout] 299 + #[derive(Clone)] [INFO] [stdout] 300 | pub struct $borrowed($crate::Opaque); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `EcdsaSig` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal/keys.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 122 | let ver_key = EcKey::from_public_key(verifying_pk.params().group(), verifying_pk.point()) [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | .expect("Error in Key creation"); [INFO] [stdout] 124 | / EcdsaSig::from_private_components( [INFO] [stdout] 125 | | self.r.bn().to_owned().unwrap(), [INFO] [stdout] 126 | | self.s.bn().to_owned().unwrap(), [INFO] [stdout] 127 | | ) [INFO] [stdout] 128 | | .unwrap() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `umbral-rs` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/internal/curve.rs:476:26 [INFO] [stdout] | [INFO] [stdout] 476 | let _ = self.bn().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `BigNumRef` does not implement `Clone`, so calling `clone` on `&BigNumRef` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 476 - let _ = self.bn().clone(); [INFO] [stdout] 476 + let _ = self.bn(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `BigNumRef`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/foreign-types-0.3.2/src/lib.rs:299:9 [INFO] [stdout] | [INFO] [stdout] 299 + #[derive(Clone)] [INFO] [stdout] 300 | pub struct $borrowed($crate::Opaque); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `umbral-rs` (lib) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8d755e305d78432184253dfc9260c3e90dbac2b193c142703752ff4772b11688", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d755e305d78432184253dfc9260c3e90dbac2b193c142703752ff4772b11688", kill_on_drop: false }` [INFO] [stdout] 8d755e305d78432184253dfc9260c3e90dbac2b193c142703752ff4772b11688