[INFO] fetching crate tun2proxy 0.5.0... [INFO] checking tun2proxy-0.5.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate tun2proxy 0.5.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate tun2proxy 0.5.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-0-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate tun2proxy 0.5.0 [INFO] finished tweaking crates.io crate tun2proxy 0.5.0 [INFO] tweaked toml for crates.io crate tun2proxy 0.5.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate tun2proxy 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e068ed324497e2c6cd9a315c26f64f52e92380debcf065991cd27d0f4159b2e7 [INFO] running `Command { std: "docker" "start" "-a" "e068ed324497e2c6cd9a315c26f64f52e92380debcf065991cd27d0f4159b2e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e068ed324497e2c6cd9a315c26f64f52e92380debcf065991cd27d0f4159b2e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e068ed324497e2c6cd9a315c26f64f52e92380debcf065991cd27d0f4159b2e7", kill_on_drop: false }` [INFO] [stdout] e068ed324497e2c6cd9a315c26f64f52e92380debcf065991cd27d0f4159b2e7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 43ee7f242a9591a321a9af28b2ff88575391427785cc5a5e96806f30b293335d [INFO] running `Command { std: "docker" "start" "-a" "43ee7f242a9591a321a9af28b2ff88575391427785cc5a5e96806f30b293335d", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking etherparse v0.15.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking clap_builder v4.5.18 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking as-any v0.3.1 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking daemonize v0.5.0 [INFO] [stderr] Checking dotenvy v0.15.7 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling tun2proxy v0.5.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling enum-as-inner v0.6.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking clap v4.5.18 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking digest_auth v0.3.1 [INFO] [stderr] Checking cidr v0.2.3 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking hickory-proto v0.24.1 [INFO] [stderr] Checking socks5-impl v0.5.14 [INFO] [stderr] Checking udp-stream v0.0.12 [INFO] [stderr] Checking ctrlc2 v3.5.8 [INFO] [stderr] Checking ipstack v0.1.0 [INFO] [stderr] Checking tun2 v3.1.4 [INFO] [stderr] Checking tproxy-config v6.0.3 [INFO] [stdout] error: this value of type `std::option::Option>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 154 | pub async fn run(device: D, mtu: u16, args: Args, shutdown_token: CancellationToken) -> crate::Result<()> [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | let virtual_dns = if args.dns == ArgDns::Virtual { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 238 | let ip_stack_stream = tokio::select! { [INFO] [stdout] | _______________________________- [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] 239 | | _ = shutdown_token.cancelled() => { [INFO] [stdout] 240 | | log::info!("Shutdown received"); [INFO] [stdout] 241 | | break; [INFO] [stdout] ... | [INFO] [stdout] 245 | | } [INFO] [stdout] 246 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::net::TcpStream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:545:9 [INFO] [stdout] | [INFO] [stdout] 534 | mut udp_stack: IpStackUdpStream, [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 535 | proxy_handler: Arc>, [INFO] [stdout] 536 | socket_queue: Option>, [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 545 | let mut server = create_tcp_stream(&socket_queue, server_addr).await?; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 154 | pub async fn run(device: D, mtu: u16, args: Args, shutdown_token: CancellationToken) -> crate::Result<()> [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | let virtual_dns = if args.dns == ArgDns::Virtual { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 238 | let ip_stack_stream = tokio::select! { [INFO] [stdout] | _______________________________- [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] 239 | | _ = shutdown_token.cancelled() => { [INFO] [stdout] 240 | | log::info!("Shutdown received"); [INFO] [stdout] 241 | | break; [INFO] [stdout] ... | [INFO] [stdout] 245 | | } [INFO] [stdout] 246 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:455:10 [INFO] [stdout] | [INFO] [stdout] 433 | mut udp_stack: IpStackUdpStream, [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 434 | proxy_type: ProxyType, [INFO] [stdout] 435 | proxy_handler: Arc>, [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 436 | socket_queue: Option>, [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 455 | let (_server, udp_addr) = match udp_addr { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::net::TcpStream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:545:9 [INFO] [stdout] | [INFO] [stdout] 534 | mut udp_stack: IpStackUdpStream, [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 535 | proxy_handler: Arc>, [INFO] [stdout] 536 | socket_queue: Option>, [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 545 | let mut server = create_tcp_stream(&socket_queue, server_addr).await?; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:455:10 [INFO] [stdout] | [INFO] [stdout] 433 | mut udp_stack: IpStackUdpStream, [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 434 | proxy_type: ProxyType, [INFO] [stdout] 435 | proxy_handler: Arc>, [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 436 | socket_queue: Option>, [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 455 | let (_server, udp_addr) = match udp_addr { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::MutexGuard<'_, std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dump_logger.rs:66:27 [INFO] [stdout] | [INFO] [stdout] 64 | let c_msg = std::ffi::CString::new(msg).unwrap(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let ptr = c_msg.as_ptr(); [INFO] [stdout] 66 | if let Some(cb) = DUMP_CALLBACK.lock().unwrap().clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tun2proxy` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::sync::MutexGuard<'_, std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dump_logger.rs:66:27 [INFO] [stdout] | [INFO] [stdout] 64 | let c_msg = std::ffi::CString::new(msg).unwrap(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let ptr = c_msg.as_ptr(); [INFO] [stdout] 66 | if let Some(cb) = DUMP_CALLBACK.lock().unwrap().clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tun2proxy` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "43ee7f242a9591a321a9af28b2ff88575391427785cc5a5e96806f30b293335d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "43ee7f242a9591a321a9af28b2ff88575391427785cc5a5e96806f30b293335d", kill_on_drop: false }` [INFO] [stdout] 43ee7f242a9591a321a9af28b2ff88575391427785cc5a5e96806f30b293335d