[INFO] fetching crate trie-db-fun 100.28.0... [INFO] checking trie-db-fun-100.28.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate trie-db-fun 100.28.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate trie-db-fun 100.28.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate trie-db-fun 100.28.0 [INFO] finished tweaking crates.io crate trie-db-fun 100.28.0 [INFO] tweaked toml for crates.io crate trie-db-fun 100.28.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] da39dd4f7a31422480947fbf5ab5f7cd7342ce9c508ff455df6e8dde1269cf11 [INFO] running `Command { std: "docker" "start" "-a" "da39dd4f7a31422480947fbf5ab5f7cd7342ce9c508ff455df6e8dde1269cf11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "da39dd4f7a31422480947fbf5ab5f7cd7342ce9c508ff455df6e8dde1269cf11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "da39dd4f7a31422480947fbf5ab5f7cd7342ce9c508ff455df6e8dde1269cf11", kill_on_drop: false }` [INFO] [stdout] da39dd4f7a31422480947fbf5ab5f7cd7342ce9c508ff455df6e8dde1269cf11 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5cb3c1235c623973c19561bf8e095e8abfd940fff1852b9b11bc33cbfb27664d [INFO] running `Command { std: "docker" "start" "-a" "5cb3c1235c623973c19561bf8e095e8abfd940fff1852b9b11bc33cbfb27664d", kill_on_drop: false }` [INFO] [stderr] Checking rustc-hex v2.1.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking hash-db v0.16.0 [INFO] [stderr] Checking trie-db-fun v100.28.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/nibble/nibbleslice.rs:169:28 [INFO] [stdout] | [INFO] [stdout] 34 | impl<'a> NibbleSlice<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 169 | pub fn right(&'a self) -> Partial { [INFO] [stdout] | ^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/nibble/nibbleslice.rs:240:27 [INFO] [stdout] | [INFO] [stdout] 34 | impl<'a> NibbleSlice<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 240 | pub fn left(&'a self) -> Prefix { [INFO] [stdout] | ^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/nibble/nibbleslice.rs:169:28 [INFO] [stdout] | [INFO] [stdout] 34 | impl<'a> NibbleSlice<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 169 | pub fn right(&'a self) -> Partial { [INFO] [stdout] | ^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/nibble/nibbleslice.rs:240:27 [INFO] [stdout] | [INFO] [stdout] 34 | impl<'a> NibbleSlice<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 240 | pub fn left(&'a self) -> Prefix { [INFO] [stdout] | ^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/node.rs:204:2 [INFO] [stdout] | [INFO] [stdout] 204 | / pub fn to_owned_node( [INFO] [stdout] 205 | | &self, [INFO] [stdout] 206 | | ) -> Result>, TrieHash, CError> { [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromIterator<()>` will fail [INFO] [stdout] --> src/node.rs:222:17 [INFO] [stdout] | [INFO] [stdout] 222 | .collect::>()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/node.rs:204:2 [INFO] [stdout] | [INFO] [stdout] 204 | / pub fn to_owned_node( [INFO] [stdout] 205 | | &self, [INFO] [stdout] 206 | | ) -> Result>, TrieHash, CError> { [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromIterator<()>` will fail [INFO] [stdout] --> src/node.rs:222:17 [INFO] [stdout] | [INFO] [stdout] 222 | .collect::>()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(usize, SmallVec<[u8; 40]>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/triedbmut.rs:1047:24 [INFO] [stdout] | [INFO] [stdout] 990 | node: Node, [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1047 | Node::NibbledBranch(encoded, mut children, stored_value) => { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(usize, SmallVec<[u8; 40]>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/triedbmut.rs:1047:24 [INFO] [stdout] | [INFO] [stdout] 990 | node: Node, [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1047 | Node::NibbledBranch(encoded, mut children, stored_value) => { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(usize, SmallVec<[u8; 40]>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/triedbmut.rs:1603:24 [INFO] [stdout] | [INFO] [stdout] 1550 | node: Node, [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1603 | Node::NibbledBranch(enc_nibble, mut children, value) => { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(usize, SmallVec<[u8; 40]>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/triedbmut.rs:1603:24 [INFO] [stdout] | [INFO] [stdout] 1550 | node: Node, [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1603 | Node::NibbledBranch(enc_nibble, mut children, value) => { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(A, B)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iter_build.rs:278:36 [INFO] [stdout] | [INFO] [stdout] 275 | let mut depth_queue = CacheAccum::::new(); [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | // compare iter ordering [INFO] [stdout] 277 | let mut iter_input = input.into_iter(); [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | if let Some(mut previous_value) = iter_input.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(A, B)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iter_build.rs:278:36 [INFO] [stdout] | [INFO] [stdout] 275 | let mut depth_queue = CacheAccum::::new(); [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | // compare iter ordering [INFO] [stdout] 277 | let mut iter_input = input.into_iter(); [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | if let Some(mut previous_value) = iter_input.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `trie-db-fun` (lib test) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `trie-db-fun` (lib) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5cb3c1235c623973c19561bf8e095e8abfd940fff1852b9b11bc33cbfb27664d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5cb3c1235c623973c19561bf8e095e8abfd940fff1852b9b11bc33cbfb27664d", kill_on_drop: false }` [INFO] [stdout] 5cb3c1235c623973c19561bf8e095e8abfd940fff1852b9b11bc33cbfb27664d