[INFO] fetching crate thomas 0.2.4... [INFO] checking thomas-0.2.4 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate thomas 0.2.4 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate thomas 0.2.4 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate thomas 0.2.4 [INFO] finished tweaking crates.io crate thomas 0.2.4 [INFO] tweaked toml for crates.io crate thomas 0.2.4 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 63 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding core-foundation v0.9.4 (available: v0.10.0) [INFO] [stderr] Adding crossterm v0.26.1 (available: v0.28.1) [INFO] [stderr] Adding device_query v1.1.3 (available: v2.1.0) [INFO] [stderr] Adding mio v0.8.11 (available: v1.0.2) [INFO] [stderr] Adding readkey v0.1.7 (available: v0.2.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows v0.46.0 (available: v0.58.0) [INFO] [stderr] Adding windows-sys v0.48.0 (available: v0.59.0) [INFO] [stderr] Adding windows-targets v0.42.2 (available: v0.52.6) [INFO] [stderr] Adding windows-targets v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.42.2 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.42.2 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.42.2 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.42.2 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.42.2 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.42.2 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.42.2 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (available: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4ca98031c555687ef88871dfbb67f0ac82603a10c492b1789d675544e364accc [INFO] running `Command { std: "docker" "start" "-a" "4ca98031c555687ef88871dfbb67f0ac82603a10c492b1789d675544e364accc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4ca98031c555687ef88871dfbb67f0ac82603a10c492b1789d675544e364accc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4ca98031c555687ef88871dfbb67f0ac82603a10c492b1789d675544e364accc", kill_on_drop: false }` [INFO] [stdout] 4ca98031c555687ef88871dfbb67f0ac82603a10c492b1789d675544e364accc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ea0b75bf2604a68ffd6b79c4760e8961e12870599538f2d29251c84fdb6037db [INFO] running `Command { std: "docker" "start" "-a" "ea0b75bf2604a68ffd6b79c4760e8961e12870599538f2d29251c84fdb6037db", kill_on_drop: false }` [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling x11 v2.21.0 [INFO] [stderr] Compiling device_query v1.1.3 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking crossterm v0.26.1 [INFO] [stderr] Compiling thomas_derive v0.2.0 [INFO] [stderr] Checking thomas v0.2.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/data/matrix.rs:48:17 [INFO] [stdout] | [INFO] [stdout] 48 | let mut cell = &mut self.matrix[y as usize][x as usize]; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RefMut<'_, sys_terminal_renderer::TerminalRendererState>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/systems/sys_terminal_renderer.rs:59:33 [INFO] [stdout] | [INFO] [stdout] 50 | move |results, commands| { [INFO] [stdout] | ------- -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let mut state = state_query [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RefMut<'_, sys_terminal_renderer::TerminalRendererState>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/systems/sys_terminal_renderer.rs:144:33 [INFO] [stdout] | [INFO] [stdout] 140 | move |results, _| { [INFO] [stdout] | ------- - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let mut state = state_results.get_only_mut::(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `thomas` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/data/matrix.rs:48:17 [INFO] [stdout] | [INFO] [stdout] 48 | let mut cell = &mut self.matrix[y as usize][x as usize]; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, entity_manager::tests::TestComponent>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/entity_manager.rs:904:36 [INFO] [stdout] | [INFO] [stdout] 890 | let mut em = EntityManager::new(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 898 | let query_results = em.query(&Query::new().has::()); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 904 | assert_eq!(result.components().get::().prop1, 10) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, entity_manager::tests::TestComponent>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/entity_manager.rs:950:29 [INFO] [stdout] | [INFO] [stdout] 918 | let mut em = EntityManager::new(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 930 | let query_results = em.query( [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 950 | let test_component = result.components().get::(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, entity_manager::tests::TestComponent>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/entity_manager.rs:1093:36 [INFO] [stdout] | [INFO] [stdout] 1075 | let mut em = EntityManager::new(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1083 | let query_results = em.query( [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1093 | assert_eq!(result.components().get::().prop1, 20) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, entity_manager::tests::TestComponent>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/entity_manager.rs:1138:29 [INFO] [stdout] | [INFO] [stdout] 1102 | let mut em = EntityManager::new(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1118 | let query_results = em.query( [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1138 | let test_component = result.components().get::(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RefMut<'_, sys_terminal_renderer::TerminalRendererState>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/systems/sys_terminal_renderer.rs:59:33 [INFO] [stdout] | [INFO] [stdout] 50 | move |results, commands| { [INFO] [stdout] | ------- -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let mut state = state_query [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RefMut<'_, sys_terminal_renderer::TerminalRendererState>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/systems/sys_terminal_renderer.rs:144:33 [INFO] [stdout] | [INFO] [stdout] 140 | move |results, _| { [INFO] [stdout] | ------- - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let mut state = state_results.get_only_mut::(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `thomas` (lib test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "ea0b75bf2604a68ffd6b79c4760e8961e12870599538f2d29251c84fdb6037db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ea0b75bf2604a68ffd6b79c4760e8961e12870599538f2d29251c84fdb6037db", kill_on_drop: false }` [INFO] [stdout] ea0b75bf2604a68ffd6b79c4760e8961e12870599538f2d29251c84fdb6037db