[INFO] fetching crate tetsy-finality-grandpa 0.13.0... [INFO] checking tetsy-finality-grandpa-0.13.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate tetsy-finality-grandpa 0.13.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate tetsy-finality-grandpa 0.13.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tetsy-finality-grandpa 0.13.0 [INFO] finished tweaking crates.io crate tetsy-finality-grandpa 0.13.0 [INFO] tweaked toml for crates.io crate tetsy-finality-grandpa 0.13.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 63 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (available: v0.7.6) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding bitvec v0.20.4 (available: v1.0.1) [INFO] [stderr] Adding env_logger v0.8.4 (available: v0.11.5) [INFO] [stderr] Adding funty v1.1.0 (available: v2.0.0) [INFO] [stderr] Adding parking_lot v0.11.2 (available: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (available: v0.9.10) [INFO] [stderr] Adding proc-macro-crate v0.1.5 (available: v3.2.0) [INFO] [stderr] Adding radium v0.6.2 (available: v1.1.0) [INFO] [stderr] Adding redox_syscall v0.2.16 (available: v0.5.6) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding toml v0.5.11 (available: v0.8.19) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wyz v0.2.0 (available: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 379b0c06e09016ccb751f998d9e8ebae9445cd10a8f706f394cec2921c8f1c1f [INFO] running `Command { std: "docker" "start" "-a" "379b0c06e09016ccb751f998d9e8ebae9445cd10a8f706f394cec2921c8f1c1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "379b0c06e09016ccb751f998d9e8ebae9445cd10a8f706f394cec2921c8f1c1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "379b0c06e09016ccb751f998d9e8ebae9445cd10a8f706f394cec2921c8f1c1f", kill_on_drop: false }` [INFO] [stdout] 379b0c06e09016ccb751f998d9e8ebae9445cd10a8f706f394cec2921c8f1c1f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3622febde93f49e0ab7aa8c93387149676c64acc81325a1818657e4df6d58734 [INFO] running `Command { std: "docker" "start" "-a" "3622febde93f49e0ab7aa8c93387149676c64acc81325a1818657e4df6d58734", kill_on_drop: false }` [INFO] [stderr] Compiling radium v0.6.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking funty v1.1.0 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking wyz v0.2.0 [INFO] [stderr] Checking byte-slice-cast v1.2.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking bitvec v0.20.4 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Compiling proc-macro-crate v0.1.5 [INFO] [stderr] Compiling tetsy-scale-codec-derive v2.0.1 [INFO] [stderr] Checking tetsy-scale-codec v2.0.1 [INFO] [stderr] Checking tetsy-finality-grandpa v0.13.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::collections::btree_map::Entry<'_, Id, VoteMultiplicity>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/round.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 97 | fn add_vote(&mut self, id: Id, vote: Vote, signature: Signature, weight: VoterWeight) [INFO] [stdout] | ---- --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | match self.votes.entry(id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vote_graph.rs:256:9 [INFO] [stdout] | [INFO] [stdout] 249 | pub fn cumulative_vote<'a>(&'a self, hash: H, number: N) -> V { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | match self.find_containing_nodes(hash.clone(), number.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Subchain` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vote_graph.rs:339:3 [INFO] [stdout] | [INFO] [stdout] 280 | pub fn find_ghost<'a, F>(&'a self, current_best: Option<(H, N)>, condition: F) -> Option<(H, N)> [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 339 | / self.ghost_find_merge_point( [INFO] [stdout] 340 | | node_key, [INFO] [stdout] 341 | | active_node, [INFO] [stdout] 342 | | if force_constrain { current_best } else { None }, [INFO] [stdout] 343 | | condition, [INFO] [stdout] 344 | | ).best() [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tetsy-finality-grandpa` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::collections::btree_map::Entry<'_, Id, VoteMultiplicity>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/round.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 97 | fn add_vote(&mut self, id: Id, vote: Vote, signature: Signature, weight: VoterWeight) [INFO] [stdout] | ---- --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | match self.votes.entry(id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vote_graph.rs:256:9 [INFO] [stdout] | [INFO] [stdout] 249 | pub fn cumulative_vote<'a>(&'a self, hash: H, number: N) -> V { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | match self.find_containing_nodes(hash.clone(), number.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Subchain` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vote_graph.rs:339:3 [INFO] [stdout] | [INFO] [stdout] 280 | pub fn find_ghost<'a, F>(&'a self, current_best: Option<(H, N)>, condition: F) -> Option<(H, N)> [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 339 | / self.ghost_find_merge_point( [INFO] [stdout] 340 | | node_key, [INFO] [stdout] 341 | | active_node, [INFO] [stdout] 342 | | if force_constrain { current_best } else { None }, [INFO] [stdout] 343 | | condition, [INFO] [stdout] 344 | | ).best() [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tetsy-finality-grandpa` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "3622febde93f49e0ab7aa8c93387149676c64acc81325a1818657e4df6d58734", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3622febde93f49e0ab7aa8c93387149676c64acc81325a1818657e4df6d58734", kill_on_drop: false }` [INFO] [stdout] 3622febde93f49e0ab7aa8c93387149676c64acc81325a1818657e4df6d58734