[INFO] fetching crate tetsy-fetch 0.1.0... [INFO] checking tetsy-fetch-0.1.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate tetsy-fetch 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate tetsy-fetch 0.1.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tetsy-fetch 0.1.0 [INFO] finished tweaking crates.io crate tetsy-fetch 0.1.0 [INFO] tweaked toml for crates.io crate tetsy-fetch 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 123 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.10.1 (available: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding bytes v0.4.12 (available: v1.7.2) [INFO] [stderr] Adding cfg-if v0.1.10 (available: v1.0.0) [INFO] [stderr] Adding cloudabi v0.0.3 (available: v0.1.0) [INFO] [stderr] Adding core-foundation v0.6.4 (available: v0.10.0) [INFO] [stderr] Adding core-foundation-sys v0.6.2 (available: v0.8.7) [INFO] [stderr] Adding crossbeam-deque v0.7.4 (available: v0.8.5) [INFO] [stderr] Adding crossbeam-epoch v0.8.2 (available: v0.9.18) [INFO] [stderr] Adding crossbeam-queue v0.2.3 (available: v0.3.11) [INFO] [stderr] Adding crossbeam-utils v0.7.2 (available: v0.8.20) [INFO] [stderr] Adding ct-logs v0.6.0 (available: v0.9.0) [INFO] [stderr] Adding futures v0.1.31 (available: v0.3.30) [INFO] [stderr] Adding h2 v0.1.26 (available: v0.4.6) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding http v0.1.21 (available: v1.1.0) [INFO] [stderr] Adding http-body v0.1.0 (available: v1.0.1) [INFO] [stderr] Adding hyper v0.12.36 (available: v1.4.1) [INFO] [stderr] Adding hyper-rustls v0.18.0 (available: v0.27.3) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding itoa v0.4.8 (available: v1.0.11) [INFO] [stderr] Adding lock_api v0.3.4 (available: v0.4.12) [INFO] [stderr] Adding memoffset v0.5.6 (available: v0.9.1) [INFO] [stderr] Adding mio v0.6.23 (available: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (available: v0.6.0) [INFO] [stderr] Adding parking_lot v0.9.0 (available: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.6.3 (available: v0.9.10) [INFO] [stderr] Adding redox_syscall v0.1.57 (available: v0.5.6) [INFO] [stderr] Adding ring v0.16.20 (available: v0.17.8) [INFO] [stderr] Adding rustc_version v0.2.3 (available: v0.4.1) [INFO] [stderr] Adding rustls v0.16.0 (available: v0.23.13) [INFO] [stderr] Adding rustls-native-certs v0.1.0 (available: v0.8.0) [INFO] [stderr] Adding sct v0.6.1 (available: v0.7.1) [INFO] [stderr] Adding security-framework v0.3.4 (available: v3.0.0) [INFO] [stderr] Adding security-framework-sys v0.3.3 (available: v2.12.0) [INFO] [stderr] Adding semver v0.9.0 (available: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (available: v0.10.2) [INFO] [stderr] Adding smallvec v0.6.14 (available: v1.13.2) [INFO] [stderr] Adding spin v0.5.2 (available: v0.9.8) [INFO] [stderr] Adding string v0.2.1 (available: v0.3.1) [INFO] [stderr] Adding time v0.1.45 (available: v0.3.36) [INFO] [stderr] Adding tokio v0.1.22 (available: v1.40.0) [INFO] [stderr] Adding tokio-rustls v0.10.3 (available: v0.26.0) [INFO] [stderr] Adding untrusted v0.7.1 (available: v0.9.0) [INFO] [stderr] Adding want v0.2.0 (available: v0.3.1) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (available: v0.10.2+wasi-snapshot-preview1) [INFO] [stderr] Adding webpki v0.21.4 (available: v0.22.4) [INFO] [stderr] Adding winapi v0.2.8 (available: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 43f12b2dbb6d7f1dc34b3e798fef71b22b18ed840d5f06a4db50429b1fbe6b59 [INFO] running `Command { std: "docker" "start" "-a" "43f12b2dbb6d7f1dc34b3e798fef71b22b18ed840d5f06a4db50429b1fbe6b59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "43f12b2dbb6d7f1dc34b3e798fef71b22b18ed840d5f06a4db50429b1fbe6b59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "43f12b2dbb6d7f1dc34b3e798fef71b22b18ed840d5f06a4db50429b1fbe6b59", kill_on_drop: false }` [INFO] [stdout] 43f12b2dbb6d7f1dc34b3e798fef71b22b18ed840d5f06a4db50429b1fbe6b59 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1c84b3b18347e7fd91dd164c451b3413ba7f177d789a9439f2ecaaa1917d5378 [INFO] running `Command { std: "docker" "start" "-a" "1c84b3b18347e7fd91dd164c451b3413ba7f177d789a9439f2ecaaa1917d5378", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Checking indexmap v1.9.3 [INFO] [stderr] Compiling parking_lot_core v0.6.3 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking http v0.1.21 [INFO] [stderr] Compiling hyper v0.12.36 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking string v0.2.1 [INFO] [stderr] Checking crossbeam-deque v0.7.4 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking tokio-sync v0.1.8 [INFO] [stderr] Checking tokio-buf v0.1.1 [INFO] [stderr] Checking want v0.2.0 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Checking tokio-codec v0.1.2 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking tokio-uds v0.2.7 [INFO] [stderr] Checking tokio-udp v0.1.6 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking tokio-fs v0.1.7 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking h2 v0.1.26 [INFO] [stderr] Checking http-body v0.1.0 [INFO] [stderr] Checking sct v0.6.1 [INFO] [stderr] Checking webpki v0.21.4 [INFO] [stderr] Checking ct-logs v0.6.0 [INFO] [stderr] Checking rustls v0.16.0 [INFO] [stderr] Checking rustls-native-certs v0.1.0 [INFO] [stderr] Checking tokio-rustls v0.10.3 [INFO] [stderr] Checking hyper-rustls v0.18.0 [INFO] [stderr] Checking tetsy-fetch v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `http::request::Builder` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:416:3 [INFO] [stdout] | [INFO] [stdout] 414 | fn from(req: Request) -> hyper::Request { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 415 | let uri: hyper::Uri = req.url.as_ref().parse().expect("Every valid URLis also a URI."); [INFO] [stdout] 416 | hyper::Request::builder() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tetsy-fetch` (lib) due to 3 previous errors [INFO] [stdout] error: this value of type `Result>, hyper::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:483:20 [INFO] [stdout] | [INFO] [stdout] 483 | match try_ready!(self.body.poll()) { [INFO] [stdout] | -----------^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `http::request::Builder` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:416:3 [INFO] [stdout] | [INFO] [stdout] 414 | fn from(req: Request) -> hyper::Request { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 415 | let uri: hyper::Uri = req.url.as_ref().parse().expect("Every valid URLis also a URI."); [INFO] [stdout] 416 | hyper::Request::builder() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result>, hyper::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:483:20 [INFO] [stdout] | [INFO] [stdout] 483 | match try_ready!(self.body.poll()) { [INFO] [stdout] | -----------^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:728:6 [INFO] [stdout] | [INFO] [stdout] 725 | .then(|res| { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 728 | other => panic!("expected timeout, got {:?}", other), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:777:6 [INFO] [stdout] | [INFO] [stdout] 774 | .then(|res| { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 777 | other => panic!("expected too many redirects error, got {:?}", other) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:818:6 [INFO] [stdout] | [INFO] [stdout] 815 | .then(|body| { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 818 | other => panic!("expected size limit error, got {:?}", other), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), client::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:862:9 [INFO] [stdout] | [INFO] [stdout] 827 | let server = TestServer::run(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 828 | let client = Client::new(4).unwrap(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 829 | let mut runtime = Runtime::new().unwrap(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 862 | match runtime.block_on(future) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/client.rs:692:26 [INFO] [stdout] | [INFO] [stdout] 692 | .map_err(|err| panic!(err)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 692 | .map_err(|err| panic!("{}", err)); [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 692 | .map_err(|err| std::panic::panic_any(err)); [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/client.rs:711:26 [INFO] [stdout] | [INFO] [stdout] 711 | .map_err(|err| panic!(err)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 711 | .map_err(|err| panic!("{}", err)); [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 711 | .map_err(|err| std::panic::panic_any(err)); [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tetsy-fetch` (lib test) due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1c84b3b18347e7fd91dd164c451b3413ba7f177d789a9439f2ecaaa1917d5378", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c84b3b18347e7fd91dd164c451b3413ba7f177d789a9439f2ecaaa1917d5378", kill_on_drop: false }` [INFO] [stdout] 1c84b3b18347e7fd91dd164c451b3413ba7f177d789a9439f2ecaaa1917d5378