[INFO] fetching crate tdf-derive 0.2.0... [INFO] checking tdf-derive-0.2.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate tdf-derive 0.2.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate tdf-derive 0.2.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tdf-derive 0.2.0 [INFO] finished tweaking crates.io crate tdf-derive 0.2.0 [INFO] tweaked toml for crates.io crate tdf-derive 0.2.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3f038ffd377738f4eefbd5470b2581dddebe635daf83cfac361de4c0417fc4d1 [INFO] running `Command { std: "docker" "start" "-a" "3f038ffd377738f4eefbd5470b2581dddebe635daf83cfac361de4c0417fc4d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3f038ffd377738f4eefbd5470b2581dddebe635daf83cfac361de4c0417fc4d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3f038ffd377738f4eefbd5470b2581dddebe635daf83cfac361de4c0417fc4d1", kill_on_drop: false }` [INFO] [stdout] 3f038ffd377738f4eefbd5470b2581dddebe635daf83cfac361de4c0417fc4d1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 186df5b32ed3641eb78698cd3f4dbcd5d68d5afeb8b3b7067bde6fb36b3d4edc [INFO] running `Command { std: "docker" "start" "-a" "186df5b32ed3641eb78698cd3f4dbcd5d68d5afeb8b3b7067bde6fb36b3d4edc", kill_on_drop: false }` [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking ident_case v1.0.1 [INFO] [stderr] Checking darling_core v0.20.10 [INFO] [stderr] Checking darling v0.20.10 [INFO] [stderr] Checking tdf-derive v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:337:34 [INFO] [stdout] | [INFO] [stdout] 306 | .map(|(variant, attr)| { [INFO] [stdout] | --------------- [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 331 | let discriminant = attr.key.expect("Missing discriminant key"); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 337 | let (idents, impls): (Vec<_>, Vec<_>) = fields [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 360 | quote!(#(#idents,)* ..) [INFO] [stdout] | ----------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 361 | } else { [INFO] [stdout] 362 | quote!(#(#idents),*) [INFO] [stdout] | -------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 371 | / quote! { [INFO] [stdout] 372 | | Self::#var_ident { #field_names } => { [INFO] [stdout] 373 | | w.write_byte(#discriminant); [INFO] [stdout] 374 | | tdf::Tagged::serialize_raw(w, #value_tag, tdf::TdfType::Group); [INFO] [stdout] ... | [INFO] [stdout] 379 | | } [INFO] [stdout] 380 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:625:34 [INFO] [stdout] | [INFO] [stdout] 578 | let attr: TdfTaggedEnumVariantAttr = [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 619 | let discriminant = attr.key.expect("Missing discriminant key"); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 625 | let (idents, impls): (Vec<_>, Vec<_>) = fields [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 635 | / quote! { [INFO] [stdout] 636 | | #discriminant => { [INFO] [stdout] 637 | | let tag = tdf::Tagged::deserialize_owned(r)?; [INFO] [stdout] ... | [INFO] [stdout] 645 | | } [INFO] [stdout] 646 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tdf-derive` (lib test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:337:34 [INFO] [stdout] | [INFO] [stdout] 306 | .map(|(variant, attr)| { [INFO] [stdout] | --------------- [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 331 | let discriminant = attr.key.expect("Missing discriminant key"); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 337 | let (idents, impls): (Vec<_>, Vec<_>) = fields [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 360 | quote!(#(#idents,)* ..) [INFO] [stdout] | ----------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 361 | } else { [INFO] [stdout] 362 | quote!(#(#idents),*) [INFO] [stdout] | -------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 371 | / quote! { [INFO] [stdout] 372 | | Self::#var_ident { #field_names } => { [INFO] [stdout] 373 | | w.write_byte(#discriminant); [INFO] [stdout] 374 | | tdf::Tagged::serialize_raw(w, #value_tag, tdf::TdfType::Group); [INFO] [stdout] ... | [INFO] [stdout] 379 | | } [INFO] [stdout] 380 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:625:34 [INFO] [stdout] | [INFO] [stdout] 578 | let attr: TdfTaggedEnumVariantAttr = [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 619 | let discriminant = attr.key.expect("Missing discriminant key"); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 625 | let (idents, impls): (Vec<_>, Vec<_>) = fields [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 635 | / quote! { [INFO] [stdout] 636 | | #discriminant => { [INFO] [stdout] 637 | | let tag = tdf::Tagged::deserialize_owned(r)?; [INFO] [stdout] ... | [INFO] [stdout] 645 | | } [INFO] [stdout] 646 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tdf-derive` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "186df5b32ed3641eb78698cd3f4dbcd5d68d5afeb8b3b7067bde6fb36b3d4edc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "186df5b32ed3641eb78698cd3f4dbcd5d68d5afeb8b3b7067bde6fb36b3d4edc", kill_on_drop: false }` [INFO] [stdout] 186df5b32ed3641eb78698cd3f4dbcd5d68d5afeb8b3b7067bde6fb36b3d4edc