[INFO] fetching crate tboard-pyo3 0.1.1... [INFO] checking tboard-pyo3-0.1.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate tboard-pyo3 0.1.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate tboard-pyo3 0.1.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tboard-pyo3 0.1.1 [INFO] finished tweaking crates.io crate tboard-pyo3 0.1.1 [INFO] tweaked toml for crates.io crate tboard-pyo3 0.1.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 90 packages to latest compatible versions [INFO] [stderr] Adding fixedbitset v0.4.2 (available: v0.5.7) [INFO] [stderr] Adding heck v0.4.1 (available: v0.5.0) [INFO] [stderr] Adding hostname v0.3.1 (available: v0.4.0) [INFO] [stderr] Adding itertools v0.12.1 (available: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding ndarray v0.15.6 (available: v0.16.1) [INFO] [stderr] Adding numpy v0.20.0 (available: v0.21.0) [INFO] [stderr] Adding prost v0.12.6 (available: v0.13.3) [INFO] [stderr] Adding prost-build v0.12.6 (available: v0.13.3) [INFO] [stderr] Adding prost-derive v0.12.6 (available: v0.13.3) [INFO] [stderr] Adding prost-types v0.12.6 (available: v0.13.3) [INFO] [stderr] Adding pyo3 v0.20.3 (available: v0.22.3) [INFO] [stderr] Adding pyo3-build-config v0.20.3 (available: v0.22.3) [INFO] [stderr] Adding pyo3-ffi v0.20.3 (available: v0.22.3) [INFO] [stderr] Adding pyo3-macros v0.20.3 (available: v0.22.3) [INFO] [stderr] Adding pyo3-macros-backend v0.20.3 (available: v0.22.3) [INFO] [stderr] Adding rustc-hash v1.1.0 (available: v2.0.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 401861bc78cb641fcb0c3db70996001534717a39546dd3dc84d0f65ff25311ce [INFO] running `Command { std: "docker" "start" "-a" "401861bc78cb641fcb0c3db70996001534717a39546dd3dc84d0f65ff25311ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "401861bc78cb641fcb0c3db70996001534717a39546dd3dc84d0f65ff25311ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "401861bc78cb641fcb0c3db70996001534717a39546dd3dc84d0f65ff25311ce", kill_on_drop: false }` [INFO] [stdout] 401861bc78cb641fcb0c3db70996001534717a39546dd3dc84d0f65ff25311ce [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4ad686f49e5f8aa7d43c51fe2c9e0c39dc887876f69c5a3c18d304f565eee77b [INFO] running `Command { std: "docker" "start" "-a" "4ad686f49e5f8aa7d43c51fe2c9e0c39dc887876f69c5a3c18d304f565eee77b", kill_on_drop: false }` [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling bytes v1.7.2 [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling anyhow v1.0.89 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Compiling fastrand v2.1.1 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling matrixmultiply v0.3.9 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling portable-atomic v1.9.0 [INFO] [stderr] Compiling multimap v0.10.0 [INFO] [stderr] Checking gimli v0.31.0 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking match_cfg v0.1.0 [INFO] [stderr] Compiling pyo3-build-config v0.20.3 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking unindent v0.2.3 [INFO] [stderr] Checking hostname v0.3.1 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling prost-derive v0.12.6 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Compiling pyo3-macros-backend v0.20.3 [INFO] [stderr] Compiling pyo3-ffi v0.20.3 [INFO] [stderr] Compiling pyo3 v0.20.3 [INFO] [stderr] Compiling tempfile v3.13.0 [INFO] [stderr] Checking addr2line v0.24.1 [INFO] [stderr] Compiling prost v0.12.6 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling prost-types v0.12.6 [INFO] [stderr] Compiling pyo3-macros v0.20.3 [INFO] [stderr] Compiling prost-build v0.12.6 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Compiling tboard v0.1.1 [INFO] [stderr] Checking numpy v0.20.0 [INFO] [stderr] Checking tboard-pyo3 v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:53:15 [INFO] [stdout] | [INFO] [stdout] 47 | fn __next__(mut slf: PyRefMut<'_, Self>, py: Python) -> PyResult> { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | match slf.reader.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:53:15 [INFO] [stdout] | [INFO] [stdout] 47 | fn __next__(mut slf: PyRefMut<'_, Self>, py: Python) -> PyResult> { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | match slf.reader.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:122:1 [INFO] [stdout] | [INFO] [stdout] 122 | #[pymethods] [INFO] [stdout] | -^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `PyClassImplCollector` is not local [INFO] [stdout] | `PyClassNewTextSignature` is not local [INFO] [stdout] | move the `impl` block outside of this function `trampoline` and up 4 bodies [INFO] [stdout] 123 | impl EventReader { [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | `EventReader` is not local [INFO] [stdout] | `EventReader` is not local [INFO] [stdout] | [INFO] [stdout] = note: the attribute macro `pymethods` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the attribute macro `pymethods` may come from an old version of the `pyo3_macros` crate, try updating your dependency with `cargo update -p pyo3_macros` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the attribute macro `pymethods` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:162:1 [INFO] [stdout] | [INFO] [stdout] 162 | #[pymethods] [INFO] [stdout] | -^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `PyClassImplCollector` is not local [INFO] [stdout] | `PyClassNewTextSignature` is not local [INFO] [stdout] | move the `impl` block outside of this function `trampoline` and up 4 bodies [INFO] [stdout] 163 | impl EventWriter { [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | `EventWriter` is not local [INFO] [stdout] | `EventWriter` is not local [INFO] [stdout] | [INFO] [stdout] = note: the attribute macro `pymethods` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the attribute macro `pymethods` may come from an old version of the `pyo3_macros` crate, try updating your dependency with `cargo update -p pyo3_macros` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the attribute macro `pymethods` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:122:1 [INFO] [stdout] | [INFO] [stdout] 122 | #[pymethods] [INFO] [stdout] | -^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `PyClassImplCollector` is not local [INFO] [stdout] | `PyClassNewTextSignature` is not local [INFO] [stdout] | move the `impl` block outside of this function `trampoline` and up 4 bodies [INFO] [stdout] 123 | impl EventReader { [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | `EventReader` is not local [INFO] [stdout] | `EventReader` is not local [INFO] [stdout] | [INFO] [stdout] = note: the attribute macro `pymethods` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the attribute macro `pymethods` may come from an old version of the `pyo3_macros` crate, try updating your dependency with `cargo update -p pyo3_macros` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the attribute macro `pymethods` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:162:1 [INFO] [stdout] | [INFO] [stdout] 162 | #[pymethods] [INFO] [stdout] | -^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `PyClassImplCollector` is not local [INFO] [stdout] | `PyClassNewTextSignature` is not local [INFO] [stdout] | move the `impl` block outside of this function `trampoline` and up 4 bodies [INFO] [stdout] 163 | impl EventWriter { [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | `EventWriter` is not local [INFO] [stdout] | `EventWriter` is not local [INFO] [stdout] | [INFO] [stdout] = note: the attribute macro `pymethods` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the attribute macro `pymethods` may come from an old version of the `pyo3_macros` crate, try updating your dependency with `cargo update -p pyo3_macros` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the attribute macro `pymethods` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tboard-pyo3` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tboard-pyo3` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4ad686f49e5f8aa7d43c51fe2c9e0c39dc887876f69c5a3c18d304f565eee77b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4ad686f49e5f8aa7d43c51fe2c9e0c39dc887876f69c5a3c18d304f565eee77b", kill_on_drop: false }` [INFO] [stdout] 4ad686f49e5f8aa7d43c51fe2c9e0c39dc887876f69c5a3c18d304f565eee77b