[INFO] fetching crate taskmanager 0.6.2... [INFO] checking taskmanager-0.6.2 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate taskmanager 0.6.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate taskmanager 0.6.2 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate taskmanager 0.6.2 [INFO] finished tweaking crates.io crate taskmanager 0.6.2 [INFO] tweaked toml for crates.io crate taskmanager 0.6.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 89 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding encode_unicode v0.3.6 (available: v1.0.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding io-lifetimes v1.0.11 (available: v2.0.3) [INFO] [stderr] Adding linux-raw-sys v0.3.8 (available: v0.6.5) [INFO] [stderr] Adding rustix v0.37.27 (available: v0.38.37) [INFO] [stderr] Adding terminal_size v0.2.6 (available: v0.4.0) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] [stderr] Adding windows-sys v0.48.0 (available: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (available: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 63e3abf21795ca442e81f646d47f49c231d409e9ea133b97727d82ad2e96a7d8 [INFO] running `Command { std: "docker" "start" "-a" "63e3abf21795ca442e81f646d47f49c231d409e9ea133b97727d82ad2e96a7d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "63e3abf21795ca442e81f646d47f49c231d409e9ea133b97727d82ad2e96a7d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "63e3abf21795ca442e81f646d47f49c231d409e9ea133b97727d82ad2e96a7d8", kill_on_drop: false }` [INFO] [stdout] 63e3abf21795ca442e81f646d47f49c231d409e9ea133b97727d82ad2e96a7d8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fb41ceea5fe45ce4c1cfe45cc66c44bdb64653da0cdd2ca9361de4320449a7dc [INFO] running `Command { std: "docker" "start" "-a" "fb41ceea5fe45ce4c1cfe45cc66c44bdb64653da0cdd2ca9361de4320449a7dc", kill_on_drop: false }` [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking waitgroup v0.1.2 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking terminal_size v0.2.6 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking loga v0.5.2 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking taskmanager v0.6.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Arc>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:271:13 [INFO] [stdout] | [INFO] [stdout] 270 | pub async fn join(self, log: &loga::Log) -> Result<(), loga::Error> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 271 | let alive_ids = self.0.alive_task_ids.clone(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 287 | let mut work = pin!(async move { [INFO] [stdout] | ________________________- [INFO] [stdout] 288 | | let results = join_all(critical_tasks).await; [INFO] [stdout] 289 | | wg.wait().await; [INFO] [stdout] 290 | | return results; [INFO] [stdout] 291 | | }); [INFO] [stdout] | |__________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 292 | let results1 = loop { [INFO] [stdout] 293 | / select!{ [INFO] [stdout] 294 | | results =& mut work => break results, [INFO] [stdout] 295 | | _ = sleep(std::time::Duration::from_secs(10)) => { [INFO] [stdout] 296 | | log.log_with( [INFO] [stdout] ... | [INFO] [stdout] 301 | | } [INFO] [stdout] 302 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Worker` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:166:21 [INFO] [stdout] | [INFO] [stdout] 166 | let _w = match tm.0.wg.lock().unwrap().as_ref() { [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 176 | / select!{ [INFO] [stdout] 177 | | _ = tm.until_terminate() => { [INFO] [stdout] 178 | | break; [INFO] [stdout] 179 | | } [INFO] [stdout] 180 | | _ = sleep(period) => { [INFO] [stdout] 181 | | } [INFO] [stdout] 182 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:271:13 [INFO] [stdout] | [INFO] [stdout] 270 | pub async fn join(self, log: &loga::Log) -> Result<(), loga::Error> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 271 | let alive_ids = self.0.alive_task_ids.clone(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 287 | let mut work = pin!(async move { [INFO] [stdout] | ________________________- [INFO] [stdout] 288 | | let results = join_all(critical_tasks).await; [INFO] [stdout] 289 | | wg.wait().await; [INFO] [stdout] 290 | | return results; [INFO] [stdout] 291 | | }); [INFO] [stdout] | |__________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 292 | let results1 = loop { [INFO] [stdout] 293 | / select!{ [INFO] [stdout] 294 | | results =& mut work => break results, [INFO] [stdout] 295 | | _ = sleep(std::time::Duration::from_secs(10)) => { [INFO] [stdout] 296 | | log.log_with( [INFO] [stdout] ... | [INFO] [stdout] 301 | | } [INFO] [stdout] 302 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `taskmanager` (lib test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Worker` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:166:21 [INFO] [stdout] | [INFO] [stdout] 166 | let _w = match tm.0.wg.lock().unwrap().as_ref() { [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 176 | / select!{ [INFO] [stdout] 177 | | _ = tm.until_terminate() => { [INFO] [stdout] 178 | | break; [INFO] [stdout] 179 | | } [INFO] [stdout] 180 | | _ = sleep(period) => { [INFO] [stdout] 181 | | } [INFO] [stdout] 182 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `taskmanager` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "fb41ceea5fe45ce4c1cfe45cc66c44bdb64653da0cdd2ca9361de4320449a7dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb41ceea5fe45ce4c1cfe45cc66c44bdb64653da0cdd2ca9361de4320449a7dc", kill_on_drop: false }` [INFO] [stdout] fb41ceea5fe45ce4c1cfe45cc66c44bdb64653da0cdd2ca9361de4320449a7dc